[LTP] [POSIX][PATCH]Cleanup the test shm_open/2-1 to make a good format

[LTP] [POSIX][PATCH]Cleanup the test shm_open/2-1 to make a good format

[Bian Naimeng]

Although it's not important, but it makes a noise in the log.

----------------------------------------------------------------
Cleanup the test shm_open/2-1 to make a good format.

Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>

---
 .../conformance/interfaces/shm_open/2-1.c          |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c b/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c
index f4bab48..b0adce6 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c
@@ -17,7 +17,9 @@
 
 int main()
 {
-        printf("Will not test that the shm_open() function create an open file description\nthat refers to the shared memory object and a file descriptor that refers to\nthat open file description.");
+        printf("Will not test that the shm_open() function create an open file"
+	       "description that refers to the shared memory object and a file"
+	       "descriptor that refers to that open file description.\n");
         return PTS_UNTESTED;
 }
 
-- 
1.7.0.4



-- 
Regards
Bian Naimeng


------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [POSIX][PATCH]Cleanup the test shm_open/2-1 to make a good format

[Garrett Cooper]

On Mon, Nov 1, 2010 at 6:37 PM, Bian Naimeng <biannm@cn.fujitsu.com> wrote:
> Although it's not important, but it makes a noise in the log.
>
> ----------------------------------------------------------------
> Cleanup the test shm_open/2-1 to make a good format.
>
> Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
>
> ---
>  .../conformance/interfaces/shm_open/2-1.c          |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c b/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c
> index f4bab48..b0adce6 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c
> @@ -17,7 +17,9 @@
>
>  int main()
>  {
> -        printf("Will not test that the shm_open() function create an open file description\nthat refers to the shared memory object and a file descriptor that refers to\nthat open file description.");
> +        printf("Will not test that the shm_open() function create an open file"
> +              "description that refers to the shared memory object and a file"
> +              "descriptor that refers to that open file description.\n");
>         return PTS_UNTESTED;
>  }

    Actually, that will look a lot worse because you just removed some
spaces in areas. description should be descriptor, etc.
    I'll fix this up and give you credit for the note :).
Thanks,
-Garrett

------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [POSIX][PATCH]Cleanup the test shm_open/2-1 to make a good format

[Bian Naimeng]

>> ---
>>  .../conformance/interfaces/shm_open/2-1.c          |    4 +++-
>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c b/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c
>> index f4bab48..b0adce6 100644
>> --- a/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c
>> +++ b/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c
>> @@ -17,7 +17,9 @@
>>
>>  int main()
>>  {
>> -        printf("Will not test that the shm_open() function create an open file description\nthat refers to the shared memory object and a file descriptor that refers to\nthat open file description.");
>> +        printf("Will not test that the shm_open() function create an open file"
>> +              "description that refers to the shared memory object and a file"
>> +              "descriptor that refers to that open file description.\n");
>>         return PTS_UNTESTED;
>>  }
> 
>     Actually, that will look a lot worse because you just removed some
> spaces in areas. description should be descriptor, etc.

  Yes, it's my mistake. Thank you for pointing out it. ^_^

> Thanks,
> -Garrett
> 
> 
> 

-- 
Regards
Bian Naimeng


------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [POSIX][PATCH]Cleanup the test shm_open/2-1 to make a good format

[Garrett Cooper]

On Mon, Nov 1, 2010 at 7:03 PM, Bian Naimeng <biannm@cn.fujitsu.com> wrote:
>>> ---
>>>  .../conformance/interfaces/shm_open/2-1.c          |    4 +++-
>>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c b/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c
>>> index f4bab48..b0adce6 100644
>>> --- a/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c
>>> +++ b/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c
>>> @@ -17,7 +17,9 @@
>>>
>>>  int main()
>>>  {
>>> -        printf("Will not test that the shm_open() function create an open file description\nthat refers to the shared memory object and a file descriptor that refers to\nthat open file description.");
>>> +        printf("Will not test that the shm_open() function create an open file"
>>> +              "description that refers to the shared memory object and a file"
>>> +              "descriptor that refers to that open file description.\n");
>>>         return PTS_UNTESTED;
>>>  }
>>
>>     Actually, that will look a lot worse because you just removed some
>> spaces in areas. description should be descriptor, etc.
>
>  Yes, it's my mistake. Thank you for pointing out it. ^_^

I'm tempted to just delete this test because it's a no-op. Anyone object?

------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [POSIX][PATCH]Cleanup the test shm_open/2-1 to make a good format

[Bian Naimeng]

Garrett Cooper 写道:
> On Mon, Nov 1, 2010 at 7:03 PM, Bian Naimeng <biannm@cn.fujitsu.com> wrote:
>>>> ---
>>>>  .../conformance/interfaces/shm_open/2-1.c          |    4 +++-
>>>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c b/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c
>>>> index f4bab48..b0adce6 100644
>>>> --- a/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c
>>>> +++ b/testcases/open_posix_testsuite/conformance/interfaces/shm_open/2-1.c
>>>> @@ -17,7 +17,9 @@
>>>>
>>>>  int main()
>>>>  {
>>>> -        printf("Will not test that the shm_open() function create an open file description\nthat refers to the shared memory object and a file descriptor that refers to\nthat open file description.");
>>>> +        printf("Will not test that the shm_open() function create an open file"
>>>> +              "description that refers to the shared memory object and a file"
>>>> +              "descriptor that refers to that open file description.\n");
>>>>         return PTS_UNTESTED;
>>>>  }
>>>     Actually, that will look a lot worse because you just removed some
>>> spaces in areas. description should be descriptor, etc.
>>  Yes, it's my mistake. Thank you for pointing out it. ^_^
> 
> I'm tempted to just delete this test because it's a no-op. Anyone object?
> 
 
  It looks good to me.

> 
> 

-- 
Regards
Bian Naimeng


------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list