From: Johannes Sixt <j.sixt@viscovery.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [RFC/PATCH 1/5] gettext: fix bug in git-sh-i18n's eval_gettext() by using envsubst(1)
Date: Tue, 09 Nov 2010 08:33:57 +0100 [thread overview]
Message-ID: <4CD8F965.6050402@viscovery.net> (raw)
In-Reply-To: <AANLkTimjRwSxkemMffASvHCxK009b1fnvNRs05_T_1DF@mail.gmail.com>
Am 11/8/2010 23:39, schrieb Ævar Arnfjörð Bjarmason:
> eval_gettext () {
> gettext "$1" | (export PATH `envsubst --variables "$1"`; envsubst "$1")
> }
So, for every message printed, you have at least 3 fork()s (usually even
more)! I'm not happy about that. You *must* avoid this at least for
NO_GETTEXT builds, but if you can reduce them even for no-NO_GETTEXT
builds, it would be great.
-- Hannes
next prev parent reply other threads:[~2010-11-09 7:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 7:18 Buglet in i18n? Johannes Sixt
2010-10-22 8:20 ` Ævar Arnfjörð Bjarmason
2010-10-22 8:34 ` Jonathan Nieder
2010-10-23 11:32 ` Ævar Arnfjörð Bjarmason
[not found] ` <20101023182940.GD21040@burratino>
2010-10-30 9:14 ` Ævar Arnfjörð Bjarmason
2010-10-31 11:34 ` [RFC/PATCH 0/5] ab/i18n: Things I'll add in the next iteration Ævar Arnfjörð Bjarmason
2010-10-31 11:34 ` [RFC/PATCH 1/5] gettext: fix bug in git-sh-i18n's eval_gettext() by using envsubst(1) Ævar Arnfjörð Bjarmason
2010-11-02 8:33 ` Johannes Sixt
2010-11-08 22:39 ` Ævar Arnfjörð Bjarmason
2010-11-09 7:33 ` Johannes Sixt [this message]
2010-11-09 9:35 ` Ævar Arnfjörð Bjarmason
2010-11-09 9:47 ` Johannes Sixt
2010-11-09 9:49 ` Ævar Arnfjörð Bjarmason
2010-11-09 10:36 ` Johannes Sixt
2010-11-09 10:38 ` Erik Faye-Lund
2010-11-09 10:52 ` Ævar Arnfjörð Bjarmason
2010-11-09 11:42 ` Johannes Sixt
2010-11-09 11:57 ` Ævar Arnfjörð Bjarmason
2010-11-09 12:22 ` Johannes Sixt
2010-11-09 12:38 ` Ævar Arnfjörð Bjarmason
2010-11-09 12:53 ` Johannes Sixt
2010-11-09 13:02 ` Ævar Arnfjörð Bjarmason
2010-10-31 11:34 ` [RFC/PATCH 2/5] gettextize: git-clone: !fixup "basic messages" Ævar Arnfjörð Bjarmason
2010-10-31 11:34 ` [RFC/PATCH 3/5] gettextize: git-init: " Ævar Arnfjörð Bjarmason
2010-10-31 11:34 ` [RFC/PATCH 4/5] gettextize: git-revert: !fixup "Your local changes" Ævar Arnfjörð Bjarmason
2010-10-31 11:34 ` [RFC/PATCH 5/5] gettextize: git-merge: !fixup "basic messages" Ævar Arnfjörð Bjarmason
2010-10-22 8:49 ` Buglet in i18n? Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD8F965.6050402@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.