From: Johannes Sixt <j.sixt@viscovery.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [RFC/PATCH 1/5] gettext: fix bug in git-sh-i18n's eval_gettext() by using envsubst(1)
Date: Tue, 09 Nov 2010 13:22:10 +0100 [thread overview]
Message-ID: <4CD93CF2.2060800@viscovery.net> (raw)
In-Reply-To: <AANLkTimhbp3AngtJjBYhHpa173=D-XJOg9L2sd6YMCwA@mail.gmail.com>
Am 11/9/2010 12:57, schrieb Ævar Arnfjörð Bjarmason:
> How about if you just replace your tests with "cat". That should give
> a more accurate indication of what speed it *should* be operating at,
> once I fix those Makefile issues.
Just FYI:
$ time (for i in {1..100}; do eval_gettext2 foobar; done) > /dev/null
real 0m14.844s
user 0m11.635s
sys 0m4.372s
Please understand that on Windows there is a difference between cat, sed,
etc. and git. There is also a speed difference, which is annoying, but it
is fact and *not* a bug. You cannot argue with how the timings "should be".
> Anyway, if it's no more expensive than cat(1) (which it shouldn't be)
> it probably won't be a problem to use git-sh-i18n--envsubst.
It *is* more expensive.
BTW, current ab/i18n fails to compile when NO_GETTEXT is specified in
config.mak and libintl.h is not available. I suggest the fix below.
-- Hannes
diff --git a/Makefile b/Makefile
index c55baa6..e9ee142 100644
--- a/Makefile
+++ b/Makefile
@@ -619,9 +619,6 @@ LIB_OBJS += entry.o
LIB_OBJS += environment.o
LIB_OBJS += exec_cmd.o
LIB_OBJS += fsck.o
-ifndef NO_GETTEXT
-LIB_OBJS += gettext.o
-endif
LIB_OBJS += graph.o
LIB_OBJS += grep.o
LIB_OBJS += hash.o
@@ -1539,7 +1536,8 @@ endif
ifdef NO_GETTEXT
COMPAT_CFLAGS += -DNO_GETTEXT
-endif
+else
+ LIB_OBJS += gettext.o
ifdef NEEDS_LIBINTL
EXTLIBS += -lintl
@@ -1552,6 +1550,7 @@ endif
ifdef GETTEXT_POISON
COMPAT_CFLAGS += -DGETTEXT_POISON
endif
+endif
ifeq ($(TCLTK_PATH),)
NO_TCLTK=NoThanks
next prev parent reply other threads:[~2010-11-09 12:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 7:18 Buglet in i18n? Johannes Sixt
2010-10-22 8:20 ` Ævar Arnfjörð Bjarmason
2010-10-22 8:34 ` Jonathan Nieder
2010-10-23 11:32 ` Ævar Arnfjörð Bjarmason
[not found] ` <20101023182940.GD21040@burratino>
2010-10-30 9:14 ` Ævar Arnfjörð Bjarmason
2010-10-31 11:34 ` [RFC/PATCH 0/5] ab/i18n: Things I'll add in the next iteration Ævar Arnfjörð Bjarmason
2010-10-31 11:34 ` [RFC/PATCH 1/5] gettext: fix bug in git-sh-i18n's eval_gettext() by using envsubst(1) Ævar Arnfjörð Bjarmason
2010-11-02 8:33 ` Johannes Sixt
2010-11-08 22:39 ` Ævar Arnfjörð Bjarmason
2010-11-09 7:33 ` Johannes Sixt
2010-11-09 9:35 ` Ævar Arnfjörð Bjarmason
2010-11-09 9:47 ` Johannes Sixt
2010-11-09 9:49 ` Ævar Arnfjörð Bjarmason
2010-11-09 10:36 ` Johannes Sixt
2010-11-09 10:38 ` Erik Faye-Lund
2010-11-09 10:52 ` Ævar Arnfjörð Bjarmason
2010-11-09 11:42 ` Johannes Sixt
2010-11-09 11:57 ` Ævar Arnfjörð Bjarmason
2010-11-09 12:22 ` Johannes Sixt [this message]
2010-11-09 12:38 ` Ævar Arnfjörð Bjarmason
2010-11-09 12:53 ` Johannes Sixt
2010-11-09 13:02 ` Ævar Arnfjörð Bjarmason
2010-10-31 11:34 ` [RFC/PATCH 2/5] gettextize: git-clone: !fixup "basic messages" Ævar Arnfjörð Bjarmason
2010-10-31 11:34 ` [RFC/PATCH 3/5] gettextize: git-init: " Ævar Arnfjörð Bjarmason
2010-10-31 11:34 ` [RFC/PATCH 4/5] gettextize: git-revert: !fixup "Your local changes" Ævar Arnfjörð Bjarmason
2010-10-31 11:34 ` [RFC/PATCH 5/5] gettextize: git-merge: !fixup "basic messages" Ævar Arnfjörð Bjarmason
2010-10-22 8:49 ` Buglet in i18n? Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD93CF2.2060800@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.