From: Wolfgang Grandegger <wg@grandegger.com>
To: David Miller <davem@davemloft.net>
Cc: tomoya-linux@dsn.okisemi.com, andrew.chih.howe.khor@intel.com,
masa-korg@dsn.okisemi.com, sameo@linux.intel.com,
margie.foster@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, socketcan-core@lists.berlios.de,
kok.howg.ewe@intel.com, joel.clark@intel.com,
yong.y.wang@intel.com, chripell@fsfe.org, qi.wang@intel.com
Subject: Re: [PATCH net-next-2.6 v4] can: Topcliff: PCH_CAN driver: Add Flow control/Fix Endianess issue/Separate IF register/Enumerate LEC macro/Move MSI processing/Use BIT(X)/Change Message Object index/Add prefix PCH_
Date: Tue, 16 Nov 2010 21:39:47 +0100 [thread overview]
Message-ID: <4CE2EC13.9090707@grandegger.com> (raw)
In-Reply-To: <20101116.091443.226753420.davem@davemloft.net>
Hi David,
On 11/16/2010 06:14 PM, David Miller wrote:
>
> Way too many changes in one patch.
>
> Please post one that fixes the endianness issues.
>
> One that fixes the register interface seperation.
>
> One that adds flow control processing.
>
> etc.
>
> When you combine many tasks into one patch it's impossible
> to bisect through your changes to debug problems in order
> to figure out which changed introduced a bug.
>
> I am not applying this, and I will not apply your patches
> until you split them up properly.
>
> You may think that there is zero value in this, but there
> is huge value in it for anyone who tries to debug your
> changes in the future. Right now you are making that a
> nearly impossible task.
Please take into account that this patch got accepted by accident
(because the maintainer did not respond properly in time). At that time
the driver was incomplete, not ready for mainline and did not even work
properly. Therefore it makes little sense to debug or even bisec these
changes. Just for that reason I made an exemption and added my
"Acked-by". Hope you can share my arguments.
Wolfgang.
WARNING: multiple messages have this Message-ID (diff)
From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
margie.foster-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
masa-korg-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org,
kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
chripell-VaTbYqLCNhc@public.gmane.org,
joel.clark-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH net-next-2.6 v4] can: Topcliff: PCH_CAN driver: Add Flow control/Fix Endianess issue/Separate IF register/Enumerate LEC macro/Move MSI processing/Use BIT(X)/Change Message Object index/Add prefix PCH_
Date: Tue, 16 Nov 2010 21:39:47 +0100 [thread overview]
Message-ID: <4CE2EC13.9090707@grandegger.com> (raw)
In-Reply-To: <20101116.091443.226753420.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Hi David,
On 11/16/2010 06:14 PM, David Miller wrote:
>
> Way too many changes in one patch.
>
> Please post one that fixes the endianness issues.
>
> One that fixes the register interface seperation.
>
> One that adds flow control processing.
>
> etc.
>
> When you combine many tasks into one patch it's impossible
> to bisect through your changes to debug problems in order
> to figure out which changed introduced a bug.
>
> I am not applying this, and I will not apply your patches
> until you split them up properly.
>
> You may think that there is zero value in this, but there
> is huge value in it for anyone who tries to debug your
> changes in the future. Right now you are making that a
> nearly impossible task.
Please take into account that this patch got accepted by accident
(because the maintainer did not respond properly in time). At that time
the driver was incomplete, not ready for mainline and did not even work
properly. Therefore it makes little sense to debug or even bisec these
changes. Just for that reason I made an exemption and added my
"Acked-by". Hope you can share my arguments.
Wolfgang.
next prev parent reply other threads:[~2010-11-16 20:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 12:14 [PATCH net-next-2.6 v4] can: Topcliff: PCH_CAN driver: Add Flow control/Fix Endianess issue/Separate IF register/Enumerate LEC macro/Move MSI processing/Use BIT(X)/Change Message Object index/Add prefix PCH_ Tomoya MORINAGA
2010-11-16 12:22 ` Wolfgang Grandegger
2010-11-16 12:22 ` Wolfgang Grandegger
2010-11-16 17:14 ` David Miller
2010-11-16 17:14 ` David Miller
2010-11-16 20:39 ` Wolfgang Grandegger [this message]
2010-11-16 20:39 ` Wolfgang Grandegger
2010-11-16 20:43 ` David Miller
2010-11-16 20:43 ` David Miller
2010-11-16 21:07 ` Wolfram Sang
2010-11-16 21:07 ` Wolfram Sang
2010-11-16 21:10 ` David Miller
2010-11-16 21:10 ` David Miller
2010-11-17 3:00 ` Tomoya MORINAGA
2010-11-17 3:00 ` Tomoya MORINAGA
-- strict thread matches above, loose matches on Subject: below --
2010-11-16 12:14 Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE2EC13.9090707@grandegger.com \
--to=wg@grandegger.com \
--cc=andrew.chih.howe.khor@intel.com \
--cc=chripell@fsfe.org \
--cc=davem@davemloft.net \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=margie.foster@intel.com \
--cc=masa-korg@dsn.okisemi.com \
--cc=netdev@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=sameo@linux.intel.com \
--cc=socketcan-core@lists.berlios.de \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.