* [PATCH v2 2/2] davinci: Platform support for OMAP-L137/AM17x NOR flash driver
@ 2010-11-12 8:02 Savinay Dharmappa
2010-11-18 11:52 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Savinay Dharmappa @ 2010-11-12 8:02 UTC (permalink / raw)
To: davinci-linux-open-source
Cc: sshtylyov, Aleksey Makarov, dgriego, linux-mtd, Savinay Dharmappa
From: Aleksey Makarov <amakarov@ru.mvista.com>
Adds platform support for OMAP-L137/AM17x NOR flash driver.
Also, configures chip select 3 to control NOR flash's upper
address lines.
Signed-off-by: Aleksey Makarov <amakarov@ru.mvista.com>
Signed-off-by: Savinay Dharmappa <savinay.dharmappa@ti.com>
---
Since v1:
Addressed Sergei's comments at [1].
[1] http://linux.davincidsp.com/pipermail/davinci-linux-open-source/2010-November/020923.html
arch/arm/mach-davinci/Kconfig | 8 +
arch/arm/mach-davinci/board-da830-evm.c | 219 +++++++++++++++++++++++++++++++
2 files changed, 227 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index 9aca60c..baa39ee 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -142,6 +142,14 @@ config DA830_UI_NAND
help
Say Y here to use the NAND flash. Do not forget to setup
the switch correctly.
+
+config DA830_UI_NOR
+ bool "NOR flash"
+ help
+ Configure this option to specify the that AEMIF CE2/CE3 will be used to
+ communicate to the NOR flash. Do not forget to setup the switch SW1
+ on UI card correctly.
+
endchoice
config MACH_DAVINCI_DA850_EVM
diff --git a/arch/arm/mach-davinci/board-da830-evm.c b/arch/arm/mach-davinci/board-da830-evm.c
index 1bb89d3..cd35198 100644
--- a/arch/arm/mach-davinci/board-da830-evm.c
+++ b/arch/arm/mach-davinci/board-da830-evm.c
@@ -20,6 +20,8 @@
#include <linux/i2c/at24.h>
#include <linux/mtd/mtd.h>
#include <linux/mtd/partitions.h>
+#include <linux/mtd/latch-addr-flash.h>
+#include <linux/clk.h>
#include <asm/mach-types.h>
#include <asm/mach/arch.h>
@@ -429,6 +431,221 @@ static inline void da830_evm_init_nand(int mux_mode)
static inline void da830_evm_init_nand(int mux_mode) { }
#endif
+#ifdef CONFIG_DA830_UI_NOR
+/*
+ * Number of Address line going to the NOR flash that are latched using
+ * AEMIF address lines B_EMIF_BA0-B_EMIF_A12 on CS2.
+ */
+#define NOR_WINDOW_SIZE_LOG2 15
+#define NOR_WINDOW_SIZE (1 << NOR_WINDOW_SIZE_LOG2)
+
+static struct {
+ struct clk *clk;
+ struct {
+ struct resource *res;
+ void __iomem *addr;
+ } latch, aemif;
+} da830_evm_nor;
+
+static struct davinci_aemif_timing da830_evm_norflash_timing = {
+ .wsetup = 0,
+ .wstrobe = 40,
+ .whold = 0,
+ .rsetup = 0,
+ .rstrobe = 130,
+ .rhold = 0,
+ .ta = 20,
+};
+
+static void da830_evm_nor_set_window(unsigned long offset, void *data)
+{
+ /*
+ * CS2 and CS3 address lines are used to address NOR flash. Address
+ * line A0-A14 going to the NOR flash are latched using AEMIF address
+ * lines B_EMIF_BA0-B_EMIF_A12 on CS2. Address lines A15-A23 of the
+ * NOR flash are latched using AEMIF address lines B_EMIF_A0-B_EMIF_A6
+ * on CS3. The offset argument received by this function is the offset
+ * within NOR flash. Upper address is obtained by shifting the offset
+ * by the number of CS2 address lines used (13) and masking it with
+ * complement of 3 (2 address lines used to address banks) and adding
+ * the resultant offset value to CS3 base address. Writing to this
+ * address will latch the upper address lines.
+ */
+ writeb(0x0, da830_evm_nor.latch.addr +
+ (~3UL & (offset >> (NOR_WINDOW_SIZE_LOG2 - 2))));
+}
+
+static void da830_evm_nor_done(void *data)
+{
+ clk_disable(da830_evm_nor.clk);
+ clk_put(da830_evm_nor.clk);
+ iounmap(da830_evm_nor.latch.addr);
+ release_mem_region(DA8XX_AEMIF_CS3_BASE, PAGE_SIZE);
+ iounmap(da830_evm_nor.aemif.addr);
+ release_mem_region(DA8XX_AEMIF_CTL_BASE, SZ_32K);
+}
+
+static int da830_evm_nor_init(void *data, int cs)
+{
+ /* Turn on AEMIF clocks */
+ da830_evm_nor.clk = clk_get(NULL, "aemif");
+ if (IS_ERR(da830_evm_nor.clk)) {
+ pr_err("%s: could not get AEMIF clock\n", __func__);
+ da830_evm_nor.clk = NULL;
+ return -ENODEV;
+ }
+ clk_enable(da830_evm_nor.clk);
+
+ da830_evm_nor.aemif.res = request_mem_region(DA8XX_AEMIF_CTL_BASE,
+ SZ_32K, "AEMIF control");
+ if (da830_evm_nor.aemif.res == NULL) {
+ pr_err("%s: could not request AEMIF control region\n",
+ __func__);
+ goto err_clk;
+ }
+
+ da830_evm_nor.aemif.addr = ioremap_nocache(DA8XX_AEMIF_CTL_BASE,
+ SZ_32K);
+ if (da830_evm_nor.aemif.addr == NULL) {
+ pr_err("%s: could not remap AEMIF control region\n", __func__);
+ goto err_aemif_region;
+ }
+
+ /* Setup AEMIF -- timings, etc. */
+
+ /* Set maximum wait cycles */
+ davinci_aemif_setup_timing(&da830_evm_norflash_timing,
+ da830_evm_nor.aemif.addr, cs);
+
+ davinci_aemif_setup_timing(&da830_evm_norflash_timing,
+ da830_evm_nor.aemif.addr, cs + 1);
+
+ /* Setup the window to access the latch */
+ da830_evm_nor.latch.res =
+ request_mem_region(DA8XX_AEMIF_CS3_BASE, PAGE_SIZE,
+ "DA830 UI NOR address latch");
+ if (da830_evm_nor.latch.res == NULL) {
+ pr_err("%s: could not request address latch region\n",
+ __func__);
+ goto err_aemif_ioremap;
+ }
+
+ da830_evm_nor.latch.addr =
+ ioremap_nocache(DA8XX_AEMIF_CS3_BASE, PAGE_SIZE);
+ if (da830_evm_nor.latch.addr == NULL) {
+ pr_err("%s: could not remap address latch region\n", __func__);
+ goto err_latch_region;
+ }
+ return 0;
+
+err_latch_region:
+ release_mem_region(DA8XX_AEMIF_CS3_BASE, PAGE_SIZE);
+
+err_aemif_ioremap:
+ iounmap(da830_evm_nor.aemif.addr);
+
+err_aemif_region:
+ release_mem_region(DA8XX_AEMIF_CTL_BASE, SZ_32K);
+
+err_clk:
+ clk_disable(da830_evm_nor.clk);
+ clk_put(da830_evm_nor.clk);
+
+ return -EBUSY;
+}
+
+static struct mtd_partition da830_evm_nor_partitions[] = {
+ /* bootloader (U-Boot, etc) in first 2 sectors */
+ [0] = {
+ .name = "bootloader",
+ .offset = 0,
+ .size = SZ_128K,
+ .mask_flags = MTD_WRITEABLE, /* force read-only */
+ },
+ /* bootloader parameters in the next 1 sector */
+ [1] = {
+ .name = "params",
+ .offset = MTDPART_OFS_APPEND,
+ .size = SZ_64K,
+ },
+ /* kernel */
+ [2] = {
+ .name = "kernel",
+ .offset = MTDPART_OFS_APPEND,
+ .size = SZ_2M,
+ },
+ /* file system */
+ [3] = {
+ .name = "filesystem",
+ .offset = MTDPART_OFS_APPEND,
+ .size = MTDPART_SIZ_FULL,
+ }
+};
+
+static struct latch_addr_flash_data da830_evm_nor_pdata = {
+ .width = 1,
+ .size = SZ_4M,
+ .init = da830_evm_nor_init,
+ .done = da830_evm_nor_done,
+ .set_window = da830_evm_nor_set_window,
+ .nr_parts = ARRAY_SIZE(da830_evm_nor_partitions),
+ .parts = da830_evm_nor_partitions,
+};
+
+static struct resource da830_evm_nor_resource[] = {
+ [0] = {
+ .start = DA8XX_AEMIF_CS2_BASE,
+ .end = DA8XX_AEMIF_CS2_BASE + NOR_WINDOW_SIZE - 1,
+ .flags = IORESOURCE_MEM,
+ },
+ [1] = {
+ .start = DA8XX_AEMIF_CS3_BASE,
+ .end = DA8XX_AEMIF_CS3_BASE + PAGE_SIZE - 1,
+ .flags = IORESOURCE_MEM,
+ },
+ [2] = {
+ .start = DA8XX_AEMIF_CTL_BASE,
+ .end = DA8XX_AEMIF_CTL_BASE + SZ_32K - 1,
+ .flags = IORESOURCE_MEM,
+ }
+};
+
+static struct platform_device da830_evm_nor_device = {
+ .name = "latch-addr-flash",
+ .id = 0,
+ .dev = {
+ .platform_data = &da830_evm_nor_pdata,
+ },
+ .num_resources = ARRAY_SIZE(da830_evm_nor_resource),
+ .resource = da830_evm_nor_resource,
+};
+
+static inline void da830_evm_init_nor(int mux_mode)
+{
+ int ret;
+
+ if (HAS_MMC) {
+ pr_warning("WARNING: both MMC/SD and NOR are "
+ "enabled, but they share AEMIF pins.\n"
+ "\tDisable MMC/SD for NOR support.\n");
+ return;
+ }
+
+ ret = davinci_cfg_reg_list(da830_evm_emif25_pins);
+ if (ret)
+ pr_warning("da830_evm_init: EMIF 2.5 mux setup failed: %d\n",
+ ret);
+
+ ret = platform_device_register(&da830_evm_nor_device);
+ if (ret)
+ pr_warning("da830_evm_init: NOR device not registered.\n");
+
+ gpio_direction_output(mux_mode, 1);
+}
+#else
+static inline void da830_evm_init_nor(int mux_mode) { }
+#endif /* CONFIG_DA830_UI_NOR */
+
#ifdef CONFIG_DA830_UI_LCD
static inline void da830_evm_init_lcdc(int mux_mode)
{
@@ -469,6 +686,8 @@ static int __init da830_evm_ui_expander_setup(struct i2c_client *client,
da830_evm_init_nand(gpio + 6);
+ da830_evm_init_nor(gpio + 6);
+
return 0;
}
--
1.5.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/2] davinci: Platform support for OMAP-L137/AM17x NOR flash driver
2010-11-12 8:02 [PATCH v2 2/2] davinci: Platform support for OMAP-L137/AM17x NOR flash driver Savinay Dharmappa
@ 2010-11-18 11:52 ` Sergei Shtylyov
2010-11-19 5:39 ` Savinay Dharmappa
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2010-11-18 11:52 UTC (permalink / raw)
To: Savinay Dharmappa
Cc: sshtylyov, Aleksey Makarov, davinci-linux-open-source, linux-mtd,
dgriego
Hello.
On 12-11-2010 11:02, Savinay Dharmappa wrote:
> From: Aleksey Makarov<amakarov@ru.mvista.com>
> Adds platform support for OMAP-L137/AM17x NOR flash driver.
> Also, configures chip select 3 to control NOR flash's upper
> address lines.
Please add back my signoff, omitted in this version. Some of the code,
including bug fixes, was authored by me.
> Signed-off-by: Aleksey Makarov <amakarov@ru.mvista.com>
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Signed-off-by: Savinay Dharmappa <savinay.dharmappa@ti.com>
> diff --git a/arch/arm/mach-davinci/board-da830-evm.c b/arch/arm/mach-davinci/board-da830-evm.c
> index 1bb89d3..cd35198 100644
> --- a/arch/arm/mach-davinci/board-da830-evm.c
> +++ b/arch/arm/mach-davinci/board-da830-evm.c
[...]
> @@ -429,6 +431,221 @@ static inline void da830_evm_init_nand(int mux_mode)
> static inline void da830_evm_init_nand(int mux_mode) { }
> #endif
>
> +#ifdef CONFIG_DA830_UI_NOR
> +/*
> + * Number of Address line
Only "lines".
> going to the NOR flash that are latched using
> + * AEMIF address lines B_EMIF_BA0-B_EMIF_A12 on CS2.
> +#define NOR_WINDOW_SIZE_LOG2 15
> +#define NOR_WINDOW_SIZE (1 << NOR_WINDOW_SIZE_LOG2)
> +
> +static struct {
> + struct clk *clk;
> + struct {
> + struct resource *res;
You're not using this field outside da830_evm_nor_init() now, so there's
not much point in keeping it...
> + void __iomem *addr;
> + } latch, aemif;
> +} da830_evm_nor;
> +static void da830_evm_nor_set_window(unsigned long offset, void *data)
> +{
> + /*
> + * CS2 and CS3 address lines are used to address NOR flash. Address
> + * line A0-A14 going to the NOR flash are latched using AEMIF address
> + * lines B_EMIF_BA0-B_EMIF_A12 on CS2.
Are they really latched, and not just used live when the NOR chip is
accessed? What's the point of latching them?
> +static int da830_evm_nor_init(void *data, int cs)
> +{
> + /* Turn on AEMIF clocks */
> + da830_evm_nor.clk = clk_get(NULL, "aemif");
> + if (IS_ERR(da830_evm_nor.clk)) {
> + pr_err("%s: could not get AEMIF clock\n", __func__);
> + da830_evm_nor.clk = NULL;
> + return -ENODEV;
> + }
> + clk_enable(da830_evm_nor.clk);
> +
> + da830_evm_nor.aemif.res = request_mem_region(DA8XX_AEMIF_CTL_BASE,
> + SZ_32K, "AEMIF control");
No need to store it -- you don't use it afterwards.
> + if (da830_evm_nor.aemif.res == NULL) {
> + pr_err("%s: could not request AEMIF control region\n",
> + __func__);
> + goto err_clk;
> + }
[...]
> + /* Setup the window to access the latch */
> + da830_evm_nor.latch.res =
> + request_mem_region(DA8XX_AEMIF_CS3_BASE, PAGE_SIZE,
> + "DA830 UI NOR address latch");
Same comment here...
> + if (da830_evm_nor.latch.res == NULL) {
> + pr_err("%s: could not request address latch region\n",
> + __func__);
> + goto err_aemif_ioremap;
> + }
[...]
> +static inline void da830_evm_init_nor(int mux_mode)
> +{
> + int ret;
> +
> + if (HAS_MMC) {
> + pr_warning("WARNING: both MMC/SD and NOR are "
> + "enabled, but they share AEMIF pins.\n"
> + "\tDisable MMC/SD for NOR support.\n");
This line is over-indented.
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v2 2/2] davinci: Platform support for OMAP-L137/AM17x NOR flash driver
2010-11-18 11:52 ` Sergei Shtylyov
@ 2010-11-19 5:39 ` Savinay Dharmappa
0 siblings, 0 replies; 3+ messages in thread
From: Savinay Dharmappa @ 2010-11-19 5:39 UTC (permalink / raw)
To: 'Sergei Shtylyov'
Cc: sshtylyov, 'Aleksey Makarov',
davinci-linux-open-source, linux-mtd, dgriego
Hi Sergei,
On Thu, Nov 18, 2010 at 17:22:26, Sergei Shtylyov wrote:
> Hello.
>
> On 12-11-2010 11:02, Savinay Dharmappa wrote:
>
> > From: Aleksey Makarov<amakarov@ru.mvista.com>
>
> > Adds platform support for OMAP-L137/AM17x NOR flash driver.
>
> > Also, configures chip select 3 to control NOR flash's upper
> > address lines.
>
> Please add back my signoff, omitted in this version. Some of the code,
> including bug fixes, was authored by me.
>
I'll add your sign-off.
> > Signed-off-by: Aleksey Makarov <amakarov@ru.mvista.com>
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> > Signed-off-by: Savinay Dharmappa <savinay.dharmappa@ti.com>
>
> > diff --git a/arch/arm/mach-davinci/board-da830-evm.c
b/arch/arm/mach-davinci/board-da830-evm.c
> > index 1bb89d3..cd35198 100644
> > --- a/arch/arm/mach-davinci/board-da830-evm.c
> > +++ b/arch/arm/mach-davinci/board-da830-evm.c
> [...]
> > @@ -429,6 +431,221 @@ static inline void da830_evm_init_nand(int
mux_mode)
> > static inline void da830_evm_init_nand(int mux_mode) { }
> > #endif
> >
> > +#ifdef CONFIG_DA830_UI_NOR
> > +/*
> > + * Number of Address line
>
> Only "lines".
>
Ok.
> > going to the NOR flash that are latched using
> > + * AEMIF address lines B_EMIF_BA0-B_EMIF_A12 on CS2.
> > +#define NOR_WINDOW_SIZE_LOG2 15
> > +#define NOR_WINDOW_SIZE (1 << NOR_WINDOW_SIZE_LOG2)
> > +
> > +static struct {
> > + struct clk *clk;
> > + struct {
> > + struct resource *res;
>
> You're not using this field outside da830_evm_nor_init() now, so
there's
> not much point in keeping it...
>
Ok. I'll use it as a local variable in da830_evm_nor_init().
> > + void __iomem *addr;
> > + } latch, aemif;
> > +} da830_evm_nor;
>
> > +static void da830_evm_nor_set_window(unsigned long offset, void *data)
> > +{
> > + /*
> > + * CS2 and CS3 address lines are used to address NOR flash. Address
> > + * line A0-A14 going to the NOR flash are latched using AEMIF
address
> > + * lines B_EMIF_BA0-B_EMIF_A12 on CS2.
>
> Are they really latched, and not just used live when the NOR chip is
> accessed? What's the point of latching them?
>
You are right. I'll correct the comment.
> > +static int da830_evm_nor_init(void *data, int cs)
> > +{
> > + /* Turn on AEMIF clocks */
> > + da830_evm_nor.clk = clk_get(NULL, "aemif");
> > + if (IS_ERR(da830_evm_nor.clk)) {
> > + pr_err("%s: could not get AEMIF clock\n", __func__);
> > + da830_evm_nor.clk = NULL;
> > + return -ENODEV;
> > + }
> > + clk_enable(da830_evm_nor.clk);
> > +
> > + da830_evm_nor.aemif.res = request_mem_region(DA8XX_AEMIF_CTL_BASE,
> > + SZ_32K, "AEMIF
control");
>
> No need to store it -- you don't use it afterwards.
>
Ok.
> > + if (da830_evm_nor.aemif.res == NULL) {
> > + pr_err("%s: could not request AEMIF control region\n",
> > + __func__);
> > + goto err_clk;
> > + }
>
> [...]
>
> > + /* Setup the window to access the latch */
> > + da830_evm_nor.latch.res =
> > + request_mem_region(DA8XX_AEMIF_CS3_BASE, PAGE_SIZE,
> > + "DA830 UI NOR address latch");
>
> Same comment here...
>
> > + if (da830_evm_nor.latch.res == NULL) {
> > + pr_err("%s: could not request address latch region\n",
> > + __func__);
> > + goto err_aemif_ioremap;
> > + }
>
> [...]
>
> > +static inline void da830_evm_init_nor(int mux_mode)
> > +{
> > + int ret;
> > +
> > + if (HAS_MMC) {
> > + pr_warning("WARNING: both MMC/SD and NOR are "
> > + "enabled, but they share AEMIF pins.\n"
> > + "\tDisable MMC/SD for NOR
support.\n");
>
> This line is over-indented.
Ok. Will address your comments and send an updated an version
Thanks,
Savinay
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-19 5:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-12 8:02 [PATCH v2 2/2] davinci: Platform support for OMAP-L137/AM17x NOR flash driver Savinay Dharmappa
2010-11-18 11:52 ` Sergei Shtylyov
2010-11-19 5:39 ` Savinay Dharmappa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.