All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] AT91RM9200: fix AT91_PMC_MCKR_MDIV_* defines for this CPU
@ 2010-11-19  1:20 clagix at gmail.com
  2010-12-05  9:51 ` Reinhard Meyer
  0 siblings, 1 reply; 4+ messages in thread
From: clagix at gmail.com @ 2010-11-19  1:20 UTC (permalink / raw)
  To: u-boot

The AT91RM9200 has a different bit assignment in PMC MCKR register than
it's successors (verified by Atmel's manuals on AT91RM9200 and AT91SAM926).
AT91RM9200 supports the additional divider of 3.

Signed-off-by: Guido Classen <clagix@gmail.com>

--- u-boot-git/arch/arm/include/asm/arch-at91/at91_pmc.h	2010-11-12 18:30:31.000000000 +0100
+++ u-boot-ccm2200/arch/arm/include/asm/arch-at91/at91_pmc.h	2010-11-16 22:00:56.000000000 +0100
@@ -91,10 +91,19 @@
  #define AT91_PMC_MCKR_PRES_64		0x00000018
  #define AT91_PMC_MCKR_PRES_MASK		0x0000001C

+#ifdef CONFIG_AT91RM9200
+#define AT91_PMC_MCKR_MDIV_1		0x00000000
+#define AT91_PMC_MCKR_MDIV_2		0x00000100
+#define AT91_PMC_MCKR_MDIV_3		0x00000200
+#define AT91_PMC_MCKR_MDIV_4		0x00000300
+#define AT91_PMC_MCKR_MDIV_MASK		0x00000300
+#else
  #define AT91_PMC_MCKR_MDIV_1		0x00000000
  #define AT91_PMC_MCKR_MDIV_2		0x00000100
  #define AT91_PMC_MCKR_MDIV_4		0x00000200
  #define AT91_PMC_MCKR_MDIV_MASK		0x00000300
+#endif

  #define AT91_PMC_MCKR_PLLADIV_1		0x00001000
  #define AT91_PMC_MCKR_PLLADIV_2		0x00002000

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] AT91RM9200: fix AT91_PMC_MCKR_MDIV_* defines for this CPU
  2010-11-19  1:20 [U-Boot] [PATCH] AT91RM9200: fix AT91_PMC_MCKR_MDIV_* defines for this CPU clagix at gmail.com
@ 2010-12-05  9:51 ` Reinhard Meyer
  2010-12-06 18:03   ` Guido Classen
  0 siblings, 1 reply; 4+ messages in thread
From: Reinhard Meyer @ 2010-12-05  9:51 UTC (permalink / raw)
  To: u-boot

Dear clagix at gmail.com,
> The AT91RM9200 has a different bit assignment in PMC MCKR register than
> it's successors (verified by Atmel's manuals on AT91RM9200 and AT91SAM926).
> AT91RM9200 supports the additional divider of 3.
> 
> Signed-off-by: Guido Classen <clagix@gmail.com>
> 
> --- u-boot-git/arch/arm/include/asm/arch-at91/at91_pmc.h	2010-11-12 18:30:31.000000000 +0100
> +++ u-boot-ccm2200/arch/arm/include/asm/arch-at91/at91_pmc.h	2010-11-16 22:00:56.000000000 +0100
> @@ -91,10 +91,19 @@
>   #define AT91_PMC_MCKR_PRES_64		0x00000018
>   #define AT91_PMC_MCKR_PRES_MASK		0x0000001C
> 
> +#ifdef CONFIG_AT91RM9200
> +#define AT91_PMC_MCKR_MDIV_1		0x00000000
> +#define AT91_PMC_MCKR_MDIV_2		0x00000100
> +#define AT91_PMC_MCKR_MDIV_3		0x00000200
> +#define AT91_PMC_MCKR_MDIV_4		0x00000300
> +#define AT91_PMC_MCKR_MDIV_MASK		0x00000300
> +#else
>   #define AT91_PMC_MCKR_MDIV_1		0x00000000
>   #define AT91_PMC_MCKR_MDIV_2		0x00000100
>   #define AT91_PMC_MCKR_MDIV_4		0x00000200
>   #define AT91_PMC_MCKR_MDIV_MASK		0x00000300
> +#endif
> 
>   #define AT91_PMC_MCKR_PLLADIV_1		0x00001000
>   #define AT91_PMC_MCKR_PLLADIV_2		0x00002000

This patch is not in git-format-patch format.
You hijacked another thread to post this message.

Please resubmit!

Best Regards,
Reinhard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] AT91RM9200: fix AT91_PMC_MCKR_MDIV_* defines for this CPU
  2010-12-05  9:51 ` Reinhard Meyer
@ 2010-12-06 18:03   ` Guido Classen
  2010-12-17  8:05     ` Reinhard Meyer
  0 siblings, 1 reply; 4+ messages in thread
From: Guido Classen @ 2010-12-06 18:03 UTC (permalink / raw)
  To: u-boot

Dear Reinhard Meyer,

please find below the git-format-patch generated patch.
Sorry, I can not see whose thread I hijacked. May you please explain?

Best Regards
  Guido

Signed-off-by: Guido Classen <clagix@gmail.com>

---
 arch/arm/include/asm/arch-at91/at91_pmc.h |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/arm/include/asm/arch-at91/at91_pmc.h b/arch/arm/include/asm/arch-at91/at91_pmc.h
index 2f9ad96..fb8bb17 100644
--- a/arch/arm/include/asm/arch-at91/at91_pmc.h
+++ b/arch/arm/include/asm/arch-at91/at91_pmc.h
@@ -91,10 +91,18 @@ typedef struct at91_pmc {
 #define AT91_PMC_MCKR_PRES_64		0x00000018
 #define AT91_PMC_MCKR_PRES_MASK		0x0000001C
 
+#ifdef CONFIG_AT91RM9200
+#define AT91_PMC_MCKR_MDIV_1		0x00000000
+#define AT91_PMC_MCKR_MDIV_2		0x00000100
+#define AT91_PMC_MCKR_MDIV_3		0x00000200
+#define AT91_PMC_MCKR_MDIV_4		0x00000300
+#define AT91_PMC_MCKR_MDIV_MASK		0x00000300
+#else
 #define AT91_PMC_MCKR_MDIV_1		0x00000000
 #define AT91_PMC_MCKR_MDIV_2		0x00000100
 #define AT91_PMC_MCKR_MDIV_4		0x00000200
 #define AT91_PMC_MCKR_MDIV_MASK		0x00000300
+#endif
 
 #define AT91_PMC_MCKR_PLLADIV_1		0x00001000
 #define AT91_PMC_MCKR_PLLADIV_2		0x00002000
-- 
1.7.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] AT91RM9200: fix AT91_PMC_MCKR_MDIV_* defines for this CPU
  2010-12-06 18:03   ` Guido Classen
@ 2010-12-17  8:05     ` Reinhard Meyer
  0 siblings, 0 replies; 4+ messages in thread
From: Reinhard Meyer @ 2010-12-17  8:05 UTC (permalink / raw)
  To: u-boot

Dear Guido Classen,
> Dear Reinhard Meyer,
> 
> please find below the git-format-patch generated patch.
> Sorry, I can not see whose thread I hijacked. May you please explain?
> 
> Best Regards
>   Guido

Please no patch irrelevant text before the "---" line below!
<manually fixed>

> 
> Signed-off-by: Guido Classen <clagix@gmail.com>
> 
> ---
>  arch/arm/include/asm/arch-at91/at91_pmc.h |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
Applied to u-boot-atmel/for-upstream.
Thanks,
Reinhard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-12-17  8:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-19  1:20 [U-Boot] [PATCH] AT91RM9200: fix AT91_PMC_MCKR_MDIV_* defines for this CPU clagix at gmail.com
2010-12-05  9:51 ` Reinhard Meyer
2010-12-06 18:03   ` Guido Classen
2010-12-17  8:05     ` Reinhard Meyer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.