* [PATCH] ACPI: eliminate unused variable warning for !ACPI_SLEEP
@ 2010-12-07 14:52 Jan Beulich
2010-12-11 6:00 ` Len Brown
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2010-12-07 14:52 UTC (permalink / raw)
To: Len Brown; +Cc: linux-acpi
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
drivers/acpi/sleep.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.37-rc5/drivers/acpi/sleep.c
+++ 2.6.37-rc5-acpi-sleep-warning/drivers/acpi/sleep.c
@@ -27,8 +27,6 @@
static u8 sleep_states[ACPI_S_STATE_COUNT];
-static u32 acpi_target_sleep_state = ACPI_STATE_S0;
-
static void acpi_sleep_tts_switch(u32 acpi_state)
{
union acpi_object in_arg = { ACPI_TYPE_INTEGER };
@@ -81,6 +79,8 @@ static int acpi_sleep_prepare(u32 acpi_s
}
#ifdef CONFIG_ACPI_SLEEP
+static u32 acpi_target_sleep_state = ACPI_STATE_S0;
+
/*
* The ACPI specification wants us to save NVS memory regions during hibernation
* and to restore them during the subsequent resume. Windows does that also for
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI: eliminate unused variable warning for !ACPI_SLEEP
2010-12-07 14:52 [PATCH] ACPI: eliminate unused variable warning for !ACPI_SLEEP Jan Beulich
@ 2010-12-11 6:00 ` Len Brown
2010-12-13 7:59 ` Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: Len Brown @ 2010-12-11 6:00 UTC (permalink / raw)
To: Jan Beulich; +Cc: linux-acpi
applied,
though i'd rather see a pach that makes unreasonable/unlikely
config combinations such as ACPI && !ACPI_SLEEP impossible.
thanks,
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI: eliminate unused variable warning for !ACPI_SLEEP
2010-12-11 6:00 ` Len Brown
@ 2010-12-13 7:59 ` Jan Beulich
0 siblings, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2010-12-13 7:59 UTC (permalink / raw)
To: Len Brown; +Cc: linux-acpi
>>> On 11.12.10 at 07:00, Len Brown <lenb@kernel.org> wrote:
> applied,
> though i'd rather see a pach that makes unreasonable/unlikely
> config combinations such as ACPI && !ACPI_SLEEP impossible.
What's so wrong about !ACPI_SLEEP? Not everyone wants/needs
suspend/hibernate capabilities...
Jan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-13 7:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-07 14:52 [PATCH] ACPI: eliminate unused variable warning for !ACPI_SLEEP Jan Beulich
2010-12-11 6:00 ` Len Brown
2010-12-13 7:59 ` Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.