* [PATCH] [qemu-kvm-next-tree] fix compile error of hw/device-assignment.c
@ 2010-12-09 6:43 Wei Yongjun
2010-12-09 13:38 ` Alex Williamson
2010-12-13 12:04 ` Avi Kivity
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2010-12-09 6:43 UTC (permalink / raw)
To: Avi Kivity; +Cc: alex.williamson, kvm
Fix the following compile error in next tree:
CC x86_64-softmmu/device-assignment.o
hw/device-assignment.c: In function ‘assigned_device_pci_cap_init’:
hw/device-assignment.c:1463: error: ‘PCI_PM_CTRL_NO_SOFT_RST’ undeclared (first use in this function)
hw/device-assignment.c:1463: error: (Each undeclared identifier is reported only once
hw/device-assignment.c:1463: error: for each function it appears in.)
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
hw/device-assignment.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index 50c6408..8446cd4 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -1460,7 +1460,7 @@ static int assigned_device_pci_cap_init(PCIDevice *pci_dev)
/* assign_device will bring the device up to D0, so we don't need
* to worry about doing that ourselves here. */
pci_set_word(pci_dev->config + pos + PCI_PM_CTRL,
- PCI_PM_CTRL_NO_SOFT_RST);
+ PCI_PM_CTRL_NO_SOFT_RESET);
pci_set_byte(pci_dev->config + pos + PCI_PM_PPB_EXTENSIONS, 0);
pci_set_byte(pci_dev->config + pos + PCI_PM_DATA_REGISTER, 0);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [qemu-kvm-next-tree] fix compile error of hw/device-assignment.c
2010-12-09 6:43 [PATCH] [qemu-kvm-next-tree] fix compile error of hw/device-assignment.c Wei Yongjun
@ 2010-12-09 13:38 ` Alex Williamson
2010-12-13 12:04 ` Avi Kivity
1 sibling, 0 replies; 3+ messages in thread
From: Alex Williamson @ 2010-12-09 13:38 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Avi Kivity, kvm
On Thu, 2010-12-09 at 14:43 +0800, Wei Yongjun wrote:
> Fix the following compile error in next tree:
> CC x86_64-softmmu/device-assignment.o
> hw/device-assignment.c: In function ‘assigned_device_pci_cap_init’:
> hw/device-assignment.c:1463: error: ‘PCI_PM_CTRL_NO_SOFT_RST’ undeclared (first use in this function)
> hw/device-assignment.c:1463: error: (Each undeclared identifier is reported only once
> hw/device-assignment.c:1463: error: for each function it appears in.)
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Interesting, my build environment was finding RST somewhere. Thanks for
the fix.
Acked-by: Alex Williamson <alex.williamson@redhat.com>
> ---
> hw/device-assignment.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/device-assignment.c b/hw/device-assignment.c
> index 50c6408..8446cd4 100644
> --- a/hw/device-assignment.c
> +++ b/hw/device-assignment.c
> @@ -1460,7 +1460,7 @@ static int assigned_device_pci_cap_init(PCIDevice *pci_dev)
> /* assign_device will bring the device up to D0, so we don't need
> * to worry about doing that ourselves here. */
> pci_set_word(pci_dev->config + pos + PCI_PM_CTRL,
> - PCI_PM_CTRL_NO_SOFT_RST);
> + PCI_PM_CTRL_NO_SOFT_RESET);
>
> pci_set_byte(pci_dev->config + pos + PCI_PM_PPB_EXTENSIONS, 0);
> pci_set_byte(pci_dev->config + pos + PCI_PM_DATA_REGISTER, 0);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [qemu-kvm-next-tree] fix compile error of hw/device-assignment.c
2010-12-09 6:43 [PATCH] [qemu-kvm-next-tree] fix compile error of hw/device-assignment.c Wei Yongjun
2010-12-09 13:38 ` Alex Williamson
@ 2010-12-13 12:04 ` Avi Kivity
1 sibling, 0 replies; 3+ messages in thread
From: Avi Kivity @ 2010-12-13 12:04 UTC (permalink / raw)
To: Wei Yongjun; +Cc: alex.williamson, kvm
On 12/09/2010 08:43 AM, Wei Yongjun wrote:
> Fix the following compile error in next tree:
> CC x86_64-softmmu/device-assignment.o
> hw/device-assignment.c: In function ‘assigned_device_pci_cap_init’:
> hw/device-assignment.c:1463: error: ‘PCI_PM_CTRL_NO_SOFT_RST’ undeclared (first use in this function)
> hw/device-assignment.c:1463: error: (Each undeclared identifier is reported only once
> hw/device-assignment.c:1463: error: for each function it appears in.)
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-13 12:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-09 6:43 [PATCH] [qemu-kvm-next-tree] fix compile error of hw/device-assignment.c Wei Yongjun
2010-12-09 13:38 ` Alex Williamson
2010-12-13 12:04 ` Avi Kivity
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.