* blame formatting bug
@ 2010-12-09 8:11 Vitali
2010-12-09 13:55 ` Thomas Rast
0 siblings, 1 reply; 2+ messages in thread
From: Vitali @ 2010-12-09 8:11 UTC (permalink / raw)
To: git
Hi.
On the jquery repo the following command:
git blame df9c37ec852f8c873e226cd0ae190f969e0edc17 -- jquery/jquery.js >
blame
gives me the file with this:
c3c706d3 jquery/jquery.js (John Resig 2006-06-22 05:23:38 +0000 576) },
6ae392a4 jquery/jquery.js (John Resig 2006-06-22 20:14:41 +0000 577)
df9c37ec jquery/jquery.js (John Resig 2006-07-09 20:49:40 +0000 578)
extend: function(obj,prop) {
if ( !prop ) {
prop = obj;
obj = this;
}
for ( var i in prop )
obj[i] = prop[i];
return obj;
}
c3c706d3 jquery/jquery.js (John Resig 2006-06-22 05:23:38 +0000 579) };
^8a4a1ed core/core.js (John Resig 2006-03-22 03:33:07 +0000 580)
df9c37ec jquery/jquery.js (John Resig 2006-07-09 20:49:40 +0000 581)
jQuery.extend = jQuery.fn.extend;
Looks like bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: blame formatting bug
2010-12-09 8:11 blame formatting bug Vitali
@ 2010-12-09 13:55 ` Thomas Rast
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Rast @ 2010-12-09 13:55 UTC (permalink / raw)
To: Vitali; +Cc: git
Vitali wrote:
> df9c37ec jquery/jquery.js (John Resig 2006-07-09 20:49:40 +0000 578)
> extend: function(obj,prop) {
> if ( !prop ) {
> prop = obj;
> obj = this;
> }
>
> for ( var i in prop )
> obj[i] = prop[i];
>
> return obj;
> }
>
> Looks like bug.
My 'less' shows that these lines are "terminated" with CRs. Git's
diff engine does not treat CRs as line endings, so neither does blame.
--
Thomas Rast
trast@{inf,student}.ethz.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-09 13:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-09 8:11 blame formatting bug Vitali
2010-12-09 13:55 ` Thomas Rast
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.