All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Breuer <breuerr@mc.net>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: "Blue Swirl" <blauwirbel@gmail.com>,
	"Andreas Färber" <andreas.faerber@web.de>
Subject: [Qemu-devel] [PATCH] sparc32: ledma extra registers need tracing too
Date: Sun, 19 Dec 2010 14:00:08 -0600	[thread overview]
Message-ID: <4D0E6448.7070006@mc.net> (raw)
In-Reply-To: <4D0E5F16.3090905@mc.net>

Also trace the extra registers, and call them undocumented instead.

Signed-off-by: Bob Breuer <breuerr@mc.net>

diff --git a/hw/sparc32_dma.c b/hw/sparc32_dma.c
index 56be8c8..0325a55 100644
--- a/hw/sparc32_dma.c
+++ b/hw/sparc32_dma.c
@@ -170,7 +170,9 @@ static uint32_t dma_mem_readl(void *opaque, target_phys_addr_t addr)
     uint32_t saddr;
 
     if (s->is_ledma && (addr > DMA_MAX_REG_OFFSET)) {
-        return 0; /* extra mystery register(s) */
+        /* extra undocumented register(s) */
+        trace_sparc32_dma_mem_readl(addr, 0);
+        return 0;
     }
     saddr = (addr & DMA_MASK) >> 2;
     trace_sparc32_dma_mem_readl(addr, s->dmaregs[saddr]);
@@ -183,7 +185,9 @@ static void dma_mem_writel(void *opaque, target_phys_addr_t addr, uint32_t val)
     uint32_t saddr;
 
     if (s->is_ledma && (addr > DMA_MAX_REG_OFFSET)) {
-        return; /* extra mystery register(s) */
+        /* extra undocumented register(s) */
+        trace_sparc32_dma_mem_writel(addr, 0, val);
+        return;
     }
     saddr = (addr & DMA_MASK) >> 2;
     trace_sparc32_dma_mem_writel(addr, s->dmaregs[saddr], val);

  reply	other threads:[~2010-12-19 19:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-18 17:09 [Qemu-devel] [PATCH] sparc32: ledma extra registers Bob Breuer
2010-12-18 18:53 ` [Qemu-devel] " Blue Swirl
2010-12-18 20:26   ` Andreas Färber
2010-12-19 19:37     ` Bob Breuer
2010-12-19 20:00       ` Bob Breuer [this message]
2010-12-20 17:55         ` [Qemu-devel] [PATCH v2] sparc32: ledma extra registers need tracing too Bob Breuer
2010-12-20 21:20           ` [Qemu-devel] " Blue Swirl
2010-12-20 10:22       ` [Qemu-devel] Re: [PATCH] sparc32: ledma extra registers Artyom Tarasenko
2010-12-20 17:33         ` Bob Breuer
2010-12-21  9:28           ` Artyom Tarasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D0E6448.7070006@mc.net \
    --to=breuerr@mc.net \
    --cc=andreas.faerber@web.de \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.