* [PATCH v2 2/9] types: Add CDMA Phone Number
@ 2010-12-17 23:11 Dara Spieker-Doyle
2010-12-20 20:48 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: Dara Spieker-Doyle @ 2010-12-17 23:11 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
---
include/types.h | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/include/types.h b/include/types.h
index de15437..a394775 100644
--- a/include/types.h
+++ b/include/types.h
@@ -84,6 +84,14 @@ struct ofono_phone_number {
int type;
};
+/* Length of NUM_FIELDS in 3GPP2 C.S0005-E v2.0*/
+#define OFONO_CDMA_MAX_PHONE_NUMBER_LENGTH 256
+
+struct ofono_cdma_phone_number {
+ /*char maps to max size of CHARi (8 bit) in 3GPP2 C.S0005-E v2.0*/
+ char number[OFONO_CDMA_MAX_PHONE_NUMBER_LENGTH];
+};
+
struct ofono_call {
unsigned int id;
int type;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 2/9] types: Add CDMA Phone Number
2010-12-17 23:11 [PATCH v2 2/9] types: Add CDMA Phone Number Dara Spieker-Doyle
@ 2010-12-20 20:48 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2010-12-20 20:48 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 946 bytes --]
Hi Dara,
On 12/17/2010 05:11 PM, Dara Spieker-Doyle wrote:
> ---
> include/types.h | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/include/types.h b/include/types.h
> index de15437..a394775 100644
> --- a/include/types.h
> +++ b/include/types.h
> @@ -84,6 +84,14 @@ struct ofono_phone_number {
> int type;
> };
>
I applied this patch, but amended the commit for some trivial style issues:
> +/* Length of NUM_FIELDS in 3GPP2 C.S0005-E v2.0*/
The closing comment */ should have a space in front
> +#define OFONO_CDMA_MAX_PHONE_NUMBER_LENGTH 256
> +
> +struct ofono_cdma_phone_number {
> + /*char maps to max size of CHARi (8 bit) in 3GPP2 C.S0005-E v2.0*/
Space after the comment opening and before the comment closing.
> + char number[OFONO_CDMA_MAX_PHONE_NUMBER_LENGTH];
> +};
> +
> struct ofono_call {
> unsigned int id;
> int type;
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-20 20:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-17 23:11 [PATCH v2 2/9] types: Add CDMA Phone Number Dara Spieker-Doyle
2010-12-20 20:48 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.