Re: [PATCH] ETM: Fix etm_probe and etb_probe section mismatch warnings in arch/arm/kernel/etm.c

Re: [PATCH] ETM: Fix etm_probe and etb_probe section mismatch warnings in arch/arm/kernel/etm.c

[Nishanth Menon]

Elvis Dowson had written, on 12/26/2010 03:26 PM, the following:
> Hi,
>        This patch fixes section mismatch warnings for etm_probe() and etb_probe() for linux-2.6.37-rc7.
> 
> Elvis Dowson

Could you post this to l-a and cc l-o?
a better cc list is got by scripts/get_maintainer.pl patch

> 
> 
> From d9168ebf22bfac428955b3a3fe2d657faae4a9ee Mon Sep 17 00:00:00 2001
> From: Elvis Dowson <elvis.dowson@gmail.com>
> Date: Mon, 27 Dec 2010 01:21:39 +0400
> Subject: [PATCH] ETM: Fix etm_probe and etb_probe section mismatch warnings in arch/arm/kernel/etm.c
> 
> Fix the following section mismatch warning when building omap2plus_defconfig:
> 
> WARNING: vmlinux.o(.data+0x1b70): Section mismatch in reference from the variable etb_driver to the function .init.text:etb_probe()
> 
> WARNING: vmlinux.o(.data+0x1bbc): Section mismatch in reference from the variable etm_driver to the function .init.text:etm_probe() 
> 
> Signed-off-by: Elvis Dowson <elvis.dowson@gmail.com>
> ---
>  arch/arm/kernel/etm.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/kernel/etm.c b/arch/arm/kernel/etm.c
> index 11db628..e881a0d 100644
> --- a/arch/arm/kernel/etm.c
> +++ b/arch/arm/kernel/etm.c
> @@ -338,7 +338,7 @@ static struct miscdevice etb_miscdev = {
>  	.fops = &etb_fops,
>  };
>  
> -static int __init etb_probe(struct amba_device *dev, struct amba_id *id)
> +static int __devinit etb_probe(struct amba_device *dev, struct amba_id *id)
>  {
>  	struct tracectx *t = &tracer;
>  	int ret = 0;
> @@ -530,7 +530,7 @@ static ssize_t trace_mode_store(struct kobject *kobj,
>  static struct kobj_attribute trace_mode_attr =
>  	__ATTR(trace_mode, 0644, trace_mode_show, trace_mode_store);
>  
> -static int __init etm_probe(struct amba_device *dev, struct amba_id *id)
> +static int __devinit etm_probe(struct amba_device *dev, struct amba_id *id)
>  {
>  	struct tracectx *t = &tracer;
>  	int ret = 0;


-- 
Regards,
Nishanth Menon

Re: [PATCH] ETM: Fix etm_probe and etb_probe section mismatch warnings in arch/arm/kernel/etm.c

[Tony Lindgren]

Hi,

* Elvis Dowson <elvis.dowson@mac.com> [101226 13:26]:
> Hi,
>        This patch fixes section mismatch warnings for etm_probe() and etb_probe() for linux-2.6.37-rc7.

This you should resend to linux-arm-kernel.

Regards,

Tony