All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] [PATCH] hwmon: Add humidity attribute to sysfs ABI
@ 2011-01-06 15:30 Guenter Roeck
  2011-01-06 15:39 ` Jonathan Cameron
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Guenter Roeck @ 2011-01-06 15:30 UTC (permalink / raw)
  To: lm-sensors

The humidity attribute is already supported by the sht15 driver, and another
driver supporting it is about to be added. Make it official.

Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
---
 Documentation/hwmon/sysfs-interface |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
index 5997b5e..033fe76 100644
--- a/Documentation/hwmon/sysfs-interface
+++ b/Documentation/hwmon/sysfs-interface
@@ -505,6 +505,15 @@ energy[1-*]_input		Cumulative energy use
 				RO
 
 
+************
+* Humidity *
+************
+
+humidity[1-*]_input		Humidity
+				Unit: percent
+				RO
+
+
 **********
 * Alarms *
 **********
-- 
1.7.3.1


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [lm-sensors] [PATCH] hwmon: Add humidity attribute to sysfs ABI
  2011-01-06 15:30 [lm-sensors] [PATCH] hwmon: Add humidity attribute to sysfs ABI Guenter Roeck
@ 2011-01-06 15:39 ` Jonathan Cameron
  2011-01-06 16:33 ` Jean Delvare
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Jonathan Cameron @ 2011-01-06 15:39 UTC (permalink / raw)
  To: lm-sensors

On 01/06/11 16:00, Guenter Roeck wrote:
> The humidity attribute is already supported by the sht15 driver, and another
> driver supporting it is about to be added. Make it official.
> 
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
> ---
>  Documentation/hwmon/sysfs-interface |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
> index 5997b5e..033fe76 100644
> --- a/Documentation/hwmon/sysfs-interface
> +++ b/Documentation/hwmon/sysfs-interface
> @@ -505,6 +505,15 @@ energy[1-*]_input		Cumulative energy use
>  				RO
>  
>  
> +************
> +* Humidity *
> +************
> +
> +humidity[1-*]_input		Humidity
> +				Unit: percent
> +				RO
> +
> +
>  **********
>  * Alarms *
>  **********


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [lm-sensors] [PATCH] hwmon: Add humidity attribute to sysfs ABI
  2011-01-06 15:30 [lm-sensors] [PATCH] hwmon: Add humidity attribute to sysfs ABI Guenter Roeck
  2011-01-06 15:39 ` Jonathan Cameron
@ 2011-01-06 16:33 ` Jean Delvare
  2011-01-06 16:50 ` Guenter Roeck
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Jean Delvare @ 2011-01-06 16:33 UTC (permalink / raw)
  To: lm-sensors

On Thu, 6 Jan 2011 08:00:42 -0800, Guenter Roeck wrote:
> The humidity attribute is already supported by the sht15 driver, and another
> driver supporting it is about to be added. Make it official.
> 
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> ---
>  Documentation/hwmon/sysfs-interface |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
> index 5997b5e..033fe76 100644
> --- a/Documentation/hwmon/sysfs-interface
> +++ b/Documentation/hwmon/sysfs-interface
> @@ -505,6 +505,15 @@ energy[1-*]_input		Cumulative energy use
>  				RO
>  
>  
> +************
> +* Humidity *
> +************
> +
> +humidity[1-*]_input		Humidity
> +				Unit: percent

Are you sure? The sht15 driver source code suggests millipercent.
Jonathan?

> +				RO
> +
> +
>  **********
>  * Alarms *
>  **********


-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [lm-sensors] [PATCH] hwmon: Add humidity attribute to sysfs ABI
  2011-01-06 15:30 [lm-sensors] [PATCH] hwmon: Add humidity attribute to sysfs ABI Guenter Roeck
  2011-01-06 15:39 ` Jonathan Cameron
  2011-01-06 16:33 ` Jean Delvare
@ 2011-01-06 16:50 ` Guenter Roeck
  2011-01-06 17:34 ` Jean Delvare
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2011-01-06 16:50 UTC (permalink / raw)
  To: lm-sensors

On Thu, Jan 06, 2011 at 11:33:00AM -0500, Jean Delvare wrote:
> On Thu, 6 Jan 2011 08:00:42 -0800, Guenter Roeck wrote:
> > The humidity attribute is already supported by the sht15 driver, and another
> > driver supporting it is about to be added. Make it official.
> > 
> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> > ---
> >  Documentation/hwmon/sysfs-interface |    9 +++++++++
> >  1 files changed, 9 insertions(+), 0 deletions(-)
> > 
> > diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
> > index 5997b5e..033fe76 100644
> > --- a/Documentation/hwmon/sysfs-interface
> > +++ b/Documentation/hwmon/sysfs-interface
> > @@ -505,6 +505,15 @@ energy[1-*]_input		Cumulative energy use
> >  				RO
> >  
> >  
> > +************
> > +* Humidity *
> > +************
> > +
> > +humidity[1-*]_input		Humidity
> > +				Unit: percent
> 
> Are you sure? The sht15 driver source code suggests millipercent.
> Jonathan?
> 
Yes, you are right. Just noticed that as well.

What would be the best term to use ? millipercent ? milli-percent ? per cent mille ?
The latter is the official term. How about 
	Unit: per cent mille (pcm, milli-percent)

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [lm-sensors] [PATCH] hwmon: Add humidity attribute to sysfs ABI
  2011-01-06 15:30 [lm-sensors] [PATCH] hwmon: Add humidity attribute to sysfs ABI Guenter Roeck
                   ` (2 preceding siblings ...)
  2011-01-06 16:50 ` Guenter Roeck
@ 2011-01-06 17:34 ` Jean Delvare
  2011-01-06 17:48 ` Jonathan Cameron
  2011-01-06 18:10 ` Guenter Roeck
  5 siblings, 0 replies; 7+ messages in thread
From: Jean Delvare @ 2011-01-06 17:34 UTC (permalink / raw)
  To: lm-sensors

On Thu, 6 Jan 2011 08:50:03 -0800, Guenter Roeck wrote:
> On Thu, Jan 06, 2011 at 11:33:00AM -0500, Jean Delvare wrote:
> > On Thu, 6 Jan 2011 08:00:42 -0800, Guenter Roeck wrote:
> > > The humidity attribute is already supported by the sht15 driver, and another
> > > driver supporting it is about to be added. Make it official.
> > > 
> > > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> > > ---
> > >  Documentation/hwmon/sysfs-interface |    9 +++++++++
> > >  1 files changed, 9 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
> > > index 5997b5e..033fe76 100644
> > > --- a/Documentation/hwmon/sysfs-interface
> > > +++ b/Documentation/hwmon/sysfs-interface
> > > @@ -505,6 +505,15 @@ energy[1-*]_input		Cumulative energy use
> > >  				RO
> > >  
> > >  
> > > +************
> > > +* Humidity *
> > > +************
> > > +
> > > +humidity[1-*]_input		Humidity
> > > +				Unit: percent
> > 
> > Are you sure? The sht15 driver source code suggests millipercent.
> > Jonathan?
> > 
> Yes, you are right. Just noticed that as well.
> 
> What would be the best term to use ? millipercent ? milli-percent ? per cent mille ?
> The latter is the official term. How about 
> 	Unit: per cent mille (pcm, milli-percent)

I'm fine either way.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [lm-sensors] [PATCH] hwmon: Add humidity attribute to sysfs ABI
  2011-01-06 15:30 [lm-sensors] [PATCH] hwmon: Add humidity attribute to sysfs ABI Guenter Roeck
                   ` (3 preceding siblings ...)
  2011-01-06 17:34 ` Jean Delvare
@ 2011-01-06 17:48 ` Jonathan Cameron
  2011-01-06 18:10 ` Guenter Roeck
  5 siblings, 0 replies; 7+ messages in thread
From: Jonathan Cameron @ 2011-01-06 17:48 UTC (permalink / raw)
  To: lm-sensors

On 01/06/11 16:50, Guenter Roeck wrote:
> On Thu, Jan 06, 2011 at 11:33:00AM -0500, Jean Delvare wrote:
>> On Thu, 6 Jan 2011 08:00:42 -0800, Guenter Roeck wrote:
>>> The humidity attribute is already supported by the sht15 driver, and another
>>> driver supporting it is about to be added. Make it official.
>>>
>>> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
>>> ---
>>>  Documentation/hwmon/sysfs-interface |    9 +++++++++
>>>  1 files changed, 9 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
>>> index 5997b5e..033fe76 100644
>>> --- a/Documentation/hwmon/sysfs-interface
>>> +++ b/Documentation/hwmon/sysfs-interface
>>> @@ -505,6 +505,15 @@ energy[1-*]_input		Cumulative energy use
>>>  				RO
>>>  
>>>  
>>> +************
>>> +* Humidity *
>>> +************
>>> +
>>> +humidity[1-*]_input		Humidity
>>> +				Unit: percent
>>
>> Are you sure? The sht15 driver source code suggests millipercent.
>> Jonathan?
Oops, not one of my better bits of reviewing...
>>
> Yes, you are right. Just noticed that as well.
> 
> What would be the best term to use ? millipercent ? milli-percent ? per cent mille ?
> The latter is the official term. How about 
> 	Unit: per cent mille (pcm, milli-percent)
could multiply values by 10 then use Permyriad :)
Otherwise maybe just write it out clearly as 'thousandth of a percent'?
> 
> Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [lm-sensors] [PATCH] hwmon: Add humidity attribute to sysfs ABI
  2011-01-06 15:30 [lm-sensors] [PATCH] hwmon: Add humidity attribute to sysfs ABI Guenter Roeck
                   ` (4 preceding siblings ...)
  2011-01-06 17:48 ` Jonathan Cameron
@ 2011-01-06 18:10 ` Guenter Roeck
  5 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2011-01-06 18:10 UTC (permalink / raw)
  To: lm-sensors

On Thu, 2011-01-06 at 12:48 -0500, Jonathan Cameron wrote:
> On 01/06/11 16:50, Guenter Roeck wrote:
> > On Thu, Jan 06, 2011 at 11:33:00AM -0500, Jean Delvare wrote:
> >> On Thu, 6 Jan 2011 08:00:42 -0800, Guenter Roeck wrote:
> >>> The humidity attribute is already supported by the sht15 driver, and another
> >>> driver supporting it is about to be added. Make it official.
> >>>
> >>> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> >>> ---
> >>>  Documentation/hwmon/sysfs-interface |    9 +++++++++
> >>>  1 files changed, 9 insertions(+), 0 deletions(-)
> >>>
> >>> diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
> >>> index 5997b5e..033fe76 100644
> >>> --- a/Documentation/hwmon/sysfs-interface
> >>> +++ b/Documentation/hwmon/sysfs-interface
> >>> @@ -505,6 +505,15 @@ energy[1-*]_input		Cumulative energy use
> >>>  				RO
> >>>  
> >>>  
> >>> +************
> >>> +* Humidity *
> >>> +************
> >>> +
> >>> +humidity[1-*]_input		Humidity
> >>> +				Unit: percent
> >>
> >> Are you sure? The sht15 driver source code suggests millipercent.
> >> Jonathan?
> Oops, not one of my better bits of reviewing...
> >>
> > Yes, you are right. Just noticed that as well.
> > 
> > What would be the best term to use ? millipercent ? milli-percent ? per cent mille ?
> > The latter is the official term. How about 
> > 	Unit: per cent mille (pcm, milli-percent)
> could multiply values by 10 then use Permyriad :)
> Otherwise maybe just write it out clearly as 'thousandth of a percent'?

Thought about that, but "a percent" sounds odd (what is "a percent" ?),
and "thousandth of percent" may be confused with "thousands of percent".
I think I'll go with "milli-percent (per cent mille, pcm)".

Guenter



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2011-01-06 18:10 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-06 15:30 [lm-sensors] [PATCH] hwmon: Add humidity attribute to sysfs ABI Guenter Roeck
2011-01-06 15:39 ` Jonathan Cameron
2011-01-06 16:33 ` Jean Delvare
2011-01-06 16:50 ` Guenter Roeck
2011-01-06 17:34 ` Jean Delvare
2011-01-06 17:48 ` Jonathan Cameron
2011-01-06 18:10 ` Guenter Roeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.