* libcap_1.10: ERROR: QA Issue with libcap: non -dev package contains symlink .so
@ 2011-01-09 14:56 Paul Menzel
2011-01-09 18:20 ` Khem Raj
0 siblings, 1 reply; 7+ messages in thread
From: Paul Menzel @ 2011-01-09 14:56 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 950 bytes --]
Dear OE folks,
doing `bitbake -k libcap` with latest master (3d030f) with
`minimal-uclibc` for `MACHINE = "beagleboard"`
NOTE: package libcap-1.10-r2: task do_qa_staging: Succeeded
ERROR: QA Issue with libcap: non -dev package contains symlink .so: libcap path '/work/armv7a-oe-linux-uclibceabi/libcap-1.10-r2/packages-split/libcap/usr/lib/libcap.so'
ERROR: QA Issue with libcap: non -dev package contains symlink .so: libcap path '/work/armv7a-oe-linux-uclibceabi/libcap-1.10-r2/packages-split/libcap/usr/lib/libcap.so'
NOTE: package libcap-1.10-r2: task do_package: Succeeded
Is that error reasonable or are library packages not allowed to have
symlinks [1]?
FILES_${PN} = "${libdir}"
FILES_${PN}-dev = "${includedir}"
Thanks,
Paul
[1] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/libcap/libcap_1.10.bb?id=3d030ffa57af27275fbb42eaa0fcd611f4925348
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: libcap_1.10: ERROR: QA Issue with libcap: non -dev package contains symlink .so
2011-01-09 14:56 libcap_1.10: ERROR: QA Issue with libcap: non -dev package contains symlink .so Paul Menzel
@ 2011-01-09 18:20 ` Khem Raj
2011-01-10 11:39 ` [PATCH] libcap, libcap2: use automatic packaging to fix QA errors Paul Menzel
0 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2011-01-09 18:20 UTC (permalink / raw)
To: openembedded-devel
On 1/9/2011 6:56 AM, Paul Menzel wrote:
> Dear OE folks,
>
>
> doing `bitbake -k libcap` with latest master (3d030f) with
> `minimal-uclibc` for `MACHINE = "beagleboard"`
>
> NOTE: package libcap-1.10-r2: task do_qa_staging: Succeeded
> ERROR: QA Issue with libcap: non -dev package contains symlink .so: libcap path '/work/armv7a-oe-linux-uclibceabi/libcap-1.10-r2/packages-split/libcap/usr/lib/libcap.so'
> ERROR: QA Issue with libcap: non -dev package contains symlink .so: libcap path '/work/armv7a-oe-linux-uclibceabi/libcap-1.10-r2/packages-split/libcap/usr/lib/libcap.so'
> NOTE: package libcap-1.10-r2: task do_package: Succeeded
>
> Is that error reasonable or are library packages not allowed to have
> symlinks [1]?
Usually sylinks are needed for debugging and linking thats why its
preferred in -dev packages. But you can sort it out by removing the
below lines and see how the automatic package puts stuff
>
> FILES_${PN} = "${libdir}"
> FILES_${PN}-dev = "${includedir}"
>
>
> Thanks,
>
> Paul
>
>
> [1] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/libcap/libcap_1.10.bb?id=3d030ffa57af27275fbb42eaa0fcd611f4925348
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] libcap, libcap2: use automatic packaging to fix QA errors
2011-01-09 18:20 ` Khem Raj
@ 2011-01-10 11:39 ` Paul Menzel
2011-01-10 13:44 ` Rolf Leggewie
0 siblings, 1 reply; 7+ messages in thread
From: Paul Menzel @ 2011-01-10 11:39 UTC (permalink / raw)
To: openembedded-devel; +Cc: Rolf Leggewie
[-- Attachment #1: Type: text/plain, Size: 4791 bytes --]
Date: Mon, 10 Jan 2011 12:09:26 +0100
Since commit 6883f6 [1] packages have been populated manually.
FILES_${PN} = "${libdir}"
FILES_${PN}-dev = "${includedir}"
This gives the following QA errors for `libcap` and `libcap2` (which is based on `libcap` [2]) [3].
• `libcap`:
ERROR: QA Issue with libcap: non -dev package contains symlink .so: libcap path '/work/armv7a-oe-linux-uclibceabi/libcap-1.10-r2/packages-split/libcap/usr/lib/libcap.so'
ERROR: QA Issue with libcap: non -dev package contains symlink .so: libcap path '/work/armv7a-oe-linux-uclibceabi/libcap-1.10-r2/packages-split/libcap/usr/lib/libcap.so'
• `libcap2`:
ERROR: QA Issue with libcap2: non -dev package contains symlink .so: libcap2 path '/work/armv7a-oe-linux-uclibceabi/libcap2-2.16-r1/packages-split/libcap2/usr/lib/libcap.so'
ERROR: QA Issue with libcap2: non -dev package contains symlink .so: libcap2 path '/work/armv7a-oe-linux-uclibceabi/libcap2-2.16-r1/packages-split/libcap2/usr/lib/libcap.so'
Using automatic packages the symlink `libcap.so -> libcap.so.1.10` is put into `libcap{,2}-dev`.
Note: The symlink `libcap.so.1 -> libcap.so.1.10` is still put into `libcap1_1.10-r2_armv7a.ipk` but does not raise a QA error.
[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=6883f65588c6aa7e9780ff7c11b15a397382a422
[2] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=c71a6ebf796df907ba0d4339e6acf66faa3c6232
[3] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-January/028557.html
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
CC: Rolf Leggewie <no2spam@nospam.arcornews.de>
---
Am Sonntag, den 09.01.2011, 10:20 -0800 schrieb Khem Raj:
> On 1/9/2011 6:56 AM, Paul Menzel wrote:
> > doing `bitbake -k libcap` with latest master (3d030f) with
> > `minimal-uclibc` for `MACHINE = "beagleboard"`
> >
> > NOTE: package libcap-1.10-r2: task do_qa_staging: Succeeded
> > ERROR: QA Issue with libcap: non -dev package contains symlink .so: libcap path '/work/armv7a-oe-linux-uclibceabi/libcap-1.10-r2/packages-split/libcap/usr/lib/libcap.so'
> > ERROR: QA Issue with libcap: non -dev package contains symlink .so: libcap path '/work/armv7a-oe-linux-uclibceabi/libcap-1.10-r2/packages-split/libcap/usr/lib/libcap.so'
> > NOTE: package libcap-1.10-r2: task do_package: Succeeded
> >
> > Is that error reasonable or are library packages not allowed to have
> > symlinks [1]?
>
> Usually sylinks are needed for debugging and linking thats why its
> preferred in -dev packages. But you can sort it out by removing the
> below lines and see how the automatic package puts stuff
You are right, automatic packaging puts the symlink into `libcap-dev`,
but as noted `libcap.so.1` is still in the “main” package.
> >
> > FILES_${PN} = "${libdir}"
> > FILES_${PN}-dev = "${includedir}"
I am putting Rolf into CC to get the reasoning for the previous
behavior.
> > [1] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/libcap/libcap_1.10.bb?id=3d030ffa57af27275fbb42eaa0fcd611f4925348
---
recipes/libcap/libcap2_2.16.bb | 5 +----
recipes/libcap/libcap_1.10.bb | 5 +----
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/recipes/libcap/libcap2_2.16.bb b/recipes/libcap/libcap2_2.16.bb
index 92cd50f..97b03d5 100644
--- a/recipes/libcap/libcap2_2.16.bb
+++ b/recipes/libcap/libcap2_2.16.bb
@@ -3,7 +3,7 @@ PRIORITY = "optional"
SECTION = "libs"
LICENSE = "GPL"
DEPENDS = "bison-native flex-native attr"
-PR = "r1"
+PR = "r2"
BUILD_CFLAGS += "-I${S}/libcap/include"
CFLAGS += "-I${S}/libcap/include"
@@ -15,9 +15,6 @@ SRC_URI = "${KERNELORG_MIRROR}/pub/linux/libs/security/linux-privs/libcap2/libca
S = "${WORKDIR}/libcap-${PV}"
-FILES_${PN} = "${libdir}"
-FILES_${PN}-dev = "${includedir}"
-
do_install() {
install -d ${D}${includedir}/sys
install -m 0644 libcap/include/sys/capability.h ${D}${includedir}/sys/
diff --git a/recipes/libcap/libcap_1.10.bb b/recipes/libcap/libcap_1.10.bb
index af5600b..a9444bb 100644
--- a/recipes/libcap/libcap_1.10.bb
+++ b/recipes/libcap/libcap_1.10.bb
@@ -3,7 +3,7 @@ PRIORITY = "optional"
SECTION = "libs"
LICENSE = "GPL"
DEPENDS = "bison-native flex-native"
-PR = "r2"
+PR = "r3"
CFLAGS_append = " -I${S}/libcap/include -fPIC"
@@ -12,9 +12,6 @@ SRC_URI = "${KERNELORG_MIRROR}/pub/linux/libs/security/linux-privs/kernel-2.4/${
file://make.patch \
file://syscall.patch"
-FILES_${PN} = "${libdir}"
-FILES_${PN}-dev = "${includedir}"
-
do_install() {
install -d ${D}${includedir}/sys
install -m 0644 libcap/include/sys/capability.h ${D}${includedir}/sys/
--
1.7.2.3
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] libcap, libcap2: use automatic packaging to fix QA errors
2011-01-10 11:39 ` [PATCH] libcap, libcap2: use automatic packaging to fix QA errors Paul Menzel
@ 2011-01-10 13:44 ` Rolf Leggewie
2011-01-10 14:45 ` Paul Menzel
0 siblings, 1 reply; 7+ messages in thread
From: Rolf Leggewie @ 2011-01-10 13:44 UTC (permalink / raw)
To: Paul Menzel, Paul Menzel; +Cc: openembedded-devel
On 10.01.2011 19:39, Paul Menzel wrote
>>> FILES_${PN} = "${libdir}"
>>> FILES_${PN}-dev = "${includedir}"
>
> I am putting Rolf into CC to get the reasoning for the previous
> behavior.
My commit did not change the previous behaviour as far as I can see and
thus I cannot comment on it. Maybe you want to look deeper into the
history of that file. Sorry.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] libcap, libcap2: use automatic packaging to fix QA errors
2011-01-10 13:44 ` Rolf Leggewie
@ 2011-01-10 14:45 ` Paul Menzel
2011-01-10 21:11 ` Dirk Opfer
2011-01-10 21:15 ` Dirk Opfer
0 siblings, 2 replies; 7+ messages in thread
From: Paul Menzel @ 2011-01-10 14:45 UTC (permalink / raw)
To: openembedded-devel; +Cc: Dirk Opfer
[-- Attachment #1: Type: text/plain, Size: 814 bytes --]
Am Montag, den 10.01.2011, 21:44 +0800 schrieb Rolf Leggewie:
> On 10.01.2011 19:39, Paul Menzel wrote
> >>> FILES_${PN} = "${libdir}"
> >>> FILES_${PN}-dev = "${includedir}"
> >
> > I am putting Rolf into CC to get the reasoning for the previous
> > behavior.
>
> My commit did not change the previous behaviour as far as I can see and
> thus I cannot comment on it.
Sorry, I misinterpreted `git blame`.
> Maybe you want to look deeper into the history of that file. Sorry.
It looks Dirk committed these lines when adding 1.10 in commit b823b4
[1].
Dirk, could you please comment on [2].
Thanks,
Paul
[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=b823b49470515182cb6f7a536d6a63fac53948aa
[2] http://patches.openembedded.org/patch/218/
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] libcap, libcap2: use automatic packaging to fix QA errors
2011-01-10 14:45 ` Paul Menzel
@ 2011-01-10 21:11 ` Dirk Opfer
2011-01-10 21:15 ` Dirk Opfer
1 sibling, 0 replies; 7+ messages in thread
From: Dirk Opfer @ 2011-01-10 21:11 UTC (permalink / raw)
To: openembedded-devel
Am 10.01.2011 15:45, schrieb Paul Menzel:
> Maybe you want to look deeper into the history of that file. Sorry.
> It looks Dirk committed these lines when adding 1.10 in commit b823b4
> [1].
>
> Dirk, could you please comment on [2].
>
No idea why this was needed in the old version.
Looks fine to me.
Acked-by: Dirk Opfer <dirk@do13.de>
Thanks,
Dirk
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] libcap, libcap2: use automatic packaging to fix QA errors
2011-01-10 14:45 ` Paul Menzel
2011-01-10 21:11 ` Dirk Opfer
@ 2011-01-10 21:15 ` Dirk Opfer
1 sibling, 0 replies; 7+ messages in thread
From: Dirk Opfer @ 2011-01-10 21:15 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 374 bytes --]
Am 10.01.2011 15:45, schrieb Paul Menzel:
> Maybe you want to look deeper into the history of that file. Sorry.
> It looks Dirk committed these lines when adding 1.10 in commit b823b4
> [1].
>
> Dirk, could you please comment on [2].
>
No idea why this was needed in the old version.
Looks fine to me.
Acked-by: Dirk Opfer <dirk@do13.de>
Thanks,
Dirk
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 3530 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-01-10 21:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-09 14:56 libcap_1.10: ERROR: QA Issue with libcap: non -dev package contains symlink .so Paul Menzel
2011-01-09 18:20 ` Khem Raj
2011-01-10 11:39 ` [PATCH] libcap, libcap2: use automatic packaging to fix QA errors Paul Menzel
2011-01-10 13:44 ` Rolf Leggewie
2011-01-10 14:45 ` Paul Menzel
2011-01-10 21:11 ` Dirk Opfer
2011-01-10 21:15 ` Dirk Opfer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.