[Qemu-devel] [PATCH] do_snapshot_blkdev() error on missing snapshot_file argument

* [Qemu-devel] [PATCH] do_snapshot_blkdev() error on missing snapshot_file argument
@ 2011-01-06 16:02 Jes.Sorensen
  2011-01-11 12:16 ` Kevin Wolf
  0 siblings, 1 reply; 2+ messages in thread
From: Jes.Sorensen @ 2011-01-06 16:02 UTC (permalink / raw)
  To: anthony; +Cc: qemu-devel

From: Jes Sorensen <Jes.Sorensen@redhat.com>

Current code does not support snapshot internally to the running
image. Error in case no snapshot_file is specified.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
 blockdev.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/blockdev.c b/blockdev.c
index d7add36..662f7a9 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -526,6 +526,12 @@ int do_snapshot_blkdev(Monitor *mon, const QDict *qdict, QObject **ret_data)
     int ret = 0;
     int flags;
 
+    if (!filename) {
+        qerror_report(QERR_MISSING_PARAMETER, "snapshot_file");
+        ret = -1;
+        goto out;
+    }
+
     bs = bdrv_find(device);
     if (!bs) {
         qerror_report(QERR_DEVICE_NOT_FOUND, device);
-- 
1.7.3.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread