* [GIT PATCHES FOR 2.6.38] Use the control framework in various subdevs
@ 2010-12-31 13:36 Hans Verkuil
2011-01-07 9:49 ` Hans Verkuil
0 siblings, 1 reply; 5+ messages in thread
From: Hans Verkuil @ 2010-12-31 13:36 UTC (permalink / raw)
To: linux-media; +Cc: Andy Walls
This is a pull request for a subset of the RFC patch series I posted almost
three weeks ago.
The only change is cx18 where Andy Walls pointed out some bugs. The same bugs
were introduced in cx25840 and Andy's fixes for those had to be applied as well
in cx18 for the AV core.
I dropped tvaudio, tda7432, tda9875 and ov7670 for now since these need more
testing.
This has been tested with the vivi, cx18, em28xx and vpif_capture/vpif_display
drivers.
Regards,
Hans
The following changes since commit 187134a5875df20356f4dca075db29f294115a47:
David Henningsson (1):
[media] DVB: IR support for TechnoTrend CT-3650
are available in the git repository at:
ssh://linuxtv.org/git/hverkuil/media_tree.git subdev-ctrl1
Hans Verkuil (11):
cs5345: use the control framework
cx18: Use the control framework.
adv7343: use control framework
bt819: use control framework
saa7110: use control framework
tlv320aic23b: use control framework
tvp514x: use the control framework
tvp5150: use the control framework
vpx3220: use control framework
tvp7002: use control framework
vivi: convert to the control framework and add test controls.
drivers/media/video/adv7343.c | 167 +++++++-----------
drivers/media/video/adv7343_regs.h | 8 +-
drivers/media/video/bt819.c | 129 +++++---------
drivers/media/video/cs5345.c | 87 ++++++---
drivers/media/video/cx18/cx18-av-audio.c | 92 ++---------
drivers/media/video/cx18/cx18-av-core.c | 175 ++++++++-----------
drivers/media/video/cx18/cx18-av-core.h | 12 +-
drivers/media/video/cx18/cx18-controls.c | 285 ++++--------------------------
drivers/media/video/cx18/cx18-controls.h | 7 +-
drivers/media/video/cx18/cx18-driver.c | 30 ++--
drivers/media/video/cx18/cx18-driver.h | 2 +-
drivers/media/video/cx18/cx18-fileops.c | 32 +---
drivers/media/video/cx18/cx18-ioctl.c | 24 +--
drivers/media/video/cx18/cx18-mailbox.c | 5 +-
drivers/media/video/cx18/cx18-mailbox.h | 5 -
drivers/media/video/cx18/cx18-streams.c | 16 +-
drivers/media/video/saa7110.c | 115 +++++-------
drivers/media/video/tlv320aic23b.c | 74 +++++---
drivers/media/video/tvp514x.c | 236 ++++++-------------------
drivers/media/video/tvp5150.c | 157 +++++------------
drivers/media/video/tvp7002.c | 117 +++++--------
drivers/media/video/vivi.c | 228 +++++++++++++++---------
drivers/media/video/vpx3220.c | 137 ++++++---------
23 files changed, 773 insertions(+), 1367 deletions(-)
--
Hans Verkuil - video4linux developer - sponsored by Cisco
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [GIT PATCHES FOR 2.6.38] Use the control framework in various subdevs
2010-12-31 13:36 [GIT PATCHES FOR 2.6.38] Use the control framework in various subdevs Hans Verkuil
@ 2011-01-07 9:49 ` Hans Verkuil
2011-01-07 10:44 ` Hans Verkuil
0 siblings, 1 reply; 5+ messages in thread
From: Hans Verkuil @ 2011-01-07 9:49 UTC (permalink / raw)
To: linux-media; +Cc: Andy Walls, Mauro Carvalho Chehab
Hi Mauro,
On Friday, December 31, 2010 14:36:59 Hans Verkuil wrote:
> This is a pull request for a subset of the RFC patch series I posted almost
> three weeks ago.
Please don't merge this yet. While testing the ov7670 driver I came across
some issues that may affect some drivers in this patch series as well. I need
to do some more debugging and testing to verify whether this patch series can
go ahead or not. I'll get back to you on this once I know more.
Regards,
Hans
> The only change is cx18 where Andy Walls pointed out some bugs. The same bugs
> were introduced in cx25840 and Andy's fixes for those had to be applied as well
> in cx18 for the AV core.
>
> I dropped tvaudio, tda7432, tda9875 and ov7670 for now since these need more
> testing.
>
> This has been tested with the vivi, cx18, em28xx and vpif_capture/vpif_display
> drivers.
>
> Regards,
>
> Hans
>
> The following changes since commit 187134a5875df20356f4dca075db29f294115a47:
> David Henningsson (1):
> [media] DVB: IR support for TechnoTrend CT-3650
>
> are available in the git repository at:
>
> ssh://linuxtv.org/git/hverkuil/media_tree.git subdev-ctrl1
>
> Hans Verkuil (11):
> cs5345: use the control framework
> cx18: Use the control framework.
> adv7343: use control framework
> bt819: use control framework
> saa7110: use control framework
> tlv320aic23b: use control framework
> tvp514x: use the control framework
> tvp5150: use the control framework
> vpx3220: use control framework
> tvp7002: use control framework
> vivi: convert to the control framework and add test controls.
>
> drivers/media/video/adv7343.c | 167 +++++++-----------
> drivers/media/video/adv7343_regs.h | 8 +-
> drivers/media/video/bt819.c | 129 +++++---------
> drivers/media/video/cs5345.c | 87 ++++++---
> drivers/media/video/cx18/cx18-av-audio.c | 92 ++---------
> drivers/media/video/cx18/cx18-av-core.c | 175 ++++++++-----------
> drivers/media/video/cx18/cx18-av-core.h | 12 +-
> drivers/media/video/cx18/cx18-controls.c | 285 ++++--------------------------
> drivers/media/video/cx18/cx18-controls.h | 7 +-
> drivers/media/video/cx18/cx18-driver.c | 30 ++--
> drivers/media/video/cx18/cx18-driver.h | 2 +-
> drivers/media/video/cx18/cx18-fileops.c | 32 +---
> drivers/media/video/cx18/cx18-ioctl.c | 24 +--
> drivers/media/video/cx18/cx18-mailbox.c | 5 +-
> drivers/media/video/cx18/cx18-mailbox.h | 5 -
> drivers/media/video/cx18/cx18-streams.c | 16 +-
> drivers/media/video/saa7110.c | 115 +++++-------
> drivers/media/video/tlv320aic23b.c | 74 +++++---
> drivers/media/video/tvp514x.c | 236 ++++++-------------------
> drivers/media/video/tvp5150.c | 157 +++++------------
> drivers/media/video/tvp7002.c | 117 +++++--------
> drivers/media/video/vivi.c | 228 +++++++++++++++---------
> drivers/media/video/vpx3220.c | 137 ++++++---------
> 23 files changed, 773 insertions(+), 1367 deletions(-)
>
>
>
--
Hans Verkuil - video4linux developer - sponsored by Cisco
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [GIT PATCHES FOR 2.6.38] Use the control framework in various subdevs
2011-01-07 9:49 ` Hans Verkuil
@ 2011-01-07 10:44 ` Hans Verkuil
2011-01-11 22:11 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 5+ messages in thread
From: Hans Verkuil @ 2011-01-07 10:44 UTC (permalink / raw)
To: linux-media; +Cc: Andy Walls, Mauro Carvalho Chehab
On Friday, January 07, 2011 10:49:30 Hans Verkuil wrote:
> Hi Mauro,
>
> On Friday, December 31, 2010 14:36:59 Hans Verkuil wrote:
> > This is a pull request for a subset of the RFC patch series I posted almost
> > three weeks ago.
>
> Please don't merge this yet. While testing the ov7670 driver I came across
> some issues that may affect some drivers in this patch series as well. I need
> to do some more debugging and testing to verify whether this patch series can
> go ahead or not. I'll get back to you on this once I know more.
OK, this patch series is fine. The specific issues I had with ov7670 do not
apply here.
So this patch series is OK to merge.
Regards,
Hans
>
> Regards,
>
> Hans
>
> > The only change is cx18 where Andy Walls pointed out some bugs. The same bugs
> > were introduced in cx25840 and Andy's fixes for those had to be applied as well
> > in cx18 for the AV core.
> >
> > I dropped tvaudio, tda7432, tda9875 and ov7670 for now since these need more
> > testing.
> >
> > This has been tested with the vivi, cx18, em28xx and vpif_capture/vpif_display
> > drivers.
> >
> > Regards,
> >
> > Hans
> >
> > The following changes since commit 187134a5875df20356f4dca075db29f294115a47:
> > David Henningsson (1):
> > [media] DVB: IR support for TechnoTrend CT-3650
> >
> > are available in the git repository at:
> >
> > ssh://linuxtv.org/git/hverkuil/media_tree.git subdev-ctrl1
> >
> > Hans Verkuil (11):
> > cs5345: use the control framework
> > cx18: Use the control framework.
> > adv7343: use control framework
> > bt819: use control framework
> > saa7110: use control framework
> > tlv320aic23b: use control framework
> > tvp514x: use the control framework
> > tvp5150: use the control framework
> > vpx3220: use control framework
> > tvp7002: use control framework
> > vivi: convert to the control framework and add test controls.
> >
> > drivers/media/video/adv7343.c | 167 +++++++-----------
> > drivers/media/video/adv7343_regs.h | 8 +-
> > drivers/media/video/bt819.c | 129 +++++---------
> > drivers/media/video/cs5345.c | 87 ++++++---
> > drivers/media/video/cx18/cx18-av-audio.c | 92 ++---------
> > drivers/media/video/cx18/cx18-av-core.c | 175 ++++++++-----------
> > drivers/media/video/cx18/cx18-av-core.h | 12 +-
> > drivers/media/video/cx18/cx18-controls.c | 285 ++++--------------------------
> > drivers/media/video/cx18/cx18-controls.h | 7 +-
> > drivers/media/video/cx18/cx18-driver.c | 30 ++--
> > drivers/media/video/cx18/cx18-driver.h | 2 +-
> > drivers/media/video/cx18/cx18-fileops.c | 32 +---
> > drivers/media/video/cx18/cx18-ioctl.c | 24 +--
> > drivers/media/video/cx18/cx18-mailbox.c | 5 +-
> > drivers/media/video/cx18/cx18-mailbox.h | 5 -
> > drivers/media/video/cx18/cx18-streams.c | 16 +-
> > drivers/media/video/saa7110.c | 115 +++++-------
> > drivers/media/video/tlv320aic23b.c | 74 +++++---
> > drivers/media/video/tvp514x.c | 236 ++++++-------------------
> > drivers/media/video/tvp5150.c | 157 +++++------------
> > drivers/media/video/tvp7002.c | 117 +++++--------
> > drivers/media/video/vivi.c | 228 +++++++++++++++---------
> > drivers/media/video/vpx3220.c | 137 ++++++---------
> > 23 files changed, 773 insertions(+), 1367 deletions(-)
> >
> >
> >
>
>
--
Hans Verkuil - video4linux developer - sponsored by Cisco
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [GIT PATCHES FOR 2.6.38] Use the control framework in various subdevs
2011-01-11 22:11 ` Mauro Carvalho Chehab
@ 2011-01-11 20:32 ` Hans Verkuil
0 siblings, 0 replies; 5+ messages in thread
From: Hans Verkuil @ 2011-01-11 20:32 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media, Andy Walls
On Tuesday, January 11, 2011 23:11:48 Mauro Carvalho Chehab wrote:
> Em 07-01-2011 08:44, Hans Verkuil escreveu:
> > On Friday, January 07, 2011 10:49:30 Hans Verkuil wrote:
>
> > So this patch series is OK to merge.
>
> >>> The following changes since commit 187134a5875df20356f4dca075db29f294115a47:
> >>> David Henningsson (1):
> >>> [media] DVB: IR support for TechnoTrend CT-3650
> >>>
> >>> are available in the git repository at:
> >>>
> >>> ssh://linuxtv.org/git/hverkuil/media_tree.git subdev-ctrl1
> >>>
> >>> Hans Verkuil (11):
> >>> vivi: convert to the control framework and add test controls.
>
>
> Hmm.. this patch is producing a new warning:
> drivers/media/video/vivi.c:1059: warning: this decimal constant is unsigned only in ISO C90
>
> Please fix.
> Mauro.
Here it is:
vivi: fix compiler warning
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Regards,
Hans
diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c
index 598acfe..6beb270 100644
--- a/drivers/media/video/vivi.c
+++ b/drivers/media/video/vivi.c
@@ -1056,8 +1056,8 @@ static const struct v4l2_ctrl_config vivi_ctrl_int32 = {
.id = VIVI_CID_CUSTOM_BASE + 2,
.name = "Integer 32 Bits",
.type = V4L2_CTRL_TYPE_INTEGER,
- .min = -2147483648,
- .max = 2147483647,
+ .min = 0x80000000,
+ .max = 0x7f000000,
.step = 1,
};
--
Hans Verkuil - video4linux developer - sponsored by Cisco
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [GIT PATCHES FOR 2.6.38] Use the control framework in various subdevs
2011-01-07 10:44 ` Hans Verkuil
@ 2011-01-11 22:11 ` Mauro Carvalho Chehab
2011-01-11 20:32 ` Hans Verkuil
0 siblings, 1 reply; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2011-01-11 22:11 UTC (permalink / raw)
To: Hans Verkuil; +Cc: linux-media, Andy Walls
Em 07-01-2011 08:44, Hans Verkuil escreveu:
> On Friday, January 07, 2011 10:49:30 Hans Verkuil wrote:
> So this patch series is OK to merge.
>>> The following changes since commit 187134a5875df20356f4dca075db29f294115a47:
>>> David Henningsson (1):
>>> [media] DVB: IR support for TechnoTrend CT-3650
>>>
>>> are available in the git repository at:
>>>
>>> ssh://linuxtv.org/git/hverkuil/media_tree.git subdev-ctrl1
>>>
>>> Hans Verkuil (11):
>>> vivi: convert to the control framework and add test controls.
Hmm.. this patch is producing a new warning:
drivers/media/video/vivi.c:1059: warning: this decimal constant is unsigned only in ISO C90
Please fix.
Mauro.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-01-11 20:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-31 13:36 [GIT PATCHES FOR 2.6.38] Use the control framework in various subdevs Hans Verkuil
2011-01-07 9:49 ` Hans Verkuil
2011-01-07 10:44 ` Hans Verkuil
2011-01-11 22:11 ` Mauro Carvalho Chehab
2011-01-11 20:32 ` Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.