All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] iio: Fixpoint formatted output bugfix
@ 2011-01-13  8:52 Roland Stigge
  2011-01-13 11:09 ` Jonathan Cameron
  0 siblings, 1 reply; 8+ messages in thread
From: Roland Stigge @ 2011-01-13  8:52 UTC (permalink / raw)
  To: linux-iio, Greg KH; +Cc: Roland Stigge, Greg KH

From: Roland Stigge <stigge@antcom.de>

Fix some ADC drivers' _scale interface to correct fixpoint formatted output

Signed-off-by: Roland Stigge <stigge@antcom.de>
Acked-by: "Hennerich, Michael" <Michael.Hennerich@analog.com>

---
 drivers/staging/iio/adc/ad7476_core.c |    2 +-
 drivers/staging/iio/adc/ad7887_core.c |    2 +-
 drivers/staging/iio/adc/ad799x_core.c |    2 +-
 drivers/staging/iio/dac/ad5446.c      |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/iio/adc/ad7476_core.c b/drivers/staging/iio/adc/ad7476_core.c
index deb68c8..b8b54da 100644
--- a/drivers/staging/iio/adc/ad7476_core.c
+++ b/drivers/staging/iio/adc/ad7476_core.c
@@ -68,7 +68,7 @@ static ssize_t ad7476_show_scale(struct device *dev,
 	/* Corresponds to Vref / 2^(bits) */
 	unsigned int scale_uv = (st->int_vref_mv * 1000) >> st->chip_info->bits;
 
-	return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
+	return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv % 1000);
 }
 static IIO_DEVICE_ATTR(in_scale, S_IRUGO, ad7476_show_scale, NULL, 0);
 
diff --git a/drivers/staging/iio/adc/ad7887_core.c b/drivers/staging/iio/adc/ad7887_core.c
index 6859089..5d85efa 100644
--- a/drivers/staging/iio/adc/ad7887_core.c
+++ b/drivers/staging/iio/adc/ad7887_core.c
@@ -68,7 +68,7 @@ static ssize_t ad7887_show_scale(struct device *dev,
 	/* Corresponds to Vref / 2^(bits) */
 	unsigned int scale_uv = (st->int_vref_mv * 1000) >> st->chip_info->bits;
 
-	return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
+	return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv % 1000);
 }
 static IIO_DEVICE_ATTR(in_scale, S_IRUGO, ad7887_show_scale, NULL, 0);
 
diff --git a/drivers/staging/iio/adc/ad799x_core.c b/drivers/staging/iio/adc/ad799x_core.c
index 6309d52..89ccf37 100644
--- a/drivers/staging/iio/adc/ad799x_core.c
+++ b/drivers/staging/iio/adc/ad799x_core.c
@@ -432,7 +432,7 @@ static ssize_t ad799x_show_scale(struct device *dev,
 	/* Corresponds to Vref / 2^(bits) */
 	unsigned int scale_uv = (st->int_vref_mv * 1000) >> st->chip_info->bits;
 
-	return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
+	return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv % 1000);
 }
 
 static IIO_DEVICE_ATTR(in_scale, S_IRUGO, ad799x_show_scale, NULL, 0);
diff --git a/drivers/staging/iio/dac/ad5446.c b/drivers/staging/iio/dac/ad5446.c
index e3387cd..0f87eca 100644
--- a/drivers/staging/iio/dac/ad5446.c
+++ b/drivers/staging/iio/dac/ad5446.c
@@ -87,7 +87,7 @@ static ssize_t ad5446_show_scale(struct device *dev,
 	/* Corresponds to Vref / 2^(bits) */
 	unsigned int scale_uv = (st->vref_mv * 1000) >> st->chip_info->bits;
 
-	return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
+	return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv % 1000);
 }
 static IIO_DEVICE_ATTR(out_scale, S_IRUGO, ad5446_show_scale, NULL, 0);
 
-- 
1.7.2.3


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] iio: Fixpoint formatted output bugfix
  2011-01-13  8:52 [PATCH] iio: Fixpoint formatted output bugfix Roland Stigge
@ 2011-01-13 11:09 ` Jonathan Cameron
  2011-01-13 16:49   ` Greg KH
  0 siblings, 1 reply; 8+ messages in thread
From: Jonathan Cameron @ 2011-01-13 11:09 UTC (permalink / raw)
  To: Roland Stigge; +Cc: linux-iio, Greg KH, Roland Stigge

On 01/13/11 08:52, Roland Stigge wrote:
> From: Roland Stigge <stigge@antcom.de>
> 
> Fix some ADC drivers' _scale interface to correct fixpoint formatted output
> 
> Signed-off-by: Roland Stigge <stigge@antcom.de>
> Acked-by: "Hennerich, Michael" <Michael.Hennerich@analog.com>
Acked-by: "Jonathan Cameron <jic23@cam.ac.uk>"

Greg, this is a simple bug fix. The ad7476 and ad799x are in 2.6.37
so it would be good to push this to stable as well.
Do you want a broken out patch with just those two in it?

> 
> ---
>  drivers/staging/iio/adc/ad7476_core.c |    2 +-
>  drivers/staging/iio/adc/ad7887_core.c |    2 +-
>  drivers/staging/iio/adc/ad799x_core.c |    2 +-
>  drivers/staging/iio/dac/ad5446.c      |    2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7476_core.c b/drivers/staging/iio/adc/ad7476_core.c
> index deb68c8..b8b54da 100644
> --- a/drivers/staging/iio/adc/ad7476_core.c
> +++ b/drivers/staging/iio/adc/ad7476_core.c
> @@ -68,7 +68,7 @@ static ssize_t ad7476_show_scale(struct device *dev,
>  	/* Corresponds to Vref / 2^(bits) */
>  	unsigned int scale_uv = (st->int_vref_mv * 1000) >> st->chip_info->bits;
>  
> -	return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
> +	return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv % 1000);
>  }
>  static IIO_DEVICE_ATTR(in_scale, S_IRUGO, ad7476_show_scale, NULL, 0);
>  
> diff --git a/drivers/staging/iio/adc/ad7887_core.c b/drivers/staging/iio/adc/ad7887_core.c
> index 6859089..5d85efa 100644
> --- a/drivers/staging/iio/adc/ad7887_core.c
> +++ b/drivers/staging/iio/adc/ad7887_core.c
> @@ -68,7 +68,7 @@ static ssize_t ad7887_show_scale(struct device *dev,
>  	/* Corresponds to Vref / 2^(bits) */
>  	unsigned int scale_uv = (st->int_vref_mv * 1000) >> st->chip_info->bits;
>  
> -	return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
> +	return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv % 1000);
>  }
>  static IIO_DEVICE_ATTR(in_scale, S_IRUGO, ad7887_show_scale, NULL, 0);
>  
> diff --git a/drivers/staging/iio/adc/ad799x_core.c b/drivers/staging/iio/adc/ad799x_core.c
> index 6309d52..89ccf37 100644
> --- a/drivers/staging/iio/adc/ad799x_core.c
> +++ b/drivers/staging/iio/adc/ad799x_core.c
> @@ -432,7 +432,7 @@ static ssize_t ad799x_show_scale(struct device *dev,
>  	/* Corresponds to Vref / 2^(bits) */
>  	unsigned int scale_uv = (st->int_vref_mv * 1000) >> st->chip_info->bits;
>  
> -	return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
> +	return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv % 1000);
>  }
>  
>  static IIO_DEVICE_ATTR(in_scale, S_IRUGO, ad799x_show_scale, NULL, 0);
> diff --git a/drivers/staging/iio/dac/ad5446.c b/drivers/staging/iio/dac/ad5446.c
> index e3387cd..0f87eca 100644
> --- a/drivers/staging/iio/dac/ad5446.c
> +++ b/drivers/staging/iio/dac/ad5446.c
> @@ -87,7 +87,7 @@ static ssize_t ad5446_show_scale(struct device *dev,
>  	/* Corresponds to Vref / 2^(bits) */
>  	unsigned int scale_uv = (st->vref_mv * 1000) >> st->chip_info->bits;
>  
> -	return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
> +	return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv % 1000);
>  }
>  static IIO_DEVICE_ATTR(out_scale, S_IRUGO, ad5446_show_scale, NULL, 0);
>  


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] iio: Fixpoint formatted output bugfix
  2011-01-13 11:09 ` Jonathan Cameron
@ 2011-01-13 16:49   ` Greg KH
  2011-01-13 17:41     ` Roland Stigge
  0 siblings, 1 reply; 8+ messages in thread
From: Greg KH @ 2011-01-13 16:49 UTC (permalink / raw)
  To: Jonathan Cameron; +Cc: Roland Stigge, linux-iio, Roland Stigge

On Thu, Jan 13, 2011 at 11:09:04AM +0000, Jonathan Cameron wrote:
> On 01/13/11 08:52, Roland Stigge wrote:
> > From: Roland Stigge <stigge@antcom.de>
> > 
> > Fix some ADC drivers' _scale interface to correct fixpoint formatted output
> > 
> > Signed-off-by: Roland Stigge <stigge@antcom.de>
> > Acked-by: "Hennerich, Michael" <Michael.Hennerich@analog.com>
> Acked-by: "Jonathan Cameron <jic23@cam.ac.uk>"
> 
> Greg, this is a simple bug fix. The ad7476 and ad799x are in 2.6.37
> so it would be good to push this to stable as well.
> Do you want a broken out patch with just those two in it?

Yes, that would be great to have, can you split this into 2 different
patches so I can handle it that way easier?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] iio: Fixpoint formatted output bugfix
  2011-01-13 16:49   ` Greg KH
@ 2011-01-13 17:41     ` Roland Stigge
  0 siblings, 0 replies; 8+ messages in thread
From: Roland Stigge @ 2011-01-13 17:41 UTC (permalink / raw)
  To: Greg KH; +Cc: Jonathan Cameron, Roland Stigge, linux-iio

On 01/13/2011 05:49 PM, Greg KH wrote:
>> Greg, this is a simple bug fix. The ad7476 and ad799x are in 2.6.37
>> so it would be good to push this to stable as well.
>> Do you want a broken out patch with just those two in it?
> 
> Yes, that would be great to have, can you split this into 2 different
> patches so I can handle it that way easier?

I'm sending the 2.6.37 version in a separate patch.

Roland

^ permalink raw reply	[flat|nested] 8+ messages in thread
* RE: [PATCH] iio: Fixpoint formatted output bugfix
  2011-01-13 17:37 Roland Stigge
@ 2011-01-13 20:32 ` Hennerich, Michael
  0 siblings, 0 replies; 8+ messages in thread
From: Hennerich, Michael @ 2011-01-13 20:32 UTC (permalink / raw)
  To: Roland Stigge, greg, linux-iio; +Cc: Roland Stigge

Roland Stigge wrote on 2011-01-13:
> Fix some ADC drivers' _scale interface to correct fixpoint formatted
> output
>
> Signed-off-by: Roland Stigge <stigge@antcom.de>
> Acked-by: "Jonathan Cameron <jic23@cam.ac.uk>"
Acked-by: "Hennerich, Michael" <Michael.Hennerich@analog.com>

> diff --git a/drivers/staging/iio/adc/ad7476_core.c
> b/drivers/staging/iio/adc/ad7476_core.c index deb68c8..b8b54da 100644
> --- a/drivers/staging/iio/adc/ad7476_core.c +++
> b/drivers/staging/iio/adc/ad7476_core.c @@ -68,7 +68,7 @@ static ssize_t
> ad7476_show_scale(struct device *dev,
>       /* Corresponds to Vref / 2^(bits) */
>       unsigned int scale_uv = (st->int_vref_mv * 1000) >> st-
>  chip_info->bits;
>
> -     return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
> +     return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv %
> 1000);
>  }
>  static IIO_DEVICE_ATTR(in_scale, S_IRUGO, ad7476_show_scale, NULL,
> 0);
>
> diff --git a/drivers/staging/iio/adc/ad799x_core.c
> b/drivers/staging/iio/adc/ad799x_core.c index 6309d52..89ccf37 100644
> --- a/drivers/staging/iio/adc/ad799x_core.c +++
> b/drivers/staging/iio/adc/ad799x_core.c @@ -432,7 +432,7 @@ static
> ssize_t ad799x_show_scale(struct device *dev,
>       /* Corresponds to Vref / 2^(bits) */
>       unsigned int scale_uv = (st->int_vref_mv * 1000) >> st-
>  chip_info->bits;
>
> -     return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
> +     return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv %
> 1000);
>  }
>
>  static IIO_DEVICE_ATTR(in_scale, S_IRUGO, ad799x_show_scale, NULL,
> 0);

Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif



^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] iio: Fixpoint formatted output bugfix
@ 2011-01-13 17:37 Roland Stigge
  2011-01-13 20:32 ` Hennerich, Michael
  0 siblings, 1 reply; 8+ messages in thread
From: Roland Stigge @ 2011-01-13 17:37 UTC (permalink / raw)
  To: greg, linux-iio; +Cc: Roland Stigge

Fix some ADC drivers' _scale interface to correct fixpoint formatted output

Signed-off-by: Roland Stigge <stigge@antcom.de>
Acked-by: "Jonathan Cameron <jic23@cam.ac.uk>"

diff --git a/drivers/staging/iio/adc/ad7476_core.c b/drivers/staging/iio/adc/ad7476_core.c
index deb68c8..b8b54da 100644
--- a/drivers/staging/iio/adc/ad7476_core.c
+++ b/drivers/staging/iio/adc/ad7476_core.c
@@ -68,7 +68,7 @@ static ssize_t ad7476_show_scale(struct device *dev,
 	/* Corresponds to Vref / 2^(bits) */
 	unsigned int scale_uv = (st->int_vref_mv * 1000) >> st->chip_info->bits;
 
-	return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
+	return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv % 1000);
 }
 static IIO_DEVICE_ATTR(in_scale, S_IRUGO, ad7476_show_scale, NULL, 0);
 
diff --git a/drivers/staging/iio/adc/ad799x_core.c b/drivers/staging/iio/adc/ad799x_core.c
index 6309d52..89ccf37 100644
--- a/drivers/staging/iio/adc/ad799x_core.c
+++ b/drivers/staging/iio/adc/ad799x_core.c
@@ -432,7 +432,7 @@ static ssize_t ad799x_show_scale(struct device *dev,
 	/* Corresponds to Vref / 2^(bits) */
 	unsigned int scale_uv = (st->int_vref_mv * 1000) >> st->chip_info->bits;
 
-	return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
+	return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv % 1000);
 }
 
 static IIO_DEVICE_ATTR(in_scale, S_IRUGO, ad799x_show_scale, NULL, 0);

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* RE: [PATCH] iio: Fixpoint formatted output bugfix
  2011-01-12 18:35 Roland Stigge
@ 2011-01-13  8:33 ` Hennerich, Michael
  0 siblings, 0 replies; 8+ messages in thread
From: Hennerich, Michael @ 2011-01-13  8:33 UTC (permalink / raw)
  To: Roland Stigge, linux-iio; +Cc: device-drivers-devel

Roland Stigge wrote on 2011-01-12:
> Fix some ADC drivers' _scale interface to correct fixpoint formatted
> output ---
>  drivers/staging/iio/adc/ad7476_core.c |    2 +-
>  drivers/staging/iio/adc/ad7887_core.c |    2 +-
>  drivers/staging/iio/adc/ad799x_core.c |    2 +-
>  drivers/staging/iio/dac/ad5446.c      |    2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)

Your Signed-off-by is missing

Acked-by: "Hennerich, Michael" <Michael.Hennerich@analog.com>


> diff --git a/drivers/staging/iio/adc/ad7476_core.c
> b/drivers/staging/iio/adc/ad7476_core.c index deb68c8..b8b54da 100644
> --- a/drivers/staging/iio/adc/ad7476_core.c +++
> b/drivers/staging/iio/adc/ad7476_core.c @@ -68,7 +68,7 @@ static ssize_t
> ad7476_show_scale(struct device *dev,
>       /* Corresponds to Vref / 2^(bits) */
>       unsigned int scale_uv = (st->int_vref_mv * 1000) >> st-
>  chip_info->bits;
>
> -     return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
> +     return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv %
> 1000);
>  }
>  static IIO_DEVICE_ATTR(in_scale, S_IRUGO, ad7476_show_scale, NULL,
> 0);
>
> diff --git a/drivers/staging/iio/adc/ad7887_core.c
> b/drivers/staging/iio/adc/ad7887_core.c index 6859089..5d85efa 100644
> --- a/drivers/staging/iio/adc/ad7887_core.c +++
> b/drivers/staging/iio/adc/ad7887_core.c @@ -68,7 +68,7 @@ static ssize_t
> ad7887_show_scale(struct device *dev,
>       /* Corresponds to Vref / 2^(bits) */
>       unsigned int scale_uv = (st->int_vref_mv * 1000) >> st-
>  chip_info->bits;
>
> -     return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
> +     return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv %
> 1000);
>  }
>  static IIO_DEVICE_ATTR(in_scale, S_IRUGO, ad7887_show_scale, NULL,
> 0);
>
> diff --git a/drivers/staging/iio/adc/ad799x_core.c
> b/drivers/staging/iio/adc/ad799x_core.c index 6309d52..89ccf37 100644
> --- a/drivers/staging/iio/adc/ad799x_core.c +++
> b/drivers/staging/iio/adc/ad799x_core.c @@ -432,7 +432,7 @@ static
> ssize_t ad799x_show_scale(struct device *dev,
>       /* Corresponds to Vref / 2^(bits) */
>       unsigned int scale_uv = (st->int_vref_mv * 1000) >> st-
>  chip_info->bits;
>
> -     return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
> +     return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv %
> 1000);
>  }
>
>  static IIO_DEVICE_ATTR(in_scale, S_IRUGO, ad799x_show_scale, NULL,
> 0); diff --git a/drivers/staging/iio/dac/ad5446.c
> b/drivers/staging/iio/dac/ad5446.c index e3387cd..0f87eca 100644 ---
> a/drivers/staging/iio/dac/ad5446.c +++
> b/drivers/staging/iio/dac/ad5446.c @@ -87,7 +87,7 @@ static ssize_t
> ad5446_show_scale(struct device *dev,
>       /* Corresponds to Vref / 2^(bits) */
>       unsigned int scale_uv = (st->vref_mv * 1000) >> st->chip_info-
>  bits;
>
> -     return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
> +     return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv %
> 1000);
>  }
>  static IIO_DEVICE_ATTR(out_scale, S_IRUGO, ad5446_show_scale, NULL,
> 0);
>

Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] iio: Fixpoint formatted output bugfix
@ 2011-01-12 18:35 Roland Stigge
  2011-01-13  8:33 ` Hennerich, Michael
  0 siblings, 1 reply; 8+ messages in thread
From: Roland Stigge @ 2011-01-12 18:35 UTC (permalink / raw)
  To: linux-iio; +Cc: Roland Stigge

Fix some ADC drivers' _scale interface to correct fixpoint formatted output
---
 drivers/staging/iio/adc/ad7476_core.c |    2 +-
 drivers/staging/iio/adc/ad7887_core.c |    2 +-
 drivers/staging/iio/adc/ad799x_core.c |    2 +-
 drivers/staging/iio/dac/ad5446.c      |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/iio/adc/ad7476_core.c b/drivers/staging/iio/adc/ad7476_core.c
index deb68c8..b8b54da 100644
--- a/drivers/staging/iio/adc/ad7476_core.c
+++ b/drivers/staging/iio/adc/ad7476_core.c
@@ -68,7 +68,7 @@ static ssize_t ad7476_show_scale(struct device *dev,
 	/* Corresponds to Vref / 2^(bits) */
 	unsigned int scale_uv = (st->int_vref_mv * 1000) >> st->chip_info->bits;
 
-	return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
+	return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv % 1000);
 }
 static IIO_DEVICE_ATTR(in_scale, S_IRUGO, ad7476_show_scale, NULL, 0);
 
diff --git a/drivers/staging/iio/adc/ad7887_core.c b/drivers/staging/iio/adc/ad7887_core.c
index 6859089..5d85efa 100644
--- a/drivers/staging/iio/adc/ad7887_core.c
+++ b/drivers/staging/iio/adc/ad7887_core.c
@@ -68,7 +68,7 @@ static ssize_t ad7887_show_scale(struct device *dev,
 	/* Corresponds to Vref / 2^(bits) */
 	unsigned int scale_uv = (st->int_vref_mv * 1000) >> st->chip_info->bits;
 
-	return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
+	return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv % 1000);
 }
 static IIO_DEVICE_ATTR(in_scale, S_IRUGO, ad7887_show_scale, NULL, 0);
 
diff --git a/drivers/staging/iio/adc/ad799x_core.c b/drivers/staging/iio/adc/ad799x_core.c
index 6309d52..89ccf37 100644
--- a/drivers/staging/iio/adc/ad799x_core.c
+++ b/drivers/staging/iio/adc/ad799x_core.c
@@ -432,7 +432,7 @@ static ssize_t ad799x_show_scale(struct device *dev,
 	/* Corresponds to Vref / 2^(bits) */
 	unsigned int scale_uv = (st->int_vref_mv * 1000) >> st->chip_info->bits;
 
-	return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
+	return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv % 1000);
 }
 
 static IIO_DEVICE_ATTR(in_scale, S_IRUGO, ad799x_show_scale, NULL, 0);
diff --git a/drivers/staging/iio/dac/ad5446.c b/drivers/staging/iio/dac/ad5446.c
index e3387cd..0f87eca 100644
--- a/drivers/staging/iio/dac/ad5446.c
+++ b/drivers/staging/iio/dac/ad5446.c
@@ -87,7 +87,7 @@ static ssize_t ad5446_show_scale(struct device *dev,
 	/* Corresponds to Vref / 2^(bits) */
 	unsigned int scale_uv = (st->vref_mv * 1000) >> st->chip_info->bits;
 
-	return sprintf(buf, "%d.%d\n", scale_uv / 1000, scale_uv % 1000);
+	return sprintf(buf, "%d.%03d\n", scale_uv / 1000, scale_uv % 1000);
 }
 static IIO_DEVICE_ATTR(out_scale, S_IRUGO, ad5446_show_scale, NULL, 0);
 
-- 
1.7.2.3


^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-01-13 20:32 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-13  8:52 [PATCH] iio: Fixpoint formatted output bugfix Roland Stigge
2011-01-13 11:09 ` Jonathan Cameron
2011-01-13 16:49   ` Greg KH
2011-01-13 17:41     ` Roland Stigge
  -- strict thread matches above, loose matches on Subject: below --
2011-01-13 17:37 Roland Stigge
2011-01-13 20:32 ` Hennerich, Michael
2011-01-12 18:35 Roland Stigge
2011-01-13  8:33 ` Hennerich, Michael

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.