All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Joey Lee" <jlee@novell.com>
To: <jj@chaosbits.net>
Cc: <trivial@kernel.org>, <mjg@redhat.com>,
	<carlos@strangeworlds.co.uk>, <linux-kernel@vger.kernel.org>,
	<platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH] X86, Acer, WMI: Do not double include linux/dmi.h in acer-wmi.c
Date: Mon, 24 Jan 2011 18:34:18 -0700	[thread overview]
Message-ID: <4D3EC34A020000230002799D@novprvlin0050.provo.novell.com> (raw)

Hi Jesper, 

於 一，2011-01-24 於 22:12 +0100，Jesper Juhl 提到：
> Including linux/dmi.h once in drivers/platform/x86/acer-wmi.c is enough.
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
>  acer-wmi.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index c5c4b8c..f21eb53 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -39,7 +39,6 @@
>  #include <linux/slab.h>
>  #include <linux/input.h>
>  #include <linux/input/sparse-keymap.h>
> -#include <linux/dmi.h>
>  
>  #include <acpi/acpi_drivers.h>
>  
> 

Reviewed-by: Lee, Chun-Yi <jlee@novell.com>

Thank's for your patch to fix my fail.

Joey Lee


WARNING: multiple messages have this Message-ID (diff)
From: "Joey Lee" <jlee@novell.com>
To: jj@chaosbits.net
Cc: trivial@kernel.org, mjg@redhat.com, carlos@strangeworlds.co.uk,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] X86, Acer, WMI: Do not double include linux/dmi.h in acer-wmi.c
Date: Mon, 24 Jan 2011 18:34:18 -0700	[thread overview]
Message-ID: <4D3EC34A020000230002799D@novprvlin0050.provo.novell.com> (raw)

Hi Jesper, 

於 一，2011-01-24 於 22:12 +0100，Jesper Juhl 提到：
> Including linux/dmi.h once in drivers/platform/x86/acer-wmi.c is enough.
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
>  acer-wmi.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index c5c4b8c..f21eb53 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -39,7 +39,6 @@
>  #include <linux/slab.h>
>  #include <linux/input.h>
>  #include <linux/input/sparse-keymap.h>
> -#include <linux/dmi.h>
>  
>  #include <acpi/acpi_drivers.h>
>  
> 

Reviewed-by: Lee, Chun-Yi <jlee@novell.com>

Thank's for your patch to fix my fail.

Joey Lee

             reply	other threads:[~2011-01-25  1:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25  1:34 Joey Lee [this message]
2011-01-25  1:34 ` [PATCH] X86, Acer, WMI: Do not double include linux/dmi.h in acer-wmi.c Joey Lee
2011-01-25 11:03 ` Jiri Kosina
  -- strict thread matches above, loose matches on Subject: below --
2011-01-24 21:12 Jesper Juhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D3EC34A020000230002799D@novprvlin0050.provo.novell.com \
    --to=jlee@novell.com \
    --cc=carlos@strangeworlds.co.uk \
    --cc=jj@chaosbits.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.