All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH] Fix Makefile of testcase/kernel/mem/ksm/
@ 2011-01-26  6:54 Bian Naimeng
  2011-01-26  6:58 ` Garrett Cooper
  0 siblings, 1 reply; 5+ messages in thread
From: Bian Naimeng @ 2011-01-26  6:54 UTC (permalink / raw)
  To: Garrett Cooper; +Cc: ltp-list

There is not any directory at testcase/kernel/mem/ksm/,
so replace generic_trunk_target.mk by generic_leaf_target.mk

Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>

---
 testcases/kernel/mem/ksm/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/testcases/kernel/mem/ksm/Makefile b/testcases/kernel/mem/ksm/Makefile
index 81509bf..22190f1 100644
--- a/testcases/kernel/mem/ksm/Makefile
+++ b/testcases/kernel/mem/ksm/Makefile
@@ -39,5 +39,5 @@ trunk-clean:: | lib-clean
 lib-clean:: $(LIBDIR)
 	$(MAKE) -C $^ -f "$(abs_srcdir)/$^/Makefile" clean
 
-include $(top_srcdir)/include/mk/generic_trunk_target.mk
 include $(top_srcdir)/include/mk/testcases.mk
+include $(top_srcdir)/include/mk/generic_leaf_target.mk
-- 
1.7.0.4




-- 
Regards
Bian Naimeng


------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [LTP] [PATCH] Fix Makefile of testcase/kernel/mem/ksm/
  2011-01-26  6:54 [LTP] [PATCH] Fix Makefile of testcase/kernel/mem/ksm/ Bian Naimeng
@ 2011-01-26  6:58 ` Garrett Cooper
  2011-01-26  7:06   ` CAI Qian
  2011-01-26  7:07   ` Bian Naimeng
  0 siblings, 2 replies; 5+ messages in thread
From: Garrett Cooper @ 2011-01-26  6:58 UTC (permalink / raw)
  To: Bian Naimeng; +Cc: ltp-list

On Tue, Jan 25, 2011 at 10:54 PM, Bian Naimeng <biannm@cn.fujitsu.com> wrote:
> There is not any directory at testcase/kernel/mem/ksm/,
> so replace generic_trunk_target.mk by generic_leaf_target.mk
>
> Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
>
> ---
>  testcases/kernel/mem/ksm/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/testcases/kernel/mem/ksm/Makefile b/testcases/kernel/mem/ksm/Makefile
> index 81509bf..22190f1 100644
> --- a/testcases/kernel/mem/ksm/Makefile
> +++ b/testcases/kernel/mem/ksm/Makefile
> @@ -39,5 +39,5 @@ trunk-clean:: | lib-clean
>  lib-clean:: $(LIBDIR)
>        $(MAKE) -C $^ -f "$(abs_srcdir)/$^/Makefile" clean
>
> -include $(top_srcdir)/include/mk/generic_trunk_target.mk
>  include $(top_srcdir)/include/mk/testcases.mk
> +include $(top_srcdir)/include/mk/generic_leaf_target.mk

    Forgot about that Makefile that Cai submitted. How about this instead?
Thanks,
-Garrett

diff --git a/testcases/kernel/mem/ksm/Makefile
b/testcases/kernel/mem/ksm/Makefile
index 81509bf..fdff5fc 100644
--- a/testcases/kernel/mem/ksm/Makefile
+++ b/testcases/kernel/mem/ksm/Makefile
@@ -18,7 +18,7 @@

 top_srcdir              ?= ../../../..

-include $(top_srcdir)/include/mk/env_pre.mk
+include $(top_srcdir)/include/mk/testcases.mk

 LDLIBS                 += $(NUMA_LIBS) -lmem
 LIBDIR                 := ../lib
@@ -39,5 +39,4 @@ trunk-clean:: | lib-clean
 lib-clean:: $(LIBDIR)
        $(MAKE) -C $^ -f "$(abs_srcdir)/$^/Makefile" clean

-include $(top_srcdir)/include/mk/generic_trunk_target.mk
-include $(top_srcdir)/include/mk/testcases.mk
+include $(top_srcdir)/include/mk/generic_leaf_target.mk

------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [LTP] [PATCH] Fix Makefile of testcase/kernel/mem/ksm/
  2011-01-26  6:58 ` Garrett Cooper
@ 2011-01-26  7:06   ` CAI Qian
  2011-01-26  7:07   ` Bian Naimeng
  1 sibling, 0 replies; 5+ messages in thread
From: CAI Qian @ 2011-01-26  7:06 UTC (permalink / raw)
  To: Garrett Cooper; +Cc: ltp-list



----- Original Message -----
> On Tue, Jan 25, 2011 at 10:54 PM, Bian Naimeng <biannm@cn.fujitsu.com>
> wrote:
> > There is not any directory at testcase/kernel/mem/ksm/,
> > so replace generic_trunk_target.mk by generic_leaf_target.mk
> >
> > Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
> >
> > ---
> >  testcases/kernel/mem/ksm/Makefile | 2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/testcases/kernel/mem/ksm/Makefile
> > b/testcases/kernel/mem/ksm/Makefile
> > index 81509bf..22190f1 100644
> > --- a/testcases/kernel/mem/ksm/Makefile
> > +++ b/testcases/kernel/mem/ksm/Makefile
> > @@ -39,5 +39,5 @@ trunk-clean:: | lib-clean
> >  lib-clean:: $(LIBDIR)
> >        $(MAKE) -C $^ -f "$(abs_srcdir)/$^/Makefile" clean
> >
> > -include $(top_srcdir)/include/mk/generic_trunk_target.mk
> >  include $(top_srcdir)/include/mk/testcases.mk
> > +include $(top_srcdir)/include/mk/generic_leaf_target.mk
> 
> Forgot about that Makefile that Cai submitted. How about this instead?
It is not me but Lucas.
> Thanks,
> -Garrett
> 
> diff --git a/testcases/kernel/mem/ksm/Makefile
> b/testcases/kernel/mem/ksm/Makefile
> index 81509bf..fdff5fc 100644
> --- a/testcases/kernel/mem/ksm/Makefile
> +++ b/testcases/kernel/mem/ksm/Makefile
> @@ -18,7 +18,7 @@
> 
> top_srcdir ?= ../../../..
> 
> -include $(top_srcdir)/include/mk/env_pre.mk
> +include $(top_srcdir)/include/mk/testcases.mk
> 
> LDLIBS += $(NUMA_LIBS) -lmem
> LIBDIR := ../lib
> @@ -39,5 +39,4 @@ trunk-clean:: | lib-clean
> lib-clean:: $(LIBDIR)
> $(MAKE) -C $^ -f "$(abs_srcdir)/$^/Makefile" clean
> 
> -include $(top_srcdir)/include/mk/generic_trunk_target.mk
> -include $(top_srcdir)/include/mk/testcases.mk
> +include $(top_srcdir)/include/mk/generic_leaf_target.mk
> 
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better
> price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [LTP] [PATCH] Fix Makefile of testcase/kernel/mem/ksm/
  2011-01-26  6:58 ` Garrett Cooper
  2011-01-26  7:06   ` CAI Qian
@ 2011-01-26  7:07   ` Bian Naimeng
  2011-01-26  7:10     ` Garrett Cooper
  1 sibling, 1 reply; 5+ messages in thread
From: Bian Naimeng @ 2011-01-26  7:07 UTC (permalink / raw)
  To: Garrett Cooper; +Cc: ltp-list



Garrett Cooper wrote:
> On Tue, Jan 25, 2011 at 10:54 PM, Bian Naimeng <biannm@cn.fujitsu.com> wrote:
>> There is not any directory at testcase/kernel/mem/ksm/,
>> so replace generic_trunk_target.mk by generic_leaf_target.mk
>>
>> Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
>>
>> ---
>>  testcases/kernel/mem/ksm/Makefile |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/testcases/kernel/mem/ksm/Makefile b/testcases/kernel/mem/ksm/Makefile
>> index 81509bf..22190f1 100644
>> --- a/testcases/kernel/mem/ksm/Makefile
>> +++ b/testcases/kernel/mem/ksm/Makefile
>> @@ -39,5 +39,5 @@ trunk-clean:: | lib-clean
>>  lib-clean:: $(LIBDIR)
>>        $(MAKE) -C $^ -f "$(abs_srcdir)/$^/Makefile" clean
>>
>> -include $(top_srcdir)/include/mk/generic_trunk_target.mk
>>  include $(top_srcdir)/include/mk/testcases.mk
>> +include $(top_srcdir)/include/mk/generic_leaf_target.mk
> 
>     Forgot about that Makefile that Cai submitted. How about this instead?

Looks better than mine. Please commit it.

Thanks
  Bian

> Thanks,
> -Garrett
> 
> diff --git a/testcases/kernel/mem/ksm/Makefile
> b/testcases/kernel/mem/ksm/Makefile
> index 81509bf..fdff5fc 100644
> --- a/testcases/kernel/mem/ksm/Makefile
> +++ b/testcases/kernel/mem/ksm/Makefile
> @@ -18,7 +18,7 @@
> 
>  top_srcdir              ?= ../../../..
> 
> -include $(top_srcdir)/include/mk/env_pre.mk
> +include $(top_srcdir)/include/mk/testcases.mk
> 
>  LDLIBS                 += $(NUMA_LIBS) -lmem
>  LIBDIR                 := ../lib
> @@ -39,5 +39,4 @@ trunk-clean:: | lib-clean
>  lib-clean:: $(LIBDIR)
>         $(MAKE) -C $^ -f "$(abs_srcdir)/$^/Makefile" clean
> 
> -include $(top_srcdir)/include/mk/generic_trunk_target.mk
> -include $(top_srcdir)/include/mk/testcases.mk
> +include $(top_srcdir)/include/mk/generic_leaf_target.mk
> 
> 

-- 
Regards
Bian Naimeng


------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [LTP] [PATCH] Fix Makefile of testcase/kernel/mem/ksm/
  2011-01-26  7:07   ` Bian Naimeng
@ 2011-01-26  7:10     ` Garrett Cooper
  0 siblings, 0 replies; 5+ messages in thread
From: Garrett Cooper @ 2011-01-26  7:10 UTC (permalink / raw)
  To: Bian Naimeng; +Cc: ltp-list

On Tue, Jan 25, 2011 at 11:07 PM, Bian Naimeng <biannm@cn.fujitsu.com> wrote:
>
>
> Garrett Cooper wrote:
>> On Tue, Jan 25, 2011 at 10:54 PM, Bian Naimeng <biannm@cn.fujitsu.com> wrote:
>>> There is not any directory at testcase/kernel/mem/ksm/,
>>> so replace generic_trunk_target.mk by generic_leaf_target.mk
>>>
>>> Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
>>>
>>> ---
>>>  testcases/kernel/mem/ksm/Makefile |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/testcases/kernel/mem/ksm/Makefile b/testcases/kernel/mem/ksm/Makefile
>>> index 81509bf..22190f1 100644
>>> --- a/testcases/kernel/mem/ksm/Makefile
>>> +++ b/testcases/kernel/mem/ksm/Makefile
>>> @@ -39,5 +39,5 @@ trunk-clean:: | lib-clean
>>>  lib-clean:: $(LIBDIR)
>>>        $(MAKE) -C $^ -f "$(abs_srcdir)/$^/Makefile" clean
>>>
>>> -include $(top_srcdir)/include/mk/generic_trunk_target.mk
>>>  include $(top_srcdir)/include/mk/testcases.mk
>>> +include $(top_srcdir)/include/mk/generic_leaf_target.mk
>>
>>     Forgot about that Makefile that Cai submitted. How about this instead?
>
> Looks better than mine. Please commit it.

Committed -- thanks!
-Garrett

------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-01-26  7:10 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-26  6:54 [LTP] [PATCH] Fix Makefile of testcase/kernel/mem/ksm/ Bian Naimeng
2011-01-26  6:58 ` Garrett Cooper
2011-01-26  7:06   ` CAI Qian
2011-01-26  7:07   ` Bian Naimeng
2011-01-26  7:10     ` Garrett Cooper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.