All of lore.kernel.org
 help / color / mirror / Atom feed
From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/3] Fix at91 includes in soft_i2c driver
Date: Wed, 26 Jan 2011 09:18:54 +0100	[thread overview]
Message-ID: <4D3FD8EE.6030009@emk-elektronik.de> (raw)
In-Reply-To: <4D3FD220.5040406@denx.de>

Dear Ryan Mellon, dear Heiko Schocher:
>>>>> Signed-off-by: Ryan Mallon<ryan@bluewatersys.com>
>>>>> ---
>>>>>   drivers/i2c/soft_i2c.c |    4 +---
>>>>>   1 files changed, 1 insertions(+), 3 deletions(-)
>>>>
>>>> I think this one goes through as a bug fix, i. e. for the upcoming
>>>> release.
>>>>
>>>> The other patches of this series go into next.
>>>
>>> Ok. Reinhard? Do you pick up this patch? If so, I give my:
>>>
>>> Acked-by: Heiko Schocher<hs@denx.de>
>>
>> I was going to complain that it was not alphabetically sorted as I
>> suggested to him,
>> however I am now considering to remove the AT91RM9200 case altogether.
>> That one has to be forced into AT91FAMILY.
>>
>> Once corrected, I will pickup this patch then.

I made up my mind, it should only test for AT91FAMILY.

AT91RM9200 is supposed to join AT91FAMILY anyway, so lets do this correctly right now.

#if defined(CONFIG_AT91FAMILY)

If its done that way, here is my
Acked-by: Reinhard Meyer<u-boot@emk-elektronik.de>

Ryan, can you please change it as such, and preferably post it as a separate
patch (not with your new board)? So Heiko can pick it up and make it go as a
bug fix to mainline faster than I could do it right now through the "atmel" tree.

Best Regards,
Reinhard

  reply	other threads:[~2011-01-26  8:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25 22:52 [U-Boot] [PATCH v2 0/3] Add Bluewater Systems Snapper 9260/9G20 module support Ryan Mallon
2011-01-25 22:52 ` [U-Boot] [PATCH v2 1/3] Fix at91 includes in soft_i2c driver Ryan Mallon
2011-01-25 22:52   ` [U-Boot] [PATCH v2 2/3] Add support for Bluewater Systems Snapper 9260 and 9G20 modules Ryan Mallon
2011-01-25 22:52     ` [U-Boot] [PATCH v2 3/3] Add Bluewater Systems Snapper 9260 and 9G20 modules to top-level boards.cfg Ryan Mallon
2011-01-26  7:22       ` Wolfgang Denk
2011-01-26  7:22     ` [U-Boot] [PATCH v2 2/3] Add support for Bluewater Systems Snapper 9260 and 9G20 modules Wolfgang Denk
2011-01-26  7:40       ` Reinhard Meyer
2011-01-27  0:14         ` Ryan Mallon
2011-01-27  6:13           ` Reinhard Meyer
2011-01-26  7:19   ` [U-Boot] [PATCH v2 1/3] Fix at91 includes in soft_i2c driver Wolfgang Denk
2011-01-26  7:30     ` Heiko Schocher
2011-01-26  7:37       ` Reinhard Meyer
2011-01-26  7:49         ` Heiko Schocher
2011-01-26  8:18           ` Reinhard Meyer [this message]
2011-01-26 18:27             ` Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D3FD8EE.6030009@emk-elektronik.de \
    --to=u-boot@emk-elektronik.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.