[Qemu-devel] [PATCH] Add documentation for STRTOSZ_DEFSUFFIX_ macros

[Qemu-devel] [PATCH] Add documentation for STRTOSZ_DEFSUFFIX_ macros

[Jes.Sorensen]

From: Jes Sorensen <Jes.Sorensen@redhat.com>

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
 qemu-common.h |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/qemu-common.h b/qemu-common.h
index c766b99..505e576 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -153,6 +153,13 @@ int qemu_fls(int i);
 int qemu_fdatasync(int fd);
 int fcntl_setfl(int fd, int flag);
 
+/*
+ * strtosz() suffixes used to specify the default treatment of an
+ * argument passed to strtosz() without an explicit suffix.
+ * These should be defined using upper case characters in the range
+ * A-Z, as strtosz() will use qemu_toupper() on the given argument
+ * prior to comparison.
+ */
 #define STRTOSZ_DEFSUFFIX_TB	'T'
 #define STRTOSZ_DEFSUFFIX_GB	'G'
 #define STRTOSZ_DEFSUFFIX_MB	'M'
-- 
1.7.3.4

Re: [Qemu-devel] [PATCH] Add documentation for STRTOSZ_DEFSUFFIX_ macros

[Markus Armbruster]

Jes.Sorensen@redhat.com writes:

> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
> ---
>  qemu-common.h |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-common.h b/qemu-common.h
> index c766b99..505e576 100644
> --- a/qemu-common.h
> +++ b/qemu-common.h
> @@ -153,6 +153,13 @@ int qemu_fls(int i);
>  int qemu_fdatasync(int fd);
>  int fcntl_setfl(int fd, int flag);
>  
> +/*
> + * strtosz() suffixes used to specify the default treatment of an
> + * argument passed to strtosz() without an explicit suffix.
> + * These should be defined using upper case characters in the range
> + * A-Z, as strtosz() will use qemu_toupper() on the given argument
> + * prior to comparison.
> + */
>  #define STRTOSZ_DEFSUFFIX_TB	'T'
>  #define STRTOSZ_DEFSUFFIX_GB	'G'
>  #define STRTOSZ_DEFSUFFIX_MB	'M'

Thanks, Jes!

Acked-by: Markus Armbruster <armbru@redhat.com>

Re: [Qemu-devel] [PATCH] Add documentation for STRTOSZ_DEFSUFFIX_ macros

[Kevin Wolf]

Am 26.01.2011 12:53, schrieb Markus Armbruster:
> Jes.Sorensen@redhat.com writes:
> 
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>> ---
>>  qemu-common.h |    7 +++++++
>>  1 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/qemu-common.h b/qemu-common.h
>> index c766b99..505e576 100644
>> --- a/qemu-common.h
>> +++ b/qemu-common.h
>> @@ -153,6 +153,13 @@ int qemu_fls(int i);
>>  int qemu_fdatasync(int fd);
>>  int fcntl_setfl(int fd, int flag);
>>  
>> +/*
>> + * strtosz() suffixes used to specify the default treatment of an
>> + * argument passed to strtosz() without an explicit suffix.
>> + * These should be defined using upper case characters in the range
>> + * A-Z, as strtosz() will use qemu_toupper() on the given argument
>> + * prior to comparison.
>> + */
>>  #define STRTOSZ_DEFSUFFIX_TB	'T'
>>  #define STRTOSZ_DEFSUFFIX_GB	'G'
>>  #define STRTOSZ_DEFSUFFIX_MB	'M'
> 
> Thanks, Jes!
> 
> Acked-by: Markus Armbruster <armbru@redhat.com>

Thanks, applied to the block branch.

Kevin