* msm gadget compilation failure with trout
@ 2011-01-27 21:12 Denis 'GNUtoo' Carikli
2011-01-27 21:26 ` Daniel Walker
0 siblings, 1 reply; 5+ messages in thread
From: Denis 'GNUtoo' Carikli @ 2011-01-27 21:12 UTC (permalink / raw)
To: linux-arm-msm
Hi,
I've that:
drivers/usb/gadget/ci13xxx_msm.c: In function
'ci13xxx_msm_notify_event':
drivers/usb/gadget/ci13xxx_msm.c:42:3: error: 'USB_AHBBURST' undeclared
(first use in this function)
drivers/usb/gadget/ci13xxx_msm.c:42:3: note: each undeclared identifier
is reported only once for each function it appears in
drivers/usb/gadget/ci13xxx_msm.c:43:3: error: 'USB_AHBMODE' undeclared
(first use in this function)
make[2]: *** [drivers/usb/gadget/ci13xxx_msm.o] Error 1
make[1]: *** [drivers/usb/gadget] Error 2
make[1]: *** Waiting for unfinished jobs....
here's my setup:
* linux-next/master
( git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git ) at
47db3d1b0b3d69c6e977158ac354a972b81677bd
* trout(also known as htc dream or G1) board
Should I include my defconfig?
Should I include more details?
Am I using the gadget wrong driver?
Denis.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: msm gadget compilation failure with trout
2011-01-27 21:12 msm gadget compilation failure with trout Denis 'GNUtoo' Carikli
@ 2011-01-27 21:26 ` Daniel Walker
2011-01-28 7:01 ` Pavan Kondeti
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Walker @ 2011-01-27 21:26 UTC (permalink / raw)
To: Denis 'GNUtoo' Carikli
Cc: linux-arm-msm, Pavankumar Kondeti, Greg Kroah-Hartman
On Thu, 2011-01-27 at 22:12 +0100, Denis 'GNUtoo' Carikli wrote:
> Hi,
>
> I've that:
> drivers/usb/gadget/ci13xxx_msm.c: In function
> 'ci13xxx_msm_notify_event':
> drivers/usb/gadget/ci13xxx_msm.c:42:3: error: 'USB_AHBBURST' undeclared
> (first use in this function)
> drivers/usb/gadget/ci13xxx_msm.c:42:3: note: each undeclared identifier
> is reported only once for each function it appears in
> drivers/usb/gadget/ci13xxx_msm.c:43:3: error: 'USB_AHBMODE' undeclared
> (first use in this function)
> make[2]: *** [drivers/usb/gadget/ci13xxx_msm.o] Error 1
> make[1]: *** [drivers/usb/gadget] Error 2
> make[1]: *** Waiting for unfinished jobs....
>
> here's my setup:
> * linux-next/master
> ( git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git ) at
> 47db3d1b0b3d69c6e977158ac354a972b81677bd
> * trout(also known as htc dream or G1) board
>
> Should I include my defconfig?
> Should I include more details?
> Am I using the gadget wrong driver?
>
> Denis.
Looks like it was cause by this commit,
commit e0c201f339fe7fc38d1b0f6f4755ff627686c7e0
Author: Pavankumar Kondeti <pkondeti@codeaurora.org>
Date: Tue Dec 7 17:53:55 2010 +0530
USB: Add MSM OTG Controller driver
This driver implements PHY initialization, clock management, ULPI IO ops
and simple OTG state machine to kick host/peripheral based on Id/VBUS
line status. VBUS/Id lines are tied to a reference voltage on some boards.
Hence provide debugfs interface to select host/peripheral mode.
Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
I CC'd the people in the commit.. I have no idea what those values are
support to be.
Daniel
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: msm gadget compilation failure with trout
2011-01-27 21:26 ` Daniel Walker
@ 2011-01-28 7:01 ` Pavan Kondeti
2011-01-28 17:15 ` Daniel Walker
0 siblings, 1 reply; 5+ messages in thread
From: Pavan Kondeti @ 2011-01-28 7:01 UTC (permalink / raw)
To: Daniel Walker
Cc: Denis 'GNUtoo' Carikli, linux-arm-msm, Greg Kroah-Hartman
Hi Denis,
On 1/28/2011 2:56 AM, Daniel Walker wrote:
> On Thu, 2011-01-27 at 22:12 +0100, Denis 'GNUtoo' Carikli wrote:
>> Hi,
>>
>> I've that:
>> drivers/usb/gadget/ci13xxx_msm.c: In function
>> 'ci13xxx_msm_notify_event':
>> drivers/usb/gadget/ci13xxx_msm.c:42:3: error: 'USB_AHBBURST' undeclared
>> (first use in this function)
>> drivers/usb/gadget/ci13xxx_msm.c:42:3: note: each undeclared identifier
>> is reported only once for each function it appears in
>> drivers/usb/gadget/ci13xxx_msm.c:43:3: error: 'USB_AHBMODE' undeclared
>> (first use in this function)
>> make[2]: *** [drivers/usb/gadget/ci13xxx_msm.o] Error 1
>> make[1]: *** [drivers/usb/gadget] Error 2
>> make[1]: *** Waiting for unfinished jobs....
>>
>> here's my setup:
>> * linux-next/master
>> ( git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git ) at
>> 47db3d1b0b3d69c6e977158ac354a972b81677bd
>> * trout(also known as htc dream or G1) board
>>
>> Should I include my defconfig?
>> Should I include more details?
>> Am I using the gadget wrong driver?
>>
AHBMODE register offset is different for trout and AHBBURST register is
not present in trout.
MSM gadget driver is supported only for QSD8x50 and MSM7x30 boards. USB
support is not added for trout which uses an external PHY unlike the
other targets. Please disable USB support in your defconfig.
Thanks,
Pavan
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: msm gadget compilation failure with trout
2011-01-28 7:01 ` Pavan Kondeti
@ 2011-01-28 17:15 ` Daniel Walker
2011-01-31 3:47 ` Pavan Kondeti
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Walker @ 2011-01-28 17:15 UTC (permalink / raw)
To: Pavan Kondeti
Cc: Denis 'GNUtoo' Carikli, linux-arm-msm, Greg Kroah-Hartman
On Fri, 2011-01-28 at 12:31 +0530, Pavan Kondeti wrote:
> Hi Denis,
>
> On 1/28/2011 2:56 AM, Daniel Walker wrote:
> > On Thu, 2011-01-27 at 22:12 +0100, Denis 'GNUtoo' Carikli wrote:
> >> Hi,
> >>
> >> I've that:
> >> drivers/usb/gadget/ci13xxx_msm.c: In function
> >> 'ci13xxx_msm_notify_event':
> >> drivers/usb/gadget/ci13xxx_msm.c:42:3: error: 'USB_AHBBURST' undeclared
> >> (first use in this function)
> >> drivers/usb/gadget/ci13xxx_msm.c:42:3: note: each undeclared identifier
> >> is reported only once for each function it appears in
> >> drivers/usb/gadget/ci13xxx_msm.c:43:3: error: 'USB_AHBMODE' undeclared
> >> (first use in this function)
> >> make[2]: *** [drivers/usb/gadget/ci13xxx_msm.o] Error 1
> >> make[1]: *** [drivers/usb/gadget] Error 2
> >> make[1]: *** Waiting for unfinished jobs....
> >>
> >> here's my setup:
> >> * linux-next/master
> >> ( git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git ) at
> >> 47db3d1b0b3d69c6e977158ac354a972b81677bd
> >> * trout(also known as htc dream or G1) board
> >>
> >> Should I include my defconfig?
> >> Should I include more details?
> >> Am I using the gadget wrong driver?
> >>
>
> AHBMODE register offset is different for trout and AHBBURST register is
> not present in trout.
>
> MSM gadget driver is supported only for QSD8x50 and MSM7x30 boards. USB
> support is not added for trout which uses an external PHY unlike the
> other targets. Please disable USB support in your defconfig.
If it's not supported don't allow it to be compiled, but you need to
make some sort of fix for this.
btw, if it's not support why is there a 7X01 define used in the header ?
Daniel
--
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: msm gadget compilation failure with trout
2011-01-28 17:15 ` Daniel Walker
@ 2011-01-31 3:47 ` Pavan Kondeti
0 siblings, 0 replies; 5+ messages in thread
From: Pavan Kondeti @ 2011-01-31 3:47 UTC (permalink / raw)
To: Daniel Walker
Cc: Denis 'GNUtoo' Carikli, linux-arm-msm, Greg Kroah-Hartman
On 1/28/2011 10:45 PM, Daniel Walker wrote:
> On Fri, 2011-01-28 at 12:31 +0530, Pavan Kondeti wrote:
>> Hi Denis,
>>
>> On 1/28/2011 2:56 AM, Daniel Walker wrote:
>>> On Thu, 2011-01-27 at 22:12 +0100, Denis 'GNUtoo' Carikli wrote:
>>>> Hi,
>>>>
>>>> I've that:
>>>> drivers/usb/gadget/ci13xxx_msm.c: In function
>>>> 'ci13xxx_msm_notify_event':
>>>> drivers/usb/gadget/ci13xxx_msm.c:42:3: error: 'USB_AHBBURST' undeclared
>>>> (first use in this function)
>>>> drivers/usb/gadget/ci13xxx_msm.c:42:3: note: each undeclared identifier
>>>> is reported only once for each function it appears in
>>>> drivers/usb/gadget/ci13xxx_msm.c:43:3: error: 'USB_AHBMODE' undeclared
>>>> (first use in this function)
>>>> make[2]: *** [drivers/usb/gadget/ci13xxx_msm.o] Error 1
>>>> make[1]: *** [drivers/usb/gadget] Error 2
>>>> make[1]: *** Waiting for unfinished jobs....
>>>>
>>>> here's my setup:
>>>> * linux-next/master
>>>> ( git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git ) at
>>>> 47db3d1b0b3d69c6e977158ac354a972b81677bd
>>>> * trout(also known as htc dream or G1) board
>>>>
>>>> Should I include my defconfig?
>>>> Should I include more details?
>>>> Am I using the gadget wrong driver?
>>>>
>>
>> AHBMODE register offset is different for trout and AHBBURST register is
>> not present in trout.
>>
>> MSM gadget driver is supported only for QSD8x50 and MSM7x30 boards. USB
>> support is not added for trout which uses an external PHY unlike the
>> other targets. Please disable USB support in your defconfig.
>
> If it's not supported don't allow it to be compiled, but you need to
> make some sort of fix for this.
>
Agreed. I will submit a patch to fix this.
> btw, if it's not support why is there a 7X01 define used in the header ?
>
Sorry. It should not have been there. It was a copy-paste mistake.
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-01-31 3:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-27 21:12 msm gadget compilation failure with trout Denis 'GNUtoo' Carikli
2011-01-27 21:26 ` Daniel Walker
2011-01-28 7:01 ` Pavan Kondeti
2011-01-28 17:15 ` Daniel Walker
2011-01-31 3:47 ` Pavan Kondeti
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.