[PATCH 00/18] wl1251: feature ports / monitor mode / packet injection

[PATCH 00/18] wl1251: feature ports / monitor mode / packet injection

[David Gnedt]

Patch 01-03 fix some bugs.
Patch 04-09 contain some feature ports from Maemo Fremantle and wl1271.
Patch 10-18 implement (mainly) monitor mode and packet injection.

Sorry for the partly broken patches, I thought I configured my client the
right way. I tried to stop the mails at my mailserver, but it was mostly
already too late.

David Gnedt (18):
  wl1251: fix queue stopping/waking for TX path
  wl1251: fix 4-byte TX buffer alignment
  wl1251: fix scan behaviour while not associated
  wl1251: add sysfs interface for bluetooth coexistence mode
    configuration
  wl1251: retry power save entry
  wl1251: enable beacon early termination while in power-saving mode
  wl1251: implement connection quality monitoring
  wl1251: implement hardware ARP filtering
  wl1251: enable adhoc mode
  wl1251: split RX and TX data path initialisation
  wl1251: configure hardware en-/decryption for monitor mode
  wl1251: set rate index and preamble flag on received packets
  wl1251: rework configure_filter() callback
  wl1251: implement multicast address filtering
  wl1251: disable power saving in monitor mode
  wl1251: fix channel switching in monitor mode
  wl1251: enable tx path in monitor mode if necessary for packet
    injection
  wl1251: disable retry and ACK policy for injected packets

 drivers/net/wireless/wl1251/acx.c    |  150 ++++++++++++++--
 drivers/net/wireless/wl1251/acx.h    |  106 ++++++++++-
 drivers/net/wireless/wl1251/boot.c   |    3 +-
 drivers/net/wireless/wl1251/cmd.c    |   58 ++++--
 drivers/net/wireless/wl1251/cmd.h    |    8 +-
 drivers/net/wireless/wl1251/event.c  |   62 ++++++
 drivers/net/wireless/wl1251/event.h  |    7 +
 drivers/net/wireless/wl1251/init.c   |   19 +-
 drivers/net/wireless/wl1251/main.c   |  348 ++++++++++++++++++++++++++++------
 drivers/net/wireless/wl1251/ps.c     |   11 +
 drivers/net/wireless/wl1251/rx.c     |   48 +++++-
 drivers/net/wireless/wl1251/tx.c     |  101 ++++++----
 drivers/net/wireless/wl1251/wl1251.h |   26 ++-
 13 files changed, 795 insertions(+), 152 deletions(-)

Re: [PATCH 00/18] wl1251: feature ports / monitor mode / packet injection

[Kalle Valo]

Hi David,

David Gnedt <david.gnedt@davizone.at> writes:

> Patch 01-03 fix some bugs.
> Patch 04-09 contain some feature ports from Maemo Fremantle and wl1271.
> Patch 10-18 implement (mainly) monitor mode and packet injection.

How did you test the patches? For example, what hardware did you use
etc.

About the code from fremantle kernels. Few weeks ago nokia sent me
privately the original patches from their internal git tree, I gave
some comments and never heard back. So, in theory I should have all
the fremantle patches somewhere in my email archives. I would just
need to clean them up and send them here. I'll go over your patches
and let's see what we should do.

> Sorry for the partly broken patches, I thought I configured my client the
> right way. I tried to stop the mails at my mailserver, but it was mostly
> already too late.

No problem. But whenever you resend your patchset, please add a
revision to them, otherwise it's impossible to know which patch is
which. Good way is to use tag "[PATCH v2]" or similar.

-- 
Kalle Valo

Re: [PATCH 00/18] wl1251: feature ports / monitor mode / packet injection

[David Gnedt]

Am 2011-01-31 16:08, schrieb Kalle Valo:
> How did you test the patches? For example, what hardware did you use
> etc.

I tested the patches with compat-wireless and a modified fremantle 2.6.28 kernel
on my Nokia N900.

> About the code from fremantle kernels. Few weeks ago nokia sent me
> privately the original patches from their internal git tree, I gave
> some comments and never heard back. So, in theory I should have all
> the fremantle patches somewhere in my email archives. I would just
> need to clean them up and send them here. I'll go over your patches
> and let's see what we should do.

It would be interesting if I missed some features. I diffed the drivers, but I
am not 100% sure if I overlooked something useful.
One thing I haven't included in this patchset is the netlink interface from the
fremantle code for NVS loading because I thought it wouldn't be accepted anyway.

Re: [PATCH 00/18] wl1251: feature ports / monitor mode / packet injection

[Kalle Valo]

David Gnedt <david.gnedt@davizone.at> writes:

> One thing I haven't included in this patchset is the netlink
> interface from the fremantle code for NVS loading because I thought
> it wouldn't be accepted anyway.

Correct, it's definitely not for upstream. nl80211 now has testmode
interface which can be used for that, but as wl1251 hardware is so old
already I doubt anyone has any interest on.

I have now read and commented some of your patches, I will go through
the rest today. But 18 patches in a patchset is quite a lot. To make
it easier to review and manage the patches I would recommend to split
them to smaller and logical patchsets.

-- 
Kalle Valo

Re: [PATCH 00/18] wl1251: feature ports / monitor mode / packet injection

[Grazvydas Ignotas]

Hi,

On Mon, Jan 31, 2011 at 5:08 PM, Kalle Valo <kvalo@adurom.com> wrote:
> Hi David,
>
> David Gnedt <david.gnedt@davizone.at> writes:
>
>> Patch 01-03 fix some bugs.
>> Patch 04-09 contain some feature ports from Maemo Fremantle and wl1271.
>> Patch 10-18 implement (mainly) monitor mode and packet injection.
>
> How did you test the patches? For example, what hardware did you use
> etc.
>
> About the code from fremantle kernels. Few weeks ago nokia sent me
> privately the original patches from their internal git tree, I gave
> some comments and never heard back. So, in theory I should have all
> the fremantle patches somewhere in my email archives. I would just
> need to clean them up and send them here. I'll go over your patches
> and let's see what we should do.

I was the one trying to organize this, Luciano managed this from Nokia
side and Yuri (CCed) did the porting to newer kernels. However several
patches were missing attribution and things somehow got stuck there.

As for this series, I'll try to test them on pandora hardware over this week.

Re: [PATCH 00/18] wl1251: feature ports / monitor mode / packet injection

[Grazvydas Ignotas]

On Sun, Jan 30, 2011 at 9:10 PM, David Gnedt <david.gnedt@davizone.at> wrote:
> Patch 01-03 fix some bugs.
> Patch 04-09 contain some feature ports from Maemo Fremantle and wl1271.
> Patch 10-18 implement (mainly) monitor mode and packet injection.

Just tried this on pandora board with 2.6.37 kernel and everything
seems to be fine. Haven't tested monitor mode or packet injection
though, so for fixes and feature ports:
Tested-by: Grazvydas Ignotas <notasas@gmail.com>