[RFC] voice call API changes (proposal)

[RFC] voice call API changes (proposal)

[Andras Domokos]

[-- Attachment #1: Type: text/plain, Size: 2912 bytes --]

Here is a proposal for expanding the VoiceCallManager interface with 
call related Supplementary Services signals, and the VoiceCall
interface with new properties.

---
 doc/call-barring-api.txt     |   10 ----------
 doc/voicecall-api.txt        |   15 +++++++++++++++
 doc/voicecallmanager-api.txt |   21 +++++++++++++++++++++
 3 files changed, 36 insertions(+), 10 deletions(-)

diff --git a/doc/call-barring-api.txt b/doc/call-barring-api.txt
index 41ae4b1..1534494 100644
--- a/doc/call-barring-api.txt
+++ b/doc/call-barring-api.txt
@@ -37,16 +37,6 @@ Signals		PropertyChanged(string property, variant value)
 			Signal is emitted whenever a property has changed.
 			The new value is passed as the signal argument.
 
-		IncomingBarringInEffect()
-
-			Signal is emitted when a call is made and an
-			incoming call barring supplementary service is in use.
-
-		OutgoingBarringInEffect()
-
-			Signal is emitted when a call is made and an
-			outgoing call barring supplementary service is in use.
-
 Properties	string VoiceIncoming [readwrite]
 
 			Contains the value of the barrings for the incoming
diff --git a/doc/voicecall-api.txt b/doc/voicecall-api.txt
index 047b8cb..e7276a3 100644
--- a/doc/voicecall-api.txt
+++ b/doc/voicecall-api.txt
@@ -145,3 +145,18 @@ Properties	string LineIdentification [readonly]
 
 			Contains the indication if the voice call is an
 			emergency call or not.
+
+		boolean Forwarded
+
+			Contains the indication whether the voice call is a
+			forwarded call or not.
+
+		boolean RemoteHold
+
+			Contains the indication whether the voice call has been
+			put on hold by the remote party or not.
+
+		boolean Waiting
+
+			Contains the indication whether the outgoing voice call
+			is waiting or not.
diff --git a/doc/voicecallmanager-api.txt b/doc/voicecallmanager-api.txt
index 2bf9ded..bbd80db 100644
--- a/doc/voicecallmanager-api.txt
+++ b/doc/voicecallmanager-api.txt
@@ -144,6 +144,27 @@ Signals		CallAdded(object path, dict properties)
 			Signal is emitted whenever a property has changed.
 			The new value is passed as the signal argument.
 
+		UnconditionalForwardingInEffect
+
+			Signal is emitted when a call is made and unconditional
+			call forwarding supplementary service is active.
+
+		ConditionalForwardingInEffect
+
+			Signal is emitted when a call is made and some of the
+			conditional call forwarding supplementary services are
+			active.
+
+		IncomingBarringInEffect()
+
+			Signal is emitted when a call is made and an
+			incoming call barring supplementary service is in use.
+
+		OutgoingBarringInEffect()
+
+			Signal is emitted when a call is made and an
+			outgoing call barring supplementary service is in use.
+
 Properties	array{string} EmergencyNumbers [readonly]
 
 			Contains the list of emergency numbers recognized
-- 
1.7.0.4

Re: [RFC] voice call API changes (proposal)

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 4055 bytes --]

Hi Andras,

On 01/31/2011 05:56 AM, Andras Domokos wrote:
> Here is a proposal for expanding the VoiceCallManager interface with 
> call related Supplementary Services signals, and the VoiceCall
> interface with new properties.
> 
> ---
>  doc/call-barring-api.txt     |   10 ----------
>  doc/voicecall-api.txt        |   15 +++++++++++++++
>  doc/voicecallmanager-api.txt |   21 +++++++++++++++++++++
>  3 files changed, 36 insertions(+), 10 deletions(-)
> 
> diff --git a/doc/call-barring-api.txt b/doc/call-barring-api.txt
> index 41ae4b1..1534494 100644
> --- a/doc/call-barring-api.txt
> +++ b/doc/call-barring-api.txt
> @@ -37,16 +37,6 @@ Signals		PropertyChanged(string property, variant value)
>  			Signal is emitted whenever a property has changed.
>  			The new value is passed as the signal argument.
>  
> -		IncomingBarringInEffect()
> -
> -			Signal is emitted when a call is made and an
> -			incoming call barring supplementary service is in use.
> -
> -		OutgoingBarringInEffect()
> -
> -			Signal is emitted when a call is made and an
> -			outgoing call barring supplementary service is in use.
> -
>  Properties	string VoiceIncoming [readwrite]
>  
>  			Contains the value of the barrings for the incoming
> diff --git a/doc/voicecall-api.txt b/doc/voicecall-api.txt
> index 047b8cb..e7276a3 100644
> --- a/doc/voicecall-api.txt
> +++ b/doc/voicecall-api.txt
> @@ -145,3 +145,18 @@ Properties	string LineIdentification [readonly]
>  
>  			Contains the indication if the voice call is an
>  			emergency call or not.
> +
> +		boolean Forwarded
> +
> +			Contains the indication whether the voice call is a
> +			forwarded call or not.
> +

So just to clarify, this is usually set on a local Incoming / Waiting
call, correct?

> +		boolean RemoteHold
> +
> +			Contains the indication whether the voice call has been
> +			put on hold by the remote party or not.
> +

This one is rather tricky, since AT modems do not report the index of
the call.  So the only way you can report this is if you have only a
single call active or your modem supports this properly (I know ISI does).

> +		boolean Waiting
> +
> +			Contains the indication whether the outgoing voice call
> +			is waiting or not.

And this is for a local dialing / alerting call.  Correct?

> diff --git a/doc/voicecallmanager-api.txt b/doc/voicecallmanager-api.txt
> index 2bf9ded..bbd80db 100644
> --- a/doc/voicecallmanager-api.txt
> +++ b/doc/voicecallmanager-api.txt
> @@ -144,6 +144,27 @@ Signals		CallAdded(object path, dict properties)
>  			Signal is emitted whenever a property has changed.
>  			The new value is passed as the signal argument.
>  
> +		UnconditionalForwardingInEffect
> +
> +			Signal is emitted when a call is made and unconditional
> +			call forwarding supplementary service is active.

This is for a local dialing / alerting call.  Correct?

> +
> +		ConditionalForwardingInEffect
> +
> +			Signal is emitted when a call is made and some of the
> +			conditional call forwarding supplementary services are
> +			active.
> +

Same as above?

> +		IncomingBarringInEffect()
> +
> +			Signal is emitted when a call is made and an
> +			incoming call barring supplementary service is in use.
> +

For local outgoing calls telling that the remote side has incoming
barring active?

> +		OutgoingBarringInEffect()
> +
> +			Signal is emitted when a call is made and an
> +			outgoing call barring supplementary service is in use.
> +

And this one telling you that local outgoing barring is active?

>  Properties	array{string} EmergencyNumbers [readonly]
>  
>  			Contains the list of emergency numbers recognized

Generally I'm fine with these but please document them a bit more
clearly, and we might have to pick names that make a bit more sense.

Other than that, you're missing the mpty join indications that Pekka had
in his earlier proposal.  These suffer from the same problem as RemoteHold.

Regards,
-Denis

Re: [RFC] voice call API changes (proposal)

[Andras Domokos]

[-- Attachment #1: Type: text/plain, Size: 6147 bytes --]

Hi Denis,

On 01/31/2011 09:58 PM, ext Denis Kenzior wrote:
> Hi Andras,
>
> On 01/31/2011 05:56 AM, Andras Domokos wrote:
>> Here is a proposal for expanding the VoiceCallManager interface with
>> call related Supplementary Services signals, and the VoiceCall
>> interface with new properties.
>>
>> ---
>>   doc/call-barring-api.txt     |   10 ----------
>>   doc/voicecall-api.txt        |   15 +++++++++++++++
>>   doc/voicecallmanager-api.txt |   21 +++++++++++++++++++++
>>   3 files changed, 36 insertions(+), 10 deletions(-)
>>
>> diff --git a/doc/call-barring-api.txt b/doc/call-barring-api.txt
>> index 41ae4b1..1534494 100644
>> --- a/doc/call-barring-api.txt
>> +++ b/doc/call-barring-api.txt
>> @@ -37,16 +37,6 @@ Signals		PropertyChanged(string property, variant value)
>>   			Signal is emitted whenever a property has changed.
>>   			The new value is passed as the signal argument.
>>
>> -		IncomingBarringInEffect()
>> -
>> -			Signal is emitted when a call is made and an
>> -			incoming call barring supplementary service is in use.
>> -
>> -		OutgoingBarringInEffect()
>> -
>> -			Signal is emitted when a call is made and an
>> -			outgoing call barring supplementary service is in use.
>> -
>>   Properties	string VoiceIncoming [readwrite]
>>
>>   			Contains the value of the barrings for the incoming
>> diff --git a/doc/voicecall-api.txt b/doc/voicecall-api.txt
>> index 047b8cb..e7276a3 100644
>> --- a/doc/voicecall-api.txt
>> +++ b/doc/voicecall-api.txt
>> @@ -145,3 +145,18 @@ Properties	string LineIdentification [readonly]
>>
>>   			Contains the indication if the voice call is an
>>   			emergency call or not.
>> +
>> +		boolean Forwarded
>> +
>> +			Contains the indication whether the voice call is a
>> +			forwarded call or not.
>> +
> So just to clarify, this is usually set on a local Incoming / Waiting
> call, correct?
This property would apply to both, outgoing and incoming calls.

When the incoming call is a forwarded call the call is accompanied
by a "forwarded call" SS notification.

When the call is an outgoing call and the call is forwarded due to the
remote party having a conditional or unconditional forwarding enabled,
the outgoing call is accompanied by a "call has been forwarded"
SS notification.

I think would be a good idea, if not mandatory, to have a voice call
property indicating the call direction.
>> +		boolean RemoteHold
>> +
>> +			Contains the indication whether the voice call has been
>> +			put on hold by the remote party or not.
>> +
> This one is rather tricky, since AT modems do not report the index of
> the call.  So the only way you can report this is if you have only a
> single call active or your modem supports this properly (I know ISI does).
Indeed, this is a tricky case since the standard AT Supplementary
Services notification don't provide the call index within the notifications.
Although in many cases the call index can be inferred correctly, there
are cases when this is impossible and the call index needs to be
provided explicitly, like in the remote hold/multiparty  cases and
assuming 2 local calls. We do best effort guess for modems not
supporting call indexes.

>> +		boolean Waiting
>> +
>> +			Contains the indication whether the outgoing voice call
>> +			is waiting or not.
> And this is for a local dialing / alerting call.  Correct?
This is an indication from the network in connection with an
outgoing call telling that the remote party is already engaged into
a call and your call is waiting to be answered or rejected (handled).

>> diff --git a/doc/voicecallmanager-api.txt b/doc/voicecallmanager-api.txt
>> index 2bf9ded..bbd80db 100644
>> --- a/doc/voicecallmanager-api.txt
>> +++ b/doc/voicecallmanager-api.txt
>> @@ -144,6 +144,27 @@ Signals		CallAdded(object path, dict properties)
>>   			Signal is emitted whenever a property has changed.
>>   			The new value is passed as the signal argument.
>>
>> +		UnconditionalForwardingInEffect
>> +
>> +			Signal is emitted when a call is made and unconditional
>> +			call forwarding supplementary service is active.
> This is for a local dialing / alerting call.  Correct?
The notification is sent in connection with an outgoing call when
the remote party has unconditional call forwarding enabled that
is enforced by the network.
>> +
>> +		ConditionalForwardingInEffect
>> +
>> +			Signal is emitted when a call is made and some of the
>> +			conditional call forwarding supplementary services are
>> +			active.
>> +
> Same as above?
The notification is sent in connection with an outgoing call when
the remote party has such conditional call forwarding enabled
that is enforced by the network.

>> +		IncomingBarringInEffect()
>> +
>> +			Signal is emitted when a call is made and an
>> +			incoming call barring supplementary service is in use.
>> +
> For local outgoing calls telling that the remote side has incoming
> barring active?
Yes.
Emitted when making an outgoing call and the remote party has such an
incoming call barring enabled that is enforced by the network.
>> +		OutgoingBarringInEffect()
>> +
>> +			Signal is emitted when a call is made and an
>> +			outgoing call barring supplementary service is in use.
>> +
> And this one telling you that local outgoing barring is active?
Yes.
Emitted when making an outgoing call and there is such outgoing
call barring enabled that is enforced by the network.
>>   Properties	array{string} EmergencyNumbers [readonly]
>>
>>   			Contains the list of emergency numbers recognized
> Generally I'm fine with these but please document them a bit more
> clearly, and we might have to pick names that make a bit more sense.
>
> Other than that, you're missing the mpty join indications that Pekka had
> in his earlier proposal.  These suffer from the same problem as RemoteHold.
That's true, RemoteMultiparty needs to be added to the the set of call
properties and we are facing the same challenges as with the RemoteHold
case.


> Regards,
> -Denis

Regards,
Andras

Re: [RFC] voice call API changes (proposal)

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 1798 bytes --]

Hi Andras,

>>> +
>>> +        boolean Forwarded
>>> +
>>> +            Contains the indication whether the voice call is a
>>> +            forwarded call or not.
>>> +
>> So just to clarify, this is usually set on a local Incoming / Waiting
>> call, correct?
> This property would apply to both, outgoing and incoming calls.
> 
> When the incoming call is a forwarded call the call is accompanied
> by a "forwarded call" SS notification.
> 
> When the call is an outgoing call and the call is forwarded due to the
> remote party having a conditional or unconditional forwarding enabled,
> the outgoing call is accompanied by a "call has been forwarded"
> SS notification.
> 
> I think would be a good idea, if not mandatory, to have a voice call
> property indicating the call direction.

So why do we need the below two signals if the Forwarded property
applies to both incoming and outgoing calls?

>>> +        UnconditionalForwardingInEffect
>>> +
>>> +            Signal is emitted when a call is made and unconditional
>>> +            call forwarding supplementary service is active.
>> This is for a local dialing / alerting call.  Correct?
> The notification is sent in connection with an outgoing call when
> the remote party has unconditional call forwarding enabled that
> is enforced by the network.
>>> +
>>> +        ConditionalForwardingInEffect
>>> +
>>> +            Signal is emitted when a call is made and some of the
>>> +            conditional call forwarding supplementary services are
>>> +            active.
>>> +
>> Same as above?
> The notification is sent in connection with an outgoing call when
> the remote party has such conditional call forwarding enabled
> that is enforced by the network.
> 

Regards,
-Denis

Re: [RFC] voice call API changes (proposal)

[Andras Domokos]

[-- Attachment #1: Type: text/plain, Size: 2013 bytes --]

Hi Denis,

On 02/01/2011 05:54 PM, ext Denis Kenzior wrote:
> Hi Andras,
>
>>>> +
>>>> +        boolean Forwarded
>>>> +
>>>> +            Contains the indication whether the voice call is a
>>>> +            forwarded call or not.
>>>> +
>>> So just to clarify, this is usually set on a local Incoming / Waiting
>>> call, correct?
>> This property would apply to both, outgoing and incoming calls.
>>
>> When the incoming call is a forwarded call the call is accompanied
>> by a "forwarded call" SS notification.
>>
>> When the call is an outgoing call and the call is forwarded due to the
>> remote party having a conditional or unconditional forwarding enabled,
>> the outgoing call is accompanied by a "call has been forwarded"
>> SS notification.
>>
>> I think would be a good idea, if not mandatory, to have a voice call
>> property indicating the call direction.
> So why do we need the below two signals if the Forwarded property
> applies to both incoming and outgoing calls?
These are optional in fact, let's ignore them for now.
What about the rest, are we OK now?
>>>> +        UnconditionalForwardingInEffect
>>>> +
>>>> +            Signal is emitted when a call is made and unconditional
>>>> +            call forwarding supplementary service is active.
>>> This is for a local dialing / alerting call.  Correct?
>> The notification is sent in connection with an outgoing call when
>> the remote party has unconditional call forwarding enabled that
>> is enforced by the network.
>>>> +
>>>> +        ConditionalForwardingInEffect
>>>> +
>>>> +            Signal is emitted when a call is made and some of the
>>>> +            conditional call forwarding supplementary services are
>>>> +            active.
>>>> +
>>> Same as above?
>> The notification is sent in connection with an outgoing call when
>> the remote party has such conditional call forwarding enabled
>> that is enforced by the network.
>>
> Regards,
> -Denis
Regards,
Andras

Re: [RFC] voice call API changes (proposal)

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 1621 bytes --]

Hi Andras,

On 02/02/2011 01:51 AM, Andras Domokos wrote:
> Hi Denis,
> 
> On 02/01/2011 05:54 PM, ext Denis Kenzior wrote:
>> Hi Andras,
>>
>>>>> +
>>>>> +        boolean Forwarded
>>>>> +
>>>>> +            Contains the indication whether the voice call is a
>>>>> +            forwarded call or not.
>>>>> +
>>>> So just to clarify, this is usually set on a local Incoming / Waiting
>>>> call, correct?
>>> This property would apply to both, outgoing and incoming calls.
>>>
>>> When the incoming call is a forwarded call the call is accompanied
>>> by a "forwarded call" SS notification.
>>>
>>> When the call is an outgoing call and the call is forwarded due to the
>>> remote party having a conditional or unconditional forwarding enabled,
>>> the outgoing call is accompanied by a "call has been forwarded"
>>> SS notification.
>>>
>>> I think would be a good idea, if not mandatory, to have a voice call
>>> property indicating the call direction.
>> So why do we need the below two signals if the Forwarded property
>> applies to both incoming and outgoing calls?
> These are optional in fact, let's ignore them for now.
> What about the rest, are we OK now?

I don't really like this Forwarded property.  I think we should really
break up the indications between the Incoming and Outgoing states.  If
you want Forwarded as a property, then treat it as incoming calls only
and keep the two signals for the outgoing conditions.

Please re-send the entire proposal with all the feedback and extra
documentation integrated in so we can have another look.

Regards,
-Denis

[RFC] voicecall API changes (proposal 2)

[Andras Domokos]

[-- Attachment #1: Type: text/plain, Size: 3226 bytes --]

---
 doc/call-barring-api.txt     |   10 ----------
 doc/voicecall-api.txt        |   17 +++++++++++++++++
 doc/voicecallmanager-api.txt |   28 ++++++++++++++++++++++++++++
 3 files changed, 45 insertions(+), 10 deletions(-)

diff --git a/doc/call-barring-api.txt b/doc/call-barring-api.txt
index 41ae4b1..1534494 100644
--- a/doc/call-barring-api.txt
+++ b/doc/call-barring-api.txt
@@ -37,16 +37,6 @@ Signals		PropertyChanged(string property, variant value)
 			Signal is emitted whenever a property has changed.
 			The new value is passed as the signal argument.
 
-		IncomingBarringInEffect()
-
-			Signal is emitted when a call is made and an
-			incoming call barring supplementary service is in use.
-
-		OutgoingBarringInEffect()
-
-			Signal is emitted when a call is made and an
-			outgoing call barring supplementary service is in use.
-
 Properties	string VoiceIncoming [readwrite]
 
 			Contains the value of the barrings for the incoming
diff --git a/doc/voicecall-api.txt b/doc/voicecall-api.txt
index 047b8cb..9e1d90f 100644
--- a/doc/voicecall-api.txt
+++ b/doc/voicecall-api.txt
@@ -145,3 +145,20 @@ Properties	string LineIdentification [readonly]
 
 			Contains the indication if the voice call is an
 			emergency call or not.
+
+		boolean ForwardedCall
+
+			Contains the indication whether the incoming voice call
+			is a redirected call due to a call forwarding operation
+			or not.
+
+		boolean RemoteHoldActive
+
+			Contains the indication whether the voice call is put on
+			hold by the remote party or not.
+
+		boolean RemoteMultiparty
+
+			Contains the indication whether the voice call is joined
+			in a multiparty call by the remote party or not.
+
diff --git a/doc/voicecallmanager-api.txt b/doc/voicecallmanager-api.txt
index 5415345..7517a7c 100644
--- a/doc/voicecallmanager-api.txt
+++ b/doc/voicecallmanager-api.txt
@@ -144,6 +144,34 @@ Signals		CallAdded(object path, dict properties)
 			Signal is emitted whenever a property has changed.
 			The new value is passed as the signal argument.
 
+		RemoteCallBarringActive()
+
+			Signal is emitted when an outgoing voice call is made
+			and the call has been barred by the network due to the
+			remote party's "Call Barring" Supplementary Services
+			settings for incoming calls.
+
+		LocalCallBarringActive()
+
+			Signal is emitted when an outgoing voice call is made
+			and the call has been barred by the network due to the
+			local party's "Call Barring" Supplementary Services
+			settings for outgoing calls.
+
+		OutgoingCallCondForwarded()
+
+			Signal is emitted when an outgoing voice call is made
+			and the call has been redirected to another number due
+			to the remote party's conditional "Call Forwarding"
+			Supplementary Service settings.
+
+		OutgoingCallUncondForwarded()
+
+			Signal is emitted when an outgoing voice call is made
+			and the call has been redirected to another number due
+			to the remote party's unconditional "Call Forwarding"
+			Supplementary Service settings.
+
 Properties	array{string} EmergencyNumbers [readonly]
 
 			Contains the list of emergency numbers recognized
-- 
1.7.0.4

Re: [RFC] voicecall API changes (proposal 2)

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 3020 bytes --]

Hi Andras,

> +
> +		boolean ForwardedCall
> +
> +			Contains the indication whether the incoming voice call
> +			is a redirected call due to a call forwarding operation
> +			or not.

Please drop the Call suffix, you are already on the VoiceCall interface,
so putting 'Call' at the end is redundant.

> +
> +		boolean RemoteHoldActive
> +
> +			Contains the indication whether the voice call is put on
> +			hold by the remote party or not.
> +

RemoteHeld might be a better name here, but I'm fine either way.

> +		boolean RemoteMultiparty
> +
> +			Contains the indication whether the voice call is joined
> +			in a multiparty call by the remote party or not.
> +
> diff --git a/doc/voicecallmanager-api.txt b/doc/voicecallmanager-api.txt
> index 5415345..7517a7c 100644
> --- a/doc/voicecallmanager-api.txt
> +++ b/doc/voicecallmanager-api.txt
> @@ -144,6 +144,34 @@ Signals		CallAdded(object path, dict properties)
>  			Signal is emitted whenever a property has changed.
>  			The new value is passed as the signal argument.
>  
> +		RemoteCallBarringActive()
> +
> +			Signal is emitted when an outgoing voice call is made
> +			and the call has been barred by the network due to the
> +			remote party's "Call Barring" Supplementary Services
> +			settings for incoming calls.
> +
> +		LocalCallBarringActive()
> +
> +			Signal is emitted when an outgoing voice call is made
> +			and the call has been barred by the network due to the
> +			local party's "Call Barring" Supplementary Services
> +			settings for outgoing calls.
> +

I suggest to combine these two signals into one:
BarringActive(string type)

where type is:
"remote" or "local".

The explanations you have should be applied to the type.  Another point
is whether we want this signal on the call object itself.  Question is
how reliably we can figure out the call index.  At what point does CSSI
/ CSSU fire, before or after the call goes to active / disconnected state?

> +		OutgoingCallCondForwarded()
> +
> +			Signal is emitted when an outgoing voice call is made
> +			and the call has been redirected to another number due
> +			to the remote party's conditional "Call Forwarding"
> +			Supplementary Service settings.
> +
> +		OutgoingCallUncondForwarded()
> +
> +			Signal is emitted when an outgoing voice call is made
> +			and the call has been redirected to another number due
> +			to the remote party's unconditional "Call Forwarding"
> +			Supplementary Service settings.
> +

Same with these two, lets call it CallForwarded(string type)

where type is:
"conditional" or "unconditional"

And the same question applies here as well, do we want this on the call
object itself?  If so, then calling this signal Forwarded(string type)
would be better.  Perhaps adding another type for incoming calls that
are forwarded and removing the 'Forwarded' property would be a good idea
as well.  e.g. something like "incoming" type.

Regards,
-Denis

Re: [RFC] voicecall API changes (proposal 2)

[Andras Domokos]

[-- Attachment #1: Type: text/plain, Size: 4251 bytes --]

Hi Denis,

On 02/02/2011 10:01 PM, ext Denis Kenzior wrote:
> Hi Andras,
>
>> +
>> +		boolean ForwardedCall
>> +
>> +			Contains the indication whether the incoming voice call
>> +			is a redirected call due to a call forwarding operation
>> +			or not.
> Please drop the Call suffix, you are already on the VoiceCall interface,
> so putting 'Call' at the end is redundant.
OK, I am fine with shorter name.
>> +
>> +		boolean RemoteHoldActive
>> +
>> +			Contains the indication whether the voice call is put on
>> +			hold by the remote party or not.
>> +
> RemoteHeld might be a better name here, but I'm fine either way.
I will go with RemoteHeld, it's shorter.
>> +		boolean RemoteMultiparty
>> +
>> +			Contains the indication whether the voice call is joined
>> +			in a multiparty call by the remote party or not.
>> +
>> diff --git a/doc/voicecallmanager-api.txt b/doc/voicecallmanager-api.txt
>> index 5415345..7517a7c 100644
>> --- a/doc/voicecallmanager-api.txt
>> +++ b/doc/voicecallmanager-api.txt
>> @@ -144,6 +144,34 @@ Signals		CallAdded(object path, dict properties)
>>   			Signal is emitted whenever a property has changed.
>>   			The new value is passed as the signal argument.
>>
>> +		RemoteCallBarringActive()
>> +
>> +			Signal is emitted when an outgoing voice call is made
>> +			and the call has been barred by the network due to the
>> +			remote party's "Call Barring" Supplementary Services
>> +			settings for incoming calls.
>> +
>> +		LocalCallBarringActive()
>> +
>> +			Signal is emitted when an outgoing voice call is made
>> +			and the call has been barred by the network due to the
>> +			local party's "Call Barring" Supplementary Services
>> +			settings for outgoing calls.
>> +
> I suggest to combine these two signals into one:
> BarringActive(string type)
>
> where type is:
> "remote" or "local".
OK, let's combine them into a single signal.
> The explanations you have should be applied to the type.  Another point
> is whether we want this signal on the call object itself.  Question is
> how reliably we can figure out the call index.  At what point does CSSI
> / CSSU fire, before or after the call goes to active / disconnected state?
Usually, the user is informed about the call barred situation in a
very generic wording, like "call barring active" with no interest
in the call index information.
I prefer to keep it simple and make this signal call index "free". I
suggest keeping it on the VoiceCallManager interface.
The CSSI indication comes right after when call reached the MO
dialing state and an operator announcement is played over
and over again telling the caller the reason why calls are not
possible.

>> +		OutgoingCallCondForwarded()
>> +
>> +			Signal is emitted when an outgoing voice call is made
>> +			and the call has been redirected to another number due
>> +			to the remote party's conditional "Call Forwarding"
>> +			Supplementary Service settings.
>> +
>> +		OutgoingCallUncondForwarded()
>> +
>> +			Signal is emitted when an outgoing voice call is made
>> +			and the call has been redirected to another number due
>> +			to the remote party's unconditional "Call Forwarding"
>> +			Supplementary Service settings.
>> +
> Same with these two, lets call it CallForwarded(string type)
>
> where type is:
> "conditional" or "unconditional"
I'll combine them into one, that's fine.
> And the same question applies here as well, do we want this on the call
> object itself?  If so, then calling this signal Forwarded(string type)
> would be better.  Perhaps adding another type for incoming calls that
> are forwarded and removing the 'Forwarded' property would be a good idea
> as well.  e.g. something like "incoming" type.
I am thinking along the same line. Let's replace the "Forwarded"
property with the "Forwarded" signal and add the "incoming" type
you were suggesting to this signal.
And we shall not care about the call index, since most probably
is not going to be used anywhere, in this respect this cases is
pretty similar to the call barring signaling case; signal will be
emitted on the VoiceCallManager interface.

> Regards,
> -Denis

Regards,
Andras

Re: [RFC] voicecall API changes (proposal 2)

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 2536 bytes --]

Hi Andras,

>> The explanations you have should be applied to the type.  Another point
>> is whether we want this signal on the call object itself.  Question is
>> how reliably we can figure out the call index.  At what point does CSSI
>> / CSSU fire, before or after the call goes to active / disconnected
>> state?
> Usually, the user is informed about the call barred situation in a
> very generic wording, like "call barring active" with no interest
> in the call index information.
> I prefer to keep it simple and make this signal call index "free". I
> suggest keeping it on the VoiceCallManager interface.
> The CSSI indication comes right after when call reached the MO
> dialing state and an operator announcement is played over
> and over again telling the caller the reason why calls are not
> possible.
> 

Ok, sounds fine to me.

>>> +        OutgoingCallCondForwarded()
>>> +
>>> +            Signal is emitted when an outgoing voice call is made
>>> +            and the call has been redirected to another number due
>>> +            to the remote party's conditional "Call Forwarding"
>>> +            Supplementary Service settings.
>>> +
>>> +        OutgoingCallUncondForwarded()
>>> +
>>> +            Signal is emitted when an outgoing voice call is made
>>> +            and the call has been redirected to another number due
>>> +            to the remote party's unconditional "Call Forwarding"
>>> +            Supplementary Service settings.
>>> +
>> Same with these two, lets call it CallForwarded(string type)
>>
>> where type is:
>> "conditional" or "unconditional"
> I'll combine them into one, that's fine.
>> And the same question applies here as well, do we want this on the call
>> object itself?  If so, then calling this signal Forwarded(string type)
>> would be better.  Perhaps adding another type for incoming calls that
>> are forwarded and removing the 'Forwarded' property would be a good idea
>> as well.  e.g. something like "incoming" type.
> I am thinking along the same line. Let's replace the "Forwarded"
> property with the "Forwarded" signal and add the "incoming" type
> you were suggesting to this signal.
> And we shall not care about the call index, since most probably
> is not going to be used anywhere, in this respect this cases is
> pretty similar to the call barring signaling case; signal will be
> emitted on the VoiceCallManager interface.

Sounds good to me.

Please resend V3 for final review.

Regards,
-Denis

[RFC] voicecall API changes (proposal v3)

[Andras Domokos]

[-- Attachment #1: Type: text/plain, Size: 3154 bytes --]

---
 doc/call-barring-api.txt     |   10 ----------
 doc/voicecall-api.txt        |   11 +++++++++++
 doc/voicecallmanager-api.txt |   26 ++++++++++++++++++++++++++
 3 files changed, 37 insertions(+), 10 deletions(-)

diff --git a/doc/call-barring-api.txt b/doc/call-barring-api.txt
index 41ae4b1..1534494 100644
--- a/doc/call-barring-api.txt
+++ b/doc/call-barring-api.txt
@@ -37,16 +37,6 @@ Signals		PropertyChanged(string property, variant value)
 			Signal is emitted whenever a property has changed.
 			The new value is passed as the signal argument.
 
-		IncomingBarringInEffect()
-
-			Signal is emitted when a call is made and an
-			incoming call barring supplementary service is in use.
-
-		OutgoingBarringInEffect()
-
-			Signal is emitted when a call is made and an
-			outgoing call barring supplementary service is in use.
-
 Properties	string VoiceIncoming [readwrite]
 
 			Contains the value of the barrings for the incoming
diff --git a/doc/voicecall-api.txt b/doc/voicecall-api.txt
index 047b8cb..6a72386 100644
--- a/doc/voicecall-api.txt
+++ b/doc/voicecall-api.txt
@@ -145,3 +145,14 @@ Properties	string LineIdentification [readonly]
 
 			Contains the indication if the voice call is an
 			emergency call or not.
+
+		boolean RemoteHeld
+
+			Contains the indication whether the voice call is put on
+			hold by the remote party or not.
+
+		boolean RemoteMultiparty
+
+			Contains the indication whether the voice call is joined
+			in a multiparty call by the remote party or not.
+
diff --git a/doc/voicecallmanager-api.txt b/doc/voicecallmanager-api.txt
index 5415345..1d49a42 100644
--- a/doc/voicecallmanager-api.txt
+++ b/doc/voicecallmanager-api.txt
@@ -144,6 +144,32 @@ Signals		CallAdded(object path, dict properties)
 			Signal is emitted whenever a property has changed.
 			The new value is passed as the signal argument.
 
+		BarringActive(string type)
+
+			Signal emitted when an outgoing voice call is made and
+			the call has been barred by the network due to the
+			remote party's "Call Barring" Supplementary Services
+			settings for incoming calls. In this case the type
+			parameter in the signal set to "remote".
+			The signal is also emitted when an outgoing voice call
+			is made and the call has been barred by the network due
+			to the local "Call Barring" Supplementary Services
+			settings for outgoing calls. In this case the type
+			parameter in the signal is set to "local".
+
+		CallForwarded(string type)
+
+			Signal emitted when an outgoing voice call is made and
+			the call has been redirected to another number due to
+			the remote party's "Call Forwarding" Supplementary
+			Services settings. In this case the type parameter in
+			the signal is set to "outgoing".
+			The signal is also emitted when the incoming voice call
+			is a redirected call due to a call forwarding operation.
+			In this case the type parameter in the signal is set to
+			"incoming".
+
+
 Properties	array{string} EmergencyNumbers [readonly]
 
 			Contains the list of emergency numbers recognized
-- 
1.7.0.4

Re: [RFC] voicecall API changes (proposal v3)

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]

Hi Andras,

> +		CallForwarded(string type)
> +
> +			Signal emitted when an outgoing voice call is made and
> +			the call has been redirected to another number due to
> +			the remote party's "Call Forwarding" Supplementary
> +			Services settings. In this case the type parameter in
> +			the signal is set to "outgoing".

You do not want to distinguish between conditional / unconditional?
Just checking here, either one is fine with me.

> +			The signal is also emitted when the incoming voice call
> +			is a redirected call due to a call forwarding operation.
> +			In this case the type parameter in the signal is set to
> +			"incoming".
> +
> +
>  Properties	array{string} EmergencyNumbers [readonly]
>  
>  			Contains the list of emergency numbers recognized

The proposal looks good to me.  I'd apply it, however git am complains:

Applying: voicecall API changes (proposal v3)
/home/denkenz/ofono-master/.git/rebase-apply/patch:32: new blank line at
EOF.
+
fatal: 1 line adds whitespace errors.

Regards,
-Denis

Re: [RFC] voicecall API changes (proposal v3)

[Andras Domokos]

[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]

Hi Denis,

On 02/07/2011 06:38 PM, ext Denis Kenzior wrote:
> Hi Andras,
>
>> +		CallForwarded(string type)
>> +
>> +			Signal emitted when an outgoing voice call is made and
>> +			the call has been redirected to another number due to
>> +			the remote party's "Call Forwarding" Supplementary
>> +			Services settings. In this case the type parameter in
>> +			the signal is set to "outgoing".
> You do not want to distinguish between conditional / unconditional?
> Just checking here, either one is fine with me.
In the end I made a simplification and I merged the conditional and
unconditional cases.
>> +			The signal is also emitted when the incoming voice call
>> +			is a redirected call due to a call forwarding operation.
>> +			In this case the type parameter in the signal is set to
>> +			"incoming".
>> +
>> +
>>   Properties	array{string} EmergencyNumbers [readonly]
>>
>>   			Contains the list of emergency numbers recognized
> The proposal looks good to me.  I'd apply it, however git am complains:
>
> Applying: voicecall API changes (proposal v3)
> /home/denkenz/ofono-master/.git/rebase-apply/patch:32: new blank line at
> EOF.
> +
> fatal: 1 line adds whitespace errors.
My mistake, there is an extra empty line there, I will redo the patch.
> Regards,
> -Denis
Regards,
Andras

[RFC] voicecall API changes (proposal v3)

[Andras Domokos]

[-- Attachment #1: Type: text/plain, Size: 3150 bytes --]

---
 doc/call-barring-api.txt     |   10 ----------
 doc/voicecall-api.txt        |   11 +++++++++++
 doc/voicecallmanager-api.txt |   25 +++++++++++++++++++++++++
 3 files changed, 36 insertions(+), 10 deletions(-)

diff --git a/doc/call-barring-api.txt b/doc/call-barring-api.txt
index 41ae4b1..1534494 100644
--- a/doc/call-barring-api.txt
+++ b/doc/call-barring-api.txt
@@ -37,16 +37,6 @@ Signals		PropertyChanged(string property, variant value)
 			Signal is emitted whenever a property has changed.
 			The new value is passed as the signal argument.
 
-		IncomingBarringInEffect()
-
-			Signal is emitted when a call is made and an
-			incoming call barring supplementary service is in use.
-
-		OutgoingBarringInEffect()
-
-			Signal is emitted when a call is made and an
-			outgoing call barring supplementary service is in use.
-
 Properties	string VoiceIncoming [readwrite]
 
 			Contains the value of the barrings for the incoming
diff --git a/doc/voicecall-api.txt b/doc/voicecall-api.txt
index 047b8cb..6a72386 100644
--- a/doc/voicecall-api.txt
+++ b/doc/voicecall-api.txt
@@ -145,3 +145,14 @@ Properties	string LineIdentification [readonly]
 
 			Contains the indication if the voice call is an
 			emergency call or not.
+
+		boolean RemoteHeld
+
+			Contains the indication whether the voice call is put on
+			hold by the remote party or not.
+
+		boolean RemoteMultiparty
+
+			Contains the indication whether the voice call is joined
+			in a multiparty call by the remote party or not.
+
diff --git a/doc/voicecallmanager-api.txt b/doc/voicecallmanager-api.txt
index 5415345..06e7b4e 100644
--- a/doc/voicecallmanager-api.txt
+++ b/doc/voicecallmanager-api.txt
@@ -144,6 +144,31 @@ Signals		CallAdded(object path, dict properties)
 			Signal is emitted whenever a property has changed.
 			The new value is passed as the signal argument.
 
+		BarringActive(string type)
+
+			Signal emitted when an outgoing voice call is made and
+			the call has been barred by the network due to the
+			remote party's "Call Barring" Supplementary Services
+			settings for incoming calls. In this case the type
+			parameter in the signal set to "remote".
+			The signal is also emitted when an outgoing voice call
+			is made and the call has been barred by the network due
+			to the local "Call Barring" Supplementary Services
+			settings for outgoing calls. In this case the type
+			parameter in the signal is set to "local".
+
+		CallForwarded(string type)
+
+			Signal emitted when an outgoing voice call is made and
+			the call has been redirected to another number due to
+			the remote party's "Call Forwarding" Supplementary
+			Services settings. In this case the type parameter in
+			the signal is set to "outgoing".
+			The signal is also emitted when the incoming voice call
+			is a redirected call due to a call forwarding operation.
+			In this case the type parameter in the signal is set to
+			"incoming".
+
 Properties	array{string} EmergencyNumbers [readonly]
 
 			Contains the list of emergency numbers recognized
-- 
1.7.0.4

Re: [RFC] voicecall API changes (proposal v3)

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

Hi Andras,

On 02/07/2011 11:09 AM, Andras Domokos wrote:
> ---
>  doc/call-barring-api.txt     |   10 ----------
>  doc/voicecall-api.txt        |   11 +++++++++++
>  doc/voicecallmanager-api.txt |   25 +++++++++++++++++++++++++
>  3 files changed, 36 insertions(+), 10 deletions(-)
> 

Your patch still didn't apply due to whitespace at EOF, but I was nice
and enough and fixed it for you.  Patch has been applied.  I went ahead
and marked the properties / signals as experimental until an
implementation arrives.

Regards,
-Denis

Re: [RFC] voicecall API changes (proposal v3)

[Andras Domokos]

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]

Hi Denis,

On 02/07/2011 09:39 PM, ext Denis Kenzior wrote:
> Hi Andras,
>
> On 02/07/2011 11:09 AM, Andras Domokos wrote:
>> ---
>>   doc/call-barring-api.txt     |   10 ----------
>>   doc/voicecall-api.txt        |   11 +++++++++++
>>   doc/voicecallmanager-api.txt |   25 +++++++++++++++++++++++++
>>   3 files changed, 36 insertions(+), 10 deletions(-)
>>
> Your patch still didn't apply due to whitespace at EOF, but I was nice
> and enough and fixed it for you.  Patch has been applied.  I went ahead
> and marked the properties / signals as experimental until an
> implementation arrives.
Thanks a lot!
I move on to preparing the implementation patches.
> Regards,
> -Denis
Regards,
Andras