From: Jens Axboe <jaxboe@fusionio.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Tejun Heo <tj@kernel.org>, "tytso@mit.edu" <tytso@mit.edu>,
"djwong@us.ibm.com" <djwong@us.ibm.com>,
"shli@kernel.org" <shli@kernel.org>,
"neilb@suse.de" <neilb@suse.de>,
"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
"jack@suse.cz" <jack@suse.cz>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kmannth@us.ibm.com" <kmannth@us.ibm.com>,
"cmm@us.ibm.com" <cmm@us.ibm.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"rwheeler@redhat.com" <rwheeler@redhat.com>,
"hch@lst.de" <hch@lst.de>, "josef@redhat.com" <josef@redhat.com>,
"jmoyer@redhat.com" <jmoyer@redhat.com>,
"vgoyal@redhat.com" <vgoyal@redhat.com>
Subject: Re: [PATCH v3 1/2] block: skip elevator data initialization for flush requests
Date: Thu, 3 Feb 2011 14:24:42 +0100 [thread overview]
Message-ID: <4D4AAC9A.4050407@fusionio.com> (raw)
In-Reply-To: <20110202225549.GA28109@redhat.com>
On 2011-02-02 23:55, Mike Snitzer wrote:
> Set REQ_SORTED, in the @rw_flags passed to the request allocator, for
> any request that may be put on IO scheduler. Skip elevator data
> initialization during request allocation if REQ_SORTED is not set.
>
> REQ_SORTED is not set for flush requests because they are never put on
> the IO scheduler.
That looks very wrong. REQ_SORTED gets set _when_ the request is sorted
into the IO scheduler. This is gross misuse, a bad hack.
--
Jens Axboe
next prev parent reply other threads:[~2011-02-03 13:24 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 15:59 [PATCHSET] block: reimplement FLUSH/FUA to support merge Tejun Heo
2011-01-21 15:59 ` Tejun Heo
2011-01-21 15:59 ` [PATCH 1/3] block: add REQ_FLUSH_SEQ Tejun Heo
2011-01-21 15:59 ` Tejun Heo
2011-01-21 15:59 ` [PATCH 2/3] block: improve flush bio completion Tejun Heo
2011-01-21 15:59 ` Tejun Heo
2011-01-21 15:59 ` [PATCH 3/3] block: reimplement FLUSH/FUA to support merge Tejun Heo
2011-01-21 18:56 ` Vivek Goyal
2011-01-21 19:19 ` Vivek Goyal
2011-01-23 10:25 ` Tejun Heo
2011-01-23 10:29 ` Tejun Heo
2011-01-24 20:31 ` Darrick J. Wong
2011-01-25 10:21 ` Tejun Heo
2011-01-25 11:39 ` Jens Axboe
2011-03-23 23:37 ` Darrick J. Wong
2011-01-25 22:56 ` Darrick J. Wong
2011-01-22 0:49 ` Mike Snitzer
2011-01-23 10:31 ` Tejun Heo
2011-01-25 20:46 ` Vivek Goyal
2011-01-25 21:04 ` Mike Snitzer
2011-01-23 10:48 ` [PATCH UPDATED " Tejun Heo
2011-01-23 10:48 ` Tejun Heo
2011-01-25 20:41 ` [KNOWN BUGGY RFC PATCH 4/3] block: skip elevator initialization for flush requests Mike Snitzer
2011-01-25 20:41 ` Mike Snitzer
2011-01-25 21:55 ` Mike Snitzer
2011-01-26 5:27 ` [RFC PATCH 4/3] block: skip elevator initialization for flush requests -- was never BUGGY relative to upstream Mike Snitzer
2011-01-26 10:03 ` [KNOWN BUGGY RFC PATCH 4/3] block: skip elevator initialization for flush requests Tejun Heo
2011-01-26 10:05 ` Tejun Heo
2011-02-01 17:38 ` [RFC " Mike Snitzer
2011-02-01 18:52 ` Tejun Heo
2011-02-01 22:46 ` [PATCH v2 1/2] " Mike Snitzer
2011-02-02 21:51 ` Vivek Goyal
2011-02-02 22:06 ` Mike Snitzer
2011-02-02 22:55 ` [PATCH v3 1/2] block: skip elevator data " Mike Snitzer
2011-02-03 9:28 ` Tejun Heo
2011-02-03 14:48 ` [PATCH v4 " Mike Snitzer
2011-02-03 13:24 ` Jens Axboe [this message]
2011-02-03 13:38 ` [PATCH v3 " Tejun Heo
2011-02-04 15:04 ` Vivek Goyal
2011-02-04 15:08 ` Tejun Heo
2011-02-04 16:58 ` [PATCH v5 " Mike Snitzer
2011-02-03 14:54 ` [PATCH v3 " Mike Snitzer
2011-02-01 22:46 ` [PATCH v2 2/2] block: share request flush fields with elevator_private Mike Snitzer
2011-02-01 22:46 ` Mike Snitzer
2011-02-02 21:52 ` Vivek Goyal
2011-02-03 9:24 ` Tejun Heo
2011-02-11 10:08 ` Jens Axboe
2011-01-21 15:59 ` [PATCH 3/3] block: reimplement FLUSH/FUA to support merge Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4AAC9A.4050407@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=adilger.kernel@dilger.ca \
--cc=cmm@us.ibm.com \
--cc=djwong@us.ibm.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=josef@redhat.com \
--cc=kmannth@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=rwheeler@redhat.com \
--cc=shli@kernel.org \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
--cc=tytso@mit.edu \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.