All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] ASoC: neo1973_wm8753: Remove scenario management code.
Date: Mon, 07 Feb 2011 18:01:41 +0100	[thread overview]
Message-ID: <4D502575.8080501@metafoo.de> (raw)
In-Reply-To: <20110207114255.GB10564@opensource.wolfsonmicro.com>

On 02/07/2011 12:42 PM, Mark Brown wrote:
> On Mon, Feb 07, 2011 at 12:04:17AM +0100, Lars-Peter Clausen wrote:
> 
>> +	snd_soc_dapm_disable_pin(codec, "Audio Out");
>> +	snd_soc_dapm_disable_pin(codec, "GSM Line Out");
>> +	snd_soc_dapm_disable_pin(codec, "GSM Line In");
>> +	snd_soc_dapm_disable_pin(codec, "Headset Mic");
>> +	snd_soc_dapm_disable_pin(codec, "Call Mic");
> 
> This will mean that it's impossible to enable most (if not all) of the
> audio paths in the system which probably isn't what you want.

I've seem to have overlooked to add DAPM_SWITCH_PIN controls for these pins, since it
has been done implicitly in the patch merging the gta01 and gta02 driver.

I'll resend a updated version.

- Lars

WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/7] ASoC: neo1973_wm8753: Remove scenario management code.
Date: Mon, 07 Feb 2011 18:01:41 +0100	[thread overview]
Message-ID: <4D502575.8080501@metafoo.de> (raw)
In-Reply-To: <20110207114255.GB10564@opensource.wolfsonmicro.com>

On 02/07/2011 12:42 PM, Mark Brown wrote:
> On Mon, Feb 07, 2011 at 12:04:17AM +0100, Lars-Peter Clausen wrote:
> 
>> +	snd_soc_dapm_disable_pin(codec, "Audio Out");
>> +	snd_soc_dapm_disable_pin(codec, "GSM Line Out");
>> +	snd_soc_dapm_disable_pin(codec, "GSM Line In");
>> +	snd_soc_dapm_disable_pin(codec, "Headset Mic");
>> +	snd_soc_dapm_disable_pin(codec, "Call Mic");
> 
> This will mean that it's impossible to enable most (if not all) of the
> audio paths in the system which probably isn't what you want.

I've seem to have overlooked to add DAPM_SWITCH_PIN controls for these pins, since it
has been done implicitly in the patch merging the gta01 and gta02 driver.

I'll resend a updated version.

- Lars

  reply	other threads:[~2011-02-07 17:00 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-06 23:04 [PATCH 1/7] ASoC: neo1973_wm8753: Remove scenario management code Lars-Peter Clausen
2011-02-06 23:04 ` [PATCH 2/7] ASoC: neo1973_wm8753: Move lm4857 specefic code to its own module Lars-Peter Clausen
2011-02-06 23:04   ` Lars-Peter Clausen
2011-02-07 11:50   ` Mark Brown
2011-02-07 11:50     ` Mark Brown
2011-02-06 23:04 ` [PATCH 3/7] ASoC: codecs: lm4857: Use dev_pm_ops Lars-Peter Clausen
2011-02-06 23:04   ` Lars-Peter Clausen
2011-02-06 23:04 ` [PATCH 4/7] ASoC: neo1973_gta02_wm8753: Remove lm4853_{set,get}_state Lars-Peter Clausen
2011-02-06 23:04 ` [PATCH 5/7] ASoC: Samsung: neo1973: Use gpio_request_array to request gpios Lars-Peter Clausen
2011-02-06 23:04   ` Lars-Peter Clausen
2011-02-06 23:04 ` [PATCH 6/7] ASoC: Samsung: neo1973_gta02: Fix bluetooth DAI registration Lars-Peter Clausen
2011-02-07 11:59   ` Mark Brown
2011-02-07 11:59     ` Mark Brown
2011-02-07 16:53     ` Lars-Peter Clausen
2011-02-07 17:02       ` Mark Brown
2011-02-07 17:37         ` Lars-Peter Clausen
2011-02-07 17:37           ` Lars-Peter Clausen
2011-02-07 17:49           ` Mark Brown
2011-02-07 17:49             ` Mark Brown
2011-02-07 18:09             ` Lars-Peter Clausen
2011-02-07 18:09               ` Lars-Peter Clausen
2011-02-07 18:17               ` Mark Brown
2011-02-07 18:17                 ` Mark Brown
2011-02-07 22:55                 ` Adding bluetooth PCM interface support to ASoC (Was: Re: [PATCH 6/7] ASoC: Samsung: neo1973_gta02: Fix bluetooth DAI registration) Lars-Peter Clausen
2011-02-07 22:55                   ` Lars-Peter Clausen
2011-02-08 13:08                   ` Mark Brown
2011-02-08 13:08                     ` Mark Brown
2011-02-06 23:04 ` [PATCH 7/7] ASoC: Samsung: Merge neo1937 and neo1973_gta02 sound board driver Lars-Peter Clausen
2011-02-07  2:25 ` [alsa-devel] [PATCH 1/7] ASoC: neo1973_wm8753: Remove scenario management code Jassi Brar
2011-02-07 11:42 ` Mark Brown
2011-02-07 11:42   ` Mark Brown
2011-02-07 17:01   ` Lars-Peter Clausen [this message]
2011-02-07 17:01     ` Lars-Peter Clausen
2011-03-07  7:04 Lars-Peter Clausen
2011-03-07 11:04 ` Liam Girdwood
2011-03-07 11:04   ` Liam Girdwood
2011-03-07 12:25   ` Mark Brown
2011-03-07 12:25     ` Mark Brown
2011-04-12 20:02     ` Lars-Peter Clausen
2011-04-12 20:20       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D502575.8080501@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.