All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Michael Goldish <mgoldish@redhat.com>
Cc: autotest@test.kernel.org, Uri Lublin <ulublin@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	kvm@vger.kernel.org
Subject: Re: [Autotest] [KVM-AUTOTEST PATCH] KVM test: refactor kvm_config.py
Date: Thu, 10 Feb 2011 13:03:53 +0200	[thread overview]
Message-ID: <4D53C619.9080907@redhat.com> (raw)
In-Reply-To: <4D53C4A4.6070700@redhat.com>

On 02/10/2011 12:57 PM, Michael Goldish wrote:
> >
> >  I can't easily think of a case where this might cause confusion.  The
> >  purpose of this is to allow people to write:
> >
> >  only qcow2..raw..rtl8139
> >
> >  without having to remember the order in which those were defined in
> >  tests_base.cfg.
>
> Sorry, I meant something like
>
> only qcow2..hugepages..rtl8139
>
> Obviously qcow2 and raw can't coexist.

The config files describe a cartesian product, in which order matters.

[A B C] x [1 2] generates [A1 A2 B1 B2 C1 C2]; no confusion here if you 
specify A..1

however

[A B C] x [A B] generates [AA AB BA BB CA CB]; A..B is ambiguous

we might require that keywords be unique.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2011-02-10 11:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-09  1:50 [KVM-AUTOTEST PATCH] KVM test: refactor kvm_config.py Michael Goldish
2011-02-09  2:56 ` Cleber Rosa
2011-02-09  9:28 ` Avi Kivity
2011-02-09 10:07   ` Michael Goldish
2011-02-09 10:19     ` Avi Kivity
2011-02-10  1:18   ` Amos Kong
2011-02-10 12:42     ` Lucas Meneghel Rodrigues
2011-02-09 16:06 ` Ryan Harper
2011-02-09 16:21   ` Eduardo Habkost
2011-02-09 23:31     ` [Autotest] " Ryan Harper
2011-02-10  9:14       ` Michael Goldish
2011-02-10 10:34         ` [Autotest] " Avi Kivity
2011-02-10 10:46           ` Michael Goldish
2011-02-10 10:47             ` Avi Kivity
2011-02-10 10:55               ` Michael Goldish
2011-02-10 10:57                 ` [Autotest] " Michael Goldish
2011-02-10 11:03                   ` Avi Kivity [this message]
2011-02-10 11:46                     ` Michael Goldish
2011-02-10 13:45                     ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D53C619.9080907@redhat.com \
    --to=avi@redhat.com \
    --cc=autotest@test.kernel.org \
    --cc=ehabkost@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mgoldish@redhat.com \
    --cc=ulublin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.