All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 03/11] atmel-mci: use dmaengine helper functions
@ 2011-02-10 15:08 Linus Walleij
  2011-02-10 15:18 ` Nicolas Ferre
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2011-02-10 15:08 UTC (permalink / raw)
  To: linux-mmc, Chris Ball; +Cc: Dan Williams, Nicolas Ferre, Linus Walleij

Use the new dmaengine helpers to make the code more readable.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/mmc/host/atmel-mci.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
index df5a135..80bc9a5 100644
--- a/drivers/mmc/host/atmel-mci.c
+++ b/drivers/mmc/host/atmel-mci.c
@@ -589,7 +589,7 @@ static void atmci_stop_dma(struct atmel_mci *host)
 	struct dma_chan *chan = host->data_chan;
 
 	if (chan) {
-	  chan->device->device_control(chan, DMA_TERMINATE_ALL, 0);
+		dmaengine_terminate_all(chan);
 		atmci_dma_cleanup(host);
 	} else {
 		/* Data transfer was stopped by the interrupt handler */
@@ -710,8 +710,8 @@ static void atmci_submit_data(struct atmel_mci *host)
 	struct dma_async_tx_descriptor	*desc = host->dma.data_desc;
 
 	if (chan) {
-		desc->tx_submit(desc);
-		chan->device->device_issue_pending(chan);
+		dmaengine_submit(desc);
+		dma_async_issue_pending(chan);
 	}
 }
 
-- 
1.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 03/11] atmel-mci: use dmaengine helper functions
  2011-02-10 15:08 [PATCH 03/11] atmel-mci: use dmaengine helper functions Linus Walleij
@ 2011-02-10 15:18 ` Nicolas Ferre
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Ferre @ 2011-02-10 15:18 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-mmc, Chris Ball, Dan Williams

Le 10/02/2011 16:08, Linus Walleij :
> Use the new dmaengine helpers to make the code more readable.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> ---

Thanks for this update Linus! (That was on my todo list ;-))

Best regards,

>  drivers/mmc/host/atmel-mci.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index df5a135..80bc9a5 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -589,7 +589,7 @@ static void atmci_stop_dma(struct atmel_mci *host)
>  	struct dma_chan *chan = host->data_chan;
>  
>  	if (chan) {
> -	  chan->device->device_control(chan, DMA_TERMINATE_ALL, 0);
> +		dmaengine_terminate_all(chan);
>  		atmci_dma_cleanup(host);
>  	} else {
>  		/* Data transfer was stopped by the interrupt handler */
> @@ -710,8 +710,8 @@ static void atmci_submit_data(struct atmel_mci *host)
>  	struct dma_async_tx_descriptor	*desc = host->dma.data_desc;
>  
>  	if (chan) {
> -		desc->tx_submit(desc);
> -		chan->device->device_issue_pending(chan);
> +		dmaengine_submit(desc);
> +		dma_async_issue_pending(chan);
>  	}
>  }
>  


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-02-10 15:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-10 15:08 [PATCH 03/11] atmel-mci: use dmaengine helper functions Linus Walleij
2011-02-10 15:18 ` Nicolas Ferre

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.