* [PATCH] Documentation: Include cpupool example in install
@ 2011-02-14 15:59 George Dunlap
2011-02-15 0:28 ` André Przywara
2011-02-15 19:39 ` Ian Jackson
0 siblings, 2 replies; 4+ messages in thread
From: George Dunlap @ 2011-02-14 15:59 UTC (permalink / raw)
To: xen-devel; +Cc: george.dunlap
xl cpupool-create at the moment requires a config file. Make
sure to include the example config file in the install.
Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
diff -r 4ea36cce2519 -r e66f078e198d tools/examples/Makefile
--- a/tools/examples/Makefile Mon Feb 14 09:10:22 2011 +0000
+++ b/tools/examples/Makefile Mon Feb 14 15:59:29 2011 +0000
@@ -22,6 +22,7 @@
XEN_CONFIGS += xend-pci-quirks.sxp
XEN_CONFIGS += xend-pci-permissive.sxp
XEN_CONFIGS += xl.conf
+XEN_CONFIGS += cpupool
.PHONY: all
all:
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: Include cpupool example in install
2011-02-14 15:59 [PATCH] Documentation: Include cpupool example in install George Dunlap
@ 2011-02-15 0:28 ` André Przywara
2011-02-15 15:14 ` Ian Jackson
2011-02-15 19:39 ` Ian Jackson
1 sibling, 1 reply; 4+ messages in thread
From: André Przywara @ 2011-02-15 0:28 UTC (permalink / raw)
To: George Dunlap; +Cc: xen-devel
Am 14.02.2011 16:59, schrieb George Dunlap:
> xl cpupool-create at the moment requires a config file. Make
> sure to include the example config file in the install.
Good point. Btw: When I did some experiments with cpupools, I couldn't
create the cpupool config file on the fly and pipe it to the xl
cpupool-create command, as it:
a) explicitly checks for a regular file to be named (and doesn't handle
'-' or can cope with /dev/stdin)
b) stats the file to learn the file size (requiring this to be a
seekable file, that's why check a)
These are restrictions which apply to guest config files, too, as they
use the same functionality.
Is this just a limit in the implementation or is the requirement for a
regular on-disk file there for a reason?
I could easily create a patch to do away with these restrictions (after
the release), are there any arguments against this?
Regards,
Andre.
--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: Include cpupool example in install
2011-02-15 0:28 ` André Przywara
@ 2011-02-15 15:14 ` Ian Jackson
0 siblings, 0 replies; 4+ messages in thread
From: Ian Jackson @ 2011-02-15 15:14 UTC (permalink / raw)
To: André Przywara; +Cc: George Dunlap, xen-devel
André Przywara writes ("Re: [Xen-devel] [PATCH] Documentation: Include cpupool example in install"):
> Is this just a limit in the implementation or is the requirement for a
> regular on-disk file there for a reason?
It's a limit in the implementation. We try to read the config file
into a char array in memory, and that's most easily done by
stat/malloc/fread.
For a domain, the config file is used both immediately when creating
the domain (being parsed by being fed to the flex bytearray scanner
entrypoint) but also stored for use when the domain is migrated/saved.
> I could easily create a patch to do away with these restrictions (after
> the release), are there any arguments against this?
No, that would be fine. The right answer is probably somewhere around
libxl_read_file_contents. Perhaps we need libxl_read_fd_contents
which reallocs.
Ian.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: Include cpupool example in install
2011-02-14 15:59 [PATCH] Documentation: Include cpupool example in install George Dunlap
2011-02-15 0:28 ` André Przywara
@ 2011-02-15 19:39 ` Ian Jackson
1 sibling, 0 replies; 4+ messages in thread
From: Ian Jackson @ 2011-02-15 19:39 UTC (permalink / raw)
To: George Dunlap; +Cc: xen-devel
George Dunlap writes ("[Xen-devel] [PATCH] Documentation: Include cpupool example in install"):
> xl cpupool-create at the moment requires a config file. Make
> sure to include the example config file in the install.
>
> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
Applied, thanks.
Ian.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-15 19:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-14 15:59 [PATCH] Documentation: Include cpupool example in install George Dunlap
2011-02-15 0:28 ` André Przywara
2011-02-15 15:14 ` Ian Jackson
2011-02-15 19:39 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.