All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Mallon <ryan@bluewatersys.com>
To: Charles Manning <cdhmanning@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	akpm@linux-foundation.org
Subject: Re: [PATCH 09/10] Add yaffs2 file system: Linux glue code
Date: Fri, 18 Feb 2011 11:24:56 +1300	[thread overview]
Message-ID: <4D5DA038.5070505@bluewatersys.com> (raw)
In-Reply-To: <1297221968-6747-10-git-send-email-cdhmanning@gmail.com>

On 02/09/2011 04:26 PM, Charles Manning wrote:
> Signed-off-by: Charles Manning <cdhmanning@gmail.com>
> ---

<snip>

> +/*
> + * yaffs_search_end() disposes of a search context and cleans up.
> + */
> +static void yaffs_search_end(struct yaffs_search_context *sc)
> +{
> +	if (sc) {

This test, and the similar one in yaffs_search_advance, are not needed.
There is no way that sc can be passed as NULL here. Even if that could
happen you probably want to oops rather than silently carrying on.

I think there are similar issues in other functions throughout the yaffs
code where you are testing if various pointers are NULL and returning
silently if they are. All of these cases should be fixed to remove the
extraneous code.

~Ryan

-- 
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon         		5 Amuri Park, 404 Barbadoes St
ryan@bluewatersys.com         	PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com	New Zealand
Phone: +64 3 3779127		Freecall: Australia 1800 148 751
Fax:   +64 3 3779135			  USA 1800 261 2934

  parent reply	other threads:[~2011-02-17 22:24 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-09  3:25 [PATCH 0/10] Add yaffs2 file system: Fifth patchset Charles Manning
2011-02-09  3:25 ` [PATCH 01/10] Add yaffs2 file system: allocators, bitmap and block handling Charles Manning
2011-02-09  3:26 ` [PATCH 02/10] Add yaffs2 file system: attrib and xattrib handling Charles Manning
2011-02-09 22:33   ` Ryan Mallon
2011-02-09  3:26 ` [PATCH 03/10] Add yaffs2 file system: checkpoint streaming Charles Manning
2011-02-10 22:27   ` Jesper Juhl
2011-02-10 22:44     ` Ryan Mallon
2011-02-10 22:50       ` Charles Manning
2011-02-09  3:26 ` [PATCH 04/10] Add yaffs2 file system: flash interface and ecc handling Charles Manning
2011-02-09  3:26 ` [PATCH 05/10] Add yaffs2 file system: tags handling Charles Manning
2011-02-09  3:26 ` [PATCH 06/10] Add yaffs2 file system: tracing and verification handling Charles Manning
2011-02-11 23:01   ` Ryan Mallon
2011-02-09  3:26 ` [PATCH 07/10] Add yaffs2 file system: yaffs1 and yaffs2 mode handling Charles Manning
2011-02-09  3:26 ` [PATCH 08/10] Add yaffs2 file system: core guts code Charles Manning
2011-02-10  2:27   ` Ryan Mallon
2011-02-09  3:26 ` [PATCH 09/10] Add yaffs2 file system: Linux glue code Charles Manning
2011-02-10 22:07   ` Ryan Mallon
2011-02-10 22:47     ` Charles Manning
2011-02-17 22:24   ` Ryan Mallon [this message]
2011-02-09  3:26 ` [PATCH 10/10] Add yaffs2 file system: hok in to Linux tree Charles Manning
2011-02-09  4:52 ` [PATCH 0/10] Add yaffs2 file system: Fifth patchset Christoph Hellwig
2011-02-09 18:22   ` Charles Manning
2011-02-16  8:04     ` Christoph Hellwig
2011-02-16 22:12       ` Charles Manning
2011-02-17  1:48         ` Mark Brown
2011-02-17  2:31           ` Charles Manning
2011-02-17  2:52             ` Ryan Mallon
2011-02-17  3:49               ` Charles Manning
2011-02-17 23:41                 ` Greg KH
2011-02-18  0:01                   ` Mark Brown
2011-02-18  0:33                     ` Greg KH
2011-02-18  0:43                       ` Mark Brown
2011-02-18  0:55                         ` Ryan Mallon
2011-02-18  0:58                           ` Greg KH
2011-02-20 17:25                             ` Charles Manning
2011-02-20 20:07                               ` Greg KH
2011-02-20 20:52                                 ` Ryan Mallon
2011-02-20 22:29                                   ` Greg KH
2011-02-20 22:57                                     ` Ryan Mallon
2011-02-18  1:08                           ` Mark Brown
2011-02-17  3:49             ` Mark Brown
2011-02-17  4:22               ` Charles Manning
2011-02-17  6:08                 ` Mark Brown
2011-02-19 17:45         ` Pavel Machek
2011-08-17 12:12 ` Linus Walleij
  -- strict thread matches above, loose matches on Subject: below --
2011-01-14  3:05 [PATCH 0/10] Add yaffs2 file system: Fourth patchset Charles Manning
2011-01-14  3:06 ` [PATCH 09/10] Add yaffs2 file system: Linux glue code Charles Manning
2011-01-20 20:14   ` Jesper Juhl
2011-01-20 21:26   ` Ryan Mallon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5DA038.5070505@bluewatersys.com \
    --to=ryan@bluewatersys.com \
    --cc=akpm@linux-foundation.org \
    --cc=cdhmanning@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.