[lm-sensors] [PATCH] lm85: extend to support emc6d103 chips

[lm-sensors] [PATCH] lm85: extend to support emc6d103 chips

[Jan Beulich]

The interface is identical emc6d102, so all that needs to be added are
some definitions and their uses.

Registers apparently missing in emc6d103:A2 compared to emc6d103:A0,
emc6d103:A1, and emc6d102 (according to the data sheets), but used
unconditionally in the driver: 62[5:7], 6D[0:7], and 6E[0:7]. For that
reason, A2 stepping chips don't get enabled for the time being.

Signed-off-by: Jan Beulich <jbeulich@novell.com>

---
 drivers/hwmon/Kconfig |    2 +-
 drivers/hwmon/lm85.c  |   14 ++++++++++++--
 2 files changed, 13 insertions(+), 3 deletions(-)

--- 2.6.38-rc5/drivers/hwmon/Kconfig
+++ 2.6.38-rc5-lm85-emc6d103/drivers/hwmon/Kconfig
@@ -574,7 +574,7 @@ config SENSORS_LM85
 	help
 	  If you say yes here you get support for National Semiconductor LM85
 	  sensor chips and clones: ADM1027, ADT7463, ADT7468, EMC6D100,
-	  EMC6D101 and EMC6D102.
+	  EMC6D101, EMC6D102, and EMC6D103.
 
 	  This driver can also be built as a module.  If so, the module
 	  will be called lm85.
--- 2.6.38-rc5/drivers/hwmon/lm85.c
+++ 2.6.38-rc5-lm85-emc6d103/drivers/hwmon/lm85.c
@@ -41,7 +41,7 @@ static const unsigned short normal_i2c[]
 enum chips {
 	any_chip, lm85b, lm85c,
 	adm1027, adt7463, adt7468,
-	emc6d100, emc6d102
+	emc6d100, emc6d102, emc6d103
 };
 
 /* The LM85 registers */
@@ -90,6 +90,9 @@ enum chips {
 #define	LM85_VERSTEP_EMC6D100_A0        0x60
 #define	LM85_VERSTEP_EMC6D100_A1        0x61
 #define	LM85_VERSTEP_EMC6D102		0x65
+#define	LM85_VERSTEP_EMC6D103_A0	0x68
+#define	LM85_VERSTEP_EMC6D103_A1	0x69
+#define	LM85_VERSTEP_EMC6D103_A2	0x6A
 
 #define	LM85_REG_CONFIG			0x40
 
@@ -348,6 +351,7 @@ static const struct i2c_device_id lm85_i
 	{ "emc6d100", emc6d100 },
 	{ "emc6d101", emc6d100 },
 	{ "emc6d102", emc6d102 },
+	{ "emc6d103", emc6d103 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, lm85_id);
@@ -1250,6 +1254,11 @@ static int lm85_detect(struct i2c_client
 		case LM85_VERSTEP_EMC6D102:
 			type_name = "emc6d102";
 			break;
+		case LM85_VERSTEP_EMC6D103_A0:
+		case LM85_VERSTEP_EMC6D103_A1:
+		/* case LM85_VERSTEP_EMC6D103_A2: */
+			type_name = "emc6d103";
+			break;
 		}
 	} else {
 		dev_dbg(&adapter->dev,
@@ -1283,6 +1292,7 @@ static int lm85_probe(struct i2c_client 
 	case adt7468:
 	case emc6d100:
 	case emc6d102:
+	case emc6d103:
 		data->freq_map = adm1027_freq_map;
 		break;
 	default:
@@ -1468,7 +1478,7 @@ static struct lm85_data *lm85_update_dev
 			/* More alarm bits */
 			data->alarms |= lm85_read_value(client,
 						EMC6D100_REG_ALARM3) << 16;
-		} else if (data->type = emc6d102) {
+		} else if (data->type = emc6d102 || data->type = emc6d103) {
 			/* Have to read LSB bits after the MSB ones because
 			   the reading of the MSB bits has frozen the
 			   LSBs (backward from the ADM1027).




_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] lm85: extend to support emc6d103 chips

[Guenter Roeck]

Jan,

On Fri, Feb 18, 2011 at 02:56:23AM -0500, Jan Beulich wrote:
> The interface is identical emc6d102, so all that needs to be added are
> some definitions and their uses.
> 
> Registers apparently missing in emc6d103:A2 compared to emc6d103:A0,
> emc6d103:A1, and emc6d102 (according to the data sheets), but used
> unconditionally in the driver: 62[5:7], 6D[0:7], and 6E[0:7]. For that
> reason, A2 stepping chips don't get enabled for the time being.
> 
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
> 
> ---
>  drivers/hwmon/Kconfig |    2 +-
>  drivers/hwmon/lm85.c  |   14 ++++++++++++--
>  2 files changed, 13 insertions(+), 3 deletions(-)
> 
> --- 2.6.38-rc5/drivers/hwmon/Kconfig
> +++ 2.6.38-rc5-lm85-emc6d103/drivers/hwmon/Kconfig
> @@ -574,7 +574,7 @@ config SENSORS_LM85
>  	help
>  	  If you say yes here you get support for National Semiconductor LM85
>  	  sensor chips and clones: ADM1027, ADT7463, ADT7468, EMC6D100,
> -	  EMC6D101 and EMC6D102.
> +	  EMC6D101, EMC6D102, and EMC6D103.
>  
>  	  This driver can also be built as a module.  If so, the module
>  	  will be called lm85.
> --- 2.6.38-rc5/drivers/hwmon/lm85.c
> +++ 2.6.38-rc5-lm85-emc6d103/drivers/hwmon/lm85.c
> @@ -41,7 +41,7 @@ static const unsigned short normal_i2c[]
>  enum chips {
>  	any_chip, lm85b, lm85c,
>  	adm1027, adt7463, adt7468,
> -	emc6d100, emc6d102
> +	emc6d100, emc6d102, emc6d103
>  };
>  
>  /* The LM85 registers */
> @@ -90,6 +90,9 @@ enum chips {
>  #define	LM85_VERSTEP_EMC6D100_A0        0x60
>  #define	LM85_VERSTEP_EMC6D100_A1        0x61
>  #define	LM85_VERSTEP_EMC6D102		0x65
> +#define	LM85_VERSTEP_EMC6D103_A0	0x68
> +#define	LM85_VERSTEP_EMC6D103_A1	0x69
> +#define	LM85_VERSTEP_EMC6D103_A2	0x6A
>  
>  #define	LM85_REG_CONFIG			0x40
>  
> @@ -348,6 +351,7 @@ static const struct i2c_device_id lm85_i
>  	{ "emc6d100", emc6d100 },
>  	{ "emc6d101", emc6d100 },
>  	{ "emc6d102", emc6d102 },
> +	{ "emc6d103", emc6d103 },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, lm85_id);
> @@ -1250,6 +1254,11 @@ static int lm85_detect(struct i2c_client
>  		case LM85_VERSTEP_EMC6D102:
>  			type_name = "emc6d102";
>  			break;
> +		case LM85_VERSTEP_EMC6D103_A0:
> +		case LM85_VERSTEP_EMC6D103_A1:
> +		/* case LM85_VERSTEP_EMC6D103_A2: */

The comment from the commit log should be here as well.
Otherwise, people won't know why the line is commented out.

> +			type_name = "emc6d103";
> +			break;
>  		}
>  	} else {
>  		dev_dbg(&adapter->dev,
> @@ -1283,6 +1292,7 @@ static int lm85_probe(struct i2c_client 
>  	case adt7468:
>  	case emc6d100:
>  	case emc6d102:
> +	case emc6d103:
>  		data->freq_map = adm1027_freq_map;
>  		break;
>  	default:
> @@ -1468,7 +1478,7 @@ static struct lm85_data *lm85_update_dev
>  			/* More alarm bits */
>  			data->alarms |= lm85_read_value(client,
>  						EMC6D100_REG_ALARM3) << 16;
> -		} else if (data->type = emc6d102) {
> +		} else if (data->type = emc6d102 || data->type = emc6d103) {
>  			/* Have to read LSB bits after the MSB ones because
>  			   the reading of the MSB bits has frozen the
>  			   LSBs (backward from the ADM1027).
> 
> 
> 

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

[lm-sensors] [PATCH] lm85: extend to support emc6d103 chips

[Jan Beulich]

The interface is identical emc6d102, so all that needs to be added are
some definitions and their uses.

Registers apparently missing in emc6d103:A2 compared to emc6d103:A0,
emc6d103:A1, and emc6d102 (according to the data sheets), but used
unconditionally in the driver: 62[5:7], 6D[0:7], and 6E[0:7]. For that
reason, A2 stepping chips don't get enabled for the time being.

Signed-off-by: Jan Beulich <jbeulich@novell.com>

---
 drivers/hwmon/Kconfig |    2 +-
 drivers/hwmon/lm85.c  |   20 ++++++++++++++++++--
 2 files changed, 19 insertions(+), 3 deletions(-)

--- 2.6.38-rc5/drivers/hwmon/Kconfig
+++ 2.6.38-rc5-lm85-emc6d103/drivers/hwmon/Kconfig
@@ -574,7 +574,7 @@ config SENSORS_LM85
 	help
 	  If you say yes here you get support for National Semiconductor LM85
 	  sensor chips and clones: ADM1027, ADT7463, ADT7468, EMC6D100,
-	  EMC6D101 and EMC6D102.
+	  EMC6D101, EMC6D102, and EMC6D103.
 
 	  This driver can also be built as a module.  If so, the module
 	  will be called lm85.
--- 2.6.38-rc5/drivers/hwmon/lm85.c
+++ 2.6.38-rc5-lm85-emc6d103/drivers/hwmon/lm85.c
@@ -41,7 +41,7 @@ static const unsigned short normal_i2c[]
 enum chips {
 	any_chip, lm85b, lm85c,
 	adm1027, adt7463, adt7468,
-	emc6d100, emc6d102
+	emc6d100, emc6d102, emc6d103
 };
 
 /* The LM85 registers */
@@ -90,6 +90,9 @@ enum chips {
 #define	LM85_VERSTEP_EMC6D100_A0        0x60
 #define	LM85_VERSTEP_EMC6D100_A1        0x61
 #define	LM85_VERSTEP_EMC6D102		0x65
+#define	LM85_VERSTEP_EMC6D103_A0	0x68
+#define	LM85_VERSTEP_EMC6D103_A1	0x69
+#define	LM85_VERSTEP_EMC6D103_A2	0x6A
 
 #define	LM85_REG_CONFIG			0x40
 
@@ -348,6 +351,7 @@ static const struct i2c_device_id lm85_i
 	{ "emc6d100", emc6d100 },
 	{ "emc6d101", emc6d100 },
 	{ "emc6d102", emc6d102 },
+	{ "emc6d103", emc6d103 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, lm85_id);
@@ -1250,6 +1254,17 @@ static int lm85_detect(struct i2c_client
 		case LM85_VERSTEP_EMC6D102:
 			type_name = "emc6d102";
 			break;
+		case LM85_VERSTEP_EMC6D103_A0:
+		case LM85_VERSTEP_EMC6D103_A1:
+		/*
+		 * Registers apparently missing in emc6d103:A2 compared to
+		 * emc6d103:A0, emc6d103:A1, and emc6d102 (according to the
+		 * data sheets), but used unconditionally in the driver:
+		 * 62[5:7], 6D[0:7], and 6E[0:7].
+		case LM85_VERSTEP_EMC6D103_A2:
+		 */
+			type_name = "emc6d103";
+			break;
 		}
 	} else {
 		dev_dbg(&adapter->dev,
@@ -1283,6 +1298,7 @@ static int lm85_probe(struct i2c_client 
 	case adt7468:
 	case emc6d100:
 	case emc6d102:
+	case emc6d103:
 		data->freq_map = adm1027_freq_map;
 		break;
 	default:
@@ -1468,7 +1484,7 @@ static struct lm85_data *lm85_update_dev
 			/* More alarm bits */
 			data->alarms |= lm85_read_value(client,
 						EMC6D100_REG_ALARM3) << 16;
-		} else if (data->type = emc6d102) {
+		} else if (data->type = emc6d102 || data->type = emc6d103) {
 			/* Have to read LSB bits after the MSB ones because
 			   the reading of the MSB bits has frozen the
 			   LSBs (backward from the ADM1027).




_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] lm85: extend to support emc6d103 chips

[Guenter Roeck]

On Fri, Feb 18, 2011 at 03:06:13AM -0500, Guenter Roeck wrote:
> Jan,
> 
> On Fri, Feb 18, 2011 at 02:56:23AM -0500, Jan Beulich wrote:
> > The interface is identical emc6d102, so all that needs to be added are
> > some definitions and their uses.
> > 
> > Registers apparently missing in emc6d103:A2 compared to emc6d103:A0,
> > emc6d103:A1, and emc6d102 (according to the data sheets), but used
> > unconditionally in the driver: 62[5:7], 6D[0:7], and 6E[0:7]. For that
> > reason, A2 stepping chips don't get enabled for the time being.
> > 
> > Signed-off-by: Jan Beulich <jbeulich@novell.com>
> > 
Applied. Added Cc: stable@kernel.org since it matches stable criteria.

sensors-detect update will follow.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] lm85: extend to support emc6d103 chips

[Jean Delvare]

Hallo Jan,

On Fri, 18 Feb 2011 08:18:26 +0000, Jan Beulich wrote:
> The interface is identical emc6d102, so all that needs to be added are
> some definitions and their uses.
> 
> Registers apparently missing in emc6d103:A2 compared to emc6d103:A0,
> emc6d103:A1, and emc6d102 (according to the data sheets), but used
> unconditionally in the driver: 62[5:7], 6D[0:7], and 6E[0:7]. For that
> reason, A2 stepping chips don't get enabled for the time being.

The EMC6D103 datasheet on smsc.com doesn't mention revision A2, so I'm
curious where you got this information?

BTW, could you please provide a dump of your chip? I'd like to add it
to my collection. Use i2cdump with the i2c-dev kernel driver.

> 
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
> 
> ---
>  drivers/hwmon/Kconfig |    2 +-
>  drivers/hwmon/lm85.c  |   20 ++++++++++++++++++--
>  2 files changed, 19 insertions(+), 3 deletions(-)

Sorry for being a little late in the game, but can you please also
update Documentation/hwmon/lm85?

The patch looks good otherwise.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] lm85: extend to support emc6d103 chips

[Guenter Roeck]

On Fri, Feb 18, 2011 at 09:54:56AM -0500, Jean Delvare wrote:
> Hallo Jan,
> 
> On Fri, 18 Feb 2011 08:18:26 +0000, Jan Beulich wrote:
> > The interface is identical emc6d102, so all that needs to be added are
> > some definitions and their uses.
> > 
> > Registers apparently missing in emc6d103:A2 compared to emc6d103:A0,
> > emc6d103:A1, and emc6d102 (according to the data sheets), but used
> > unconditionally in the driver: 62[5:7], 6D[0:7], and 6E[0:7]. For that
> > reason, A2 stepping chips don't get enabled for the time being.
> 
> The EMC6D103 datasheet on smsc.com doesn't mention revision A2, so I'm
> curious where you got this information?
> 
Ah, this made me look.

This is really EMC6D103S.
See http://www.smsc.com/media/Downloads_Public/Data_Sheets/6d103s.pdf.

So it should not be listed as step A2, but separately as EMC6D103S
(and it does not have to be mentioned in the code for now, since it is
really a different chip).

> BTW, could you please provide a dump of your chip? I'd like to add it
> to my collection. Use i2cdump with the i2c-dev kernel driver.
> 
> > 
> > Signed-off-by: Jan Beulich <jbeulich@novell.com>
> > 
> > ---
> >  drivers/hwmon/Kconfig |    2 +-
> >  drivers/hwmon/lm85.c  |   20 ++++++++++++++++++--
> >  2 files changed, 19 insertions(+), 3 deletions(-)
> 
> Sorry for being a little late in the game, but can you please also
> update Documentation/hwmon/lm85?
> 
> The patch looks good otherwise.
> 
... except as mentioned above, I think you should remove the reference
to the A2 step entirely.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] lm85: extend to support emc6d103 chips

[Jan Beulich]

>>> On 18.02.11 at 16:38, Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> On Fri, Feb 18, 2011 at 09:54:56AM -0500, Jean Delvare wrote:
>> Hallo Jan,
>> 
>> On Fri, 18 Feb 2011 08:18:26 +0000, Jan Beulich wrote:
>> > The interface is identical emc6d102, so all that needs to be added are
>> > some definitions and their uses.
>> > 
>> > Registers apparently missing in emc6d103:A2 compared to emc6d103:A0,
>> > emc6d103:A1, and emc6d102 (according to the data sheets), but used
>> > unconditionally in the driver: 62[5:7], 6D[0:7], and 6E[0:7]. For that
>> > reason, A2 stepping chips don't get enabled for the time being.
>> 
>> The EMC6D103 datasheet on smsc.com doesn't mention revision A2, so I'm
>> curious where you got this information?
>> 
> Ah, this made me look.
> 
> This is really EMC6D103S.
> See http://www.smsc.com/media/Downloads_Public/Data_Sheets/6d103s.pdf.
> 
> So it should not be listed as step A2, but separately as EMC6D103S
> (and it does not have to be mentioned in the code for now, since it is
> really a different chip).

No. While revision 0.3 indeed only talks about A0 and A1, revision
0.4 even states 0x6A (where 0x68 is A0 and 0x69 is A1) to be the
default in the version/stepping register.

Jan


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] lm85: extend to support emc6d103 chips

[Guenter Roeck]

On Fri, Feb 18, 2011 at 10:50:32AM -0500, Jan Beulich wrote:
> >>> On 18.02.11 at 16:38, Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> > On Fri, Feb 18, 2011 at 09:54:56AM -0500, Jean Delvare wrote:
> >> Hallo Jan,
> >> 
> >> On Fri, 18 Feb 2011 08:18:26 +0000, Jan Beulich wrote:
> >> > The interface is identical emc6d102, so all that needs to be added are
> >> > some definitions and their uses.
> >> > 
> >> > Registers apparently missing in emc6d103:A2 compared to emc6d103:A0,
> >> > emc6d103:A1, and emc6d102 (according to the data sheets), but used
> >> > unconditionally in the driver: 62[5:7], 6D[0:7], and 6E[0:7]. For that
> >> > reason, A2 stepping chips don't get enabled for the time being.
> >> 
> >> The EMC6D103 datasheet on smsc.com doesn't mention revision A2, so I'm
> >> curious where you got this information?
> >> 
> > Ah, this made me look.
> > 
> > This is really EMC6D103S.
> > See http://www.smsc.com/media/Downloads_Public/Data_Sheets/6d103s.pdf.
> > 
> > So it should not be listed as step A2, but separately as EMC6D103S
> > (and it does not have to be mentioned in the code for now, since it is
> > really a different chip).
> 
> No. While revision 0.3 indeed only talks about A0 and A1, revision
> 0.4 even states 0x6A (where 0x68 is A0 and 0x69 is A1) to be the
> default in the version/stepping register.
> 
The datasheet on the SMSC web site is version 0.3 from 2007, the datasheet
at http://www.datasheetcatalog.org/datasheets2/15/1543596_1.pdf
is version 0.4 from 2005. Confusing. 

On the other side, SMSC also has the datasheet for EMC6D103S with ID 0x6a
on their web site. Maybe they relabeled rev A2 as EMC6D103S to avoid confusion
due to the changed functionality.

My take is that we should go with SMSC and list it as EMC6D103S.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] lm85: extend to support emc6d103 chips

[Jean Delvare]

On Fri, 18 Feb 2011 08:08:23 -0800, Guenter Roeck wrote:
> On Fri, Feb 18, 2011 at 10:50:32AM -0500, Jan Beulich wrote:
> > >>> On 18.02.11 at 16:38, Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> > > On Fri, Feb 18, 2011 at 09:54:56AM -0500, Jean Delvare wrote:
> > >> The EMC6D103 datasheet on smsc.com doesn't mention revision A2, so I'm
> > >> curious where you got this information?
> > >> 
> > > Ah, this made me look.
> > > 
> > > This is really EMC6D103S.
> > > See http://www.smsc.com/media/Downloads_Public/Data_Sheets/6d103s.pdf.
> > > 
> > > So it should not be listed as step A2, but separately as EMC6D103S
> > > (and it does not have to be mentioned in the code for now, since it is
> > > really a different chip).
> > 
> > No. While revision 0.3 indeed only talks about A0 and A1, revision
> > 0.4 even states 0x6A (where 0x68 is A0 and 0x69 is A1) to be the
> > default in the version/stepping register.
>
> The datasheet on the SMSC web site is version 0.3 from 2007, the datasheet
> at http://www.datasheetcatalog.org/datasheets2/15/1543596_1.pdf
> is version 0.4 from 2005. Confusing. 

I have an old copy of the datasheet, from 2004, version 0.3. I suspect
that the 2007 document is simply a reformatted copy of the 2004
document to comply with the layout of the day at SMSC. Which means that
SMSC apparently "lost" the 0.4 version from 2005. Might as well have
been on purpose if Guenter is right and revision A2 of the chip became
the EMC6D103S.

Anyway, I hope SMSC are better at designing and implementing chips than
at handling documents and deciding names ;)

> On the other side, SMSC also has the datasheet for EMC6D103S with ID 0x6a
> on their web site. Maybe they relabeled rev A2 as EMC6D103S to avoid confusion
> due to the changed functionality.
> 
> My take is that we should go with SMSC and list it as EMC6D103S.

It's really difficult to tell from the datasheets. Jan, maybe you could
try to take a look at the device physically to see how it is labelled?

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] lm85: extend to support emc6d103 chips

[Jan Beulich]

>>> On 18.02.11 at 17:08, Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> On Fri, Feb 18, 2011 at 10:50:32AM -0500, Jan Beulich wrote:
>> >>> On 18.02.11 at 16:38, Guenter Roeck <guenter.roeck@ericsson.com> wrote:
>> > On Fri, Feb 18, 2011 at 09:54:56AM -0500, Jean Delvare wrote:
>> >> Hallo Jan,
>> >> 
>> >> On Fri, 18 Feb 2011 08:18:26 +0000, Jan Beulich wrote:
>> >> > The interface is identical emc6d102, so all that needs to be added are
>> >> > some definitions and their uses.
>> >> > 
>> >> > Registers apparently missing in emc6d103:A2 compared to emc6d103:A0,
>> >> > emc6d103:A1, and emc6d102 (according to the data sheets), but used
>> >> > unconditionally in the driver: 62[5:7], 6D[0:7], and 6E[0:7]. For that
>> >> > reason, A2 stepping chips don't get enabled for the time being.
>> >> 
>> >> The EMC6D103 datasheet on smsc.com doesn't mention revision A2, so I'm
>> >> curious where you got this information?
>> >> 
>> > Ah, this made me look.
>> > 
>> > This is really EMC6D103S.
>> > See http://www.smsc.com/media/Downloads_Public/Data_Sheets/6d103s.pdf.
>> > 
>> > So it should not be listed as step A2, but separately as EMC6D103S
>> > (and it does not have to be mentioned in the code for now, since it is
>> > really a different chip).
>> 
>> No. While revision 0.3 indeed only talks about A0 and A1, revision
>> 0.4 even states 0x6A (where 0x68 is A0 and 0x69 is A1) to be the
>> default in the version/stepping register.
>> 
> The datasheet on the SMSC web site is version 0.3 from 2007, the datasheet
> at http://www.datasheetcatalog.org/datasheets2/15/1543596_1.pdf 
> is version 0.4 from 2005. Confusing. 
> 
> On the other side, SMSC also has the datasheet for EMC6D103S with ID 0x6a
> on their web site. Maybe they relabeled rev A2 as EMC6D103S to avoid 
> confusion
> due to the changed functionality.
> 
> My take is that we should go with SMSC and list it as EMC6D103S.

So do you expect me to re-spin the patch, or will you create a
fixup on top of it?

Jan


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] lm85: extend to support emc6d103 chips

[Guenter Roeck]

On Fri, Feb 18, 2011 at 11:47:51AM -0500, Jan Beulich wrote:
> >>> On 18.02.11 at 17:08, Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> > On Fri, Feb 18, 2011 at 10:50:32AM -0500, Jan Beulich wrote:
> >> >>> On 18.02.11 at 16:38, Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> >> > On Fri, Feb 18, 2011 at 09:54:56AM -0500, Jean Delvare wrote:
> >> >> Hallo Jan,
> >> >> 
> >> >> On Fri, 18 Feb 2011 08:18:26 +0000, Jan Beulich wrote:
> >> >> > The interface is identical emc6d102, so all that needs to be added are
> >> >> > some definitions and their uses.
> >> >> > 
> >> >> > Registers apparently missing in emc6d103:A2 compared to emc6d103:A0,
> >> >> > emc6d103:A1, and emc6d102 (according to the data sheets), but used
> >> >> > unconditionally in the driver: 62[5:7], 6D[0:7], and 6E[0:7]. For that
> >> >> > reason, A2 stepping chips don't get enabled for the time being.
> >> >> 
> >> >> The EMC6D103 datasheet on smsc.com doesn't mention revision A2, so I'm
> >> >> curious where you got this information?
> >> >> 
> >> > Ah, this made me look.
> >> > 
> >> > This is really EMC6D103S.
> >> > See http://www.smsc.com/media/Downloads_Public/Data_Sheets/6d103s.pdf.
> >> > 
> >> > So it should not be listed as step A2, but separately as EMC6D103S
> >> > (and it does not have to be mentioned in the code for now, since it is
> >> > really a different chip).
> >> 
> >> No. While revision 0.3 indeed only talks about A0 and A1, revision
> >> 0.4 even states 0x6A (where 0x68 is A0 and 0x69 is A1) to be the
> >> default in the version/stepping register.
> >> 
> > The datasheet on the SMSC web site is version 0.3 from 2007, the datasheet
> > at http://www.datasheetcatalog.org/datasheets2/15/1543596_1.pdf 
> > is version 0.4 from 2005. Confusing. 
> > 
> > On the other side, SMSC also has the datasheet for EMC6D103S with ID 0x6a
> > on their web site. Maybe they relabeled rev A2 as EMC6D103S to avoid 
> > confusion
> > due to the changed functionality.
> > 
> > My take is that we should go with SMSC and list it as EMC6D103S.
> 
> So do you expect me to re-spin the patch, or will you create a
> fixup on top of it?
> 
We should re-spin it. I didn't send it to Linus yet, so we have that option.
I can do it or you can - your call. Let me know.

Another option (maybe the best) would be to define it as EMC6D103S and
mention that it may also be called EMC6D103 rev. 2. That is what I would
probably do.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] lm85: extend to support emc6d103 chips

[Guenter Roeck]

On Fri, Feb 18, 2011 at 12:45:57PM -0500, Guenter Roeck wrote:
> On Fri, Feb 18, 2011 at 11:47:51AM -0500, Jan Beulich wrote:
> > >>> On 18.02.11 at 17:08, Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> > > On Fri, Feb 18, 2011 at 10:50:32AM -0500, Jan Beulich wrote:
> > >> >>> On 18.02.11 at 16:38, Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> > >> > On Fri, Feb 18, 2011 at 09:54:56AM -0500, Jean Delvare wrote:
> > >> >> Hallo Jan,
> > >> >> 
> > >> >> On Fri, 18 Feb 2011 08:18:26 +0000, Jan Beulich wrote:
> > >> >> > The interface is identical emc6d102, so all that needs to be added are
> > >> >> > some definitions and their uses.
> > >> >> > 
> > >> >> > Registers apparently missing in emc6d103:A2 compared to emc6d103:A0,
> > >> >> > emc6d103:A1, and emc6d102 (according to the data sheets), but used
> > >> >> > unconditionally in the driver: 62[5:7], 6D[0:7], and 6E[0:7]. For that
> > >> >> > reason, A2 stepping chips don't get enabled for the time being.
> > >> >> 
> > >> >> The EMC6D103 datasheet on smsc.com doesn't mention revision A2, so I'm
> > >> >> curious where you got this information?
> > >> >> 
> > >> > Ah, this made me look.
> > >> > 
> > >> > This is really EMC6D103S.
> > >> > See http://www.smsc.com/media/Downloads_Public/Data_Sheets/6d103s.pdf.
> > >> > 
> > >> > So it should not be listed as step A2, but separately as EMC6D103S
> > >> > (and it does not have to be mentioned in the code for now, since it is
> > >> > really a different chip).
> > >> 
> > >> No. While revision 0.3 indeed only talks about A0 and A1, revision
> > >> 0.4 even states 0x6A (where 0x68 is A0 and 0x69 is A1) to be the
> > >> default in the version/stepping register.
> > >> 
> > > The datasheet on the SMSC web site is version 0.3 from 2007, the datasheet
> > > at http://www.datasheetcatalog.org/datasheets2/15/1543596_1.pdf 
> > > is version 0.4 from 2005. Confusing. 
> > > 
> > > On the other side, SMSC also has the datasheet for EMC6D103S with ID 0x6a
> > > on their web site. Maybe they relabeled rev A2 as EMC6D103S to avoid 
> > > confusion
> > > due to the changed functionality.
> > > 
> > > My take is that we should go with SMSC and list it as EMC6D103S.
> > 
> > So do you expect me to re-spin the patch, or will you create a
> > fixup on top of it?
> > 
> We should re-spin it. I didn't send it to Linus yet, so we have that option.
> I can do it or you can - your call. Let me know.
> 
> Another option (maybe the best) would be to define it as EMC6D103S and
> mention that it may also be called EMC6D103 rev. 2. That is what I would
> probably do.
> 
I have not heard from you (weekend ?), and I want to send the patches 
to Linus today. So I'll go ahead and make the changes myself.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] lm85: extend to support emc6d103 chips

[Jan Beulich]

>>> On 19.02.11 at 16:53, Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> I have not heard from you (weekend ?), and I want to send the patches 
> to Linus today. So I'll go ahead and make the changes myself.

Thanks! (Indeed it was due to the weekend that I didn't respond.)

Jan


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] lm85: extend to support emc6d103 chips

[Jan Beulich]

>>> On 18.02.11 at 15:54, Jean Delvare <khali@linux-fr.org> wrote:
> BTW, could you please provide a dump of your chip? I'd like to add it
> to my collection. Use i2cdump with the i2c-dev kernel driver.

The box got two of them, one at 002c

     0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f    0123456789abcdef
00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
20: 89 60 bf c4 be 1f 24 24 e0 0b ff ff 9c 0b ff ff    ?`????$$??..??..
30: ff ff ff 00 00 00 00 00 00 00 00 00 00 00 5c 68    ..............\h
40: 05 80 08 00 00 ff 00 ff 00 ff 00 ff 00 ff 81 7f    ???...........??
50: 81 7f 81 7f 30 2a 30 2a 30 2a ff ff 62 62 62 aa    ????0*0*0*..bbb?
60: aa aa e8 88 44 44 44 1e 1e 1e 7f 64 7f 44 40 00    ????DDD????d?D@.
70: ff ff ff 09 09 09 09 09 09 00 00 00 40 00 ec 1a    ...??????...@.??
80: 1f a4 0e 00 00 a4 3c c9 0c 00 40 40 09 09 0b 00    ???..?<??.@@???.
90: 14 14 14 04 0c 0c 0c 5a f1 00 00 00 23 00 00 00    ???????Z?...#...
a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................

and the other at 002e

     0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f    0123456789abcdef
00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f2 f2    ..............??
20: 87 5f bc bf bc 18 27 1c 9b 14 9a 14 ff ff ff ff    ?_????'?????....
30: 66 66 66 00 00 00 00 00 00 00 00 00 00 00 5c 68    fff...........\h
40: 05 80 30 00 00 ff 00 ff 00 ff 00 ff 00 ff 81 7f    ??0...........??
50: 81 7f 81 7f 30 2a 30 2a 30 2a 30 2a c2 c2 c2 73    ????0*0*0*0*???s
60: 7a 73 e8 88 66 66 66 37 37 37 46 64 46 44 40 00    zs??fff777FdFD@.
70: 66 66 66 09 09 09 09 09 09 00 00 00 40 00 ec 1a    fff??????...@.??
80: 1f a4 0e 00 00 8a 98 dd fa 00 40 40 09 09 0b 00    ???..????.@@???.
90: 14 14 14 04 0c 0c 0c 5a f1 00 00 00 23 00 00 00    ???????Z?...#...
a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................

Jan


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] lm85: extend to support emc6d103 chips

[Jean Delvare]

On Wed, 23 Feb 2011 14:38:50 +0000, Jan Beulich wrote:
> >>> On 18.02.11 at 15:54, Jean Delvare <khali@linux-fr.org> wrote:
> > BTW, could you please provide a dump of your chip? I'd like to add it
> > to my collection. Use i2cdump with the i2c-dev kernel driver.
> 
> The box got two of them, one at 002c
> 
>      0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f    0123456789abcdef
> 00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
> 10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
> 20: 89 60 bf c4 be 1f 24 24 e0 0b ff ff 9c 0b ff ff    ?`????$$??..??..
> 30: ff ff ff 00 00 00 00 00 00 00 00 00 00 00 5c 68    ..............\h
> 40: 05 80 08 00 00 ff 00 ff 00 ff 00 ff 00 ff 81 7f    ???...........??
> 50: 81 7f 81 7f 30 2a 30 2a 30 2a ff ff 62 62 62 aa    ????0*0*0*..bbb?
> 60: aa aa e8 88 44 44 44 1e 1e 1e 7f 64 7f 44 40 00    ????DDD????d?D@.
> 70: ff ff ff 09 09 09 09 09 09 00 00 00 40 00 ec 1a    ...??????...@.??
> 80: 1f a4 0e 00 00 a4 3c c9 0c 00 40 40 09 09 0b 00    ???..?<??.@@???.
> 90: 14 14 14 04 0c 0c 0c 5a f1 00 00 00 23 00 00 00    ???????Z?...#...
> a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
> b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
> c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
> d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
> e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
> f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
> 
> and the other at 002e
> 
>      0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f    0123456789abcdef
> 00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
> 10: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f2 f2    ..............??
> 20: 87 5f bc bf bc 18 27 1c 9b 14 9a 14 ff ff ff ff    ?_????'?????....
> 30: 66 66 66 00 00 00 00 00 00 00 00 00 00 00 5c 68    fff...........\h
> 40: 05 80 30 00 00 ff 00 ff 00 ff 00 ff 00 ff 81 7f    ??0...........??
> 50: 81 7f 81 7f 30 2a 30 2a 30 2a 30 2a c2 c2 c2 73    ????0*0*0*0*???s
> 60: 7a 73 e8 88 66 66 66 37 37 37 46 64 46 44 40 00    zs??fff777FdFD@.
> 70: 66 66 66 09 09 09 09 09 09 00 00 00 40 00 ec 1a    fff??????...@.??
> 80: 1f a4 0e 00 00 8a 98 dd fa 00 40 40 09 09 0b 00    ???..????.@@???.
> 90: 14 14 14 04 0c 0c 0c 5a f1 00 00 00 23 00 00 00    ???????Z?...#...
> a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
> b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
> c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
> d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
> e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
> f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................

Great, thank you.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors