From: Lars-Peter Clausen <lars@metafoo.de> To: Lars-Peter Clausen <lars@metafoo.de> Cc: Ben Dooks <ben-linux@fluff.org>, Kukjin Kim <kgene.kim@samsung.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 01/09] ARM: s3c2442: gta02: Fix usage gpio bank j pin definitions Date: Fri, 18 Feb 2011 11:41:05 +0100 [thread overview] Message-ID: <4D5E4CC1.1010705@metafoo.de> (raw) In-Reply-To: <1297043521-21903-1-git-send-email-lars@metafoo.de> On 02/07/2011 02:51 AM, Lars-Peter Clausen wrote: > The gta02 header file still uses the old S3C2410_GPJx defines instead of the > S3C2410_GPJ(x) macro. Since the S3C2410_GPJx defines have already been removed > this causes the following build failure: > > sound/soc/samsung/neo1973_wm8753.c: In function 'lm4853_set_spk': > sound/soc/samsung/neo1973_wm8753.c:259: error: 'S3C2440_GPJ2' undeclared (first use in this function) > sound/soc/samsung/neo1973_wm8753.c:259: error: (Each undeclared identifier is reported only once > sound/soc/samsung/neo1973_wm8753.c:259: error: for each function it appears in.) > sound/soc/samsung/neo1973_wm8753.c: In function 'lm4853_get_spk': > sound/soc/samsung/neo1973_wm8753.c:267: error: 'S3C2440_GPJ2' undeclared (first use in this function) > sound/soc/samsung/neo1973_wm8753.c: In function 'lm4853_event': > sound/soc/samsung/neo1973_wm8753.c:276: error: 'S3C2440_GPJ1' undeclared (first use in this function) > sound/soc/samsung/neo1973_wm8753.c: At top level: > sound/soc/samsung/neo1973_wm8753.c:439: error: 'S3C2440_GPJ2' undeclared here (not in a function) > sound/soc/samsung/neo1973_wm8753.c:440: error: 'S3C2440_GPJ1' undeclared here (not in a function) > > This patches fixes the issue by doing a s,S3C2410_GPJ([\d]+),S3C2410_GPJ(\1),g > on the file. > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Hi Ben or Kukjin could you take a look at this series and merge it, if it is ok? - Lars > --- > arch/arm/mach-s3c2440/include/mach/gta02.h | 26 +++++++++++++------------- > 1 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/arch/arm/mach-s3c2440/include/mach/gta02.h b/arch/arm/mach-s3c2440/include/mach/gta02.h > index 953331d..3a56a22 100644 > --- a/arch/arm/mach-s3c2440/include/mach/gta02.h > +++ b/arch/arm/mach-s3c2440/include/mach/gta02.h > @@ -44,19 +44,19 @@ > #define GTA02v3_GPIO_nUSB_FLT S3C2410_GPG(10) /* v3 + v4 only */ > #define GTA02v3_GPIO_nGSM_OC S3C2410_GPG(11) /* v3 + v4 only */ > > -#define GTA02_GPIO_AMP_SHUT S3C2440_GPJ1 /* v2 + v3 + v4 only */ > -#define GTA02v1_GPIO_WLAN_GPIO10 S3C2440_GPJ2 > -#define GTA02_GPIO_HP_IN S3C2440_GPJ2 /* v2 + v3 + v4 only */ > -#define GTA02_GPIO_INT0 S3C2440_GPJ3 /* v2 + v3 + v4 only */ > -#define GTA02_GPIO_nGSM_EN S3C2440_GPJ4 > -#define GTA02_GPIO_3D_RESET S3C2440_GPJ5 > -#define GTA02_GPIO_nDL_GSM S3C2440_GPJ6 /* v4 + v5 only */ > -#define GTA02_GPIO_WLAN_GPIO0 S3C2440_GPJ7 > -#define GTA02v1_GPIO_BAT_ID S3C2440_GPJ8 > -#define GTA02_GPIO_KEEPACT S3C2440_GPJ8 > -#define GTA02v1_GPIO_HP_IN S3C2440_GPJ10 > -#define GTA02_CHIP_PWD S3C2440_GPJ11 /* v2 + v3 + v4 only */ > -#define GTA02_GPIO_nWLAN_RESET S3C2440_GPJ12 /* v2 + v3 + v4 only */ > +#define GTA02_GPIO_AMP_SHUT S3C2410_GPJ(1) /* v2 + v3 + v4 only */ > +#define GTA02v1_GPIO_WLAN_GPIO10 S3C2410_GPJ(2) > +#define GTA02_GPIO_HP_IN S3C2410_GPJ(2) /* v2 + v3 + v4 only */ > +#define GTA02_GPIO_INT0 S3C2410_GPJ(3) /* v2 + v3 + v4 only */ > +#define GTA02_GPIO_nGSM_EN S3C2410_GPJ(4) > +#define GTA02_GPIO_3D_RESET S3C2410_GPJ(5) > +#define GTA02_GPIO_nDL_GSM S3C2410_GPJ(6) /* v4 + v5 only */ > +#define GTA02_GPIO_WLAN_GPIO0 S3C2410_GPJ(7) > +#define GTA02v1_GPIO_BAT_ID S3C2410_GPJ(8) > +#define GTA02_GPIO_KEEPACT S3C2410_GPJ(8) > +#define GTA02v1_GPIO_HP_IN S3C2410_GPJ(10) > +#define GTA02_CHIP_PWD S3C2410_GPJ(11) /* v2 + v3 + v4 only */ > +#define GTA02_GPIO_nWLAN_RESET S3C2410_GPJ(12) /* v2 + v3 + v4 only */ > > #define GTA02_IRQ_GSENSOR_1 IRQ_EINT0 > #define GTA02_IRQ_MODEM IRQ_EINT1
WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 01/09] ARM: s3c2442: gta02: Fix usage gpio bank j pin definitions Date: Fri, 18 Feb 2011 11:41:05 +0100 [thread overview] Message-ID: <4D5E4CC1.1010705@metafoo.de> (raw) In-Reply-To: <1297043521-21903-1-git-send-email-lars@metafoo.de> On 02/07/2011 02:51 AM, Lars-Peter Clausen wrote: > The gta02 header file still uses the old S3C2410_GPJx defines instead of the > S3C2410_GPJ(x) macro. Since the S3C2410_GPJx defines have already been removed > this causes the following build failure: > > sound/soc/samsung/neo1973_wm8753.c: In function 'lm4853_set_spk': > sound/soc/samsung/neo1973_wm8753.c:259: error: 'S3C2440_GPJ2' undeclared (first use in this function) > sound/soc/samsung/neo1973_wm8753.c:259: error: (Each undeclared identifier is reported only once > sound/soc/samsung/neo1973_wm8753.c:259: error: for each function it appears in.) > sound/soc/samsung/neo1973_wm8753.c: In function 'lm4853_get_spk': > sound/soc/samsung/neo1973_wm8753.c:267: error: 'S3C2440_GPJ2' undeclared (first use in this function) > sound/soc/samsung/neo1973_wm8753.c: In function 'lm4853_event': > sound/soc/samsung/neo1973_wm8753.c:276: error: 'S3C2440_GPJ1' undeclared (first use in this function) > sound/soc/samsung/neo1973_wm8753.c: At top level: > sound/soc/samsung/neo1973_wm8753.c:439: error: 'S3C2440_GPJ2' undeclared here (not in a function) > sound/soc/samsung/neo1973_wm8753.c:440: error: 'S3C2440_GPJ1' undeclared here (not in a function) > > This patches fixes the issue by doing a s,S3C2410_GPJ([\d]+),S3C2410_GPJ(\1),g > on the file. > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Hi Ben or Kukjin could you take a look at this series and merge it, if it is ok? - Lars > --- > arch/arm/mach-s3c2440/include/mach/gta02.h | 26 +++++++++++++------------- > 1 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/arch/arm/mach-s3c2440/include/mach/gta02.h b/arch/arm/mach-s3c2440/include/mach/gta02.h > index 953331d..3a56a22 100644 > --- a/arch/arm/mach-s3c2440/include/mach/gta02.h > +++ b/arch/arm/mach-s3c2440/include/mach/gta02.h > @@ -44,19 +44,19 @@ > #define GTA02v3_GPIO_nUSB_FLT S3C2410_GPG(10) /* v3 + v4 only */ > #define GTA02v3_GPIO_nGSM_OC S3C2410_GPG(11) /* v3 + v4 only */ > > -#define GTA02_GPIO_AMP_SHUT S3C2440_GPJ1 /* v2 + v3 + v4 only */ > -#define GTA02v1_GPIO_WLAN_GPIO10 S3C2440_GPJ2 > -#define GTA02_GPIO_HP_IN S3C2440_GPJ2 /* v2 + v3 + v4 only */ > -#define GTA02_GPIO_INT0 S3C2440_GPJ3 /* v2 + v3 + v4 only */ > -#define GTA02_GPIO_nGSM_EN S3C2440_GPJ4 > -#define GTA02_GPIO_3D_RESET S3C2440_GPJ5 > -#define GTA02_GPIO_nDL_GSM S3C2440_GPJ6 /* v4 + v5 only */ > -#define GTA02_GPIO_WLAN_GPIO0 S3C2440_GPJ7 > -#define GTA02v1_GPIO_BAT_ID S3C2440_GPJ8 > -#define GTA02_GPIO_KEEPACT S3C2440_GPJ8 > -#define GTA02v1_GPIO_HP_IN S3C2440_GPJ10 > -#define GTA02_CHIP_PWD S3C2440_GPJ11 /* v2 + v3 + v4 only */ > -#define GTA02_GPIO_nWLAN_RESET S3C2440_GPJ12 /* v2 + v3 + v4 only */ > +#define GTA02_GPIO_AMP_SHUT S3C2410_GPJ(1) /* v2 + v3 + v4 only */ > +#define GTA02v1_GPIO_WLAN_GPIO10 S3C2410_GPJ(2) > +#define GTA02_GPIO_HP_IN S3C2410_GPJ(2) /* v2 + v3 + v4 only */ > +#define GTA02_GPIO_INT0 S3C2410_GPJ(3) /* v2 + v3 + v4 only */ > +#define GTA02_GPIO_nGSM_EN S3C2410_GPJ(4) > +#define GTA02_GPIO_3D_RESET S3C2410_GPJ(5) > +#define GTA02_GPIO_nDL_GSM S3C2410_GPJ(6) /* v4 + v5 only */ > +#define GTA02_GPIO_WLAN_GPIO0 S3C2410_GPJ(7) > +#define GTA02v1_GPIO_BAT_ID S3C2410_GPJ(8) > +#define GTA02_GPIO_KEEPACT S3C2410_GPJ(8) > +#define GTA02v1_GPIO_HP_IN S3C2410_GPJ(10) > +#define GTA02_CHIP_PWD S3C2410_GPJ(11) /* v2 + v3 + v4 only */ > +#define GTA02_GPIO_nWLAN_RESET S3C2410_GPJ(12) /* v2 + v3 + v4 only */ > > #define GTA02_IRQ_GSENSOR_1 IRQ_EINT0 > #define GTA02_IRQ_MODEM IRQ_EINT1
next prev parent reply other threads:[~2011-02-18 10:41 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-07 1:51 [PATCH 01/09] ARM: s3c2442: gta02: Fix usage gpio bank j pin definitions Lars-Peter Clausen 2011-02-07 1:51 ` Lars-Peter Clausen 2011-02-07 1:51 ` [PATCH 02/09] ARM: s3c2440: gta02: Register PCM device Lars-Peter Clausen 2011-02-07 1:51 ` Lars-Peter Clausen 2011-02-28 6:38 ` Kukjin Kim 2011-02-28 6:38 ` Kukjin Kim 2011-02-07 1:51 ` [PATCH 03/09] ARM: s3c2440: gta02: Add button support Lars-Peter Clausen 2011-02-07 1:51 ` Lars-Peter Clausen 2011-02-28 6:37 ` Kukjin Kim 2011-02-28 6:37 ` Kukjin Kim 2011-02-07 1:51 ` [PATCH 04/09] ARM: s3c2440: gta02: Select missing S3C_DEV_USB_HOST Lars-Peter Clausen 2011-02-07 1:51 ` Lars-Peter Clausen 2011-02-28 6:31 ` Kukjin Kim 2011-02-28 6:31 ` Kukjin Kim 2011-02-07 1:51 ` [PATCH 05/09] ARM: s3c2440: gta02: Fix regulator valid_modes_ops Lars-Peter Clausen 2011-02-07 1:51 ` Lars-Peter Clausen 2011-02-28 6:48 ` Kukjin Kim 2011-02-28 6:48 ` Kukjin Kim 2011-02-07 1:51 ` [PATCH 06/09] ARM: s3c2440: gta02: Remove state_mem constraints for the pcf50633 regulators Lars-Peter Clausen 2011-02-07 1:51 ` Lars-Peter Clausen 2011-02-28 6:26 ` Kukjin Kim 2011-02-28 6:26 ` Kukjin Kim 2011-02-28 10:28 ` Lars-Peter Clausen 2011-02-28 10:28 ` Lars-Peter Clausen 2011-02-28 10:58 ` Kukjin Kim 2011-02-28 10:58 ` Kukjin Kim 2011-02-07 1:51 ` [PATCH 07/09] ARM: s3c2440: gta02: Call regulator_has_full_constraints Lars-Peter Clausen 2011-02-07 1:51 ` Lars-Peter Clausen 2011-02-07 11:58 ` Mark Brown 2011-02-07 11:58 ` Mark Brown 2011-02-08 2:55 ` [PATCH v2 " Lars-Peter Clausen 2011-02-08 2:55 ` Lars-Peter Clausen 2011-02-28 6:47 ` Kukjin Kim 2011-02-28 6:47 ` Kukjin Kim 2011-02-07 1:52 ` [PATCH 08/09] ARM: s3c2440: gta02: Request usb pullup pin before using it Lars-Peter Clausen 2011-02-07 1:52 ` Lars-Peter Clausen 2011-02-28 6:16 ` Kukjin Kim 2011-02-28 6:16 ` Kukjin Kim 2011-02-28 10:25 ` Lars-Peter Clausen 2011-02-28 10:25 ` Lars-Peter Clausen 2011-02-28 10:44 ` Kukjin Kim 2011-02-28 10:44 ` Kukjin Kim 2011-02-28 10:58 ` Lars-Peter Clausen 2011-02-28 10:58 ` Lars-Peter Clausen 2011-03-07 6:42 ` Kukjin Kim 2011-03-07 6:42 ` Kukjin Kim 2011-03-07 7:00 ` Lars-Peter Clausen 2011-03-07 7:00 ` Lars-Peter Clausen 2011-02-07 1:52 ` [PATCH 09/09] ARM: s3c2440: gta02: Add touchscreen support Lars-Peter Clausen 2011-02-07 1:52 ` Lars-Peter Clausen 2011-02-28 6:04 ` Kukjin Kim 2011-02-28 6:04 ` Kukjin Kim 2011-02-28 10:44 ` Lars-Peter Clausen 2011-02-28 10:44 ` Lars-Peter Clausen 2011-02-28 10:57 ` Kukjin Kim 2011-02-28 10:57 ` Kukjin Kim 2011-02-28 11:17 ` [PATCH v2 " Lars-Peter Clausen 2011-02-28 11:17 ` Lars-Peter Clausen 2011-02-28 11:56 ` Kukjin Kim 2011-02-28 11:56 ` Kukjin Kim 2011-02-18 10:41 ` Lars-Peter Clausen [this message] 2011-02-18 10:41 ` [PATCH 01/09] ARM: s3c2442: gta02: Fix usage gpio bank j pin definitions Lars-Peter Clausen 2011-02-21 9:58 ` Kukjin Kim 2011-02-21 9:58 ` Kukjin Kim 2011-02-28 6:41 ` Kukjin Kim 2011-02-28 6:41 ` Kukjin Kim 2011-02-28 10:46 ` Lars-Peter Clausen 2011-02-28 10:46 ` Lars-Peter Clausen 2011-02-28 10:49 ` Kukjin Kim 2011-02-28 10:49 ` Kukjin Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4D5E4CC1.1010705@metafoo.de \ --to=lars@metafoo.de \ --cc=ben-linux@fluff.org \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.