[PATCH] x86: cleanup after tboot fix (c/s 23101:dd386a4b6595)

[PATCH] x86: cleanup after tboot fix (c/s 23101:dd386a4b6595)

[Jan Beulich]

[-- Attachment #1: Type: text/plain, Size: 805 bytes --]

When submitting the patch that became 23101:dd386a4b6595 I forgot that
I actually intended to remove the pointless IRQ disabling and restoring
(and the then pointless comment). Pointless because the code, other
than its pre-23013:65d26504e843 original, now runs before interrupts
get enabled for the first time.

Signed-off-by: Jan Beulich <jbeulich@novell.com>

--- a/xen/drivers/passthrough/vtd/dmar.c
+++ b/xen/drivers/passthrough/vtd/dmar.c
@@ -761,12 +761,7 @@ out:
 
 int __init acpi_dmar_init(void)
 {
-    unsigned long flags;
-
-    /* Disabling IRQs avoids cross-CPU TLB flush in map_pages_to_xen(). */
-    local_irq_save(flags);
     acpi_get_table(ACPI_SIG_DMAR, 0, &dmar_table);
-    local_irq_restore(flags);
 
     return parse_dmar_table(acpi_parse_dmar);
 }




[-- Attachment #2: acpi-tboot-cleanup-23101.patch --]
[-- Type: text/plain, Size: 799 bytes --]

When submitting the patch that became 23101:dd386a4b6595 I forgot that
I actually intended to remove the pointless IRQ disabling and restoring
(and the then pointless comment). Pointless because the code, other
than its pre-23013:65d26504e843 original, now runs before interrupts
get enabled for the first time.

Signed-off-by: Jan Beulich <jbeulich@novell.com>

--- a/xen/drivers/passthrough/vtd/dmar.c
+++ b/xen/drivers/passthrough/vtd/dmar.c
@@ -761,12 +761,7 @@ out:
 
 int __init acpi_dmar_init(void)
 {
-    unsigned long flags;
-
-    /* Disabling IRQs avoids cross-CPU TLB flush in map_pages_to_xen(). */
-    local_irq_save(flags);
     acpi_get_table(ACPI_SIG_DMAR, 0, &dmar_table);
-    local_irq_restore(flags);
 
     return parse_dmar_table(acpi_parse_dmar);
 }

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel