All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
To: Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
Cc: Tatyana Brokhman
	<tlinder-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	gregkh-l3A5Bk7waGM@public.gmane.org,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	balbi-l0cyMroinI0@public.gmane.org,
	ablay-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 4/5] usb/gadget: don't deploy SS descriptors if SS is not enabled.
Date: Wed, 13 Apr 2011 12:56:57 +0200	[thread overview]
Message-ID: <4DA58179.40004@linutronix.de> (raw)
In-Reply-To: <4DA57F0F.1090609-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>

Sergei Shtylyov wrote:
> Hello.

Hello Sergei,

> Cleaned-up example:
> 
> (in header)
>     #ifndef CONFIG_NET_FUNKINESS
>     static inline void init_funky_net (struct net_device *d) {}
>     #endif
> 
> (in the code itself)
>     dev = alloc_etherdev (sizeof(struct funky_private));
>     if (!dev)
>         return -ENODEV;
>     init_funky_net(dev);

The problem here is that the code is included via

   #include "composite.c

so we don't really use header files. The alternative would be to use the
gadget_is_super_speed() function but that one takes a gadget as argument.
Preferences?

> 
> WBR, Sergei

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Tatyana Brokhman <tlinder@codeaurora.org>,
	gregkh@suse.de, linux-arm-msm@vger.kernel.org, balbi@ti.com,
	ablay@codeaurora.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] usb/gadget: don't deploy SS descriptors if SS is not enabled.
Date: Wed, 13 Apr 2011 12:56:57 +0200	[thread overview]
Message-ID: <4DA58179.40004@linutronix.de> (raw)
In-Reply-To: <4DA57F0F.1090609@ru.mvista.com>

Sergei Shtylyov wrote:
> Hello.

Hello Sergei,

> Cleaned-up example:
> 
> (in header)
>     #ifndef CONFIG_NET_FUNKINESS
>     static inline void init_funky_net (struct net_device *d) {}
>     #endif
> 
> (in the code itself)
>     dev = alloc_etherdev (sizeof(struct funky_private));
>     if (!dev)
>         return -ENODEV;
>     init_funky_net(dev);

The problem here is that the code is included via

   #include "composite.c

so we don't really use header files. The alternative would be to use the
gadget_is_super_speed() function but that one takes a gadget as argument.
Preferences?

> 
> WBR, Sergei

Sebastian

  parent reply	other threads:[~2011-04-13 10:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-23  8:04 [PATCH 5/5 v5] usb:gadget: Add SuperSpeed support to the Gadget Framework Tatyana Brokhman
2011-03-23  8:04 ` Tatyana Brokhman
     [not found] ` <1300867498-20997-1-git-send-email-tlinder-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-03-25 13:41   ` Felipe Balbi
2011-03-25 13:41     ` Felipe Balbi
2011-03-28  8:45     ` Tanya Brokhman
2011-03-28  8:45       ` Tanya Brokhman
2011-03-28  8:54       ` Felipe Balbi
2011-03-28  9:15         ` Tanya Brokhman
2011-03-28  9:15           ` Tanya Brokhman
2011-04-11 17:59   ` Sebastian Andrzej Siewior
2011-04-11 17:59     ` Sebastian Andrzej Siewior
2011-04-12 19:34     ` Sebastian Andrzej Siewior
2011-04-12 19:34       ` [PATCH 2/5] usb/gadget: rename bos to get_bos_descr in composite Sebastian Andrzej Siewior
2011-04-12 19:34       ` [PATCH 3/5] usb/gadget: rename create_ss_descriptors() to usb_create_ss_descriptors() Sebastian Andrzej Siewior
2011-04-12 19:34       ` [PATCH 4/5] usb/gadget: don't deploy SS descriptors if SS is not enabled Sebastian Andrzej Siewior
2011-04-13 10:46         ` Sergei Shtylyov
     [not found]           ` <4DA57F0F.1090609-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2011-04-13 10:56             ` Sebastian Andrzej Siewior [this message]
2011-04-13 10:56               ` Sebastian Andrzej Siewior
2011-04-13 10:59               ` Michal Nazarewicz
     [not found]       ` <1302636896-12717-1-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2011-04-12 19:34         ` [PATCH 1/5] usb/gadget: cleanup of "Add SuperSpeed support to the Gadget Framework" Sebastian Andrzej Siewior
2011-04-12 19:34           ` Sebastian Andrzej Siewior
2011-04-13  8:17           ` Felipe Balbi
2011-04-12 19:34         ` [PATCH 5/5] usb/gadget: don't auto-create SS descriptors if HS are avilable Sebastian Andrzej Siewior
2011-04-12 19:34           ` Sebastian Andrzej Siewior
2011-04-13 11:12       ` [PATCH 5/5 v5] usb:gadget: Add SuperSpeed support to the Gadget Framework Tanya Brokhman
2011-04-13 11:12         ` Tanya Brokhman
2011-04-14  7:36     ` Tanya Brokhman
2011-04-14  7:36       ` Tanya Brokhman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DA58179.40004@linutronix.de \
    --to=bigeasy-hfztesqfncyowbw4kg4ksq@public.gmane.org \
    --cc=ablay-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=gregkh-l3A5Bk7waGM@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org \
    --cc=tlinder-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.