All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fixed gpio polarity of gpio USB-phy reset.
@ 2011-04-14  7:31 ` Juergen Kilb
  0 siblings, 0 replies; 13+ messages in thread
From: Juergen Kilb @ 2011-04-14  7:31 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: dbrownell, balbi, gregkh, linux-usb, linux-omap, linux-kernel,
	sameo, Juergen Kilb

With commit 19403165 a main part of ehci-omap.c moved to
drivers/mfd/omap-usb-host.c created by commit 17cdd29d.
Due to this reorganisation the polarity used to reset the
external USB phy changed and USB host doesn't recognize
any devices.

Signed-off-by: Juergen Kilb <J.Kilb@phytec.de>
---
 drivers/mfd/omap-usb-host.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 53450f4..491cac5 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -719,14 +719,14 @@ static int usbhs_enable(struct device *dev)
 			gpio_request(pdata->ehci_data->reset_gpio_port[0],
 						"USB1 PHY reset");
 			gpio_direction_output
-				(pdata->ehci_data->reset_gpio_port[0], 1);
+				(pdata->ehci_data->reset_gpio_port[0], 0);
 		}
 
 		if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1])) {
 			gpio_request(pdata->ehci_data->reset_gpio_port[1],
 						"USB2 PHY reset");
 			gpio_direction_output
-				(pdata->ehci_data->reset_gpio_port[1], 1);
+				(pdata->ehci_data->reset_gpio_port[1], 0);
 		}
 
 		/* Hold the PHY in RESET for enough time till DIR is high */
@@ -906,11 +906,11 @@ static int usbhs_enable(struct device *dev)
 
 		if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[0]))
 			gpio_set_value
-				(pdata->ehci_data->reset_gpio_port[0], 0);
+				(pdata->ehci_data->reset_gpio_port[0], 1);
 
 		if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1]))
 			gpio_set_value
-				(pdata->ehci_data->reset_gpio_port[1], 0);
+				(pdata->ehci_data->reset_gpio_port[1], 1);
 	}
 
 end_count:
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH] Fixed gpio polarity of gpio USB-phy reset.
@ 2011-04-14  7:31 ` Juergen Kilb
  0 siblings, 0 replies; 13+ messages in thread
From: Juergen Kilb @ 2011-04-14  7:31 UTC (permalink / raw)
  To: linux-arm-kernel

With commit 19403165 a main part of ehci-omap.c moved to
drivers/mfd/omap-usb-host.c created by commit 17cdd29d.
Due to this reorganisation the polarity used to reset the
external USB phy changed and USB host doesn't recognize
any devices.

Signed-off-by: Juergen Kilb <J.Kilb@phytec.de>
---
 drivers/mfd/omap-usb-host.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 53450f4..491cac5 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -719,14 +719,14 @@ static int usbhs_enable(struct device *dev)
 			gpio_request(pdata->ehci_data->reset_gpio_port[0],
 						"USB1 PHY reset");
 			gpio_direction_output
-				(pdata->ehci_data->reset_gpio_port[0], 1);
+				(pdata->ehci_data->reset_gpio_port[0], 0);
 		}
 
 		if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1])) {
 			gpio_request(pdata->ehci_data->reset_gpio_port[1],
 						"USB2 PHY reset");
 			gpio_direction_output
-				(pdata->ehci_data->reset_gpio_port[1], 1);
+				(pdata->ehci_data->reset_gpio_port[1], 0);
 		}
 
 		/* Hold the PHY in RESET for enough time till DIR is high */
@@ -906,11 +906,11 @@ static int usbhs_enable(struct device *dev)
 
 		if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[0]))
 			gpio_set_value
-				(pdata->ehci_data->reset_gpio_port[0], 0);
+				(pdata->ehci_data->reset_gpio_port[0], 1);
 
 		if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1]))
 			gpio_set_value
-				(pdata->ehci_data->reset_gpio_port[1], 0);
+				(pdata->ehci_data->reset_gpio_port[1], 1);
 	}
 
 end_count:
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread
* Re: [PATCH] Fixed gpio polarity of gpio USB-phy reset.
@ 2011-04-14  8:56   ` Samuel Ortiz
  0 siblings, 0 replies; 13+ messages in thread
From: Samuel Ortiz @ 2011-04-14  8:56 UTC (permalink / raw)
  To: Juergen Kilb, balbi
  Cc: linux-arm-kernel, dbrownell, gregkh, linux-usb, linux-omap, linux-kernel

Hi Juergen,

On Thu, Apr 14, 2011 at 09:31:43AM +0200, Juergen Kilb wrote:
> With commit 19403165 a main part of ehci-omap.c moved to
> drivers/mfd/omap-usb-host.c created by commit 17cdd29d.
> Due to this reorganisation the polarity used to reset the
> external USB phy changed and USB host doesn't recognize
> any devices.
If that fix is correct, it looks like it should make its way to 2.6.39.
Felipe, are you ok with this fix ?

Cheers,
Samuel.

> Signed-off-by: Juergen Kilb <J.Kilb@phytec.de>
> ---
>  drivers/mfd/omap-usb-host.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index 53450f4..491cac5 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -719,14 +719,14 @@ static int usbhs_enable(struct device *dev)
>  			gpio_request(pdata->ehci_data->reset_gpio_port[0],
>  						"USB1 PHY reset");
>  			gpio_direction_output
> -				(pdata->ehci_data->reset_gpio_port[0], 1);
> +				(pdata->ehci_data->reset_gpio_port[0], 0);
>  		}
>  
>  		if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1])) {
>  			gpio_request(pdata->ehci_data->reset_gpio_port[1],
>  						"USB2 PHY reset");
>  			gpio_direction_output
> -				(pdata->ehci_data->reset_gpio_port[1], 1);
> +				(pdata->ehci_data->reset_gpio_port[1], 0);
>  		}
>  
>  		/* Hold the PHY in RESET for enough time till DIR is high */
> @@ -906,11 +906,11 @@ static int usbhs_enable(struct device *dev)
>  
>  		if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[0]))
>  			gpio_set_value
> -				(pdata->ehci_data->reset_gpio_port[0], 0);
> +				(pdata->ehci_data->reset_gpio_port[0], 1);
>  
>  		if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1]))
>  			gpio_set_value
> -				(pdata->ehci_data->reset_gpio_port[1], 0);
> +				(pdata->ehci_data->reset_gpio_port[1], 1);
>  	}
>  
>  end_count:
> -- 
> 1.7.0.4
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] Fixed gpio polarity of gpio USB-phy reset.
@ 2011-04-14  8:56   ` Samuel Ortiz
  0 siblings, 0 replies; 13+ messages in thread
From: Samuel Ortiz @ 2011-04-14  8:56 UTC (permalink / raw)
  To: Juergen Kilb, balbi-l0cyMroinI0
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f, gregkh-l3A5Bk7waGM,
	linux-usb-u79uwXL29TY76Z2rM5mHXA,
	linux-omap-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Hi Juergen,

On Thu, Apr 14, 2011 at 09:31:43AM +0200, Juergen Kilb wrote:
> With commit 19403165 a main part of ehci-omap.c moved to
> drivers/mfd/omap-usb-host.c created by commit 17cdd29d.
> Due to this reorganisation the polarity used to reset the
> external USB phy changed and USB host doesn't recognize
> any devices.
If that fix is correct, it looks like it should make its way to 2.6.39.
Felipe, are you ok with this fix ?

Cheers,
Samuel.

> Signed-off-by: Juergen Kilb <J.Kilb-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org>
> ---
>  drivers/mfd/omap-usb-host.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index 53450f4..491cac5 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -719,14 +719,14 @@ static int usbhs_enable(struct device *dev)
>  			gpio_request(pdata->ehci_data->reset_gpio_port[0],
>  						"USB1 PHY reset");
>  			gpio_direction_output
> -				(pdata->ehci_data->reset_gpio_port[0], 1);
> +				(pdata->ehci_data->reset_gpio_port[0], 0);
>  		}
>  
>  		if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1])) {
>  			gpio_request(pdata->ehci_data->reset_gpio_port[1],
>  						"USB2 PHY reset");
>  			gpio_direction_output
> -				(pdata->ehci_data->reset_gpio_port[1], 1);
> +				(pdata->ehci_data->reset_gpio_port[1], 0);
>  		}
>  
>  		/* Hold the PHY in RESET for enough time till DIR is high */
> @@ -906,11 +906,11 @@ static int usbhs_enable(struct device *dev)
>  
>  		if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[0]))
>  			gpio_set_value
> -				(pdata->ehci_data->reset_gpio_port[0], 0);
> +				(pdata->ehci_data->reset_gpio_port[0], 1);
>  
>  		if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1]))
>  			gpio_set_value
> -				(pdata->ehci_data->reset_gpio_port[1], 0);
> +				(pdata->ehci_data->reset_gpio_port[1], 1);
>  	}
>  
>  end_count:
> -- 
> 1.7.0.4
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [PATCH] Fixed gpio polarity of gpio USB-phy reset.
@ 2011-04-14  8:56   ` Samuel Ortiz
  0 siblings, 0 replies; 13+ messages in thread
From: Samuel Ortiz @ 2011-04-14  8:56 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Juergen,

On Thu, Apr 14, 2011 at 09:31:43AM +0200, Juergen Kilb wrote:
> With commit 19403165 a main part of ehci-omap.c moved to
> drivers/mfd/omap-usb-host.c created by commit 17cdd29d.
> Due to this reorganisation the polarity used to reset the
> external USB phy changed and USB host doesn't recognize
> any devices.
If that fix is correct, it looks like it should make its way to 2.6.39.
Felipe, are you ok with this fix ?

Cheers,
Samuel.

> Signed-off-by: Juergen Kilb <J.Kilb@phytec.de>
> ---
>  drivers/mfd/omap-usb-host.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index 53450f4..491cac5 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -719,14 +719,14 @@ static int usbhs_enable(struct device *dev)
>  			gpio_request(pdata->ehci_data->reset_gpio_port[0],
>  						"USB1 PHY reset");
>  			gpio_direction_output
> -				(pdata->ehci_data->reset_gpio_port[0], 1);
> +				(pdata->ehci_data->reset_gpio_port[0], 0);
>  		}
>  
>  		if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1])) {
>  			gpio_request(pdata->ehci_data->reset_gpio_port[1],
>  						"USB2 PHY reset");
>  			gpio_direction_output
> -				(pdata->ehci_data->reset_gpio_port[1], 1);
> +				(pdata->ehci_data->reset_gpio_port[1], 0);
>  		}
>  
>  		/* Hold the PHY in RESET for enough time till DIR is high */
> @@ -906,11 +906,11 @@ static int usbhs_enable(struct device *dev)
>  
>  		if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[0]))
>  			gpio_set_value
> -				(pdata->ehci_data->reset_gpio_port[0], 0);
> +				(pdata->ehci_data->reset_gpio_port[0], 1);
>  
>  		if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1]))
>  			gpio_set_value
> -				(pdata->ehci_data->reset_gpio_port[1], 0);
> +				(pdata->ehci_data->reset_gpio_port[1], 1);
>  	}
>  
>  end_count:
> -- 
> 1.7.0.4
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] Fixed gpio polarity of gpio USB-phy reset.
  2011-04-14  7:31 ` Juergen Kilb
@ 2011-04-14 10:32   ` Felipe Balbi
  -1 siblings, 0 replies; 13+ messages in thread
From: Felipe Balbi @ 2011-04-14 10:32 UTC (permalink / raw)
  To: Juergen Kilb
  Cc: linux-arm-kernel, dbrownell, balbi, gregkh, linux-usb,
	linux-omap, linux-kernel, sameo

On Thu, Apr 14, 2011 at 09:31:43AM +0200, Juergen Kilb wrote:
> With commit 19403165 a main part of ehci-omap.c moved to
> drivers/mfd/omap-usb-host.c created by commit 17cdd29d.
> Due to this reorganisation the polarity used to reset the
> external USB phy changed and USB host doesn't recognize
> any devices.
> 
> Signed-off-by: Juergen Kilb <J.Kilb@phytec.de>

Judging by how ehci-omap.c was before moving the code:

Acked-by: Felipe Balbi <balbi@ti.com>

-- 
balbi

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [PATCH] Fixed gpio polarity of gpio USB-phy reset.
@ 2011-04-14 10:32   ` Felipe Balbi
  0 siblings, 0 replies; 13+ messages in thread
From: Felipe Balbi @ 2011-04-14 10:32 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Apr 14, 2011 at 09:31:43AM +0200, Juergen Kilb wrote:
> With commit 19403165 a main part of ehci-omap.c moved to
> drivers/mfd/omap-usb-host.c created by commit 17cdd29d.
> Due to this reorganisation the polarity used to reset the
> external USB phy changed and USB host doesn't recognize
> any devices.
> 
> Signed-off-by: Juergen Kilb <J.Kilb@phytec.de>

Judging by how ehci-omap.c was before moving the code:

Acked-by: Felipe Balbi <balbi@ti.com>

-- 
balbi

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] Fixed gpio polarity of gpio USB-phy reset.
  2011-04-14  7:31 ` Juergen Kilb
@ 2011-04-14 11:02   ` Sergei Shtylyov
  -1 siblings, 0 replies; 13+ messages in thread
From: Sergei Shtylyov @ 2011-04-14 11:02 UTC (permalink / raw)
  To: Juergen Kilb
  Cc: linux-arm-kernel, dbrownell, balbi, gregkh, linux-usb,
	linux-omap, linux-kernel, sameo

Hello.

On 14-04-2011 11:31, Juergen Kilb wrote:

> With commit 19403165 a main part of ehci-omap.c moved to
> drivers/mfd/omap-usb-host.c created by commit 17cdd29d.

    Pelase also specify the summaries of those commits -- for the human readers.

> Due to this reorganisation the polarity used to reset the
> external USB phy changed and USB host doesn't recognize
> any devices.

> Signed-off-by: Juergen Kilb <J.Kilb@phytec.de>

WBR, Sergei

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [PATCH] Fixed gpio polarity of gpio USB-phy reset.
@ 2011-04-14 11:02   ` Sergei Shtylyov
  0 siblings, 0 replies; 13+ messages in thread
From: Sergei Shtylyov @ 2011-04-14 11:02 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 14-04-2011 11:31, Juergen Kilb wrote:

> With commit 19403165 a main part of ehci-omap.c moved to
> drivers/mfd/omap-usb-host.c created by commit 17cdd29d.

    Pelase also specify the summaries of those commits -- for the human readers.

> Due to this reorganisation the polarity used to reset the
> external USB phy changed and USB host doesn't recognize
> any devices.

> Signed-off-by: Juergen Kilb <J.Kilb@phytec.de>

WBR, Sergei

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] Fixed gpio polarity of gpio USB-phy reset.
  2011-04-14 10:32   ` Felipe Balbi
@ 2011-04-15 13:17     ` Steve Sakoman
  -1 siblings, 0 replies; 13+ messages in thread
From: Steve Sakoman @ 2011-04-15 13:17 UTC (permalink / raw)
  To: balbi
  Cc: Juergen Kilb, linux-arm-kernel, gregkh, linux-usb, linux-omap,
	linux-kernel, sameo

On Thu, Apr 14, 2011 at 3:32 AM, Felipe Balbi <balbi@ti.com> wrote:
> On Thu, Apr 14, 2011 at 09:31:43AM +0200, Juergen Kilb wrote:
>> With commit 19403165 a main part of ehci-omap.c moved to
>> drivers/mfd/omap-usb-host.c created by commit 17cdd29d.
>> Due to this reorganisation the polarity used to reset the
>> external USB phy changed and USB host doesn't recognize
>> any devices.
>>
>> Signed-off-by: Juergen Kilb <J.Kilb@phytec.de>
>
> Judging by how ehci-omap.c was before moving the code:
>
> Acked-by: Felipe Balbi <balbi@ti.com>

This fixes the issue on Overo:

Tested-by: Steve Sakoman <steve@sakoman.com>

Steve

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [PATCH] Fixed gpio polarity of gpio USB-phy reset.
@ 2011-04-15 13:17     ` Steve Sakoman
  0 siblings, 0 replies; 13+ messages in thread
From: Steve Sakoman @ 2011-04-15 13:17 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Apr 14, 2011 at 3:32 AM, Felipe Balbi <balbi@ti.com> wrote:
> On Thu, Apr 14, 2011 at 09:31:43AM +0200, Juergen Kilb wrote:
>> With commit 19403165 a main part of ehci-omap.c moved to
>> drivers/mfd/omap-usb-host.c created by commit 17cdd29d.
>> Due to this reorganisation the polarity used to reset the
>> external USB phy changed and USB host doesn't recognize
>> any devices.
>>
>> Signed-off-by: Juergen Kilb <J.Kilb@phytec.de>
>
> Judging by how ehci-omap.c was before moving the code:
>
> Acked-by: Felipe Balbi <balbi@ti.com>

This fixes the issue on Overo:

Tested-by: Steve Sakoman <steve@sakoman.com>

Steve

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] Fixed gpio polarity of gpio USB-phy reset.
  2011-04-14  7:31 ` Juergen Kilb
@ 2011-04-18  8:55   ` Samuel Ortiz
  -1 siblings, 0 replies; 13+ messages in thread
From: Samuel Ortiz @ 2011-04-18  8:55 UTC (permalink / raw)
  To: Juergen Kilb
  Cc: linux-arm-kernel, dbrownell, balbi, gregkh, linux-usb,
	linux-omap, linux-kernel

Hi Juergen,

On Thu, Apr 14, 2011 at 09:31:43AM +0200, Juergen Kilb wrote:
> With commit 19403165 a main part of ehci-omap.c moved to
> drivers/mfd/omap-usb-host.c created by commit 17cdd29d.
> Due to this reorganisation the polarity used to reset the
> external USB phy changed and USB host doesn't recognize
> any devices.
Patch applied to my for-linus branch, thanks a lot.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [PATCH] Fixed gpio polarity of gpio USB-phy reset.
@ 2011-04-18  8:55   ` Samuel Ortiz
  0 siblings, 0 replies; 13+ messages in thread
From: Samuel Ortiz @ 2011-04-18  8:55 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Juergen,

On Thu, Apr 14, 2011 at 09:31:43AM +0200, Juergen Kilb wrote:
> With commit 19403165 a main part of ehci-omap.c moved to
> drivers/mfd/omap-usb-host.c created by commit 17cdd29d.
> Due to this reorganisation the polarity used to reset the
> external USB phy changed and USB host doesn't recognize
> any devices.
Patch applied to my for-linus branch, thanks a lot.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2011-04-18  8:56 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-14  7:31 [PATCH] Fixed gpio polarity of gpio USB-phy reset Juergen Kilb
2011-04-14  7:31 ` Juergen Kilb
2011-04-14  8:56 ` Samuel Ortiz
2011-04-14  8:56   ` Samuel Ortiz
2011-04-14  8:56   ` Samuel Ortiz
2011-04-14 10:32 ` Felipe Balbi
2011-04-14 10:32   ` Felipe Balbi
2011-04-15 13:17   ` Steve Sakoman
2011-04-15 13:17     ` Steve Sakoman
2011-04-14 11:02 ` Sergei Shtylyov
2011-04-14 11:02   ` Sergei Shtylyov
2011-04-18  8:55 ` Samuel Ortiz
2011-04-18  8:55   ` Samuel Ortiz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.