* [PATCH 0/7] sparc32,leon: additional genirq patches
@ 2011-04-19 16:06 Daniel Hellstrom
2011-04-20 5:42 ` David Miller
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: Daniel Hellstrom @ 2011-04-19 16:06 UTC (permalink / raw)
To: sparclinux
Hello Dave,
All the changes in this patch set [1..7] must be applied on top
of Sam genirq patch. The are all LEON specific.
They add:
* mask/unmask spinlock protection
* Support for LEON Extended IRQ controller
* Use new genirq layer for per-cpu Timer ISR (cleanup)
* other cleanups
* add support for CPU affinity
Daniel Hellstrom
arch/sparc/include/asm/leon.h | 37 +----
arch/sparc/kernel/entry.S | 16 --
arch/sparc/kernel/leon_kernel.c | 318
++++++++++++++++++++++++---------------
arch/sparc/kernel/leon_smp.c | 12 +-
4 files changed, 207 insertions(+), 176 deletions(-)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/7] sparc32,leon: additional genirq patches
2011-04-19 16:06 [PATCH 0/7] sparc32,leon: additional genirq patches Daniel Hellstrom
@ 2011-04-20 5:42 ` David Miller
2011-04-20 9:49 ` Daniel Hellstrom
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2011-04-20 5:42 UTC (permalink / raw)
To: sparclinux
From: Daniel Hellstrom <daniel@gaisler.com>
Date: Tue, 19 Apr 2011 18:06:12 +0200
> Hello Dave,
>
> All the changes in this patch set [1..7] must be applied on top
> of Sam genirq patch. The are all LEON specific.
>
> They add:
> * mask/unmask spinlock protection
> * Support for LEON Extended IRQ controller
> * Use new genirq layer for per-cpu Timer ISR (cleanup)
> * other cleanups
> * add support for CPU affinity
>
> Daniel Hellstrom
Hey Daniel, could you please address Sam's feedback on a few patches
and then resubmit this? You can integrate the ACK's he gave for
some of the patches when you do that.
Thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/7] sparc32,leon: additional genirq patches
2011-04-19 16:06 [PATCH 0/7] sparc32,leon: additional genirq patches Daniel Hellstrom
2011-04-20 5:42 ` David Miller
@ 2011-04-20 9:49 ` Daniel Hellstrom
2011-04-20 11:23 ` Daniel Hellstrom
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Daniel Hellstrom @ 2011-04-20 9:49 UTC (permalink / raw)
To: sparclinux
David Miller wrote:
>From: Daniel Hellstrom <daniel@gaisler.com>
>Date: Tue, 19 Apr 2011 18:06:12 +0200
>
>
>
>>Hello Dave,
>>
>>All the changes in this patch set [1..7] must be applied on top
>>of Sam genirq patch. The are all LEON specific.
>>
>>They add:
>>* mask/unmask spinlock protection
>>* Support for LEON Extended IRQ controller
>>* Use new genirq layer for per-cpu Timer ISR (cleanup)
>>* other cleanups
>>* add support for CPU affinity
>>
>>Daniel Hellstrom
>>
>>
>
>Hey Daniel, could you please address Sam's feedback on a few patches
>and then resubmit this? You can integrate the ACK's he gave for
>some of the patches when you do that.
>
>
It became a bit more messy than my intension... I have added Sam's
boot_cpu_id patch in front of my patches, and previous patch 6 (now 7)
has been swapped with previous patch 7 (now 8). I have added Sam's ACK.
The previous patch 6 which I was supposed to drop have now been cleaned
up using Sam's boot_cpu_id instead of a LEON specific variable
leon3_boot_cpu.
Thanks,
Daniel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/7] sparc32,leon: additional genirq patches
2011-04-19 16:06 [PATCH 0/7] sparc32,leon: additional genirq patches Daniel Hellstrom
2011-04-20 5:42 ` David Miller
2011-04-20 9:49 ` Daniel Hellstrom
@ 2011-04-20 11:23 ` Daniel Hellstrom
2011-04-20 12:58 ` Sam Ravnborg
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Daniel Hellstrom @ 2011-04-20 11:23 UTC (permalink / raw)
To: sparclinux
Daniel Hellstrom wrote:
> David Miller wrote:
>
>> From: Daniel Hellstrom <daniel@gaisler.com>
>> Date: Tue, 19 Apr 2011 18:06:12 +0200
>>
>>
>>
>>> Hello Dave,
>>>
>>> All the changes in this patch set [1..7] must be applied on top
>>> of Sam genirq patch. The are all LEON specific.
>>>
>>> They add:
>>> * mask/unmask spinlock protection
>>> * Support for LEON Extended IRQ controller
>>> * Use new genirq layer for per-cpu Timer ISR (cleanup)
>>> * other cleanups
>>> * add support for CPU affinity
>>>
>>> Daniel Hellstrom
>>>
>>
>>
>> Hey Daniel, could you please address Sam's feedback on a few patches
>> and then resubmit this? You can integrate the ACK's he gave for
>> some of the patches when you do that.
>>
>>
> It became a bit more messy than my intension... I have added Sam's
> boot_cpu_id patch in front of my patches, and previous patch 6 (now 7)
> has been swapped with previous patch 7 (now 8). I have added Sam's
> ACK. The previous patch 6 which I was supposed to drop have now been
> cleaned up using Sam's boot_cpu_id instead of a LEON specific variable
> leon3_boot_cpu.
I'm sorry to mess up stuff even more, the patches 1 and 8 in my series
does not compile on UP since setup.h isn't included. But even worse is
that the boot_cpu_id is always 0 it seems because it is initialized
before BSS is cleared, and boot_cpu_id is part of BSS.
Please apply patches [2/8]..[7/8], and drop [1/8] and [8/8]. It is
better we do it the way you proposed (drop boot_cpu patch). I'm sorry
that I ever brought up the boot_cpu_id stuff, as that had nothing to do
with the genirq patches, and I'm sorry for taking your time like this.
Daniel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/7] sparc32,leon: additional genirq patches
2011-04-19 16:06 [PATCH 0/7] sparc32,leon: additional genirq patches Daniel Hellstrom
` (2 preceding siblings ...)
2011-04-20 11:23 ` Daniel Hellstrom
@ 2011-04-20 12:58 ` Sam Ravnborg
2011-04-21 18:09 ` David Miller
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Sam Ravnborg @ 2011-04-20 12:58 UTC (permalink / raw)
To: sparclinux
>
> I'm sorry to mess up stuff even more, the patches 1 and 8 in my series
> does not compile on UP since setup.h isn't included. But even worse is
> that the boot_cpu_id is always 0 it seems because it is initialized
> before BSS is cleared, and boot_cpu_id is part of BSS.
>
> Please apply patches [2/8]..[7/8], and drop [1/8] and [8/8]. It is
> better we do it the way you proposed (drop boot_cpu patch). I'm sorry
> that I ever brought up the boot_cpu_id stuff, as that had nothing to do
> with the genirq patches, and I'm sorry for taking your time like this.
I agree. Lets get the genirq related stuff in and fix the boot_cpu_id stuff
properly later.
Added to my TODO list.
The issue with boot_cpu_id being cleared is btw not new - but
I should have caught that anyway.
Sam
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/7] sparc32,leon: additional genirq patches
2011-04-19 16:06 [PATCH 0/7] sparc32,leon: additional genirq patches Daniel Hellstrom
` (3 preceding siblings ...)
2011-04-20 12:58 ` Sam Ravnborg
@ 2011-04-21 18:09 ` David Miller
2011-04-21 18:46 ` daniel
2011-04-21 22:31 ` David Miller
6 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2011-04-21 18:09 UTC (permalink / raw)
To: sparclinux
From: Sam Ravnborg <sam@ravnborg.org>
Date: Wed, 20 Apr 2011 14:58:53 +0200
> The issue with boot_cpu_id being cleared is btw not new - but
> I should have caught that anyway.
It's partially another side effect of that awful behavioral change GCC
made several years ago to "auto BSS" variables explicitly initialized
to zero.
You used to be able to add an explicit zero initialization to force
items into the data section.
This change has broken various things in the sparc32 port over the
years.
Probably the thing to do is to initialize boot_cpu_id{,4} to some
"invalid" value (like 0xff) in the kernel image and just make certain
the the initialization happens early enough.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/7] sparc32,leon: additional genirq patches
2011-04-19 16:06 [PATCH 0/7] sparc32,leon: additional genirq patches Daniel Hellstrom
` (4 preceding siblings ...)
2011-04-21 18:09 ` David Miller
@ 2011-04-21 18:46 ` daniel
2011-04-21 22:31 ` David Miller
6 siblings, 0 replies; 8+ messages in thread
From: daniel @ 2011-04-21 18:46 UTC (permalink / raw)
To: sparclinux
On Thu, 21 Apr 2011 11:09:23 -0700 (PDT), David Miller wrote:
From: Sam Ravnborg <sam@ravnborg.org>
> Date: Wed, 20 Apr 2011 14:58:53 +0200
>
> > The issue with boot_cpu_id being cleared is btw not new - but
> > I should have caught that anyway.
>
> It's partially another side effect of that awful behavioral change GCC
> made several years ago to "auto BSS" variables explicitly initialized
> to zero.
>
> You used to be able to add an explicit zero initialization to force
> items into the data section.
Yeah, ridiculous that change is, one could always use attribute section
to force it into DATA but that is kind of complicated. I always thought
I was stupid but now I know that the compiler changed its behaviour...
thanks. Another problem is that "cleanup people" does not know of this
and erase that only hint.
>
> This change has broken various things in the sparc32 port over the
> years.
>
> Probably the thing to do is to initialize boot_cpu_id{,4} to some
> "invalid" value (like 0xff) in the kernel image and just make certain
> the the initialization happens early enough.
That is basically what I've done in the next "[1..3] sparc32:
boot_cpu_id patches".
Daniel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/7] sparc32,leon: additional genirq patches
2011-04-19 16:06 [PATCH 0/7] sparc32,leon: additional genirq patches Daniel Hellstrom
` (5 preceding siblings ...)
2011-04-21 18:46 ` daniel
@ 2011-04-21 22:31 ` David Miller
6 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2011-04-21 22:31 UTC (permalink / raw)
To: sparclinux
From: Daniel Hellstrom <daniel@gaisler.com>
Date: Wed, 20 Apr 2011 13:23:00 +0200
> Please apply patches [2/8]..[7/8], and drop [1/8] and [8/8].
Done.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-04-21 22:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-19 16:06 [PATCH 0/7] sparc32,leon: additional genirq patches Daniel Hellstrom
2011-04-20 5:42 ` David Miller
2011-04-20 9:49 ` Daniel Hellstrom
2011-04-20 11:23 ` Daniel Hellstrom
2011-04-20 12:58 ` Sam Ravnborg
2011-04-21 18:09 ` David Miller
2011-04-21 18:46 ` daniel
2011-04-21 22:31 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.