From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Joe Perches <joe@perches.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Greg KH <gregkh@linuxfoundation.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
devel@driverdev.osuosl.org, daniel.baluta@gmail.com,
Himanshi Jain <himshijain.hj@gmail.com>,
Michael.Hennerich@analog.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, nick.desaulniers@gmail.com,
outreachy-kernel@googlegroups.com, pmeerw@pmeerw.net,
knaack.h@gmx.de, Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v2 1/2] include: linux: sysfs: Add __ATTR_NAMED macro
Date: Wed, 13 Sep 2017 16:16:51 -0700 [thread overview]
Message-ID: <4DB672D4-AE6E-4CFF-8566-F62BFBAB62AB@jic23.retrosnub.co.uk> (raw)
In-Reply-To: <1505339903.8969.20.camel@perches.com>
On 13 September 2017 14:58:23 GMT-07:00, Joe Perches <joe@perches.com> wrote:
>On Thu, 2017-09-14 at 00:43 +0300, Dan Carpenter wrote:
>> He was exagerating a bit to call it a "static checker" warning...
>
>Not really.
>
>False positives and false negatives exist in just about
>every static
>checker.
>
>> It's just checkpatch.pl complaining about adding spaces around the -
>> operator.
>
>checkpatch is a brain-damaged by design static checker.
>regexes can only be sensitive to patterns, not compiled code.
>
>> The sysfs file has a hyphen in the middle.
>
>Another option would be to use an underscore instead.
Userspace ABI plus it really does mean subtract. Used in description of differential channels.
Most such IIO ABI is generated by the IIO core, this just comes up with corner cases of the ABI.
Jonathan
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Joe Perches <joe@perches.com>,Dan Carpenter
<dan.carpenter@oracle.com>,Greg KH <gregkh@linuxfoundation.org>
Cc: Lars-Peter Clausen
<lars@metafoo.de>,devel@driverdev.osuosl.org,daniel.baluta@gmail.com,Himanshi
Jain
<himshijain.hj@gmail.com>,Michael.Hennerich@analog.com,linux-iio@vger.kernel.org,linux-kernel@vger.kernel.org,nick.desaulniers@gmail.com,outreachy-kernel@googlegroups.com,pmeerw@pmeerw.net,knaack.h@gmx.de,Jonathan
Cameron <jic23@kernel.org>
Subject: Re: [PATCH v2 1/2] include: linux: sysfs: Add __ATTR_NAMED macro
Date: Wed, 13 Sep 2017 16:16:51 -0700 [thread overview]
Message-ID: <4DB672D4-AE6E-4CFF-8566-F62BFBAB62AB@jic23.retrosnub.co.uk> (raw)
In-Reply-To: <1505339903.8969.20.camel@perches.com>
On 13 September 2017 14:58:23 GMT-07:00, Joe Perches <joe@perches=2Ecom> w=
rote:
>On Thu, 2017-09-14 at 00:43 +0300, Dan Carpenter wrote:
>> He was exagerating a bit to call it a "static checker" warning=2E=2E=2E
>
>Not really=2E
>
>False positives and false negatives exist in just about
>every static
>checker=2E
>
>> It's just checkpatch=2Epl complaining about adding spaces around the -
>> operator=2E
>
>checkpatch is a brain-damaged by design static checker=2E
>regexes can only be sensitive to patterns, not compiled code=2E
>
>> The sysfs file has a hyphen in the middle=2E
>
>Another option would be to use an underscore instead=2E
Userspace ABI plus it really does mean subtract=2E Used in description of=
differential channels=2E
Most such IIO ABI is generated by the IIO core, this just comes up with co=
rner cases of the ABI=2E
Jonathan
--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Joe Perches <joe@perches.com>,Dan Carpenter
<dan.carpenter@oracle.com>,Greg KH <gregkh@linuxfoundation.org>
Cc: Lars-Peter Clausen
<lars@metafoo.de>,devel@driverdev.osuosl.org,daniel.baluta@gmail.com,Himanshi
Jain
<himshijain.hj@gmail.com>,Michael.Hennerich@analog.com,linux-iio@vger.kernel.org,linux-kernel@vger.kernel.org,nick.desaulniers@gmail.com,outreachy-kernel@googlegroups.com,pmeerw@pmeerw.net,knaack.h@gmx.de,Jonathan
Cameron <jic23@kernel.org>
Subject: Re: [PATCH v2 1/2] include: linux: sysfs: Add __ATTR_NAMED macro
Date: Wed, 13 Sep 2017 16:16:51 -0700 [thread overview]
Message-ID: <4DB672D4-AE6E-4CFF-8566-F62BFBAB62AB@jic23.retrosnub.co.uk> (raw)
In-Reply-To: <1505339903.8969.20.camel@perches.com>
On 13 September 2017 14:58:23 GMT-07:00, Joe Perches <joe@perches.com> wrote:
>On Thu, 2017-09-14 at 00:43 +0300, Dan Carpenter wrote:
>> He was exagerating a bit to call it a "static checker" warning...
>
>Not really.
>
>False positives and false negatives exist in just about
>every static
>checker.
>
>> It's just checkpatch.pl complaining about adding spaces around the -
>> operator.
>
>checkpatch is a brain-damaged by design static checker.
>regexes can only be sensitive to patterns, not compiled code.
>
>> The sysfs file has a hyphen in the middle.
>
>Another option would be to use an underscore instead.
Userspace ABI plus it really does mean subtract. Used in description of differential channels.
Most such IIO ABI is generated by the IIO core, this just comes up with corner cases of the ABI.
Jonathan
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
next prev parent reply other threads:[~2017-09-13 23:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 8:42 [PATCH v2 0/2] Rewrite the IIO_DEVICE_ATTR_NAMED API to pass name as string Himanshi Jain
2017-09-13 8:55 ` Himanshi Jain
2017-09-13 8:44 ` [PATCH v2 1/2] include: linux: sysfs: Add __ATTR_NAMED macro Himanshi Jain
2017-09-13 8:44 ` [PATCH v2 2/2] iio: Change to __ATTR_NAMED() Himanshi Jain
2017-09-13 17:03 ` [PATCH v2 1/2] include: linux: sysfs: Add __ATTR_NAMED macro Jonathan Cameron
2017-09-13 18:58 ` Greg KH
2017-09-13 19:23 ` Lars-Peter Clausen
2017-09-13 20:50 ` Jonathan Cameron
2017-09-13 20:50 ` Jonathan Cameron
2017-09-18 10:49 ` Himanshi Jain
2017-09-21 13:54 ` Jonathan Cameron
2017-09-21 14:07 ` [Outreachy kernel] " Julia Lawall
2017-09-21 14:07 ` Julia Lawall
2017-09-13 21:29 ` Greg KH
2017-09-13 21:43 ` Dan Carpenter
2017-09-13 21:58 ` Joe Perches
2017-09-13 23:16 ` Jonathan Cameron [this message]
2017-09-13 23:16 ` Jonathan Cameron
2017-09-13 23:16 ` Jonathan Cameron
2017-09-14 5:10 ` [Outreachy kernel] " Julia Lawall
2017-09-19 12:13 ` Lars-Peter Clausen
2017-09-13 8:46 ` [Outreachy kernel] [PATCH v2 0/2] Rewrite the IIO_DEVICE_ATTR_NAMED API to pass name as string Julia Lawall
2017-09-13 17:04 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB672D4-AE6E-4CFF-8566-F62BFBAB62AB@jic23.retrosnub.co.uk \
--to=jic23@jic23.retrosnub.co.uk \
--cc=Michael.Hennerich@analog.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel.baluta@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=himshijain.hj@gmail.com \
--cc=jic23@kernel.org \
--cc=joe@perches.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick.desaulniers@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.