From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: "Serge E. Hallyn" <serge@hallyn.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, andreas.niederl@iaik.tugraz.at
Subject: Re: [Qemu-devel] [PATCH V4 00/10] Qemu Trusted Platform Module (TPM) integration
Date: Tue, 10 May 2011 08:43:07 -0400 [thread overview]
Message-ID: <4DC932DB.2080000@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110510115935.GA3541@mail.hallyn.com>
On 05/10/2011 07:59 AM, Serge E. Hallyn wrote:
> Quoting Stefan Berger (stefanb@linux.vnet.ibm.com):
>> On 05/10/2011 12:07 AM, Serge E. Hallyn wrote:
>>> To get this to compile on top of qemu-kvm, I needed the following
>>> patch to force CONFIG_THREAD on so as to define things like
>>> qemu_mutex_lock:
>>>
>>> Index: qemu-kvm-tpm/configure
>>> ===================================================================
>>> --- qemu-kvm-tpm.orig/configure 2011-05-09 21:19:10.920002303 -0500
>>> +++ qemu-kvm-tpm/configure 2011-05-09 21:19:22.150002305 -0500
>>> @@ -3420,6 +3420,7 @@
>>> exit 1
>>> fi
>>> echo "CONFIG_TPM=y">> $config_host_mak
>>> + echo "CONFIG_THREAD=y">> $config_host_mak
>>> fi
>>> fi
>>>
>> That seems to be qemu-kvm specific.
> Hm, yeah, I guess it is. Wonder what the odds are of that actually
> working then. Well, I've just about got this and libtpms packaged,
> will hopefully finish up this afternoon and see.
>
> I saw nothing problematic in the patches, but just didn't feel
> qualified to send acks based on simple review, so figured I'd be
> better off actually testing.
>
I am currently making modifications to the patches to support command
lines like this one to be in line with other devices:
-tpm type=builtin,path=<path>,id=xyz -device tpm_tis,id=xyz
Typically with command lines like this Qemu also supports multiple
devices of the same type. With the TPM this is a bit problematic since
it would need to support multiple TPMs also in the firmware (aka BIOS).
So I may support this command line but only allow one TPM.
> What is your plan regarding libtpms? Will you be making actual
> releases at sf.net at some point?
I was going to wait for a review of all the patches here on the ml and
see the code checked in -- until that hasn't happened anything could
change. So for now I am keeping libtpms in Fedora Rawhide and then was
going to produce a libtpms-0.5.2 and make it commonly available via
Fedora, maybe putting a copy of the library on sf.net. I would hold off
on packaging and distributing it.
Stefan
next prev parent reply other threads:[~2011-05-10 12:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 17:32 [Qemu-devel] [PATCH V4 00/10] Qemu Trusted Platform Module (TPM) integration Stefan Berger
2011-05-06 17:32 ` [Qemu-devel] [PATCH V4 01/10] Support for TPM command line options Stefan Berger
2011-05-06 20:23 ` Serge E. Hallyn
2011-05-06 20:32 ` Stefan Berger
2011-05-06 20:33 ` Serge E. Hallyn
2011-05-17 20:58 ` Serge E. Hallyn
2011-05-17 23:15 ` Stefan Berger
2011-05-18 1:52 ` Serge E. Hallyn
2011-05-17 23:16 ` Stefan Berger
2011-05-06 17:32 ` [Qemu-devel] [PATCH V4 02/10] Add TPM (frontend) hardware interface (TPM TIS) to Qemu Stefan Berger
2011-05-07 1:54 ` Serge E. Hallyn
2011-05-18 7:23 ` Markus Armbruster
2011-05-18 10:53 ` Stefan Berger
2011-05-06 17:32 ` [Qemu-devel] [PATCH V4 03/10] Add persistent state handling to TPM TIS frontend driver Stefan Berger
2011-05-18 7:25 ` Markus Armbruster
2011-05-18 10:51 ` Stefan Berger
2011-05-25 14:49 ` Stefan Berger
2011-05-06 17:32 ` [Qemu-devel] [PATCH V4 04/10] Add tpm_tis driver to build process Stefan Berger
2011-05-06 17:32 ` [Qemu-devel] [PATCH V4 05/10] Add a debug register Stefan Berger
2011-05-06 17:32 ` [Qemu-devel] [PATCH V4 06/10] Add a TPM backend skeleton implementation Stefan Berger
2011-05-06 17:32 ` [Qemu-devel] [PATCH V4 07/10] Implementation of the libtpms-based backend Stefan Berger
2011-05-06 17:32 ` [Qemu-devel] [PATCH V4 08/10] Introduce file lock for the block layer Stefan Berger
2011-05-06 17:32 ` [Qemu-devel] [PATCH V4 09/10] Add block storage support for libtpms based TPM backend Stefan Berger
2011-05-06 17:32 ` [Qemu-devel] [PATCH V4 10/10] Encrypt state blobs using AES CBC encryption Stefan Berger
2011-05-09 14:21 ` [Qemu-devel] [PATCH V4 00/10] Qemu Trusted Platform Module (TPM) integration Serge E. Hallyn
2011-05-09 17:37 ` Stefan Berger
2011-05-10 4:07 ` Serge E. Hallyn
2011-05-10 10:46 ` Stefan Berger
2011-05-10 11:59 ` Serge E. Hallyn
2011-05-10 12:43 ` Stefan Berger [this message]
2011-05-10 14:20 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC932DB.2080000@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=andreas.niederl@iaik.tugraz.at \
--cc=qemu-devel@nongnu.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.