* [U-Boot] AT91: CFI support broken
@ 2011-05-20 10:51 esw at bus-elektronik.de
2011-05-20 11:54 ` Reinhard Meyer
0 siblings, 1 reply; 5+ messages in thread
From: esw at bus-elektronik.de @ 2011-05-20 10:51 UTC (permalink / raw)
To: u-boot
Hello,
since "AT91: fix timer.c - remove reset_timer()"
<http://git.denx.de/?p=u-boot/u-boot-atmel.git;a=commit;h=cfff263f41e32c7ba2ee9162a8cc6423eb5a8390>
was commited the arm926ejs/at91 boards can't compile with cfi_flash support:
u-boot/drivers/mtd/cfi_flash.c:576: undefined reference to `reset_timer'
I think this patch should be revert, as long as other modules need the
reset_timer function.
Can anybody confirm this
Thanks
Jens Scharsig
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] AT91: CFI support broken
2011-05-20 10:51 [U-Boot] AT91: CFI support broken esw at bus-elektronik.de
@ 2011-05-20 11:54 ` Reinhard Meyer
2011-05-20 13:01 ` Jens Scharsig
0 siblings, 1 reply; 5+ messages in thread
From: Reinhard Meyer @ 2011-05-20 11:54 UTC (permalink / raw)
To: u-boot
Dear esw at bus-elektronik.de,
> Hello,
>
> since "AT91: fix timer.c - remove reset_timer()"
>
> <http://git.denx.de/?p=u-boot/u-boot-atmel.git;a=commit;h=cfff263f41e32c7ba2ee9162a8cc6423eb5a8390>
>
> was commited the arm926ejs/at91 boards can't compile with cfi_flash support:
>
> u-boot/drivers/mtd/cfi_flash.c:576: undefined reference to `reset_timer'
>
> I think this patch should be revert, as long as other modules need the
> reset_timer function.
>
> Can anybody confirm this
I think we should fix the place where reset_timer() is still used, to use get_timer() only.
All other drivers that are used in atmel context do not use reset_timer(), but rely on the fact
that get_timer() is monotonic. reset_timer() resets the value back to zero.
Best Regards,
Reinhard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] AT91: CFI support broken
2011-05-20 11:54 ` Reinhard Meyer
@ 2011-05-20 13:01 ` Jens Scharsig
2011-05-23 7:19 ` Stefan Roese
0 siblings, 1 reply; 5+ messages in thread
From: Jens Scharsig @ 2011-05-20 13:01 UTC (permalink / raw)
To: u-boot
Hello Stefan Roese,
>> Hello,
>>
>> since "AT91: fix timer.c - remove reset_timer()"
>>
>> <http://git.denx.de/?p=u-boot/u-boot-atmel.git;a=commit;h=cfff263f41e32c7ba2ee9162a8cc6423eb5a8390>
>>
>> was commited the arm926ejs/at91 boards can't compile with cfi_flash support:
>>
>> u-boot/drivers/mtd/cfi_flash.c:576: undefined reference to `reset_timer'
>>
>> I think this patch should be revert, as long as other modules need the
>> reset_timer function.
>>
>> Can anybody confirm this
>
> I think we should fix the place where reset_timer() is still used, to use get_timer() only.
> All other drivers that are used in atmel context do not use reset_timer(), but rely on the fact
> that get_timer() is monotonic. reset_timer() resets the value back to zero.
>
> Best Regards,
> Reinhard
what do you think about?
Best regards
Jens
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] AT91: CFI support broken
2011-05-20 13:01 ` Jens Scharsig
@ 2011-05-23 7:19 ` Stefan Roese
2011-05-23 7:44 ` Graeme Russ
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Roese @ 2011-05-23 7:19 UTC (permalink / raw)
To: u-boot
Hi Jens,
On Friday 20 May 2011 15:01:21 Jens Scharsig wrote:
> >> u-boot/drivers/mtd/cfi_flash.c:576: undefined reference to `reset_timer'
> >>
> >> I think this patch should be revert, as long as other modules need the
> >> reset_timer function.
> >>
> >> Can anybody confirm this
> >
> > I think we should fix the place where reset_timer() is still used, to use
> > get_timer() only. All other drivers that are used in atmel context do
> > not use reset_timer(), but rely on the fact that get_timer() is
> > monotonic. reset_timer() resets the value back to zero.
> >
> > Best Regards,
> > Reinhard
>
> what do you think about?
I would welcome it, if somebody would provide a patch to remove the
reset_timer() call from the common CFI driver.
Best regards,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] AT91: CFI support broken
2011-05-23 7:19 ` Stefan Roese
@ 2011-05-23 7:44 ` Graeme Russ
0 siblings, 0 replies; 5+ messages in thread
From: Graeme Russ @ 2011-05-23 7:44 UTC (permalink / raw)
To: u-boot
On Monday, May 23, 2011, Stefan Roese <sr@denx.de> wrote:
> Hi Jens,
>
> On Friday 20 May 2011 15:01:21 Jens Scharsig wrote:
>> >> u-boot/drivers/mtd/cfi_flash.c:576: undefined reference to `reset_timer'
>> >>
>> >> I think this patch should be revert, as long as other modules need the
>> >> reset_timer function.
>> >>
>> >> Can anybody confirm this
>> >
>> > I think we should fix the place where reset_timer() is still used, to use
>> > get_timer() only. All other drivers that are used in atmel context do
>> > not use reset_timer(), but rely on the fact that get_timer() is
>> > monotonic. reset_timer() resets the value back to zero.
>> >
>> > Best Regards,
>> > Reinhard
>>
>> what do you think about?
>
> I would welcome it, if somebody would provide a patch to remove the
> reset_timer() call from the common CFI driver.
>
Working on it now
Regards,
Graeme
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-05-23 7:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-20 10:51 [U-Boot] AT91: CFI support broken esw at bus-elektronik.de
2011-05-20 11:54 ` Reinhard Meyer
2011-05-20 13:01 ` Jens Scharsig
2011-05-23 7:19 ` Stefan Roese
2011-05-23 7:44 ` Graeme Russ
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.