Re: [tip:tools/kvm] kvm tools: Add conditional compilation of symbol resolving

Re: [tip:tools/kvm] kvm tools: Add conditional compilation of symbol resolving

[Ingo Molnar]

* tip-bot for Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> diff --git a/tools/perf/feature-tests.mak b/tools/kvm/config/feature-tests.mak
> similarity index 83%
> copy from tools/perf/feature-tests.mak
> copy to tools/kvm/config/feature-tests.mak

Btw, now that we have feature-tests.mak it would be nice to populate the checks 
for the various assumptions.

One i recently ran into on a new box where i tried to install tools/kvm was:

In file included from /usr/include/features.h:387:0,
                 from /usr/include/unistd.h:26,
                 from include/kvm/util.h:12,
                 from bios/e820.c:5:
/usr/include/gnu/stubs.h:7:27: fatal error: gnu/stubs-32.h: No such file or directory
compilation terminated.
make: *** [bios/bios-rom.bin] Error 1

that's a dependency on glibc-dev[el].

Thanks,

	Ingo

Re: [tip:tools/kvm] kvm tools: Add conditional compilation of symbol resolving

[Ingo Molnar]

* Ingo Molnar <mingo@elte.hu> wrote:

> 
> * tip-bot for Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> 
> > diff --git a/tools/perf/feature-tests.mak b/tools/kvm/config/feature-tests.mak
> > similarity index 83%
> > copy from tools/perf/feature-tests.mak
> > copy to tools/kvm/config/feature-tests.mak
> 
> Btw, now that we have feature-tests.mak it would be nice to populate the checks 
> for the various assumptions.
> 
> One i recently ran into on a new box where i tried to install tools/kvm was:
> 
> In file included from /usr/include/features.h:387:0,
>                  from /usr/include/unistd.h:26,
>                  from include/kvm/util.h:12,
>                  from bios/e820.c:5:
> /usr/include/gnu/stubs.h:7:27: fatal error: gnu/stubs-32.h: No such file or directory
> compilation terminated.
> make: *** [bios/bios-rom.bin] Error 1
> 
> that's a dependency on glibc-dev[el].

Another detail: on 64-bit hosts the dependency is on gibc-dev[el].i686, i.e. 
the 32-bit package.

Would it be simple to remove this dependency? It's not typically installed by 
default on distros and it would be nice to make most of the kvm code build by 
default almost everywhere.

Thanks,

	Ingo

Re: [tip:tools/kvm] kvm tools: Add conditional compilation of symbol resolving

[Cyrill Gorcunov]

On 05/22/2011 02:58 PM, Ingo Molnar wrote:
> 
> * tip-bot for Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> 
>> diff --git a/tools/perf/feature-tests.mak b/tools/kvm/config/feature-tests.mak
>> similarity index 83%
>> copy from tools/perf/feature-tests.mak
>> copy to tools/kvm/config/feature-tests.mak
> 
> Btw, now that we have feature-tests.mak it would be nice to populate the checks 
> for the various assumptions.
> 
> One i recently ran into on a new box where i tried to install tools/kvm was:
> 
> In file included from /usr/include/features.h:387:0,
>                  from /usr/include/unistd.h:26,
>                  from include/kvm/util.h:12,
>                  from bios/e820.c:5:
> /usr/include/gnu/stubs.h:7:27: fatal error: gnu/stubs-32.h: No such file or directory
> compilation terminated.
> make: *** [bios/bios-rom.bin] Error 1
> 
> that's a dependency on glibc-dev[el].
> 
> Thanks,
> 
> 	Ingo

  Ouch. I've been hitting this lack of gnu/stubs-32.h on Fedora 15 too and eventually
I had to install i686 packages for devel. I'll try to resolve this issue tonight, I
suppose it's not absolutely urgent, right?

-- 
    Cyrill

Re: [tip:tools/kvm] kvm tools: Add conditional compilation of symbol resolving

[Cyrill Gorcunov]

On 05/22/2011 03:00 PM, Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
>>
>> * tip-bot for Cyrill Gorcunov <gorcunov@gmail.com> wrote:
>>
>>> diff --git a/tools/perf/feature-tests.mak b/tools/kvm/config/feature-tests.mak
>>> similarity index 83%
>>> copy from tools/perf/feature-tests.mak
>>> copy to tools/kvm/config/feature-tests.mak
>>
>> Btw, now that we have feature-tests.mak it would be nice to populate the checks 
>> for the various assumptions.
>>
>> One i recently ran into on a new box where i tried to install tools/kvm was:
>>
>> In file included from /usr/include/features.h:387:0,
>>                  from /usr/include/unistd.h:26,
>>                  from include/kvm/util.h:12,
>>                  from bios/e820.c:5:
>> /usr/include/gnu/stubs.h:7:27: fatal error: gnu/stubs-32.h: No such file or directory
>> compilation terminated.
>> make: *** [bios/bios-rom.bin] Error 1
>>
>> that's a dependency on glibc-dev[el].
> 
> Another detail: on 64-bit hosts the dependency is on gibc-dev[el].i686, i.e. 
> the 32-bit package.
> 
> Would it be simple to remove this dependency? It's not typically installed by 
> default on distros and it would be nice to make most of the kvm code build by 
> default almost everywhere.
> 
> Thanks,
> 
> 	Ingo

  I'll take a look if we really need it (note we need to compile 16bit code for
bios blob so it might eventually be a problem ;)

-- 
    Cyrill