Do LSB test unreported issues need fix?

Do LSB test unreported issues need fix?

[Kang Kai]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

Hi Mark,

I meet one test item of LSB core test,

/tset/LSB.fhs/var/lib-hwclock/lib-hwclock-tc 1    unreported

the result is unreported.

We were told that unreported issues don't need to be fixed. Would you 
give us some confirmation?

And this issue will test /var/lib/hwclock/adjtime whether exists,  if 
this issue needs to be fixed could I add it manually just as in 
attachment patch.

Regards,
Kai

[-- Attachment #2: 0001-lsbsetup-add-var-lib-hwclock-adjtime-manually.patch --]
[-- Type: text/x-patch, Size: 1417 bytes --]

From fc887b0afa36845ae044e2f0e5f3c55db30498d0 Mon Sep 17 00:00:00 2001
From: Kang Kai <kai.kang@windriver.com>
Date: Mon, 23 May 2011 18:54:56 +0800
Subject: [PATCH] lsbsetup: add /var/lib/hwclock/adjtime manually

LSB core test will test /var/lib/hwclock/adjtime whether exists,
but no package provides it. So add it manually.

Signed-off-by: Kang Kai <kai.kang@windriver.com>
---
 meta/recipes-extended/lsb/lsbsetup_0.9.bb |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-extended/lsb/lsbsetup_0.9.bb b/meta/recipes-extended/lsb/lsbsetup_0.9.bb
index b0d0a3f..b98bbce 100644
--- a/meta/recipes-extended/lsb/lsbsetup_0.9.bb
+++ b/meta/recipes-extended/lsb/lsbsetup_0.9.bb
@@ -2,7 +2,7 @@ DESCRIPTION = "auto-setup environment for lsb test"
 SECTION = "console/utils"
 PRIORITY = "required"
 LICENSE = "GPLv2"
-PR = "r2"
+PR = "r3"
 
 LIC_FILES_CHKSUM = "file://LSB_Setup.sh;beginline=3;endline=16;md5=97451c7c0786ce5bbe9ac58042945583"
 
@@ -20,4 +20,14 @@ do_install() {
         ln -sf ${base_sbindir}/sendmail ${D}/${libdir}/lsb/sendmail
 }
 
+pkg_postinst_${PN} () {
+        if [ "x$D" = "x" ]; then
+            [ -d /var/lib/hwclock ] || mkdir -p /var/lib/hwclock
+            touch /var/lib/hwclock/adjtime
+        else
+            exit 1
+        fi
+}
+
+
 FILES_${PN} += "${libdir}/lsb"
-- 
1.7.5.1.300.gc565c

Re: Do LSB test unreported issues need fix?

[Mark Hatle]

On 5/23/11 5:57 AM, Kang Kai wrote:
> Hi Mark,
> 
> I meet one test item of LSB core test,
> 
> /tset/LSB.fhs/var/lib-hwclock/lib-hwclock-tc 1    unreported
> 
> the result is unreported.
> 
> We were told that unreported issues don't need to be fixed. Would you 
> give us some confirmation?
> 
> And this issue will test /var/lib/hwclock/adjtime whether exists,  if 
> this issue needs to be fixed could I add it manually just as in 
> attachment patch.

This would be a good one to specifically "note".  And given time, investigate.
However, I would say it does not need to be fixed unless someone comes back and
says "no I think this is a bug".

(In this particular case, if the hwclock doesn't exist on a machine -- or it has
no time adjustment set, I don't believe it's actually required...  but it's good
to know about.)

--Mark

> Regards,
> Kai