* [PATCH 1/2] KVM-test: control: Fix of spliting augments
[not found] <BANLkTikmAAF8AP6-bZakZh7hJdfSC1CF9A@mail.gmail.com>
@ 2011-05-25 2:24 ` Amos Kong
2011-05-25 2:24 ` [PATCH 2/2] KVM-test: kvm_vm.py: Add quotation marks for appended arguments Amos Kong
1 sibling, 0 replies; 4+ messages in thread
From: Amos Kong @ 2011-05-25 2:24 UTC (permalink / raw)
To: autotest; +Cc: lmr, amwang, kvm
../../bin/autotest control --args='only=boot kernel_cmdline="root=/dev/vda ro quite" only=qcow2'
original result:
only boot
kernel_cmdline="root = /dev/vda ro quite"
only qcow2'
new result:
only boot
kernel_cmdline="root=/dev/vda ro quite"
only qcow2'
Reported-by: Cong Wang <amwang@redhat.com>
Signed-off-by: Amos Kong <akong@redhat.com>
---
client/tests/kvm/control | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/client/tests/kvm/control b/client/tests/kvm/control
index c887a3e..959d2bc 100644
--- a/client/tests/kvm/control
+++ b/client/tests/kvm/control
@@ -55,7 +55,7 @@ if args:
# We get test parameters from command line
for arg in args:
try:
- (key, value) = re.findall("(.*)=(.*)", arg)[0]
+ (key, value) = re.findall("^(\w+)=(.*)", arg)[0]
if key == "only":
str += "only %s\n" % value
elif key == "no":
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] KVM-test: kvm_vm.py: Add quotation marks for appended arguments
[not found] <BANLkTikmAAF8AP6-bZakZh7hJdfSC1CF9A@mail.gmail.com>
2011-05-25 2:24 ` [PATCH 1/2] KVM-test: control: Fix of spliting augments Amos Kong
@ 2011-05-25 2:24 ` Amos Kong
2011-05-25 3:04 ` Cong Wang
2011-05-25 20:07 ` Lucas Meneghel Rodrigues
1 sibling, 2 replies; 4+ messages in thread
From: Amos Kong @ 2011-05-25 2:24 UTC (permalink / raw)
To: autotest; +Cc: amwang, kvm
Appended kernel cmdline should be involved by quotation marks.
-append 'root=/dev/vda ro ..'
Reported-by: Cong Wang <amwang@redhat.com>
Signed-off-by: Amos Kong <akong@redhat.com>
---
client/virt/kvm_vm.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/client/virt/kvm_vm.py b/client/virt/kvm_vm.py
index c9bb273..343488f 100644
--- a/client/virt/kvm_vm.py
+++ b/client/virt/kvm_vm.py
@@ -332,7 +332,7 @@ class VM(virt_vm.BaseVM):
return " -initrd '%s'" % filename
def add_kernel_cmdline(help, cmdline):
- return " -append %s" % cmdline
+ return " -append '%s'" % cmdline
def add_testdev(help, filename):
return (" -chardev file,id=testlog,path=%s"
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] KVM-test: kvm_vm.py: Add quotation marks for appended arguments
2011-05-25 2:24 ` [PATCH 2/2] KVM-test: kvm_vm.py: Add quotation marks for appended arguments Amos Kong
@ 2011-05-25 3:04 ` Cong Wang
2011-05-25 20:07 ` Lucas Meneghel Rodrigues
1 sibling, 0 replies; 4+ messages in thread
From: Cong Wang @ 2011-05-25 3:04 UTC (permalink / raw)
To: Amos Kong; +Cc: autotest, lmr, kvm
Amos, thanks for fixing it!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] KVM-test: kvm_vm.py: Add quotation marks for appended arguments
2011-05-25 2:24 ` [PATCH 2/2] KVM-test: kvm_vm.py: Add quotation marks for appended arguments Amos Kong
2011-05-25 3:04 ` Cong Wang
@ 2011-05-25 20:07 ` Lucas Meneghel Rodrigues
1 sibling, 0 replies; 4+ messages in thread
From: Lucas Meneghel Rodrigues @ 2011-05-25 20:07 UTC (permalink / raw)
To: Amos Kong; +Cc: autotest, amwang, kvm
On Tue, May 24, 2011 at 11:24 PM, Amos Kong <akong@redhat.com> wrote:
> Appended kernel cmdline should be involved by quotation marks.
> -append 'root=/dev/vda ro ..'
Applied, thanks!
> Reported-by: Cong Wang <amwang@redhat.com>
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
> client/virt/kvm_vm.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/client/virt/kvm_vm.py b/client/virt/kvm_vm.py
> index c9bb273..343488f 100644
> --- a/client/virt/kvm_vm.py
> +++ b/client/virt/kvm_vm.py
> @@ -332,7 +332,7 @@ class VM(virt_vm.BaseVM):
> return " -initrd '%s'" % filename
>
> def add_kernel_cmdline(help, cmdline):
> - return " -append %s" % cmdline
> + return " -append '%s'" % cmdline
>
> def add_testdev(help, filename):
> return (" -chardev file,id=testlog,path=%s"
>
> _______________________________________________
> Autotest mailing list
> Autotest@test.kernel.org
> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>
--
Lucas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-05-25 20:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <BANLkTikmAAF8AP6-bZakZh7hJdfSC1CF9A@mail.gmail.com>
2011-05-25 2:24 ` [PATCH 1/2] KVM-test: control: Fix of spliting augments Amos Kong
2011-05-25 2:24 ` [PATCH 2/2] KVM-test: kvm_vm.py: Add quotation marks for appended arguments Amos Kong
2011-05-25 3:04 ` Cong Wang
2011-05-25 20:07 ` Lucas Meneghel Rodrigues
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.