* [PATCH] drivers/misc: fix a memory leak in spear_pcie_gadget_probe error path
@ 2011-05-25 3:23 Axel Lin
2011-05-25 3:29 ` Pratyush Anand
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2011-05-25 3:23 UTC (permalink / raw)
To: linux-kernel; +Cc: Pratyush Anand, Andrew Morton
In the case of goto err_kzalloc, we should kfree target.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/misc/spear13xx_pcie_gadget.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/misc/spear13xx_pcie_gadget.c b/drivers/misc/spear13xx_pcie_gadget.c
index 7aded90..cfbddbe 100644
--- a/drivers/misc/spear13xx_pcie_gadget.c
+++ b/drivers/misc/spear13xx_pcie_gadget.c
@@ -845,7 +845,7 @@ err_iounmap:
err_iounmap_app:
iounmap(config->va_app_base);
err_kzalloc:
- kfree(config);
+ kfree(target);
err_rel_res:
release_mem_region(res1->start, resource_size(res1));
err_rel_res0:
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/misc: fix a memory leak in spear_pcie_gadget_probe error path
2011-05-25 3:23 [PATCH] drivers/misc: fix a memory leak in spear_pcie_gadget_probe error path Axel Lin
@ 2011-05-25 3:29 ` Pratyush Anand
0 siblings, 0 replies; 2+ messages in thread
From: Pratyush Anand @ 2011-05-25 3:29 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Andrew Morton
On 5/25/2011 8:53 AM, Axel Lin wrote:
> In the case of goto err_kzalloc, we should kfree target.
>
Yes, you are right. Its a mistake.
Regards
Pratyush
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/misc/spear13xx_pcie_gadget.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/spear13xx_pcie_gadget.c b/drivers/misc/spear13xx_pcie_gadget.c
> index 7aded90..cfbddbe 100644
> --- a/drivers/misc/spear13xx_pcie_gadget.c
> +++ b/drivers/misc/spear13xx_pcie_gadget.c
> @@ -845,7 +845,7 @@ err_iounmap:
> err_iounmap_app:
> iounmap(config->va_app_base);
> err_kzalloc:
> - kfree(config);
> + kfree(target);
> err_rel_res:
> release_mem_region(res1->start, resource_size(res1));
> err_rel_res0:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-25 3:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-25 3:23 [PATCH] drivers/misc: fix a memory leak in spear_pcie_gadget_probe error path Axel Lin
2011-05-25 3:29 ` Pratyush Anand
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.