* [Cluster-devel] [PATCH] compare cluster name in cman daemon
@ 2011-05-25 7:23 Evgeniy Sokolov
2011-05-25 8:05 ` Christine Caulfield
0 siblings, 1 reply; 6+ messages in thread
From: Evgeniy Sokolov @ 2011-05-25 7:23 UTC (permalink / raw)
To: cluster-devel.redhat.com
if length of cluster name = 16, last char of msg->clustername will not
be zero.
In this case strcmp will continue read member fence_agent from
cl_transmsg structure.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-compare-clustername.diff
Type: text/x-patch
Size: 574 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20110525/55fdb480/attachment.bin>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Cluster-devel] [PATCH] compare cluster name in cman daemon
2011-05-25 7:23 [Cluster-devel] [PATCH] compare cluster name in cman daemon Evgeniy Sokolov
@ 2011-05-25 8:05 ` Christine Caulfield
2011-05-25 8:37 ` Evgeniy Sokolov
2011-05-30 9:06 ` Dmitry Mishin
0 siblings, 2 replies; 6+ messages in thread
From: Christine Caulfield @ 2011-05-25 8:05 UTC (permalink / raw)
To: cluster-devel.redhat.com
On 25/05/11 08:23, Evgeniy Sokolov wrote:
> if length of cluster name = 16, last char of msg->clustername will not
> be zero.
> In this case strcmp will continue read member fence_agent from
> cl_transmsg structure.
>
>
If the length of the cluster name = 16 then there is a bug somewhere
else that needs fixing ;-)
Chrissie
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Cluster-devel] [PATCH] compare cluster name in cman daemon
2011-05-25 8:05 ` Christine Caulfield
@ 2011-05-25 8:37 ` Evgeniy Sokolov
2011-05-30 8:45 ` Evgeniy Sokolov
2011-05-30 9:06 ` Dmitry Mishin
1 sibling, 1 reply; 6+ messages in thread
From: Evgeniy Sokolov @ 2011-05-25 8:37 UTC (permalink / raw)
To: cluster-devel.redhat.com
On 25.05.2011 12:05, Christine Caulfield wrote:
> On 25/05/11 08:23, Evgeniy Sokolov wrote:
>> if length of cluster name = 16, last char of msg->clustername will not
>> be zero.
>> In this case strcmp will continue read member fence_agent from
>> cl_transmsg structure.
>>
>>
>
> If the length of the cluster name = 16 then there is a bug somewhere
> else that needs fixing ;-)
>
> Chrissie
>
>
Design of cl_transmsg->clustername[16] is string with max length 15 + 1
char for zero. Is it correct?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Cluster-devel] [PATCH] compare cluster name in cman daemon
2011-05-25 8:37 ` Evgeniy Sokolov
@ 2011-05-30 8:45 ` Evgeniy Sokolov
2011-05-31 7:40 ` Christine Caulfield
0 siblings, 1 reply; 6+ messages in thread
From: Evgeniy Sokolov @ 2011-05-30 8:45 UTC (permalink / raw)
To: cluster-devel.redhat.com
On 25.05.2011 12:37, Evgeniy Sokolov wrote:
> On 25.05.2011 12:05, Christine Caulfield wrote:
>> On 25/05/11 08:23, Evgeniy Sokolov wrote:
>>> if length of cluster name = 16, last char of msg->clustername will not
>>> be zero.
>>> In this case strcmp will continue read member fence_agent from
>>> cl_transmsg structure.
>>>
>>>
>>
>> If the length of the cluster name = 16 then there is a bug somewhere
>> else that needs fixing ;-)
>>
>> Chrissie
>>
>>
>
> Design of cl_transmsg->clustername[16] is string with max length 15 + 1
> char for zero. Is it correct?
Christine, can you answer the question?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Cluster-devel] [PATCH] compare cluster name in cman daemon
2011-05-25 8:05 ` Christine Caulfield
2011-05-25 8:37 ` Evgeniy Sokolov
@ 2011-05-30 9:06 ` Dmitry Mishin
1 sibling, 0 replies; 6+ messages in thread
From: Dmitry Mishin @ 2011-05-30 9:06 UTC (permalink / raw)
To: cluster-devel.redhat.com
For example, in user's mind or in incoming parameters parsing, do you mean
this?
Where does this limitation come from?
On Wednesday 25 May 2011 12:05:05 Christine Caulfield wrote:
> On 25/05/11 08:23, Evgeniy Sokolov wrote:
> > if length of cluster name = 16, last char of msg->clustername will not
> > be zero.
> > In this case strcmp will continue read member fence_agent from
> > cl_transmsg structure.
>
> If the length of the cluster name = 16 then there is a bug somewhere
> else that needs fixing ;-)
>
> Chrissie
--
Thanks,
Dmitry.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Cluster-devel] [PATCH] compare cluster name in cman daemon
2011-05-30 8:45 ` Evgeniy Sokolov
@ 2011-05-31 7:40 ` Christine Caulfield
0 siblings, 0 replies; 6+ messages in thread
From: Christine Caulfield @ 2011-05-31 7:40 UTC (permalink / raw)
To: cluster-devel.redhat.com
On 30/05/11 09:45, Evgeniy Sokolov wrote:
> On 25.05.2011 12:37, Evgeniy Sokolov wrote:
>> On 25.05.2011 12:05, Christine Caulfield wrote:
>>> On 25/05/11 08:23, Evgeniy Sokolov wrote:
>>>> if length of cluster name = 16, last char of msg->clustername will not
>>>> be zero.
>>>> In this case strcmp will continue read member fence_agent from
>>>> cl_transmsg structure.
>>>>
>>>>
>>>
>>> If the length of the cluster name = 16 then there is a bug somewhere
>>> else that needs fixing ;-)
>>>
>>> Chrissie
>>>
>>>
>>
>> Design of cl_transmsg->clustername[16] is string with max length 15 + 1
>> char for zero. Is it correct?
>
> Christine, can you answer the question?
Yes, that's correct.
Chrissie
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-05-31 7:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-25 7:23 [Cluster-devel] [PATCH] compare cluster name in cman daemon Evgeniy Sokolov
2011-05-25 8:05 ` Christine Caulfield
2011-05-25 8:37 ` Evgeniy Sokolov
2011-05-30 8:45 ` Evgeniy Sokolov
2011-05-31 7:40 ` Christine Caulfield
2011-05-30 9:06 ` Dmitry Mishin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.