All of lore.kernel.org
 help / color / mirror / Atom feed
* [GIT PATCHES FOR 2.6.40] Fixes
@ 2011-05-23 11:06 Hans Verkuil
  2011-05-24  1:42 ` Mauro Carvalho Chehab
  2011-06-10 12:22 ` Matti J. Aaltonen
  0 siblings, 2 replies; 6+ messages in thread
From: Hans Verkuil @ 2011-05-23 11:06 UTC (permalink / raw)
  To: linux-media; +Cc: Manjunatha Halli, Matti J. Aaltonen

Hi Mauro,

Here are a few fixes: the first fixes a bug in the wl12xx drivers (I hope Matti's
email is still correct). The second fixes a few DocBook validation errors, and
the last fixes READ_ONLY and GRABBED handling in the control framework.

Regards,

	Hans

The following changes since commit 87cf028f3aa1ed51fe29c36df548aa714dc7438f:

  [media] dm1105: GPIO handling added, I2C on GPIO added, LNB control through GPIO reworked (2011-05-21 11:10:28 -0300)

are available in the git repository at:
  ssh://linuxtv.org/git/hverkuil/media_tree.git fixes

Hans Verkuil (3):
      wl12xx: g_volatile_ctrl fix: wrong field set.
      Media DocBook: fix validation errors.
      v4l2-ctrls: drivers should be able to ignore READ_ONLY and GRABBED flags

 Documentation/DocBook/dvb/dvbproperty.xml    |    5 ++-
 Documentation/DocBook/v4l/subdev-formats.xml |   10 ++--
 drivers/media/radio/radio-wl1273.c           |    2 +-
 drivers/media/radio/wl128x/fmdrv_v4l2.c      |    2 +-
 drivers/media/video/v4l2-ctrls.c             |   59 +++++++++++++++++---------
 5 files changed, 50 insertions(+), 28 deletions(-)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PATCHES FOR 2.6.40] Fixes
  2011-05-23 11:06 [GIT PATCHES FOR 2.6.40] Fixes Hans Verkuil
@ 2011-05-24  1:42 ` Mauro Carvalho Chehab
  2011-05-24  6:28   ` Hans Verkuil
  2011-06-10 12:22 ` Matti J. Aaltonen
  1 sibling, 1 reply; 6+ messages in thread
From: Mauro Carvalho Chehab @ 2011-05-24  1:42 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: linux-media, Manjunatha Halli, Matti J. Aaltonen

Em 23-05-2011 08:06, Hans Verkuil escreveu:
> Hi Mauro,
> 
> Here are a few fixes: the first fixes a bug in the wl12xx drivers (I hope Matti's
> email is still correct). The second fixes a few DocBook validation errors, and
> the last fixes READ_ONLY and GRABBED handling in the control framework.
> 
> Regards,
> 
> 	Hans
> 
> The following changes since commit 87cf028f3aa1ed51fe29c36df548aa714dc7438f:
> 
>   [media] dm1105: GPIO handling added, I2C on GPIO added, LNB control through GPIO reworked (2011-05-21 11:10:28 -0300)
> 
> are available in the git repository at:
>   ssh://linuxtv.org/git/hverkuil/media_tree.git fixes
> 
> Hans Verkuil (3):
>       wl12xx: g_volatile_ctrl fix: wrong field set.
>       Media DocBook: fix validation errors.

The two above are fixes...

>       v4l2-ctrls: drivers should be able to ignore READ_ONLY and GRABBED flags

But this one is a change at the behaviour. I need to analyse it better. The idea
of a "read only" control that it is not read only seems too weird on my tired eyes.

I'll take a more careful look on it tomorrow.

Thanks,
Mauro.

> 
>  Documentation/DocBook/dvb/dvbproperty.xml    |    5 ++-
>  Documentation/DocBook/v4l/subdev-formats.xml |   10 ++--
>  drivers/media/radio/radio-wl1273.c           |    2 +-
>  drivers/media/radio/wl128x/fmdrv_v4l2.c      |    2 +-
>  drivers/media/video/v4l2-ctrls.c             |   59 +++++++++++++++++---------
>  5 files changed, 50 insertions(+), 28 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PATCHES FOR 2.6.40] Fixes
  2011-05-24  1:42 ` Mauro Carvalho Chehab
@ 2011-05-24  6:28   ` Hans Verkuil
  2011-05-25  8:27     ` Hans Verkuil
  0 siblings, 1 reply; 6+ messages in thread
From: Hans Verkuil @ 2011-05-24  6:28 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: linux-media, Manjunatha Halli, Matti J. Aaltonen

On Tuesday, May 24, 2011 03:42:32 Mauro Carvalho Chehab wrote:
> Em 23-05-2011 08:06, Hans Verkuil escreveu:
> > Hi Mauro,
> > 
> > Here are a few fixes: the first fixes a bug in the wl12xx drivers (I hope Matti's
> > email is still correct). The second fixes a few DocBook validation errors, and
> > the last fixes READ_ONLY and GRABBED handling in the control framework.
> > 
> > Regards,
> > 
> > 	Hans
> > 
> > The following changes since commit 87cf028f3aa1ed51fe29c36df548aa714dc7438f:
> > 
> >   [media] dm1105: GPIO handling added, I2C on GPIO added, LNB control through GPIO reworked (2011-05-21 11:10:28 -0300)
> > 
> > are available in the git repository at:
> >   ssh://linuxtv.org/git/hverkuil/media_tree.git fixes
> > 
> > Hans Verkuil (3):
> >       wl12xx: g_volatile_ctrl fix: wrong field set.
> >       Media DocBook: fix validation errors.
> 
> The two above are fixes...
> 
> >       v4l2-ctrls: drivers should be able to ignore READ_ONLY and GRABBED flags
> 
> But this one is a change at the behaviour. I need to analyse it better. The idea
> of a "read only" control that it is not read only seems too weird on my tired eyes.

It's read-only for *applications*. But if you have a read-only control that
reflects a driver state, then it should be possible for a *driver* to change
it. It's something that is needed for the upcoming Flash and HDMI APIs.

The userspace behavior does not change.

BTW, if you prefer to move this last patch to 2.6.41, then that's OK by me.
It's not really necessary for 2.6.40.

Regards,

	Hans

> 
> I'll take a more careful look on it tomorrow.
> 
> Thanks,
> Mauro.
> 
> > 
> >  Documentation/DocBook/dvb/dvbproperty.xml    |    5 ++-
> >  Documentation/DocBook/v4l/subdev-formats.xml |   10 ++--
> >  drivers/media/radio/radio-wl1273.c           |    2 +-
> >  drivers/media/radio/wl128x/fmdrv_v4l2.c      |    2 +-
> >  drivers/media/video/v4l2-ctrls.c             |   59 +++++++++++++++++---------
> >  5 files changed, 50 insertions(+), 28 deletions(-)
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-media" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PATCHES FOR 2.6.40] Fixes
  2011-05-24  6:28   ` Hans Verkuil
@ 2011-05-25  8:27     ` Hans Verkuil
  2011-05-26  0:23       ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 6+ messages in thread
From: Hans Verkuil @ 2011-05-25  8:27 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: linux-media, Manjunatha Halli, Matti J. Aaltonen

On Tuesday, May 24, 2011 08:28:32 Hans Verkuil wrote:
> On Tuesday, May 24, 2011 03:42:32 Mauro Carvalho Chehab wrote:
> > Em 23-05-2011 08:06, Hans Verkuil escreveu:
> > > Hi Mauro,
> > > 
> > > Here are a few fixes: the first fixes a bug in the wl12xx drivers (I hope Matti's
> > > email is still correct). The second fixes a few DocBook validation errors, and
> > > the last fixes READ_ONLY and GRABBED handling in the control framework.
> > > 
> > > Regards,
> > > 
> > > 	Hans
> > > 
> > > The following changes since commit 87cf028f3aa1ed51fe29c36df548aa714dc7438f:
> > > 
> > >   [media] dm1105: GPIO handling added, I2C on GPIO added, LNB control through GPIO reworked (2011-05-21 11:10:28 -0300)
> > > 
> > > are available in the git repository at:
> > >   ssh://linuxtv.org/git/hverkuil/media_tree.git fixes
> > > 
> > > Hans Verkuil (3):
> > >       wl12xx: g_volatile_ctrl fix: wrong field set.
> > >       Media DocBook: fix validation errors.
> > 
> > The two above are fixes...
> > 
> > >       v4l2-ctrls: drivers should be able to ignore READ_ONLY and GRABBED flags
> > 
> > But this one is a change at the behaviour. I need to analyse it better. The idea
> > of a "read only" control that it is not read only seems too weird on my tired eyes.
> 
> It's read-only for *applications*. But if you have a read-only control that
> reflects a driver state, then it should be possible for a *driver* to change
> it. It's something that is needed for the upcoming Flash and HDMI APIs.
> 
> The userspace behavior does not change.
> 
> BTW, if you prefer to move this last patch to 2.6.41, then that's OK by me.
> It's not really necessary for 2.6.40.

I'm going to move this patch to 2.6.41, so there is no need for you to review this.
I'll include it in another patch series I'm working on.

Regards,

	Hans

> 
> Regards,
> 
> 	Hans
> 
> > 
> > I'll take a more careful look on it tomorrow.
> > 
> > Thanks,
> > Mauro.
> > 
> > > 
> > >  Documentation/DocBook/dvb/dvbproperty.xml    |    5 ++-
> > >  Documentation/DocBook/v4l/subdev-formats.xml |   10 ++--
> > >  drivers/media/radio/radio-wl1273.c           |    2 +-
> > >  drivers/media/radio/wl128x/fmdrv_v4l2.c      |    2 +-
> > >  drivers/media/video/v4l2-ctrls.c             |   59 +++++++++++++++++---------
> > >  5 files changed, 50 insertions(+), 28 deletions(-)
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-media" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PATCHES FOR 2.6.40] Fixes
  2011-05-25  8:27     ` Hans Verkuil
@ 2011-05-26  0:23       ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 6+ messages in thread
From: Mauro Carvalho Chehab @ 2011-05-26  0:23 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: linux-media, Manjunatha Halli, Matti J. Aaltonen

Em 25-05-2011 05:27, Hans Verkuil escreveu:
> On Tuesday, May 24, 2011 08:28:32 Hans Verkuil wrote:
>> On Tuesday, May 24, 2011 03:42:32 Mauro Carvalho Chehab wrote:
>>> Em 23-05-2011 08:06, Hans Verkuil escreveu:
>>>> Hi Mauro,
>>>>
>>>> Here are a few fixes: the first fixes a bug in the wl12xx drivers (I hope Matti's
>>>> email is still correct). The second fixes a few DocBook validation errors, and
>>>> the last fixes READ_ONLY and GRABBED handling in the control framework.
>>>>
>>>> Regards,
>>>>
>>>> 	Hans
>>>>
>>>> The following changes since commit 87cf028f3aa1ed51fe29c36df548aa714dc7438f:
>>>>
>>>>   [media] dm1105: GPIO handling added, I2C on GPIO added, LNB control through GPIO reworked (2011-05-21 11:10:28 -0300)
>>>>
>>>> are available in the git repository at:
>>>>   ssh://linuxtv.org/git/hverkuil/media_tree.git fixes
>>>>
>>>> Hans Verkuil (3):
>>>>       wl12xx: g_volatile_ctrl fix: wrong field set.
>>>>       Media DocBook: fix validation errors.
>>>
>>> The two above are fixes...
>>>
>>>>       v4l2-ctrls: drivers should be able to ignore READ_ONLY and GRABBED flags
>>>
>>> But this one is a change at the behaviour. I need to analyse it better. The idea
>>> of a "read only" control that it is not read only seems too weird on my tired eyes.
>>
>> It's read-only for *applications*. But if you have a read-only control that
>> reflects a driver state, then it should be possible for a *driver* to change
>> it. It's something that is needed for the upcoming Flash and HDMI APIs.
>>
>> The userspace behavior does not change.
>>
>> BTW, if you prefer to move this last patch to 2.6.41, then that's OK by me.
>> It's not really necessary for 2.6.40.
> 
> I'm going to move this patch to 2.6.41, so there is no need for you to review this.
> I'll include it in another patch series I'm working on.

Ok, I'll remove it from my queue.

Thanks,
Mauro

> 
> Regards,
> 
> 	Hans
> 
>>
>> Regards,
>>
>> 	Hans
>>
>>>
>>> I'll take a more careful look on it tomorrow.
>>>
>>> Thanks,
>>> Mauro.
>>>
>>>>
>>>>  Documentation/DocBook/dvb/dvbproperty.xml    |    5 ++-
>>>>  Documentation/DocBook/v4l/subdev-formats.xml |   10 ++--
>>>>  drivers/media/radio/radio-wl1273.c           |    2 +-
>>>>  drivers/media/radio/wl128x/fmdrv_v4l2.c      |    2 +-
>>>>  drivers/media/video/v4l2-ctrls.c             |   59 +++++++++++++++++---------
>>>>  5 files changed, 50 insertions(+), 28 deletions(-)
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>>>> the body of a message to majordomo@vger.kernel.org
>>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PATCHES FOR 2.6.40] Fixes
  2011-05-23 11:06 [GIT PATCHES FOR 2.6.40] Fixes Hans Verkuil
  2011-05-24  1:42 ` Mauro Carvalho Chehab
@ 2011-06-10 12:22 ` Matti J. Aaltonen
  1 sibling, 0 replies; 6+ messages in thread
From: Matti J. Aaltonen @ 2011-06-10 12:22 UTC (permalink / raw)
  To: ext Hans Verkuil; +Cc: linux-media, Manjunatha Halli

Hello.

On Mon, 2011-05-23 at 13:06 +0200, ext Hans Verkuil wrote:
> Hi Mauro,
> 
> Here are a few fixes: the first fixes a bug in the wl12xx drivers (I hope Matti's
> email is still correct). The second fixes a few DocBook validation errors, and

I'm still here... And it's a nice surprise that the wl1273 radio driver
hasn't been deprecated or has it... I actually could add some features
to it.

Cheers,
Matti

> the last fixes READ_ONLY and GRABBED handling in the control framework.
> 
> Regards,
> 
> 	Hans
> 
> The following changes since commit 87cf028f3aa1ed51fe29c36df548aa714dc7438f:
> 
>   [media] dm1105: GPIO handling added, I2C on GPIO added, LNB control through GPIO reworked (2011-05-21 11:10:28 -0300)
> 
> are available in the git repository at:
>   ssh://linuxtv.org/git/hverkuil/media_tree.git fixes
> 
> Hans Verkuil (3):
>       wl12xx: g_volatile_ctrl fix: wrong field set.
>       Media DocBook: fix validation errors.
>       v4l2-ctrls: drivers should be able to ignore READ_ONLY and GRABBED flags
> 
>  Documentation/DocBook/dvb/dvbproperty.xml    |    5 ++-
>  Documentation/DocBook/v4l/subdev-formats.xml |   10 ++--
>  drivers/media/radio/radio-wl1273.c           |    2 +-
>  drivers/media/radio/wl128x/fmdrv_v4l2.c      |    2 +-
>  drivers/media/video/v4l2-ctrls.c             |   59 +++++++++++++++++---------
>  5 files changed, 50 insertions(+), 28 deletions(-)



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-06-10 12:22 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-23 11:06 [GIT PATCHES FOR 2.6.40] Fixes Hans Verkuil
2011-05-24  1:42 ` Mauro Carvalho Chehab
2011-05-24  6:28   ` Hans Verkuil
2011-05-25  8:27     ` Hans Verkuil
2011-05-26  0:23       ` Mauro Carvalho Chehab
2011-06-10 12:22 ` Matti J. Aaltonen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.