* Re: linux-next: build failure after merge of the voltage tree
[not found] <201105271759.p4RHxa2X008919@hera.kernel.org>
@ 2011-05-27 19:58 ` Randy Dunlap
2011-05-27 21:13 ` Liam Girdwood
0 siblings, 1 reply; 20+ messages in thread
From: Randy Dunlap @ 2011-05-27 19:58 UTC (permalink / raw)
To: Linux Kernel Mailing List, Samuel Ortiz
Cc: Jorge Eduardo Candelaria, Liam Girdwood, Mark Brown, Liam Girdwood
On Fri, 27 May 2011 17:59:36 GMT Linux Kernel Mailing List wrote:
> Gitweb: http://git.kernel.org/linus/c01e36dde4632e0a7474fddf0716f1e54f01f13e
> Commit: c01e36dde4632e0a7474fddf0716f1e54f01f13e
> Parent: 327e15af15248563c896c16adad6fc6e04bb5a4d
> Author: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> AuthorDate: Wed May 11 01:43:02 2011 -0500
> Committer: Liam Girdwood <lrg@slimlogic.co.uk>
> CommitDate: Fri May 27 10:49:09 2011 +0100
>
> linux-next: build failure after merge of the voltage tree
>
> On May 10, 2011, at 9:27 PM, Stephen Rothwell wrote:
>
> > Hi Jorge,
> >
> > On Tue, 10 May 2011 12:30:36 -0500 Jorge Eduardo Candelaria <jedu@slimlogic.co.uk> wrote:
> >>
> >> On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:
> >>
> >>> On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
> >>>> Hi Liam,
> >>>>
> >>>> After merging the voltage tree, today's linux-next build (x86_64
> >>>> allmodconfig) failed like this:
> >>>>
> >>>> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
> >>>> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
> >>>> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
> >>>> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
> >>>> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
> >>>>
> >>>> I have used the voltage tree from next-20110509 for today.
> >>>
> >>> Jorge, could you send a fix for this today.
> >>
> >> The following patch should solve this:
> >>
> >> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> >> MFD: Fix TPS65910 build
> >>
> >> Support for tps65910 as a module is not available. The driver can
> >> only be compiled as built-in. OTOH, the regulator driver can still
> >> be built as module without breaking the compilation.
> >>
> >> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> >
> > Today (even with the above patch included) I got these errors from the
> > x86_64 allmodconfig build:
> >
> > tps65910.c:(.text+0xf4140): undefined reference to `i2c_master_send'
> > drivers/built-in.o: In function `tps65910_i2c_read':
> > tps65910.c:(.text+0xf41d2): undefined reference to `i2c_transfer'
> > drivers/built-in.o: In function `tps65910_i2c_init':
> > tps65910.c:(.init.text+0xcb83): undefined reference to `i2c_register_driver'
> > drivers/built-in.o: In function `tps65910_i2c_exit':
> > tps65910.c:(.exit.text+0x6e0): undefined reference to `i2c_del_driver'
> >
> > I have used the voltage tree from next-20110509 again today.
>
> Following patch should fix the dependency problems. Please review:
>
> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> [PATCH] MFD: TPS65910: Fix I2C dependency
>
> TPS65910 driver can only be compiled built-in, so the I2C driver
> should be as well.
>
> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 05f882f..4990a49 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -721,7 +721,7 @@ config MFD_PM8XXX_IRQ
>
> config MFD_TPS65910
> bool "TPS65910 Power Management chip"
> - depends on I2C && GPIOLIB
> + depends on I2C=y && GPIOLIB
> select MFD_CORE
> help
> if you say yes here you get support for the TPS65910 series of
> --
Hi,
Current mainline build fails when GPIO is not enabled:
warning: (MFD_TPS65910) selects GPIO_TPS65910 which has unmet direct dependencies (GPIOLIB && MFD_TPS65910)
which causes:
In file included from drivers/gpio/tps65910-gpio.c:21:
include/linux/mfd/tps65910.h:774: error: field 'gpio' has incomplete type
drivers/gpio/tps65910-gpio.c: In function 'tps65910_gpio_get':
drivers/gpio/tps65910-gpio.c:25: warning: type defaults to 'int' in declaration of '__mptr'
drivers/gpio/tps65910-gpio.c:25: warning: initialization from incompatible pointer type
drivers/gpio/tps65910-gpio.c: In function 'tps65910_gpio_set':
drivers/gpio/tps65910-gpio.c:39: warning: type defaults to 'int' in declaration of '__mptr'
drivers/gpio/tps65910-gpio.c:39: warning: initialization from incompatible pointer type
drivers/gpio/tps65910-gpio.c: In function 'tps65910_gpio_output':
drivers/gpio/tps65910-gpio.c:52: warning: type defaults to 'int' in declaration of '__mptr'
drivers/gpio/tps65910-gpio.c:52: warning: initialization from incompatible pointer type
drivers/gpio/tps65910-gpio.c: In function 'tps65910_gpio_input':
drivers/gpio/tps65910-gpio.c:63: warning: type defaults to 'int' in declaration of '__mptr'
drivers/gpio/tps65910-gpio.c:63: warning: initialization from incompatible pointer type
drivers/gpio/tps65910-gpio.c: In function 'tps65910_gpio_init':
drivers/gpio/tps65910-gpio.c:96: error: implicit declaration of function 'gpiochip_add'
make[3]: *** [drivers/gpio/tps65910-gpio.o] Error 1
make[2]: *** [drivers/gpio] Error 2
make[1]: *** [drivers] Error 2
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2011-05-27 19:58 ` linux-next: build failure after merge of the voltage tree Randy Dunlap
@ 2011-05-27 21:13 ` Liam Girdwood
2011-05-27 21:21 ` Randy Dunlap
0 siblings, 1 reply; 20+ messages in thread
From: Liam Girdwood @ 2011-05-27 21:13 UTC (permalink / raw)
To: Randy Dunlap
Cc: Linux Kernel Mailing List, Samuel Ortiz,
Jorge Eduardo Candelaria, Mark Brown, Liam Girdwood
On Fri, 2011-05-27 at 12:58 -0700, Randy Dunlap wrote:
> On Fri, 27 May 2011 17:59:36 GMT Linux Kernel Mailing List wrote:
>
> > Gitweb: http://git.kernel.org/linus/c01e36dde4632e0a7474fddf0716f1e54f01f13e
> > Commit: c01e36dde4632e0a7474fddf0716f1e54f01f13e
> > Parent: 327e15af15248563c896c16adad6fc6e04bb5a4d
> > Author: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> > AuthorDate: Wed May 11 01:43:02 2011 -0500
> > Committer: Liam Girdwood <lrg@slimlogic.co.uk>
> > CommitDate: Fri May 27 10:49:09 2011 +0100
> >
> > linux-next: build failure after merge of the voltage tree
> >
> > On May 10, 2011, at 9:27 PM, Stephen Rothwell wrote:
> >
> > > Hi Jorge,
> > >
> > > On Tue, 10 May 2011 12:30:36 -0500 Jorge Eduardo Candelaria <jedu@slimlogic.co.uk> wrote:
> > >>
> > >> On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:
> > >>
> > >>> On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
> > >>>> Hi Liam,
> > >>>>
> > >>>> After merging the voltage tree, today's linux-next build (x86_64
> > >>>> allmodconfig) failed like this:
> > >>>>
> > >>>> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
> > >>>> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
> > >>>> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
> > >>>> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
> > >>>> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
> > >>>>
> > >>>> I have used the voltage tree from next-20110509 for today.
> > >>>
> > >>> Jorge, could you send a fix for this today.
> > >>
> > >> The following patch should solve this:
> > >>
> > >> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> > >> MFD: Fix TPS65910 build
> > >>
> > >> Support for tps65910 as a module is not available. The driver can
> > >> only be compiled as built-in. OTOH, the regulator driver can still
> > >> be built as module without breaking the compilation.
> > >>
> > >> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> > >
> > > Today (even with the above patch included) I got these errors from the
> > > x86_64 allmodconfig build:
> > >
> > > tps65910.c:(.text+0xf4140): undefined reference to `i2c_master_send'
> > > drivers/built-in.o: In function `tps65910_i2c_read':
> > > tps65910.c:(.text+0xf41d2): undefined reference to `i2c_transfer'
> > > drivers/built-in.o: In function `tps65910_i2c_init':
> > > tps65910.c:(.init.text+0xcb83): undefined reference to `i2c_register_driver'
> > > drivers/built-in.o: In function `tps65910_i2c_exit':
> > > tps65910.c:(.exit.text+0x6e0): undefined reference to `i2c_del_driver'
> > >
> > > I have used the voltage tree from next-20110509 again today.
> >
> > Following patch should fix the dependency problems. Please review:
> >
> > From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> > [PATCH] MFD: TPS65910: Fix I2C dependency
> >
> > TPS65910 driver can only be compiled built-in, so the I2C driver
> > should be as well.
> >
> > Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> > Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
> > ---
> > drivers/mfd/Kconfig | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 05f882f..4990a49 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -721,7 +721,7 @@ config MFD_PM8XXX_IRQ
> >
> > config MFD_TPS65910
> > bool "TPS65910 Power Management chip"
> > - depends on I2C && GPIOLIB
> > + depends on I2C=y && GPIOLIB
> > select MFD_CORE
> > help
> > if you say yes here you get support for the TPS65910 series of
> > --
>
>
> Hi,
>
> Current mainline build fails when GPIO is not enabled:
>
> warning: (MFD_TPS65910) selects GPIO_TPS65910 which has unmet direct dependencies (GPIOLIB && MFD_TPS65910)
>
> which causes:
>
> In file included from drivers/gpio/tps65910-gpio.c:21:
> include/linux/mfd/tps65910.h:774: error: field 'gpio' has incomplete type
> drivers/gpio/tps65910-gpio.c: In function 'tps65910_gpio_get':
> drivers/gpio/tps65910-gpio.c:25: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/gpio/tps65910-gpio.c:25: warning: initialization from incompatible pointer type
> drivers/gpio/tps65910-gpio.c: In function 'tps65910_gpio_set':
> drivers/gpio/tps65910-gpio.c:39: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/gpio/tps65910-gpio.c:39: warning: initialization from incompatible pointer type
> drivers/gpio/tps65910-gpio.c: In function 'tps65910_gpio_output':
> drivers/gpio/tps65910-gpio.c:52: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/gpio/tps65910-gpio.c:52: warning: initialization from incompatible pointer type
> drivers/gpio/tps65910-gpio.c: In function 'tps65910_gpio_input':
> drivers/gpio/tps65910-gpio.c:63: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/gpio/tps65910-gpio.c:63: warning: initialization from incompatible pointer type
> drivers/gpio/tps65910-gpio.c: In function 'tps65910_gpio_init':
> drivers/gpio/tps65910-gpio.c:96: error: implicit declaration of function 'gpiochip_add'
> make[3]: *** [drivers/gpio/tps65910-gpio.o] Error 1
> make[2]: *** [drivers/gpio] Error 2
> make[1]: *** [drivers] Error 2
>
>
Hi,
gah, looks this was broken by moving the tps65910 gpio directory move.
This should fix it though:-
From: Liam Girdwood <lrg@ti.com>
Date: Fri, 27 May 2011 22:06:52 +0100
Subject: [PATCH] mfd: tps65910 - fix build breakage caused by tps65910 gpio directory move.
Signed-off-by: Liam Girdwood <lrg@ti.com>
---
drivers/mfd/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index b6c2677..0f09c05 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -721,7 +721,7 @@ config MFD_PM8XXX_IRQ
config MFD_TPS65910
bool "TPS65910 Power Management chip"
- depends on I2C=y
+ depends on I2C=y && GPIOLIB
select MFD_CORE
select GPIO_TPS65910
help
--
1.7.4.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2011-05-27 21:13 ` Liam Girdwood
@ 2011-05-27 21:21 ` Randy Dunlap
0 siblings, 0 replies; 20+ messages in thread
From: Randy Dunlap @ 2011-05-27 21:21 UTC (permalink / raw)
To: Liam Girdwood
Cc: Linux Kernel Mailing List, Samuel Ortiz,
Jorge Eduardo Candelaria, Mark Brown, Liam Girdwood
> Hi,
>
> gah, looks this was broken by moving the tps65910 gpio directory move.
>
> This should fix it though:-
It does. Thanks.
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> From: Liam Girdwood <lrg@ti.com>
> Date: Fri, 27 May 2011 22:06:52 +0100
> Subject: [PATCH] mfd: tps65910 - fix build breakage caused by tps65910 gpio directory move.
>
> Signed-off-by: Liam Girdwood <lrg@ti.com>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index b6c2677..0f09c05 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -721,7 +721,7 @@ config MFD_PM8XXX_IRQ
>
> config MFD_TPS65910
> bool "TPS65910 Power Management chip"
> - depends on I2C=y
> + depends on I2C=y && GPIOLIB
> select MFD_CORE
> select GPIO_TPS65910
> help
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2011-05-11 6:43 ` Jorge Eduardo Candelaria
@ 2011-05-11 13:29 ` Liam Girdwood
0 siblings, 0 replies; 20+ messages in thread
From: Liam Girdwood @ 2011-05-11 13:29 UTC (permalink / raw)
To: Jorge Eduardo Candelaria
Cc: Stephen Rothwell, linux-next, linux-kernel, Graeme Gregory
On Wed, 2011-05-11 at 01:43 -0500, Jorge Eduardo Candelaria wrote:
> On May 10, 2011, at 9:27 PM, Stephen Rothwell wrote:
>
> > Hi Jorge,
> >
> > On Tue, 10 May 2011 12:30:36 -0500 Jorge Eduardo Candelaria <jedu@slimlogic.co.uk> wrote:
> >>
> >> On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:
> >>
> >>> On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
> >>>> Hi Liam,
> >>>>
> >>>> After merging the voltage tree, today's linux-next build (x86_64
> >>>> allmodconfig) failed like this:
> >>>>
> >>>> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
> >>>> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
> >>>> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
> >>>> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
> >>>> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
> >>>>
> >>>> I have used the voltage tree from next-20110509 for today.
> >>>
> >>> Jorge, could you send a fix for this today.
> >>
> >> The following patch should solve this:
> >>
> >> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> >> MFD: Fix TPS65910 build
> >>
> >> Support for tps65910 as a module is not available. The driver can
> >> only be compiled as built-in. OTOH, the regulator driver can still
> >> be built as module without breaking the compilation.
> >>
> >> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> >
> > Today (even with the above patch included) I got these errors from the
> > x86_64 allmodconfig build:
> >
> > tps65910.c:(.text+0xf4140): undefined reference to `i2c_master_send'
> > drivers/built-in.o: In function `tps65910_i2c_read':
> > tps65910.c:(.text+0xf41d2): undefined reference to `i2c_transfer'
> > drivers/built-in.o: In function `tps65910_i2c_init':
> > tps65910.c:(.init.text+0xcb83): undefined reference to `i2c_register_driver'
> > drivers/built-in.o: In function `tps65910_i2c_exit':
> > tps65910.c:(.exit.text+0x6e0): undefined reference to `i2c_del_driver'
> >
> > I have used the voltage tree from next-20110509 again today.
>
> Following patch should fix the dependency problems. Please review:
>
> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> [PATCH] MFD: TPS65910: Fix I2C dependency
>
> TPS65910 driver can only be compiled built-in, so the I2C driver
> should be as well.
>
> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index c78865e..0131d49 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -673,7 +673,7 @@ config MFD_OMAP_USB_HOST
>
> config MFD_TPS65910
> bool "TPS65910 Power Management chip"
> - depends on I2C && GPIOLIB
> + depends on I2C=y && GPIOLIB
> select MFD_CORE
> help
> if you say yes here you get support for the TPS65910 series of
Now applied.
Liam
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2011-05-11 2:27 ` Stephen Rothwell
@ 2011-05-11 6:43 ` Jorge Eduardo Candelaria
2011-05-11 13:29 ` Liam Girdwood
0 siblings, 1 reply; 20+ messages in thread
From: Jorge Eduardo Candelaria @ 2011-05-11 6:43 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel, Graeme Gregory
On May 10, 2011, at 9:27 PM, Stephen Rothwell wrote:
> Hi Jorge,
>
> On Tue, 10 May 2011 12:30:36 -0500 Jorge Eduardo Candelaria <jedu@slimlogic.co.uk> wrote:
>>
>> On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:
>>
>>> On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
>>>> Hi Liam,
>>>>
>>>> After merging the voltage tree, today's linux-next build (x86_64
>>>> allmodconfig) failed like this:
>>>>
>>>> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
>>>> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
>>>> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
>>>> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
>>>> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
>>>>
>>>> I have used the voltage tree from next-20110509 for today.
>>>
>>> Jorge, could you send a fix for this today.
>>
>> The following patch should solve this:
>>
>> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
>> MFD: Fix TPS65910 build
>>
>> Support for tps65910 as a module is not available. The driver can
>> only be compiled as built-in. OTOH, the regulator driver can still
>> be built as module without breaking the compilation.
>>
>> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
>
> Today (even with the above patch included) I got these errors from the
> x86_64 allmodconfig build:
>
> tps65910.c:(.text+0xf4140): undefined reference to `i2c_master_send'
> drivers/built-in.o: In function `tps65910_i2c_read':
> tps65910.c:(.text+0xf41d2): undefined reference to `i2c_transfer'
> drivers/built-in.o: In function `tps65910_i2c_init':
> tps65910.c:(.init.text+0xcb83): undefined reference to `i2c_register_driver'
> drivers/built-in.o: In function `tps65910_i2c_exit':
> tps65910.c:(.exit.text+0x6e0): undefined reference to `i2c_del_driver'
>
> I have used the voltage tree from next-20110509 again today.
Following patch should fix the dependency problems. Please review:
From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
[PATCH] MFD: TPS65910: Fix I2C dependency
TPS65910 driver can only be compiled built-in, so the I2C driver
should be as well.
Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
---
drivers/mfd/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index c78865e..0131d49 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -673,7 +673,7 @@ config MFD_OMAP_USB_HOST
config MFD_TPS65910
bool "TPS65910 Power Management chip"
- depends on I2C && GPIOLIB
+ depends on I2C=y && GPIOLIB
select MFD_CORE
help
if you say yes here you get support for the TPS65910 series of
--
1.7.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2011-05-10 17:30 ` Jorge Eduardo Candelaria
2011-05-10 19:57 ` Liam Girdwood
@ 2011-05-11 2:27 ` Stephen Rothwell
2011-05-11 6:43 ` Jorge Eduardo Candelaria
1 sibling, 1 reply; 20+ messages in thread
From: Stephen Rothwell @ 2011-05-11 2:27 UTC (permalink / raw)
To: Jorge Eduardo Candelaria
Cc: Liam Girdwood, linux-next, linux-kernel, Graeme Gregory
[-- Attachment #1: Type: text/plain, Size: 1993 bytes --]
Hi Jorge,
On Tue, 10 May 2011 12:30:36 -0500 Jorge Eduardo Candelaria <jedu@slimlogic.co.uk> wrote:
>
> On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:
>
> > On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
> >> Hi Liam,
> >>
> >> After merging the voltage tree, today's linux-next build (x86_64
> >> allmodconfig) failed like this:
> >>
> >> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
> >> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
> >> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
> >> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
> >> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
> >>
> >> I have used the voltage tree from next-20110509 for today.
> >
> > Jorge, could you send a fix for this today.
>
> The following patch should solve this:
>
> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> MFD: Fix TPS65910 build
>
> Support for tps65910 as a module is not available. The driver can
> only be compiled as built-in. OTOH, the regulator driver can still
> be built as module without breaking the compilation.
>
> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
Today (even with the above patch included) I got these errors from the
x86_64 allmodconfig build:
tps65910.c:(.text+0xf4140): undefined reference to `i2c_master_send'
drivers/built-in.o: In function `tps65910_i2c_read':
tps65910.c:(.text+0xf41d2): undefined reference to `i2c_transfer'
drivers/built-in.o: In function `tps65910_i2c_init':
tps65910.c:(.init.text+0xcb83): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `tps65910_i2c_exit':
tps65910.c:(.exit.text+0x6e0): undefined reference to `i2c_del_driver'
I have used the voltage tree from next-20110509 again today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2011-05-10 17:30 ` Jorge Eduardo Candelaria
@ 2011-05-10 19:57 ` Liam Girdwood
2011-05-11 2:27 ` Stephen Rothwell
1 sibling, 0 replies; 20+ messages in thread
From: Liam Girdwood @ 2011-05-10 19:57 UTC (permalink / raw)
To: Jorge Eduardo Candelaria
Cc: linux-next, linux-kernel, Graeme Gregory, Stephen Rothwell
On Tue, 2011-05-10 at 12:30 -0500, Jorge Eduardo Candelaria wrote:
> On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:
>
> > On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
> >> Hi Liam,
> >>
> >> After merging the voltage tree, today's linux-next build (x86_64
> >> allmodconfig) failed like this:
> >>
> >> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
> >> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
> >> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
> >> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
> >> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
> >>
> >> I have used the voltage tree from next-20110509 for today.
> >
> > Jorge, could you send a fix for this today.
> >
> > Thanks
> >
> > Liam
> >
>
> The following patch should solve this:
>
> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> MFD: Fix TPS65910 build
>
> Support for tps65910 as a module is not available. The driver can
> only be compiled as built-in. OTOH, the regulator driver can still
> be built as module without breaking the compilation.
>
> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> ---
> drivers/mfd/Kconfig | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 65930a7..c78865e 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -672,8 +672,8 @@ config MFD_OMAP_USB_HOST
> OMAP USB Host drivers.
>
> config MFD_TPS65910
> - tristate "TPS65910 Power Management chip"
> - depends on I2C && GPIOLIB
> + bool "TPS65910 Power Management chip"
> + depends on I2C && GPIOLIB
> select MFD_CORE
> help
> if you say yes here you get support for the TPS65910 series of
Applied.
Thanks
Liam
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2011-05-10 8:38 ` Liam Girdwood
@ 2011-05-10 17:30 ` Jorge Eduardo Candelaria
2011-05-10 19:57 ` Liam Girdwood
2011-05-11 2:27 ` Stephen Rothwell
0 siblings, 2 replies; 20+ messages in thread
From: Jorge Eduardo Candelaria @ 2011-05-10 17:30 UTC (permalink / raw)
To: Liam Girdwood; +Cc: linux-next, linux-kernel, Graeme Gregory, Stephen Rothwell
On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:
> On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
>> Hi Liam,
>>
>> After merging the voltage tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
>> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
>> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
>> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
>> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
>>
>> I have used the voltage tree from next-20110509 for today.
>
> Jorge, could you send a fix for this today.
>
> Thanks
>
> Liam
>
The following patch should solve this:
From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
MFD: Fix TPS65910 build
Support for tps65910 as a module is not available. The driver can
only be compiled as built-in. OTOH, the regulator driver can still
be built as module without breaking the compilation.
Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
---
drivers/mfd/Kconfig | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 65930a7..c78865e 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -672,8 +672,8 @@ config MFD_OMAP_USB_HOST
OMAP USB Host drivers.
config MFD_TPS65910
- tristate "TPS65910 Power Management chip"
- depends on I2C && GPIOLIB
+ bool "TPS65910 Power Management chip"
+ depends on I2C && GPIOLIB
select MFD_CORE
help
if you say yes here you get support for the TPS65910 series of
--
1.7.1
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2011-05-10 2:44 Stephen Rothwell
@ 2011-05-10 8:38 ` Liam Girdwood
2011-05-10 17:30 ` Jorge Eduardo Candelaria
0 siblings, 1 reply; 20+ messages in thread
From: Liam Girdwood @ 2011-05-10 8:38 UTC (permalink / raw)
To: Jorge Eduardo Candelaria
Cc: linux-next, linux-kernel, Graeme Gregory, Stephen Rothwell
On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
> Hi Liam,
>
> After merging the voltage tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
>
> I have used the voltage tree from next-20110509 for today.
Jorge, could you send a fix for this today.
Thanks
Liam
^ permalink raw reply [flat|nested] 20+ messages in thread
* linux-next: build failure after merge of the voltage tree
@ 2011-05-10 2:44 Stephen Rothwell
2011-05-10 8:38 ` Liam Girdwood
0 siblings, 1 reply; 20+ messages in thread
From: Stephen Rothwell @ 2011-05-10 2:44 UTC (permalink / raw)
To: Liam Girdwood
Cc: linux-next, linux-kernel, Graeme Gregory, Jorge Eduardo Candelaria
[-- Attachment #1: Type: text/plain, Size: 630 bytes --]
Hi Liam,
After merging the voltage tree, today's linux-next build (x86_64
allmodconfig) failed like this:
ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
I have used the voltage tree from next-20110509 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2010-12-15 9:04 ` Liam Girdwood
@ 2010-12-15 14:03 ` Mark Brown
0 siblings, 0 replies; 20+ messages in thread
From: Mark Brown @ 2010-12-15 14:03 UTC (permalink / raw)
To: Liam Girdwood; +Cc: Stephen Rothwell, linux-next, linux-kernel, Yong Shen
On Wed, Dec 15, 2010 at 09:04:44AM +0000, Liam Girdwood wrote:
> Yong, can you send a patch *today* that fixes the modular build for
> this.
Looks like he's not going to get a chance to do that, I'm cooking up
some patches just now which should deal with the issue.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2010-12-15 2:09 Stephen Rothwell
@ 2010-12-15 9:04 ` Liam Girdwood
2010-12-15 14:03 ` Mark Brown
0 siblings, 1 reply; 20+ messages in thread
From: Liam Girdwood @ 2010-12-15 9:04 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Yong Shen
On Wed, 2010-12-15 at 13:09 +1100, Stephen Rothwell wrote:
> Hi Liam,
>
> After merging the voltage tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/built-in.o: In function `mc13xxx_regulator_is_enabled':
> mc13xxx-regulator-core.c:(.text+0x9b01c): undefined reference to `mc13xxx_lock'
> mc13xxx-regulator-core.c:(.text+0x9b038): undefined reference to `mc13xxx_reg_read'
> mc13xxx-regulator-core.c:(.text+0x9b04a): undefined reference to `mc13xxx_unlock'
> drivers/built-in.o: In function `mc13xxx_regulator_disable':
> mc13xxx-regulator-core.c:(.text+0x9b256): undefined reference to `mc13xxx_lock'
> mc13xxx-regulator-core.c:(.text+0x9b26f): undefined reference to `mc13xxx_reg_rmw'
> mc13xxx-regulator-core.c:(.text+0x9b281): undefined reference to `mc13xxx_unlock'
> drivers/built-in.o: In function `mc13xxx_regulator_enable':
> mc13xxx-regulator-core.c:(.text+0x9b323): undefined reference to `mc13xxx_lock'
> mc13xxx-regulator-core.c:(.text+0x9b33c): undefined reference to `mc13xxx_reg_rmw'
> mc13xxx-regulator-core.c:(.text+0x9b34e): undefined reference to `mc13xxx_unlock'
> drivers/built-in.o: In function `mc13xxx_regulator_get_voltage':
> mc13xxx-regulator-core.c:(.text+0x9b3f5): undefined reference to `mc13xxx_lock'
> mc13xxx-regulator-core.c:(.text+0x9b40c): undefined reference to `mc13xxx_reg_read'
> mc13xxx-regulator-core.c:(.text+0x9b41f): undefined reference to `mc13xxx_unlock'
> drivers/built-in.o: In function `mc13xxx_regulator_set_voltage':
> mc13xxx-regulator-core.c:(.text+0x9b67f): undefined reference to `mc13xxx_lock'
> mc13xxx-regulator-core.c:(.text+0x9b6a4): undefined reference to `mc13xxx_reg_rmw'
> mc13xxx-regulator-core.c:(.text+0x9b6b6): undefined reference to `mc13xxx_unlock'
>
> Please build test this stuff ...
>
Sorry, this driver does build as built-in.
Yong, can you send a patch *today* that fixes the modular build for
this.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 20+ messages in thread
* linux-next: build failure after merge of the voltage tree
@ 2010-12-15 2:09 Stephen Rothwell
2010-12-15 9:04 ` Liam Girdwood
0 siblings, 1 reply; 20+ messages in thread
From: Stephen Rothwell @ 2010-12-15 2:09 UTC (permalink / raw)
To: Liam Girdwood; +Cc: linux-next, linux-kernel, Yong Shen
[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]
Hi Liam,
After merging the voltage tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
drivers/built-in.o: In function `mc13xxx_regulator_is_enabled':
mc13xxx-regulator-core.c:(.text+0x9b01c): undefined reference to `mc13xxx_lock'
mc13xxx-regulator-core.c:(.text+0x9b038): undefined reference to `mc13xxx_reg_read'
mc13xxx-regulator-core.c:(.text+0x9b04a): undefined reference to `mc13xxx_unlock'
drivers/built-in.o: In function `mc13xxx_regulator_disable':
mc13xxx-regulator-core.c:(.text+0x9b256): undefined reference to `mc13xxx_lock'
mc13xxx-regulator-core.c:(.text+0x9b26f): undefined reference to `mc13xxx_reg_rmw'
mc13xxx-regulator-core.c:(.text+0x9b281): undefined reference to `mc13xxx_unlock'
drivers/built-in.o: In function `mc13xxx_regulator_enable':
mc13xxx-regulator-core.c:(.text+0x9b323): undefined reference to `mc13xxx_lock'
mc13xxx-regulator-core.c:(.text+0x9b33c): undefined reference to `mc13xxx_reg_rmw'
mc13xxx-regulator-core.c:(.text+0x9b34e): undefined reference to `mc13xxx_unlock'
drivers/built-in.o: In function `mc13xxx_regulator_get_voltage':
mc13xxx-regulator-core.c:(.text+0x9b3f5): undefined reference to `mc13xxx_lock'
mc13xxx-regulator-core.c:(.text+0x9b40c): undefined reference to `mc13xxx_reg_read'
mc13xxx-regulator-core.c:(.text+0x9b41f): undefined reference to `mc13xxx_unlock'
drivers/built-in.o: In function `mc13xxx_regulator_set_voltage':
mc13xxx-regulator-core.c:(.text+0x9b67f): undefined reference to `mc13xxx_lock'
mc13xxx-regulator-core.c:(.text+0x9b6a4): undefined reference to `mc13xxx_reg_rmw'
mc13xxx-regulator-core.c:(.text+0x9b6b6): undefined reference to `mc13xxx_unlock'
Please build test this stuff ...
I have used the voltage tree from next-20101213 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2010-12-14 15:56 ` Liam Girdwood
@ 2010-12-15 2:03 ` Yong Shen
0 siblings, 0 replies; 20+ messages in thread
From: Yong Shen @ 2010-12-15 2:03 UTC (permalink / raw)
To: Liam Girdwood; +Cc: Stephen Rothwell, linux-next, linux-kernel
Hi Liam,
Thanks for reminding. I will bear that in mind.
Thanks
Yong
On Tue, Dec 14, 2010 at 11:56 PM, Liam Girdwood <lrg@slimlogic.co.uk> wrote:
> On Tue, 2010-12-14 at 13:10 +0800, Yong Shen wrote:
>> Hi Stephen,
>>
>> I had already noticed Liam. Mc13892's patch depends on other two
>> patches which are not applied yet.
>>
>
> All applied now.
>
> Yong, in the future please wait until patches are applied before sending
> new dependent patches. This series and the last were quite confusing to
> deal with due to the sheer number of similar subject emails.
>
> Thanks
>
> Liam
> --
> Freelance Developer, SlimLogic Ltd
> ASoC and Voltage Regulator Maintainer.
> http://www.slimlogic.co.uk
>
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2010-12-14 5:10 ` Yong Shen
@ 2010-12-14 15:56 ` Liam Girdwood
2010-12-15 2:03 ` Yong Shen
0 siblings, 1 reply; 20+ messages in thread
From: Liam Girdwood @ 2010-12-14 15:56 UTC (permalink / raw)
To: Yong Shen; +Cc: Stephen Rothwell, linux-next, linux-kernel
On Tue, 2010-12-14 at 13:10 +0800, Yong Shen wrote:
> Hi Stephen,
>
> I had already noticed Liam. Mc13892's patch depends on other two
> patches which are not applied yet.
>
All applied now.
Yong, in the future please wait until patches are applied before sending
new dependent patches. This series and the last were quite confusing to
deal with due to the sheer number of similar subject emails.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2010-12-14 4:49 Stephen Rothwell
@ 2010-12-14 5:10 ` Yong Shen
2010-12-14 15:56 ` Liam Girdwood
0 siblings, 1 reply; 20+ messages in thread
From: Yong Shen @ 2010-12-14 5:10 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel
Hi Stephen,
I had already noticed Liam. Mc13892's patch depends on other two
patches which are not applied yet.
Yong
On Tue, Dec 14, 2010 at 12:49 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Liam,
>
> After merging the voltage tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/regulator/mc13892-regulator.c:21:21: error: mc13xxx.h: No such file or directory
> drivers/regulator/mc13892-regulator.c:261: error: array type has incomplete element type
> drivers/regulator/mc13892-regulator.c:262: error: implicit declaration of function 'MC13xxx_DEFINE'
> drivers/regulator/mc13892-regulator.c:262: error: 'MC13892_' undeclared here (not in a function)
>
> and on and on ....
>
> Caused by commit b0e2417cdbc12b1649245315a607ae8f1072b2bf ("regulator:
> support PMIC mc13892"). A file missing from the commit, I assume.
>
> I have used the voltage tree form next-20101213 for today.
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* linux-next: build failure after merge of the voltage tree
@ 2010-12-14 4:49 Stephen Rothwell
2010-12-14 5:10 ` Yong Shen
0 siblings, 1 reply; 20+ messages in thread
From: Stephen Rothwell @ 2010-12-14 4:49 UTC (permalink / raw)
To: Liam Girdwood; +Cc: linux-next, linux-kernel, Yong Shen
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
Hi Liam,
After merging the voltage tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/regulator/mc13892-regulator.c:21:21: error: mc13xxx.h: No such file or directory
drivers/regulator/mc13892-regulator.c:261: error: array type has incomplete element type
drivers/regulator/mc13892-regulator.c:262: error: implicit declaration of function 'MC13xxx_DEFINE'
drivers/regulator/mc13892-regulator.c:262: error: 'MC13892_' undeclared here (not in a function)
and on and on ....
Caused by commit b0e2417cdbc12b1649245315a607ae8f1072b2bf ("regulator:
support PMIC mc13892"). A file missing from the commit, I assume.
I have used the voltage tree form next-20101213 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2010-11-11 11:46 ` Mark Brown
@ 2010-11-11 12:09 ` Liam Girdwood
0 siblings, 0 replies; 20+ messages in thread
From: Liam Girdwood @ 2010-11-11 12:09 UTC (permalink / raw)
To: Mark Brown; +Cc: Stephen Rothwell, linux-next, linux-kernel
On Thu, 2010-11-11 at 11:46 +0000, Mark Brown wrote:
> On Thu, Nov 11, 2010 at 11:36:38AM +1100, Stephen Rothwell wrote:
>
> > After merging the voltage tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
>
> Oh, a platform where pcap can actually be built! That's useful, thanks.
>
> > drivers/regulator/pcap-regulator.c:155: error: expected declaration specifiers or '...' before 'unsiged'
> > drivers/regulator/pcap-regulator.c: In function 'pcap_regulator_set_voltage':
> > drivers/regulator/pcap-regulator.c:175: error: 'selector' undeclared (first use in this function)
> > drivers/regulator/pcap-regulator.c: At top level:
> > drivers/regulator/pcap-regulator.c:251: warning: initialization from incompatible pointer type
>
> > Caused by commit d2f03ebfe8c63d1e3e1ab2352dd32d161546003e ("regulator:
> > Report actual configured voltage to set_voltage()"). Please always build
> > changed files ...
>
> With a lot of the embedded drivers that can be difficult - often there
> are dependencies on APIs that are only available on a small set of
> platforms (which may not even be documented). For example, with PCAP
> the core driver uses irq_to_gpio() which is not implemented on any of
> the platforms I commonly build for.
> --
Fix now applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: linux-next: build failure after merge of the voltage tree
2010-11-11 0:36 Stephen Rothwell
@ 2010-11-11 11:46 ` Mark Brown
2010-11-11 12:09 ` Liam Girdwood
0 siblings, 1 reply; 20+ messages in thread
From: Mark Brown @ 2010-11-11 11:46 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Liam Girdwood, linux-next, linux-kernel
On Thu, Nov 11, 2010 at 11:36:38AM +1100, Stephen Rothwell wrote:
> After merging the voltage tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
Oh, a platform where pcap can actually be built! That's useful, thanks.
> drivers/regulator/pcap-regulator.c:155: error: expected declaration specifiers or '...' before 'unsiged'
> drivers/regulator/pcap-regulator.c: In function 'pcap_regulator_set_voltage':
> drivers/regulator/pcap-regulator.c:175: error: 'selector' undeclared (first use in this function)
> drivers/regulator/pcap-regulator.c: At top level:
> drivers/regulator/pcap-regulator.c:251: warning: initialization from incompatible pointer type
> Caused by commit d2f03ebfe8c63d1e3e1ab2352dd32d161546003e ("regulator:
> Report actual configured voltage to set_voltage()"). Please always build
> changed files ...
With a lot of the embedded drivers that can be difficult - often there
are dependencies on APIs that are only available on a small set of
platforms (which may not even be documented). For example, with PCAP
the core driver uses irq_to_gpio() which is not implemented on any of
the platforms I commonly build for.
^ permalink raw reply [flat|nested] 20+ messages in thread
* linux-next: build failure after merge of the voltage tree
@ 2010-11-11 0:36 Stephen Rothwell
2010-11-11 11:46 ` Mark Brown
0 siblings, 1 reply; 20+ messages in thread
From: Stephen Rothwell @ 2010-11-11 0:36 UTC (permalink / raw)
To: Liam Girdwood; +Cc: linux-next, linux-kernel, Mark Brown
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
Hi Liam,
After merging the voltage tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/regulator/pcap-regulator.c:155: error: expected declaration specifiers or '...' before 'unsiged'
drivers/regulator/pcap-regulator.c: In function 'pcap_regulator_set_voltage':
drivers/regulator/pcap-regulator.c:175: error: 'selector' undeclared (first use in this function)
drivers/regulator/pcap-regulator.c: At top level:
drivers/regulator/pcap-regulator.c:251: warning: initialization from incompatible pointer type
Caused by commit d2f03ebfe8c63d1e3e1ab2352dd32d161546003e ("regulator:
Report actual configured voltage to set_voltage()"). Please always build
changed files ...
I have used the voltage tree from next-20101110 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2011-05-27 21:22 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201105271759.p4RHxa2X008919@hera.kernel.org>
2011-05-27 19:58 ` linux-next: build failure after merge of the voltage tree Randy Dunlap
2011-05-27 21:13 ` Liam Girdwood
2011-05-27 21:21 ` Randy Dunlap
2011-05-10 2:44 Stephen Rothwell
2011-05-10 8:38 ` Liam Girdwood
2011-05-10 17:30 ` Jorge Eduardo Candelaria
2011-05-10 19:57 ` Liam Girdwood
2011-05-11 2:27 ` Stephen Rothwell
2011-05-11 6:43 ` Jorge Eduardo Candelaria
2011-05-11 13:29 ` Liam Girdwood
-- strict thread matches above, loose matches on Subject: below --
2010-12-15 2:09 Stephen Rothwell
2010-12-15 9:04 ` Liam Girdwood
2010-12-15 14:03 ` Mark Brown
2010-12-14 4:49 Stephen Rothwell
2010-12-14 5:10 ` Yong Shen
2010-12-14 15:56 ` Liam Girdwood
2010-12-15 2:03 ` Yong Shen
2010-11-11 0:36 Stephen Rothwell
2010-11-11 11:46 ` Mark Brown
2010-11-11 12:09 ` Liam Girdwood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.