[Qemu-devel] [RESEND][PATCH 1/2] Fix USB mouse Set_Protocol behavior

[Qemu-devel] [RESEND][PATCH 1/2] Fix USB mouse Set_Protocol behavior

[Kevin O'Connor]

The QEMU USB mouse claims to support the "boot" protocol
(bInterfaceSubClass is 1).  However, the mouse rejects the
Set_Protocol command.

The qemu mouse does support the "boot" protocol specification, so a
simple fix is to enable the Set_Protocol request.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
---
 hw/usb-hid.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/usb-hid.c b/hw/usb-hid.c
index 89c293c..268669b 100644
--- a/hw/usb-hid.c
+++ b/hw/usb-hid.c
@@ -779,13 +779,13 @@ static int usb_hid_handle_control(USBDevice *dev, int request, int value,
             goto fail;
         break;
     case GET_PROTOCOL:
-        if (s->kind != USB_KEYBOARD)
+        if (s->kind != USB_KEYBOARD && s->kind != USB_MOUSE)
             goto fail;
         ret = 1;
         data[0] = s->protocol;
         break;
     case SET_PROTOCOL:
-        if (s->kind != USB_KEYBOARD)
+        if (s->kind != USB_KEYBOARD && s->kind != USB_MOUSE)
             goto fail;
         ret = 0;
         s->protocol = value;
-- 
1.7.4.4

Re: [Qemu-devel] [RESEND][PATCH 1/2] Fix USB mouse Set_Protocol behavior

[Gerd Hoffmann]

On 05/28/11 17:47, Kevin O'Connor wrote:
> The QEMU USB mouse claims to support the "boot" protocol
> (bInterfaceSubClass is 1).  However, the mouse rejects the
> Set_Protocol command.
>
> The qemu mouse does support the "boot" protocol specification, so a
> simple fix is to enable the Set_Protocol request.

Added to the usb patch queue (both).

thanks,
   Gerd