All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lutz Sammer <johns98@gmx.net>
To: hselasky@c2i.net
Cc: linux-media@vger.kernel.org
Subject: RE: [PATCH v3 - resend] Fix the derot zig-zag to work with TT-USB2.0 TechnoTrend.
Date: Thu, 02 Jun 2011 11:46:15 +0200	[thread overview]
Message-ID: <4DE75BE7.4050403@gmx.net> (raw)

Hello Hans Petter,

I haven't tested your patch yet, but looking at the source I see some
problems.

What does your patch fix and how?

If you have problem locking channels, try my locking patch:
https://patchwork.kernel.org/patch/753382/

On each step (timing, carrier, data) you reset the derot:
     stb0899_set_derot(state, 0);
Why?

Afaik you destroy already locked frequencies, which slows
down the locking.

Than you do 8 loops:
    for (index = 0; index < 8; index++) {
Why?

All checks already contains some delays, if the delays are too
short, you should fix this delays.

Johns

             reply	other threads:[~2011-06-02  9:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02  9:46 Lutz Sammer [this message]
2011-06-02 10:03 ` [PATCH v3 - resend] Fix the derot zig-zag to work with TT-USB2.0 TechnoTrend Hans Petter Selasky
  -- strict thread matches above, loose matches on Subject: below --
2011-05-28 13:16 Hans Petter Selasky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE75BE7.4050403@gmx.net \
    --to=johns98@gmx.net \
    --cc=hselasky@c2i.net \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.