All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [STATUS] WARNING: huge ARM board removal pending
@ 2011-06-02 21:51 Wolfgang Denk
       [not found] ` <8A423D2D-B4CA-422A-813D-E808A0B849A0@googlemail.com>
                   ` (5 more replies)
  0 siblings, 6 replies; 14+ messages in thread
From: Wolfgang Denk @ 2011-06-02 21:51 UTC (permalink / raw)
  To: u-boot


Hi,

this is a * W A R N I N G * message to maintainers / users / owners
of ARM boards.  If your board fails to build in the current release,
it will be subject to a big cleanup action which is going to remove
all old, unmaintained and broken boards in the next merge window.
According to our current schedule, this is in 10 days from now.


At present, the following 112 boards are scheduled for removal:

B2		    at91sam9m10g45ek	edb9307a	    omap2420h4
CPU9260		    at91sam9rlek	edb9312		    omap5912osk
CPU9G20		    cmc_pu2		edb9315		    omap730p2
CPUAT91		    cp1026		edb9315a	    otc570_dataflash
SBC35_A9G20	    cp1136		ep7312		    pm9261
SMN42		    cp920t		evb4510		    pm9263
TNY_A9260	    cp922_XA10		gcplus		    pm9g45
TNY_A9G20	    cp926ejs		impa7		    sbc2410x
afeb9260	    cp946es		imx31_phycore	    scb9328
ap7		    cp966		imx31_phycore_eet   shannon
ap720t		    cpu9260		integratorap	    smdk2400
ap920t		    cpu9260_128M	integratorcp	    smdk6400
ap922_XA10	    cpu9260_nand	jornada		    snapper9260
ap926ejs	    cpu9260_nand_128M	kb9202		    snapper9g20
ap946es		    cpu9G20		lart		    spear300
ap966		    cpu9G20_128M	lpc2292sodimm	    spear310
apollon		    cpu9G20_nand	lpd7a400	    spear320
armadillo	    cpu9G20_nand_128M	m501sk		    spear600
assabet		    cpuat91		meesc		    tnetv107x_evm
at91cap9adk	    cpuat91_ram		meesc_dataflash	    top9000eval_xe
at91rm9200dk	    csb226		modnet50	    top9000su_xe
at91rm9200ek	    csb637		mx1ads		    trab
at91rm9200ek_ram    dnp1110		mx1fs2		    versatile
at91sam9260ek	    eb_cpux9k2		mx31ads		    versatileab
at91sam9261ek	    edb9301		netstar		    versatilepb
at91sam9263ek	    edb9302		omap1510inn	    voiceblue
at91sam9g10ek	    edb9302a		omap1610h2	    zipitz2
at91sam9g20ek	    edb9307		omap1610inn	    zylonite


Please submit fixes to prevent removal.

Note:  countdown is T minus 10 days, and counting.

You have been warned.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
C++ is the best example of second-system effect since OS/360.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [STATUS] WARNING: huge ARM board removal pending
       [not found] ` <8A423D2D-B4CA-422A-813D-E808A0B849A0@googlemail.com>
@ 2011-06-03  8:09   ` Wolfgang Denk
  0 siblings, 0 replies; 14+ messages in thread
From: Wolfgang Denk @ 2011-06-03  8:09 UTC (permalink / raw)
  To: u-boot

Dear Reinhard,

In message <8A423D2D-B4CA-422A-813D-E808A0B849A0@googlemail.com> Andreas Bie?mann wrote:
> 
> > At present, the following 112 boards are scheduled for removal:
>
> <snip boards>
>
> > Please submit fixes to prevent removal.
>
> http://patchwork.ozlabs.org/patch/83703/ is pending since february and will fix at least:
>
> at91rm9200ek at91rm9200ek_ram eb_cpux9k2
> (maybe some other arm920t/at91 boards)
>  
> > Note:  countdown is T minus 10 days, and counting.
>
> Reinhard could you please schedule this patch?
>

Can you please comment why thi spatch has not been applied yet, and
when we will see a pull request to include it?

Would it be possible to have this in the next few days, so we cah have
a -rc3 before the .06 release?

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What was sliced bread the greatest thing since?

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [STATUS] WARNING: huge ARM board removal pending
  2011-06-02 21:51 [U-Boot] [STATUS] WARNING: huge ARM board removal pending Wolfgang Denk
       [not found] ` <8A423D2D-B4CA-422A-813D-E808A0B849A0@googlemail.com>
@ 2011-06-03  8:31 ` Andy Pont
  2011-06-03 11:13   ` Wolfgang Denk
  2011-06-03 11:09 ` Graeme Russ
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 14+ messages in thread
From: Andy Pont @ 2011-06-03  8:31 UTC (permalink / raw)
  To: u-boot

Hi Wolfgang,

> this is a * W A R N I N G * message to maintainers / users / owners
> of ARM boards.  If your board fails to build in the current release,
> it will be subject to a big cleanup action which is going to remove
> all old, unmaintained and broken boards in the next merge window.
> According to our current schedule, this is in 10 days from now.

Although I'm not the board maintainer I do have an omap5912osk board sat on
the shelf and am happy to do the necessary work to get the current code
release to work but it would have to wait until some current project work is
completed which may take the rest of June.

Is that OK?

Andy.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [STATUS] WARNING: huge ARM board removal pending
  2011-06-02 21:51 [U-Boot] [STATUS] WARNING: huge ARM board removal pending Wolfgang Denk
       [not found] ` <8A423D2D-B4CA-422A-813D-E808A0B849A0@googlemail.com>
  2011-06-03  8:31 ` Andy Pont
@ 2011-06-03 11:09 ` Graeme Russ
  2011-06-03 12:50 ` Eric Bénard
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 14+ messages in thread
From: Graeme Russ @ 2011-06-03 11:09 UTC (permalink / raw)
  To: u-boot

On 03/06/11 07:51, Wolfgang Denk wrote:
> 
> Hi,
> 
> this is a * W A R N I N G * message to maintainers / users / owners
> of ARM boards.  If your board fails to build in the current release,
> it will be subject to a big cleanup action which is going to remove
> all old, unmaintained and broken boards in the next merge window.
> According to our current schedule, this is in 10 days from now.
> 
> 
> At present, the following 112 boards are scheduled for removal:
> 
> B2		    at91sam9m10g45ek	edb9307a	    omap2420h4
> CPU9260		    at91sam9rlek	edb9312		    omap5912osk
> CPU9G20		    cmc_pu2		edb9315		    omap730p2
> CPUAT91		    cp1026		edb9315a	    otc570_dataflash
> SBC35_A9G20	    cp1136		ep7312		    pm9261
> SMN42		    cp920t		evb4510		    pm9263
> TNY_A9260	    cp922_XA10		gcplus		    pm9g45
> TNY_A9G20	    cp926ejs		impa7		    sbc2410x
> afeb9260	    cp946es		imx31_phycore	    scb9328
> ap7		    cp966		imx31_phycore_eet   shannon
> ap720t		    cpu9260		integratorap	    smdk2400
> ap920t		    cpu9260_128M	integratorcp	    smdk6400
> ap922_XA10	    cpu9260_nand	jornada		    snapper9260
> ap926ejs	    cpu9260_nand_128M	kb9202		    snapper9g20
> ap946es		    cpu9G20		lart		    spear300
> ap966		    cpu9G20_128M	lpc2292sodimm	    spear310
> apollon		    cpu9G20_nand	lpd7a400	    spear320
> armadillo	    cpu9G20_nand_128M	m501sk		    spear600
> assabet		    cpuat91		meesc		    tnetv107x_evm
> at91cap9adk	    cpuat91_ram		meesc_dataflash	    top9000eval_xe
> at91rm9200dk	    csb226		modnet50	    top9000su_xe
> at91rm9200ek	    csb637		mx1ads		    trab
> at91rm9200ek_ram    dnp1110		mx1fs2		    versatile
> at91sam9260ek	    eb_cpux9k2		mx31ads		    versatileab
> at91sam9261ek	    edb9301		netstar		    versatilepb
> at91sam9263ek	    edb9302		omap1510inn	    voiceblue
> at91sam9g10ek	    edb9302a		omap1610h2	    zipitz2
> at91sam9g20ek	    edb9307		omap1610inn	    zylonite
> 
> 
> Please submit fixes to prevent removal.
> 
> Note:  countdown is T minus 10 days, and counting.
> 
> You have been warned.
> 

Looks like the worst offenders of the current timer API are also on this
list. If they get fixed within the next merge window, the timer API will
get updated 'for free' - If you bring them back from the dead, you will
have to sort out updating timer API usage yourself (as well as relocation)

Regards,

Graeme

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [STATUS] WARNING: huge ARM board removal pending
  2011-06-03  8:31 ` Andy Pont
@ 2011-06-03 11:13   ` Wolfgang Denk
  0 siblings, 0 replies; 14+ messages in thread
From: Wolfgang Denk @ 2011-06-03 11:13 UTC (permalink / raw)
  To: u-boot

Dear "Andy Pont",

In message <009601cc21c8$92412360$b6c36a20$@pont@sdcsystems.com> you wrote:
> 
> Although I'm not the board maintainer I do have an omap5912osk board sat on
> the shelf and am happy to do the necessary work to get the current code
> release to work but it would have to wait until some current project work is
> completed which may take the rest of June.
> 
> Is that OK?

Sure. Thanks in advance.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There is, however, a strange, musty smell in the air that reminds  me
of something...hmm...yes...I've got it...there's a VMS nearby, or I'm
a Blit.          - Larry Wall in Configure from the perl distribution

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [STATUS] WARNING: huge ARM board removal pending
  2011-06-02 21:51 [U-Boot] [STATUS] WARNING: huge ARM board removal pending Wolfgang Denk
                   ` (2 preceding siblings ...)
  2011-06-03 11:09 ` Graeme Russ
@ 2011-06-03 12:50 ` Eric Bénard
  2011-06-03 13:10 ` Igor Grinberg
  2011-06-08  8:47 ` Minkyu Kang
  5 siblings, 0 replies; 14+ messages in thread
From: Eric Bénard @ 2011-06-03 12:50 UTC (permalink / raw)
  To: u-boot

Hi Wolfgang,

cpu9260* and cpu9G20* were fixed in april by commit 
c2b2a07eeb688b52ad74a1b679904cf3c339f34f
cpuat91* were fixed in 632f8fdf4c4fae8343409be13d5e028cd4eee32d

All these boards were then broken by the at91 rework in Reinhard's pull 
request of may.

So please don't remove these board until I find time to fix them.

Thanks,
Eric

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [STATUS] WARNING: huge ARM board removal pending
  2011-06-02 21:51 [U-Boot] [STATUS] WARNING: huge ARM board removal pending Wolfgang Denk
                   ` (3 preceding siblings ...)
  2011-06-03 12:50 ` Eric Bénard
@ 2011-06-03 13:10 ` Igor Grinberg
  2011-06-06 20:17   ` Albert ARIBAUD
  2011-06-08  8:47 ` Minkyu Kang
  5 siblings, 1 reply; 14+ messages in thread
From: Igor Grinberg @ 2011-06-03 13:10 UTC (permalink / raw)
  To: u-boot

On 06/03/11 00:51, Wolfgang Denk wrote:

> Hi,

Hi Wolfgang,

[...]

> omap1610h2
> omap1610inn

> Please submit fixes to prevent removal.

I've sent a compile fix [1] for omap1610h2 and omap1610inn about a month ago,
but still it hasn't been picked up.

Sandeep said, he is on vacation, may be Albert should pick this up instead?

[1] http://patchwork.ozlabs.org/patch/93545/

-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [STATUS] WARNING: huge ARM board removal pending
  2011-06-03 13:10 ` Igor Grinberg
@ 2011-06-06 20:17   ` Albert ARIBAUD
  2011-06-07  5:42     ` Igor Grinberg
  0 siblings, 1 reply; 14+ messages in thread
From: Albert ARIBAUD @ 2011-06-06 20:17 UTC (permalink / raw)
  To: u-boot

Hi,

Le 03/06/2011 15:10, Igor Grinberg a ?crit :
> On 06/03/11 00:51, Wolfgang Denk wrote:
>
>> Hi,
>
> Hi Wolfgang,
>
> [...]
>
>> omap1610h2
>> omap1610inn
>
>> Please submit fixes to prevent removal.
>
> I've sent a compile fix [1] for omap1610h2 and omap1610inn about a month ago,
> but still it hasn't been picked up.
>
> Sandeep said, he is on vacation, may be Albert should pick this up instead?
>
> [1] http://patchwork.ozlabs.org/patch/93545/

What exactly do the FIXMEs mean? Are the definitions of 
CONFIG_SYS_INIT_SP_ADDR somehow incorrect in this patch, or just 
non-optimal?

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [STATUS] WARNING: huge ARM board removal pending
  2011-06-06 20:17   ` Albert ARIBAUD
@ 2011-06-07  5:42     ` Igor Grinberg
  2011-06-07 18:21       ` Albert ARIBAUD
  0 siblings, 1 reply; 14+ messages in thread
From: Igor Grinberg @ 2011-06-07  5:42 UTC (permalink / raw)
  To: u-boot

On 06/06/11 23:17, Albert ARIBAUD wrote:

> Hi,
>
> Le 03/06/2011 15:10, Igor Grinberg a ?crit :
>> On 06/03/11 00:51, Wolfgang Denk wrote:
>>
>>> Hi,
>>
>> Hi Wolfgang,
>>
>> [...]
>>
>>> omap1610h2
>>> omap1610inn
>>
>>> Please submit fixes to prevent removal.
>>
>> I've sent a compile fix [1] for omap1610h2 and omap1610inn about a month ago,
>> but still it hasn't been picked up.
>>
>> Sandeep said, he is on vacation, may be Albert should pick this up instead?
>>
>> [1] http://patchwork.ozlabs.org/patch/93545/
>
> What exactly do the FIXMEs mean? Are the definitions of CONFIG_SYS_INIT_SP_ADDR somehow incorrect in this patch, or just non-optimal?

This means, that I could not test those, because I don't have the hardware.
I've taken those from the same SoC, so they should be fine, but again could not test,
so I've added a comment.

-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [STATUS] WARNING: huge ARM board removal pending
  2011-06-07  5:42     ` Igor Grinberg
@ 2011-06-07 18:21       ` Albert ARIBAUD
  2011-06-08 20:00         ` Igor Grinberg
  0 siblings, 1 reply; 14+ messages in thread
From: Albert ARIBAUD @ 2011-06-07 18:21 UTC (permalink / raw)
  To: u-boot

Hi Igor,

Le 07/06/2011 07:42, Igor Grinberg a ?crit :
> On 06/06/11 23:17, Albert ARIBAUD wrote:
>
>> Hi,
>>
>> Le 03/06/2011 15:10, Igor Grinberg a ?crit :
>>> On 06/03/11 00:51, Wolfgang Denk wrote:
>>>
>>>> Hi,
>>>
>>> Hi Wolfgang,
>>>
>>> [...]
>>>
>>>> omap1610h2
>>>> omap1610inn
>>>
>>>> Please submit fixes to prevent removal.
>>>
>>> I've sent a compile fix [1] for omap1610h2 and omap1610inn about a month ago,
>>> but still it hasn't been picked up.
>>>
>>> Sandeep said, he is on vacation, may be Albert should pick this up instead?
>>>
>>> [1] http://patchwork.ozlabs.org/patch/93545/
>>
>> What exactly do the FIXMEs mean? Are the definitions of CONFIG_SYS_INIT_SP_ADDR somehow incorrect in this patch, or just non-optimal?
>
> This means, that I could not test those, because I don't have the hardware.
> I've taken those from the same SoC, so they should be fine, but again could not test,
> so I've added a comment.

FIXME implies the writer know something was wrong and mention it. Here, 
it is less of a FIXME and more of a TODO: test <whatever>; and I don't 
want readers to think there is a known error where there is not. Can you 
resubmit with the FIXMEs turned into TODOs?

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [STATUS] WARNING: huge ARM board removal pending
  2011-06-02 21:51 [U-Boot] [STATUS] WARNING: huge ARM board removal pending Wolfgang Denk
                   ` (4 preceding siblings ...)
  2011-06-03 13:10 ` Igor Grinberg
@ 2011-06-08  8:47 ` Minkyu Kang
  2011-06-08 20:16   ` Albert ARIBAUD
  5 siblings, 1 reply; 14+ messages in thread
From: Minkyu Kang @ 2011-06-08  8:47 UTC (permalink / raw)
  To: u-boot

Dear Albert ARIBAUD,

On 3 June 2011 06:51, Wolfgang Denk <wd@denx.de> wrote:
>
> Hi,
>
> this is a * W A R N I N G * message to maintainers / users / owners
> of ARM boards. ?If your board fails to build in the current release,
> it will be subject to a big cleanup action which is going to remove
> all old, unmaintained and broken boards in the next merge window.
> According to our current schedule, this is in 10 days from now.
>
>
> At present, the following 112 boards are scheduled for removal:
>
> B2 ? ? ? ? ? ? ? ? ?at91sam9m10g45ek ? ?edb9307a ? ? ? ? ? ?omap2420h4
> CPU9260 ? ? ? ? ? ? at91sam9rlek ? ? ? ?edb9312 ? ? ? ? ? ? omap5912osk
> CPU9G20 ? ? ? ? ? ? cmc_pu2 ? ? ? ? ? ? edb9315 ? ? ? ? ? ? omap730p2
> CPUAT91 ? ? ? ? ? ? cp1026 ? ? ? ? ? ? ?edb9315a ? ? ? ? ? ?otc570_dataflash
> SBC35_A9G20 ? ? ? ? cp1136 ? ? ? ? ? ? ?ep7312 ? ? ? ? ? ? ?pm9261
> SMN42 ? ? ? ? ? ? ? cp920t ? ? ? ? ? ? ?evb4510 ? ? ? ? ? ? pm9263
> TNY_A9260 ? ? ? ? ? cp922_XA10 ? ? ? ? ?gcplus ? ? ? ? ? ? ?pm9g45
> TNY_A9G20 ? ? ? ? ? cp926ejs ? ? ? ? ? ?impa7 ? ? ? ? ? ? ? sbc2410x
> afeb9260 ? ? ? ? ? ?cp946es ? ? ? ? ? ? imx31_phycore ? ? ? scb9328
> ap7 ? ? ? ? ? ? ? ? cp966 ? ? ? ? ? ? ? imx31_phycore_eet ? shannon
> ap720t ? ? ? ? ? ? ?cpu9260 ? ? ? ? ? ? integratorap ? ? ? ?smdk2400
> ap920t ? ? ? ? ? ? ?cpu9260_128M ? ? ? ?integratorcp ? ? ? ?smdk6400
> ap922_XA10 ? ? ? ? ?cpu9260_nand ? ? ? ?jornada ? ? ? ? ? ? snapper9260
> ap926ejs ? ? ? ? ? ?cpu9260_nand_128M ? kb9202 ? ? ? ? ? ? ?snapper9g20
> ap946es ? ? ? ? ? ? cpu9G20 ? ? ? ? ? ? lart ? ? ? ? ? ? ? ?spear300
> ap966 ? ? ? ? ? ? ? cpu9G20_128M ? ? ? ?lpc2292sodimm ? ? ? spear310
> apollon ? ? ? ? ? ? cpu9G20_nand ? ? ? ?lpd7a400 ? ? ? ? ? ?spear320
> armadillo ? ? ? ? ? cpu9G20_nand_128M ? m501sk ? ? ? ? ? ? ?spear600
> assabet ? ? ? ? ? ? cpuat91 ? ? ? ? ? ? meesc ? ? ? ? ? ? ? tnetv107x_evm
> at91cap9adk ? ? ? ? cpuat91_ram ? ? ? ? meesc_dataflash ? ? top9000eval_xe
> at91rm9200dk ? ? ? ?csb226 ? ? ? ? ? ? ?modnet50 ? ? ? ? ? ?top9000su_xe
> at91rm9200ek ? ? ? ?csb637 ? ? ? ? ? ? ?mx1ads ? ? ? ? ? ? ?trab
> at91rm9200ek_ram ? ?dnp1110 ? ? ? ? ? ? mx1fs2 ? ? ? ? ? ? ?versatile
> at91sam9260ek ? ? ? eb_cpux9k2 ? ? ? ? ?mx31ads ? ? ? ? ? ? versatileab
> at91sam9261ek ? ? ? edb9301 ? ? ? ? ? ? netstar ? ? ? ? ? ? versatilepb
> at91sam9263ek ? ? ? edb9302 ? ? ? ? ? ? omap1510inn ? ? ? ? voiceblue
> at91sam9g10ek ? ? ? edb9302a ? ? ? ? ? ?omap1610h2 ? ? ? ? ?zipitz2
> at91sam9g20ek ? ? ? edb9307 ? ? ? ? ? ? omap1610inn ? ? ? ? zylonite
>
>
> Please submit fixes to prevent removal.
>
> Note: ?countdown is T minus 10 days, and counting.
>

Please apply this patch for SMDK6400.
http://patchwork.ozlabs.org/patch/98525/

Thanks
Minkyu Kang
-- 
from. prom.
www.promsoft.net

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [STATUS] WARNING: huge ARM board removal pending
  2011-06-07 18:21       ` Albert ARIBAUD
@ 2011-06-08 20:00         ` Igor Grinberg
  2011-06-08 20:23           ` Albert ARIBAUD
  0 siblings, 1 reply; 14+ messages in thread
From: Igor Grinberg @ 2011-06-08 20:00 UTC (permalink / raw)
  To: u-boot

Hi Albert,

On 06/07/11 21:21, Albert ARIBAUD wrote:
> Hi Igor,
>
> Le 07/06/2011 07:42, Igor Grinberg a ?crit :
>> On 06/06/11 23:17, Albert ARIBAUD wrote:
>>
>>> Hi,
>>>
>>> Le 03/06/2011 15:10, Igor Grinberg a ?crit :
>>>> On 06/03/11 00:51, Wolfgang Denk wrote:
>>>>
>>>>> Hi,
>>>>
>>>> Hi Wolfgang,
>>>>
>>>> [...]
>>>>
>>>>> omap1610h2
>>>>> omap1610inn
>>>>
>>>>> Please submit fixes to prevent removal.
>>>>
>>>> I've sent a compile fix [1] for omap1610h2 and omap1610inn about a month ago,
>>>> but still it hasn't been picked up.
>>>>
>>>> Sandeep said, he is on vacation, may be Albert should pick this up instead?
>>>>
>>>> [1] http://patchwork.ozlabs.org/patch/93545/
>>>
>>> What exactly do the FIXMEs mean? Are the definitions of CONFIG_SYS_INIT_SP_ADDR somehow incorrect in this patch, or just non-optimal?
>>
>> This means, that I could not test those, because I don't have the hardware.
>> I've taken those from the same SoC, so they should be fine, but again could not test,
>> so I've added a comment.
>
> FIXME implies the writer know something was wrong and mention it. Here, it is less of a FIXME and more of a TODO: test <whatever>; and I don't want readers to think there is a known error where there is not. Can you resubmit with the FIXMEs turned into TODOs?

I can see Aneesh has posted several fixes of that kind (also for these two boards),
so may be his values are better justified and don't need either TODO or FIXME.
If it is so, then my patch can be dropped.


-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [STATUS] WARNING: huge ARM board removal pending
  2011-06-08  8:47 ` Minkyu Kang
@ 2011-06-08 20:16   ` Albert ARIBAUD
  0 siblings, 0 replies; 14+ messages in thread
From: Albert ARIBAUD @ 2011-06-08 20:16 UTC (permalink / raw)
  To: u-boot

Hi Minkyu,

Le 08/06/2011 10:47, Minkyu Kang a ?crit :

> Please apply this patch for SMDK6400.
> http://patchwork.ozlabs.org/patch/98525/
>
> Thanks
> Minkyu Kang


Done.

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [STATUS] WARNING: huge ARM board removal pending
  2011-06-08 20:00         ` Igor Grinberg
@ 2011-06-08 20:23           ` Albert ARIBAUD
  0 siblings, 0 replies; 14+ messages in thread
From: Albert ARIBAUD @ 2011-06-08 20:23 UTC (permalink / raw)
  To: u-boot

Hi Igor,

Le 08/06/2011 22:00, Igor Grinberg a ?crit :
> Hi Albert,

> I can see Aneesh has posted several fixes of that kind (also for these two boards),
> so may be his values are better justified and don't need either TODO or FIXME.
> If it is so, then my patch can be dropped.

Alright -- I'll apply Aneesh's set as soon as magic numbers are fixed.

Amicalement,
-- 
Albert.

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2011-06-08 20:23 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-02 21:51 [U-Boot] [STATUS] WARNING: huge ARM board removal pending Wolfgang Denk
     [not found] ` <8A423D2D-B4CA-422A-813D-E808A0B849A0@googlemail.com>
2011-06-03  8:09   ` Wolfgang Denk
2011-06-03  8:31 ` Andy Pont
2011-06-03 11:13   ` Wolfgang Denk
2011-06-03 11:09 ` Graeme Russ
2011-06-03 12:50 ` Eric Bénard
2011-06-03 13:10 ` Igor Grinberg
2011-06-06 20:17   ` Albert ARIBAUD
2011-06-07  5:42     ` Igor Grinberg
2011-06-07 18:21       ` Albert ARIBAUD
2011-06-08 20:00         ` Igor Grinberg
2011-06-08 20:23           ` Albert ARIBAUD
2011-06-08  8:47 ` Minkyu Kang
2011-06-08 20:16   ` Albert ARIBAUD

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.