* [PATCH]: [xfstests] v2: Make ext2 requirement explicit for test 049
@ 2011-06-10 20:27 Chandra Seetharaman
2011-06-10 22:12 ` Eric Sandeen
0 siblings, 1 reply; 2+ messages in thread
From: Chandra Seetharaman @ 2011-06-10 20:27 UTC (permalink / raw)
To: XFS Mailing List; +Cc: Eric Sandeen
Test 049 depends on ext2 module being supported by the kernel.
This patch makes it a explicit, instead of failing the test with
obscure message.
Signed-Off-By: Chandra Seetharaman <sekharan@us.ibm.com>
---
diff --git a/049 b/049
index 3d3f030..c6c4faa 100755
--- a/049
+++ b/049
@@ -64,6 +64,7 @@ _require_nobigloopfs
_require_nonexternal
_require_scratch
_require_loop
+_require_ext2
rm -f $seq.full
diff --git a/common.rc b/common.rc
index c510c66..44c746d 100644
--- a/common.rc
+++ b/common.rc
@@ -769,6 +769,24 @@ _require_loop()
fi
}
+# this test requires ext2 filesystem support
+#
+_require_ext2()
+{
+ if [ "$HOSTOS" != "Linux" ]
+ then
+ _notrun "This test requires linux for ext2 filesystem support"
+ fi
+
+ modprobe ext2 >/dev/null 2>&1
+ if grep ext2 /proc/filesystems >/dev/null 2>&1
+ then
+ :
+ else
+ _notrun "This test requires ext2 filesystem support"
+ fi
+}
+
# this test requires that (large) loopback device files are not in use
#
_require_nobigloopfs()
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH]: [xfstests] v2: Make ext2 requirement explicit for test 049
2011-06-10 20:27 [PATCH]: [xfstests] v2: Make ext2 requirement explicit for test 049 Chandra Seetharaman
@ 2011-06-10 22:12 ` Eric Sandeen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2011-06-10 22:12 UTC (permalink / raw)
To: sekharan; +Cc: XFS Mailing List
On 6/10/11 3:27 PM, Chandra Seetharaman wrote:
> Test 049 depends on ext2 module being supported by the kernel.
>
> This patch makes it a explicit, instead of failing the test with
> obscure message.
>
> Signed-Off-By: Chandra Seetharaman <sekharan@us.ibm.com>
committed in the xfstests-dev tree on kernel.org, thanks!
-Eric
> ---
>
> diff --git a/049 b/049
> index 3d3f030..c6c4faa 100755
> --- a/049
> +++ b/049
> @@ -64,6 +64,7 @@ _require_nobigloopfs
> _require_nonexternal
> _require_scratch
> _require_loop
> +_require_ext2
>
> rm -f $seq.full
>
> diff --git a/common.rc b/common.rc
> index c510c66..44c746d 100644
> --- a/common.rc
> +++ b/common.rc
> @@ -769,6 +769,24 @@ _require_loop()
> fi
> }
>
> +# this test requires ext2 filesystem support
> +#
> +_require_ext2()
> +{
> + if [ "$HOSTOS" != "Linux" ]
> + then
> + _notrun "This test requires linux for ext2 filesystem support"
> + fi
> +
> + modprobe ext2 >/dev/null 2>&1
> + if grep ext2 /proc/filesystems >/dev/null 2>&1
> + then
> + :
> + else
> + _notrun "This test requires ext2 filesystem support"
> + fi
> +}
> +
> # this test requires that (large) loopback device files are not in use
> #
> _require_nobigloopfs()
>
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-10 22:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-10 20:27 [PATCH]: [xfstests] v2: Make ext2 requirement explicit for test 049 Chandra Seetharaman
2011-06-10 22:12 ` Eric Sandeen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.